Re: [libav-devel] [PATCH 01/10] Add AVFormatContext.event_flags for signaling to the user when events have happened in the stream.

2014-08-01 Thread Andrew Stone
On Fri, Aug 1, 2014 at 7:14 PM, wm4 wrote: > On Thu, 31 Jul 2014 19:56:33 -0400 > Andrew Stone wrote: > >> The only flag, for now, is AVFMT_EVENT_FLAG_METADATA_UPDATED, which is >> updated after each call to >> av_read_frame(). This comes with the caveat that, on stream start, it might >> not b

[libav-devel] [PATCH] af_resample: Set the number of samples in the last frame

2014-08-01 Thread Luca Barbato
Otherwise trailing zeroes would appear. --- This patch requires to update the reference files. Shall I upload a v3? libavfilter/af_resample.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_resample.c b/libavfilter/af_resample.c index bc8fd8a..ce4273a 100644 --- a/libavfilter/

Re: [libav-devel] [PATCH 01/10] Add AVFormatContext.event_flags for signaling to the user when events have happened in the stream.

2014-08-01 Thread wm4
On Thu, 31 Jul 2014 19:56:33 -0400 Andrew Stone wrote: > The only flag, for now, is AVFMT_EVENT_FLAG_METADATA_UPDATED, which is > updated after each call to > av_read_frame(). This comes with the caveat that, on stream start, it might > not be set properly > as packets might be buffered in AVFo

Re: [libav-devel] [PATCH] af_channelmap: Set the frame channel layout

2014-08-01 Thread Justin Ruggles
On 08/01/2014 05:48 PM, Luca Barbato wrote: Otherwise the frame would show the first layout matching the channel count. --- libavfilter/af_channelmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 3e5cc3d..3035405 100644

Re: [libav-devel] [PATCH] log: Introduce a syslog stock logger

2014-08-01 Thread Luca Barbato
On 01/08/14 22:53, wm4 wrote: > On Fri, 1 Aug 2014 17:20:05 +0200 > Luca Barbato wrote: > >> It support syslog(3) and android-specific logging. >> --- > > syslog is pretty legacy. Why not use dbus to send log messages to > journald? This feature is needed mainly by Android and iOS, that uses s

[libav-devel] [PATCH] af_channelmap: Set the frame channel layout

2014-08-01 Thread Luca Barbato
Otherwise the frame would show the first layout matching the channel count. --- libavfilter/af_channelmap.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_channelmap.c b/libavfilter/af_channelmap.c index 3e5cc3d..3035405 100644 --- a/libavfilter/af_channelmap.c +++ b/libavfil

Re: [libav-devel] [PATCH] mpeg4video: doxygen comments

2014-08-01 Thread Timothy Gu
On Aug 1, 2014 12:09 PM, "Nidhi Makhijani" wrote: > > --- > libavcodec/mpeg4video.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) You're de-doxygenizing. The commit message is wrong [...] Timothy ___ libav-devel mailing lis

Re: [libav-devel] [PATCH] log: Introduce a syslog stock logger

2014-08-01 Thread wm4
On Fri, 1 Aug 2014 17:20:05 +0200 Luca Barbato wrote: > It support syslog(3) and android-specific logging. > --- syslog is pretty legacy. Why not use dbus to send log messages to journald? ___ libav-devel mailing list libav-devel@libav.org https://lis

Re: [libav-devel] [PATCH] movenc: make meta box the last box in the file

2014-08-01 Thread John Stebbins
On 07/31/2014 05:19 PM, Luca Barbato wrote: > On 31/07/14 23:41, John Stebbins wrote: >> This facilitates tagging with braindead taggers (ahem iTunes and >> mp3tag). >> --- >> libavformat/movenc.c | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> > Ok, I guess. > > lu > > Hi. Plea

Re: [libav-devel] [PATCH] af_join: Set the output frame format

2014-08-01 Thread Justin Ruggles
On 08/01/2014 04:27 PM, Luca Barbato wrote: --- libavfilter/af_join.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index ee87340..e684cb9 100644 --- a/libavfilter/af_join.c +++ b/libavfilter/af_join.c @@ -480,6 +480,7 @@ static int join_requ

[libav-devel] [PATCH] af_join: Set the output frame format

2014-08-01 Thread Luca Barbato
--- libavfilter/af_join.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_join.c b/libavfilter/af_join.c index ee87340..e684cb9 100644 --- a/libavfilter/af_join.c +++ b/libavfilter/af_join.c @@ -480,6 +480,7 @@ static int join_request_frame(AVFilterLink *outlink) frame->nb_

Re: [libav-devel] [PATCH] png: disable broken MMX/SIMD code for bpp > 2

2014-08-01 Thread Kostya Shishkov
On Fri, Aug 01, 2014 at 08:33:11PM +0200, Luca Barbato wrote: > On 01/08/14 20:19, Vittorio Giovara wrote: > > The decoder was producing different results when ASM was disabled. > > Based on a long debug session with Kostya. > > --- > > libavcodec/pngdec.c | 2 +- > > 1 file changed, 1 insertion(+

Re: [libav-devel] [PATCH] mpeg4video: doxygen comments

2014-08-01 Thread Vittorio Giovara
On Fri, Aug 1, 2014 at 8:09 PM, Nidhi Makhijani wrote: > --- > libavcodec/mpeg4video.h | 16 > 1 file changed, 8 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h > index b092684..fce24c1 100644 > --- a/libavcodec/mpeg4video.h > +++

[libav-devel] [PATCH] mpeg4video: doxygen comments

2014-08-01 Thread Nidhi Makhijani
--- libavcodec/mpeg4video.h | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h index b092684..fce24c1 100644 --- a/libavcodec/mpeg4video.h +++ b/libavcodec/mpeg4video.h @@ -62,29 +62,29 @@ typedef struct Mpeg4DecC

Re: [libav-devel] [PATCH] png: disable broken MMX/SIMD code for bpp > 2

2014-08-01 Thread Luca Barbato
On 01/08/14 20:19, Vittorio Giovara wrote: > The decoder was producing different results when ASM was disabled. > Based on a long debug session with Kostya. > --- > libavcodec/pngdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec

[libav-devel] [PATCH] swscale: support AV_PIX_FMT_YA16 as input

2014-08-01 Thread Vittorio Giovara
--- Updated with a fix on PPC by Kostya. Vittorio libswscale/input.c| 40 libswscale/swscale-test.c | 4 +++- libswscale/swscale_internal.h | 4 +++- libswscale/swscale_unscaled.c | 1 + libswscale/utils.c| 2 ++ 5 files cha

[libav-devel] [PATCH] png: disable broken MMX/SIMD code for bpp > 2

2014-08-01 Thread Vittorio Giovara
The decoder was producing different results when ASM was disabled. Based on a long debug session with Kostya. --- libavcodec/pngdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c index 826edab..fa7f7cc 100644 --- a/libavcodec/pngdec.

Re: [libav-devel] [PATCH 09/10] ogg: update AVFormatContext.event_flags with METADATA_UPDATED whenever metadata changes.

2014-08-01 Thread Andrew Stone
On Thu, Jul 31, 2014 at 8:31 PM, wm4 wrote: > On Thu, 31 Jul 2014 19:56:41 -0400 > Andrew Stone wrote: > >> --- >> libavformat/oggparsevorbis.c | 4 +++- >> 1 file changed, 3 insertions(+), 1 deletion(-) >> >> diff --git a/libavformat/oggparsevorbis.c b/libavformat/oggparsevorbis.c >> index 58cb

Re: [libav-devel] [PATCH] log: Introduce a syslog stock logger

2014-08-01 Thread Luca Barbato
On 01/08/14 17:20, Luca Barbato wrote: > It support syslog(3) and android-specific logging. > --- > configure | 5 ++ > libavutil/log.c | 152 > +++- > libavutil/log.h | 14 ++ > 3 files changed, 147 insertions(+), 24 deletions(-) >

[libav-devel] [PATCH] log: Introduce a syslog stock logger

2014-08-01 Thread Luca Barbato
It support syslog(3) and android-specific logging. --- configure | 5 ++ libavutil/log.c | 152 +++- libavutil/log.h | 14 ++ 3 files changed, 147 insertions(+), 24 deletions(-) diff --git a/configure b/configure index 03742f0..a74b

Re: [libav-devel] [PATCH] avformat/mpegtsenc: Check data array size in mpegts_write_pmt()

2014-08-01 Thread Kieran Kunhya
> Indeed, now the question pending is how we can overflow it and how to > notify the user when it happens. Not looked at it deeply but it appears to be possible if the user specifies too many languages. ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] avformat/mpegtsenc: Check data array size in mpegts_write_pmt()

2014-08-01 Thread Luca Barbato
On 01/08/14 14:41, Rafaël Carré wrote: > On 08/01/14 13:57, Luca Barbato wrote: >> On 01/08/14 13:41, siret...@gmail.com wrote: >>> From: Michael Niedermayer >>> >>> Prevents out of array writes >>> Addresses: CVE-2014-2263 >>> --- >>> libavformat/mpegtsenc.c | 9 +++-- >>> 1 file changed, 7

Re: [libav-devel] [PATCH] avformat/mpegtsenc: Check data array size in mpegts_write_pmt()

2014-08-01 Thread Rafaël Carré
On 08/01/14 13:57, Luca Barbato wrote: > On 01/08/14 13:41, siret...@gmail.com wrote: >> From: Michael Niedermayer >> >> Prevents out of array writes >> Addresses: CVE-2014-2263 >> --- >> libavformat/mpegtsenc.c | 9 +++-- >> 1 file changed, 7 insertions(+), 2 deletions(-) > > This is an enc

Re: [libav-devel] [PATCH] flv: Index the audio stream

2014-08-01 Thread wm4
On Fri, 1 Aug 2014 13:53:41 +0200 Luca Barbato wrote: > And leverage the video index if the video is just disabled as wm4 > did in an initial patch. > --- > libavformat/flvdec.c | 7 +-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/libavformat/flvdec.c b/libavformat/f

Re: [libav-devel] [PATCH] pgssubdec: Check RLE size before copying

2014-08-01 Thread Diego Biurrun
On Thu, Jul 31, 2014 at 11:41:05AM +0200, Luca Barbato wrote: > From: Michael Niedermayer > > Make sure the buffer size does not exceed the expected > RLE size. > > Prevent an out of array bound write. > > Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind > Signed-off-by: Michael Niedermay

Re: [libav-devel] [PATCH] avformat/mpegtsenc: Check data array size in mpegts_write_pmt()

2014-08-01 Thread Luca Barbato
On 01/08/14 13:41, siret...@gmail.com wrote: > From: Michael Niedermayer > > Prevents out of array writes > Addresses: CVE-2014-2263 > --- > libavformat/mpegtsenc.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) This is an encoder, it means that the data buffer is smaller than

[libav-devel] [PATCH] flv: Index the audio stream

2014-08-01 Thread Luca Barbato
And leverage the video index if the video is just disabled as wm4 did in an initial patch. --- libavformat/flvdec.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 8e4cc5e..034e346 100644 --- a/libavformat/flvdec.c +++ b/

Re: [libav-devel] [PATCH] flv: Index the audio stream if no video is present

2014-08-01 Thread Luca Barbato
On 01/08/14 13:30, wm4 wrote: > On Fri, 1 Aug 2014 03:05:43 +0200 > Luca Barbato wrote: > >> And leverage the video index if the video is just disabled as wm4 >> did in an initial patch. >> --- >> libavformat/flvdec.c | 11 +-- >> 1 file changed, 9 insertions(+), 2 deletions(-) >> >> di

[libav-devel] [PATCH] avformat/mpegtsenc: Check data array size in mpegts_write_pmt()

2014-08-01 Thread siretart
From: Michael Niedermayer Prevents out of array writes Addresses: CVE-2014-2263 --- libavformat/mpegtsenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index 838702e..de27d70 100644 --- a/libavformat/mpegtsenc.c +

Re: [libav-devel] [PATCH] flv: Index the audio stream if no video is present

2014-08-01 Thread wm4
On Fri, 1 Aug 2014 03:05:43 +0200 Luca Barbato wrote: > And leverage the video index if the video is just disabled as wm4 > did in an initial patch. > --- > libavformat/flvdec.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/libavformat/flvdec.c b/libavfor

Re: [libav-devel] [PATCH] flvdec: fix seeking with video disabled

2014-08-01 Thread Luca Barbato
On 01/08/14 03:18, Jean-Baptiste Kempf wrote: > On 01 Aug, wm4 wrote : >> On Fri, 01 Aug 2014 02:28:41 +0200 >> Luca Barbato wrote: >> >>> On 01/08/14 01:32, wm4 wrote: If the video stream is disabled (discard set to AVDISCARD_ALL), the code for adding a seek index entry is skipped. This

Re: [libav-devel] [PATCH] tscc: Eliminate pointless variable indirections in decode_frame()

2014-08-01 Thread Diego Biurrun
On Tue, Jul 29, 2014 at 10:43:02AM -0700, Diego Biurrun wrote: > --- > libavcodec/tscc.c | 22 ++ > 1 file changed, 10 insertions(+), 12 deletions(-) LGTK on IRC Diego ___ libav-devel mailing list libav-devel@libav.org https://lists

Re: [libav-devel] [PATCH 1/2] pngenc: Drop pointless pointer cast in png_write_row()

2014-08-01 Thread Diego Biurrun
On Tue, Jul 29, 2014 at 09:07:06AM -0700, Diego Biurrun wrote: > --- > libavcodec/pngenc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) OKed by Vittorio on IRC. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org