Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread Rémi Denis-Courmont
Le 2014-08-12 19:54, Anton Khirnov a écrit : --- doc/APIchanges | 3 +++ libavutil/mem.c | 20 libavutil/mem.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 34 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6e5

Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread Anton Khirnov
On Tue, 12 Aug 2014 21:34:33 +0200, wm4 wrote: > On Tue, 12 Aug 2014 16:54:50 + > Anton Khirnov wrote: > > > --- > > doc/APIchanges | 3 +++ > > libavutil/mem.c | 20 > > libavutil/mem.h | 10 ++ > > libavutil/version.h | 2 +- > > 4 files change

Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread Anton Khirnov
On Tue, 12 Aug 2014 19:10:20 +0200, Luca Barbato wrote: > On 12/08/14 18:54, Anton Khirnov wrote: > > --- > > doc/APIchanges | 3 +++ > > libavutil/mem.c | 20 > > libavutil/mem.h | 10 ++ > > libavutil/version.h | 2 +- > > 4 files changed, 34 inserti

Re: [libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Timothy Gu
On Aug 12, 2014 12:27 PM, "Luca Barbato" wrote: > > And convert it to Markdown. > --- > README| 13 + > README.md | 40 > 2 files changed, 41 insertions(+), 12 deletions(-) > mode change 100644 => 12 README Why don't you just drop RE

Re: [libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Luca Barbato
On 12/08/14 22:08, Andrew Kelley wrote: > On Tue, Aug 12, 2014 at 1:02 PM, Luca Barbato wrote: > >> On 12/08/14 21:30, Andrew Kelley wrote: >>> What's this?! Next we'll be accepting GitHub pull requests :-) >> >> I'm thinking about figuring out how to do that actually. >> > > I use it quite a bi

Re: [libav-devel] [PATCH 1/3] avconv: rename output_packet() to process_input_packet()

2014-08-12 Thread Diego Biurrun
On Tue, Aug 12, 2014 at 04:54:49PM +, Anton Khirnov wrote: > It more accurately describes what does this function do. .. what this function does. Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav

Re: [libav-devel] [PATCH] mpeg4video: Fix doxygen comment syntax to document correct struct member

2014-08-12 Thread Diego Biurrun
On Tue, Aug 12, 2014 at 05:58:17PM +0530, Nidhi Makhijani wrote: > --- > libavcodec/mpeg4video.h | 20 ++-- > 1 file changed, 10 insertions(+), 10 deletions(-) LGTM, queueing. Diego ___ libav-devel mailing list libav-devel@libav.org htt

[libav-devel] [PATCH 1/4] flvdec: update AVFormatContext.event_flags with METADATA_UPDATED whenever metadata changes.

2014-08-12 Thread Andrew Stone
--- libavformat/flvdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 8d18dbe..999ad68 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -498,6 +498,7 @@ static int amf_parse_object(AVFormatContext *s, AVStream *astream,

[libav-devel] [PATCH 3/4] mov: update AVFormatContext.event_flags with METADATA_UPDATED whenever metadata changes.

2014-08-12 Thread Andrew Stone
--- libavformat/mov.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index fdf9c8d..3ab6776 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -80,6 +80,7 @@ static int mov_metadata_track_or_disc_number(MOVContext *c, AVIOContext *pb,

[libav-devel] [PATCH 4/4] ogg: update event_flags with STREAM_/METADATA_UPDATED whenever metadata changes.

2014-08-12 Thread Andrew Stone
Originally, AVFormatContext and a metadata dict were provided to ff_vorbis_comment(), but this presented issues if an AVStream was being updated or the metadata on AVFormatContext wasn't actually being updated. To remedy this, ff_vorbis_stream_comment() explicitly updates a stream's metadata and

[libav-devel] [PATCH 2/4] nutdec: update AVFormatContext.event_flags with STREAM_/METADATA_UPDATED whenever metadata changes.

2014-08-12 Thread Andrew Stone
--- libavformat/nutdec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 8ec67ae..6c95d55 100644 --- a/libavformat/nutdec.c +++ b/libavformat/nutdec.c @@ -461,9 +461,11 @@ static int decode_info_header(NUTContext

Re: [libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Andrew Kelley
On Tue, Aug 12, 2014 at 1:02 PM, Luca Barbato wrote: > On 12/08/14 21:30, Andrew Kelley wrote: > > What's this?! Next we'll be accepting GitHub pull requests :-) > > I'm thinking about figuring out how to do that actually. > I use it quite a bit and I find it to be convenient. Libav developers m

Re: [libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Luca Barbato
On 12/08/14 21:30, Andrew Kelley wrote: > On Tue, Aug 12, 2014 at 12:26 PM, Luca Barbato wrote: > >> And convert it to Markdown. > > > What's this?! Next we'll be accepting GitHub pull requests :-) I'm thinking about figuring out how to do that actually. lu __

Re: [libav-devel] [PATCH] Expose metadata found in onCuePoint events in .flv files.

2014-08-12 Thread Martin Storsjö
On Mon, 11 Aug 2014, Andrew Stone wrote: Currently, only onMetaData is used, but some providers (wrongly) put metadata into onCuePoint events, and it's still nice to be able to use that data. onCuePoint events also present metadata slightly differently than onMetaData events: all metadata is fo

Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread wm4
On Tue, 12 Aug 2014 16:54:50 + Anton Khirnov wrote: > --- > doc/APIchanges | 3 +++ > libavutil/mem.c | 20 > libavutil/mem.h | 10 ++ > libavutil/version.h | 2 +- > 4 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges

Re: [libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Andrew Kelley
On Tue, Aug 12, 2014 at 12:26 PM, Luca Barbato wrote: > And convert it to Markdown. What's this?! Next we'll be accepting GitHub pull requests :-) ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] doc: Add more information in the README

2014-08-12 Thread Luca Barbato
And convert it to Markdown. --- README| 13 + README.md | 40 2 files changed, 41 insertions(+), 12 deletions(-) mode change 100644 => 12 README create mode 100644 README.md diff --git a/README b/README deleted file mode 100644 index

[libav-devel] [PATCH] mpegts: Do not try to write a PMT larger than SECTION_SIZE

2014-08-12 Thread Luca Barbato
Prevent out of array write. Similar to what Michael Niedermayer did to address the same issue. Bug-Id: CVE-2014-2263 CC: libav-sta...@libav.org --- mpegtsenc would enjoy a complete overhaul, but not this week. patch should got in master and release/10 libavformat/mpegtsenc.c | 25

Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread Luca Barbato
On 12/08/14 19:24, James Almer wrote: > On 12/08/14 1:54 PM, Anton Khirnov wrote: >> --- >> doc/APIchanges | 3 +++ >> libavutil/mem.c | 20 >> libavutil/mem.h | 10 ++ >> libavutil/version.h | 2 +- >> 4 files changed, 34 insertions(+), 1 deletion(-) >>

Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread James Almer
On 12/08/14 1:54 PM, Anton Khirnov wrote: > --- > doc/APIchanges | 3 +++ > libavutil/mem.c | 20 > libavutil/mem.h | 10 ++ > libavutil/version.h | 2 +- > 4 files changed, 34 insertions(+), 1 deletion(-) > Shouldn't this be in avstring.h/c? _

Re: [libav-devel] [PATCH 3/3] cmdutils: allow matching by metadata in stream specifiers

2014-08-12 Thread Luca Barbato
On 12/08/14 18:54, Anton Khirnov wrote: > --- > Changelog| 1 + > cmdutils.c | 23 +++ > doc/avconv.texi | 5 + > doc/avtools-common-opts.texi | 7 +++ > 4 files changed, 36 insertions(+) > Nice. I like it. __

Re: [libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread Luca Barbato
On 12/08/14 18:54, Anton Khirnov wrote: > --- > doc/APIchanges | 3 +++ > libavutil/mem.c | 20 > libavutil/mem.h | 10 ++ > libavutil/version.h | 2 +- > 4 files changed, 34 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges

Re: [libav-devel] [PATCH 1/3] avconv: rename output_packet() to process_input_packet()

2014-08-12 Thread Luca Barbato
On 12/08/14 18:54, Anton Khirnov wrote: > It more accurately describes what does this function do. > --- > avconv.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.

[libav-devel] [PATCH 4/4] mxf: Add the UL for the MPEG2VideoDescriptor

2014-08-12 Thread Luca Barbato
--- libavformat/mxfdec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index eb0f5d0..2b5eff8 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1822,6 +1822,7 @@ static const MXFMetadataReadTableEntry mxf_metadata_read_table[] = {

[libav-devel] [PATCH 3/4] mxf: Support AAC

2014-08-12 Thread Luca Barbato
--- libavformat/mxf.c| 1 + libavformat/mxfdec.c | 8 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/mxf.c b/libavformat/mxf.c index 8f09c61..19ee35f 100644 --- a/libavformat/mxf.c +++ b/libavformat/mxf.c @@ -48,6 +48,7 @@ const MXFCodecUL ff_mxf_codec_uls[

Re: [libav-devel] [PATCH] Add AVFormatContext.event_flags and AVStream.event_flags for signaling to the user when events happen.

2014-08-12 Thread Anton Khirnov
On Tue, 12 Aug 2014 12:19:33 -0400, Andrew Stone wrote: > On Tue, Aug 12, 2014 at 3:39 AM, Anton Khirnov wrote: > > > > On Fri, 8 Aug 2014 13:09:23 -0400, Andrew Stone wrote: > >> The only flags, for now, indicate if metadata was updated and are set > >> after each call to > >> av_read_frame(

[libav-devel] [PATCH 2/4] mxf: Print non-parsed ULs

2014-08-12 Thread Luca Barbato
Useful to implement missing features. --- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index ba76577..410c13b 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2185,6 +2185,9 @@ static int mxf_read_header(AVF

[libav-devel] [PATCH 1/4] mxf: Add UID print helpers

2014-08-12 Thread Luca Barbato
Simplify a lot error and diagnostic messages. --- libavformat/mxf.h | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/mxf.h b/libavformat/mxf.h index a2d919a..2443207 100644 --- a/libavformat/mxf.h +++ b/libavformat/mxf.h @@ -79,6 +79,18 @@ extern const MXFCodecUL ff_mx

[libav-devel] [PATCH 1/3] avconv: rename output_packet() to process_input_packet()

2014-08-12 Thread Anton Khirnov
It more accurately describes what does this function do. --- avconv.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/avconv.c b/avconv.c index 0ee7628..65f33b2 100644 --- a/avconv.c +++ b/avconv.c @@ -1354,7 +1354,7 @@ static int transcode_subtitles(InputStream *ist, A

[libav-devel] [PATCH 3/3] cmdutils: allow matching by metadata in stream specifiers

2014-08-12 Thread Anton Khirnov
--- Changelog| 1 + cmdutils.c | 23 +++ doc/avconv.texi | 5 + doc/avtools-common-opts.texi | 7 +++ 4 files changed, 36 insertions(+) diff --git a/Changelog b/Changelog index edba289..48a4f27 100644 --- a/Changelo

[libav-devel] [PATCH 2/3] mem: add av_strndup() for duplicating substrings

2014-08-12 Thread Anton Khirnov
--- doc/APIchanges | 3 +++ libavutil/mem.c | 20 libavutil/mem.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 34 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 6e5242e..fc56677 100644 --- a/doc/APIchanges +++ b

Re: [libav-devel] [GASPP PATCH 1/1] allow a comma between macro name and first macro parameter

2014-08-12 Thread Martin Storsjö
On Tue, 12 Aug 2014, Janne Grunau wrote: Both gas and llvm's integrated assembler accept it. --- gas-preprocessor.pl | 2 +- test.S | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 3020401..fbf0853 100755 ---

Re: [libav-devel] [PATCH] Add AVFormatContext.event_flags and AVStream.event_flags for signaling to the user when events happen.

2014-08-12 Thread Andrew Stone
On Tue, Aug 12, 2014 at 3:39 AM, Anton Khirnov wrote: > > On Fri, 8 Aug 2014 13:09:23 -0400, Andrew Stone wrote: >> The only flags, for now, indicate if metadata was updated and are set after >> each call to >> av_read_frame(). This comes with the caveat that, on stream start, it might >> not

[libav-devel] [GASPP PATCH 1/1] allow a comma between macro name and first macro parameter

2014-08-12 Thread Janne Grunau
Both gas and llvm's integrated assembler accept it. --- gas-preprocessor.pl | 2 +- test.S | 9 + 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/gas-preprocessor.pl b/gas-preprocessor.pl index 3020401..fbf0853 100755 --- a/gas-preprocessor.pl +++ b/gas-preproce

Re: [libav-devel] [PATCH] stereo3d: initialize AVStereo3D to zero

2014-08-12 Thread Vittorio Giovara
On Tue, Aug 12, 2014 at 1:56 PM, Felix Abecassis wrote: > --- > libavutil/stereo3d.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c > index 850fd75..2dcfddf 100644 > --- a/libavutil/stereo3d.c > +++ b/libavutil/stereo3d.c > @@ -19,6 +19,7 @

[libav-devel] [PATCH 1/3] idct: remove call to ff_idctdsp_init from ff_MPV_common_init

2014-08-12 Thread John Stebbins
One step in untangling the mpegvideo code and fixing some problems in the order that initialization is being done in h263dec and h261dec. --- fix comment in mpeg12dec libavcodec/dnxhdenc.c | 3 +-- libavcodec/h261dec.c | 4 +++- libavcodec/h263dec.c | 8 ++-- libavcodec/mp

[libav-devel] [PATCH] stereo3d: initialize AVStereo3D to zero

2014-08-12 Thread Felix Abecassis
--- libavutil/stereo3d.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/stereo3d.c b/libavutil/stereo3d.c index 850fd75..2dcfddf 100644 --- a/libavutil/stereo3d.c +++ b/libavutil/stereo3d.c @@ -19,6 +19,7 @@ */ #include +#include #include "mem.h" #include "stereo3d.h"

Re: [libav-devel] [PATCH] configure: Check for nanosleep in headers as well, not only in libs

2014-08-12 Thread Hendrik Leppkes
On Tue, Aug 12, 2014 at 2:25 PM, Derek Buitenhuis wrote: > On 8/11/2014 7:27 PM, Rémi Denis-Courmont wrote: >> I've seen it as well on Debian unstable, not sure with what version though, >> but it is hopefully fixed in newer versions. IMHO, this is/was definitely a >> toolchain bug. > > I've seen

Re: [libav-devel] [PATCH] http: Stop reading after receiving the whole file for non-chunked transfers

2014-08-12 Thread Derek Buitenhuis
On 8/11/2014 8:30 AM, Martin Storsjö wrote: > Previously this logic was only used if the server didn't > respond with Connection: close, but use it even for that case, > if the server response is non-chunked. > > Originally the http code has relied on Connection: close to close > the socket when t

[libav-devel] [PATCH] mpeg4video: Fix doxygen comment syntax to document correct struct member

2014-08-12 Thread Nidhi Makhijani
--- libavcodec/mpeg4video.h | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/mpeg4video.h b/libavcodec/mpeg4video.h index b092684..ce588dd 100644 --- a/libavcodec/mpeg4video.h +++ b/libavcodec/mpeg4video.h @@ -62,29 +62,29 @@ typedef struct Mpe

Re: [libav-devel] [PATCH] w32threads: Use newer thread synchronization functions when targeting Vista

2014-08-12 Thread Derek Buitenhuis
On 8/11/2014 7:05 PM, Martin Storsjö wrote: > When explicitly targeting Vista or newer (which only happens if the > caller explicitly sets _WIN32_WINNT to a high enough value via the > extra cflags option - otherwise configure script sets > -D_WIN32_WINNT=0x0502), we already unconditionally link to

Re: [libav-devel] [PATCH] configure: Check for nanosleep in headers as well, not only in libs

2014-08-12 Thread Derek Buitenhuis
On 8/11/2014 7:27 PM, Rémi Denis-Courmont wrote: > I've seen it as well on Debian unstable, not sure with what version though, > but it is hopefully fixed in newer versions. IMHO, this is/was definitely a > toolchain bug. I've seen this bug on Mac and Linux too... been asked more than once about

Re: [libav-devel] [PATCH 4/4] proresenc: Properly account for alpha plane

2014-08-12 Thread Diego Biurrun
On Tue, Aug 12, 2014 at 01:02:00PM +0200, Christophe Gisquet wrote: > From 89fe1d689a665e9daf85c96e54ad236196299c6a Mon Sep 17 00:00:00 2001 > From: Christophe Gisquet > Date: Tue, 12 Aug 2014 03:07:56 -0700 > Subject: [PATCH 4/4] proresenc: Properly account for alpha plane > > The packet buffer

Re: [libav-devel] [PATCH 4/4] proresenc: Properly account for alpha plane

2014-08-12 Thread Christophe Gisquet
Hi, 2014-08-12 12:07 GMT+02:00 Diego Biurrun : > From: Christophe Gisquet > > The packet buffer allocation is considered DCT-coded, while it is > actually run-coded and thus requires a larger buffer. Forgot a word (alpha) in the original commit message, so here it is fixed. From 89fe1d689a665e9d

Re: [libav-devel] [PATCH 3/4] proresenc: Realloc if buffer is too small

2014-08-12 Thread Christophe Gisquet
Hi, 2014-08-12 12:10 GMT+02:00 Christophe Gisquet : > I'm going to rework that part once more. Please wait while I test the > patches with my slow laptop busy cherry-picking and compiling. I keep around the maximum slice size and use it to determine when to reallocate and by how much in the attac

Re: [libav-devel] [PATCH 3/4] proresenc: Realloc if buffer is too small

2014-08-12 Thread Christophe Gisquet
2014-08-12 12:07 GMT+02:00 Diego Biurrun : > +if (pkt_size <= buf - orig_buf + FF_MIN_BUFFER_SIZE) { > +uint8_t *start = pkt->data; > +// double the size > +int delta = FFMAX(FF_MIN_BUFFER_SIZE, buf - orig_buf); I'm going

[libav-devel] [PATCH 2/4] proresenc: Report buffer overflow

2014-08-12 Thread Diego Biurrun
From: Christophe Gisquet If the allocated size, despite best efforts, is too small, exit with the appropriate error. Signed-off-by: Diego Biurrun --- libavcodec/proresenc.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavcodec/proresenc.c b/libavcodec/p

[libav-devel] [PATCH 3/4] proresenc: Realloc if buffer is too small

2014-08-12 Thread Diego Biurrun
From: Christophe Gisquet The buffer allocation may be incorrect (e.g. with an alpha plane), and currently causes the buffer to be set to NULL by init_put_bits, causing a crash later on. So, detect that situation, and if detected, reallocate the buffer and ask for a sample that shows the problem.

[libav-devel] [PATCH 4/4] proresenc: Properly account for alpha plane

2014-08-12 Thread Diego Biurrun
From: Christophe Gisquet The packet buffer allocation is considered DCT-coded, while it is actually run-coded and thus requires a larger buffer. Signed-off-by: Diego Biurrun --- libavcodec/proresenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/pro

[libav-devel] [PATCH 1/4] proresenc: Remove unneeded parameters from encode_alpha_plane()

2014-08-12 Thread Diego Biurrun
From: Christophe Gisquet Signed-off-by: Diego Biurrun --- libavcodec/proresenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/proresenc.c b/libavcodec/proresenc.c index bdb826c..6acaede 100644 --- a/libavcodec/proresenc.c +++ b/libavcodec/proresenc.c @@ -

Re: [libav-devel] [PATCH 0/4] prores: fix various issues

2014-08-12 Thread Luca Barbato
On 12/08/14 00:04, Christophe Gisquet wrote: > There are mostly issues (in order), potentially causing crashes: > - no check on the buffer left > - no reallocation when the buffer will overflow > - incorrect buffer size when encoding alpha > > Christophe Gisquet (4): > proresenc: remove unneeded

Re: [libav-devel] [PATCH] Add AVFormatContext.event_flags and AVStream.event_flags for signaling to the user when events happen.

2014-08-12 Thread Anton Khirnov
On Fri, 8 Aug 2014 13:09:23 -0400, Andrew Stone wrote: > The only flags, for now, indicate if metadata was updated and are set after > each call to > av_read_frame(). This comes with the caveat that, on stream start, it might > not be set properly > as packets might be buffered in AVFormatCont

Re: [libav-devel] [PATCH] mpeg4video: change doxygen comment syntax so that correct member is documented

2014-08-12 Thread Diego Biurrun
more compact log message: mpeg4video: Fix doxygen comment syntax to document correct struct member On Tue, Aug 12, 2014 at 11:55:48AM +0530, Nidhi Makhijani wrote: > --- a/libavcodec/mpeg4video.h > +++ b/libavcodec/mpeg4video.h > @@ -92,11 +92,11 @@ typedef struct Mpeg4DecContext { > -int vol