Re: [libav-devel] [PATCH 1/2] deshake/stabilisation filters

On 15/08/14 19:38, Timothy Gu wrote: > On Fri, Aug 15, 2014 at 4:55 AM, Vittorio Giovara > wrote: >> From: Georg Martius >> >> vid.stab support for libav consists of two filters: >> vidstabdetect and vidstabtransform >> >> Signed-off-by: Vittorio Giovara >> --- > > You need to acknowledge other

Re: [libav-devel] [PATCH 2/2] fate: vidstab tests

On 15/08/14 18:26, Georg Martius wrote: > Hi, > > On Friday 15 August 2014 12:55:50 you wrote: >> vidstabtransform depends on what is output from vidstabdetect, so the two >> are piped together. > > the '-' you have below in the cmdline is not supported as stdin/stdout. It > will create a file c

Re: [libav-devel] [PATCH 17/17] eval: Discard return value from strtod()

On 15/08/14 22:13, Diego Biurrun wrote: > The value is never used; this also avoids a warning from MSVC. > --- > > There is probably a prettier solution. > > libavutil/eval.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/eval.c b/libavutil/eval.c > index 31e

Re: [libav-devel] [PATCH 15/17] asfdec: Drop unused variable from asf_build_simple_index()

On 15/08/14 22:13, Diego Biurrun wrote: > --- > libavformat/asfdec.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c > index 85e800d..084b82f 100644 > --- a/libavformat/asfdec.c > +++ b/libavformat/asfdec.c > @@ -1425,7 +1425,6 @@ static int asf

Re: [libav-devel] [PATCH 16/17] vsrc_movie: Avoid a variable indirection in movie_get_frame()

On 15/08/14 22:13, Diego Biurrun wrote: > This avoids an unused variable warning with MSVC since the variable is > only used in a debug mode printf statement. > --- > libavfilter/vsrc_movie.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) Ok.

Re: [libav-devel] [PATCH 13/17] pcm: Drop av_unused attribute from variable that is always used

On 15/08/14 22:13, Diego Biurrun wrote: > --- > libavcodec/pcm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c > index 2985156..e06712e 100644 > --- a/libavcodec/pcm.c > +++ b/libavcodec/pcm.c > @@ -253,7 +253,7 @@ static av_cold int

Re: [libav-devel] [PATCH 12/17] pcm: Drop unused variable from DECODE_PLANAR macro

On 15/08/14 22:13, Diego Biurrun wrote: > --- > libavcodec/pcm.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c > index 9fadcb7..2985156 100644 > --- a/libavcodec/pcm.c > +++ b/libavcodec/pcm.c > @@ -264,7 +264,6 @@ static av_cold int pcm_decode_init(A

Re: [libav-devel] [PATCH 11/17] avfilter: Remove unused variable from ff_get_video_buffer()

On 15/08/14 22:13, Diego Biurrun wrote: > --- > libavfilter/video.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavfilter/video.c b/libavfilter/video.c > index 23bf867..9f1103e 100644 > --- a/libavfilter/video.c > +++ b/libavfilter/video.c > @@ -105,7 +105,6 @@ AVFrame *ff_get_video

Re: [libav-devel] [PATCH 10/17] vc1: Add missing parentheses to conditions in vc1_decode_b_mb_intfr()

On 15/08/14 22:13, Diego Biurrun wrote: > --- > > Not sure about this one, but it looks *very* suspicious. > > libavcodec/vc1dec.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > I wonder why it seemed working... ___ libav-devel mailin

Re: [libav-devel] [PATCH 04/17] qt-faststart: Only define fseeko/ftello if they are undefined

On 15/08/14 22:13, Diego Biurrun wrote: > This avoids a number of redefinition warnings on MinGW64. > --- > > I'm assuming that they are not defined to anything silly, which I > hope is safe to do. > > tools/qt-faststart.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/tools/q

Re: [libav-devel] [PATCH 05/17] mov: Drop unused parameter from ff_mov_read_esds()

On 15/08/14 22:13, Diego Biurrun wrote: > This is cleaner and avoids an uninitialized variable warning with MSVC. > --- > libavformat/cafdec.c | 3 +-- > libavformat/isom.h | 2 +- > libavformat/mov.c| 4 ++-- > 3 files changed, 4 insertions(+), 5 deletions(-) > Seems fine. __

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

On Fri, Aug 15, 2014 at 1:54 PM, Timothy Gu wrote: > Just undef it first if it is defined. See https://github.com/FFmpeg/FFmpeg/commit/ef122ff5072463366c020157f0a27aad7e6610db for example. Timothy ___ libav-devel mailing list libav-devel@libav.org ht

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

On Fri, Aug 15, 2014 at 1:13 PM, Diego Biurrun wrote: > This avoids a number of redefinition warnings on MinGW64. > --- > > I'm assuming that they are not defined to anything silly, which I > hope is safe to do. It's not safe at all. > > libavformat/os_support.h | 6 ++ > 1 file changed, 6

Re: [libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

On 15 Aug, Diego Biurrun wrote : > This avoids a number of redefinition warnings on MinGW64. > --- > > I'm assuming that they are not defined to anything silly, which I > hope is safe to do. >From experience, it's not safe. I would always undef and redef. -- Jean-Baptiste Kempf http://www.jbke

Re: [libav-devel] [PATCH 08/17] vfwcap: Drop fallback VfW defines

On Fri, Aug 15, 2014 at 1:13 PM, Diego Biurrun wrote: > The defines were added long ago when MinGW still lacked them. > --- > libavdevice/vfwcap.c | 8 > 1 file changed, 8 deletions(-) OK. [...] Timothy ___ libav-devel mailing list libav-dev

Re: [libav-devel] [PATCH 01/17] configure: Suppress "potentially uninitialized variable" warnings from MSVC

On Fri, Aug 15, 2014 at 1:12 PM, Diego Biurrun wrote: > The same is done for GCC and clang already. > I agree with making this consistent with GCC and clang. However now that we're on the subject - it's a pretty useful warning. Perhaps we

[libav-devel] [PATCH 04/17] qt-faststart: Only define fseeko/ftello if they are undefined

This avoids a number of redefinition warnings on MinGW64. --- I'm assuming that they are not defined to anything silly, which I hope is safe to do. tools/qt-faststart.c | 8 1 file changed, 8 insertions(+) diff --git a/tools/qt-faststart.c b/tools/qt-faststart.c index ed6de1b..4a0d441

[libav-devel] [PATCH 11/17] avfilter: Remove unused variable from ff_get_video_buffer()

--- libavfilter/video.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavfilter/video.c b/libavfilter/video.c index 23bf867..9f1103e 100644 --- a/libavfilter/video.c +++ b/libavfilter/video.c @@ -105,7 +105,6 @@ AVFrame *ff_get_video_buffer(AVFilterLink *link, int w, int h) { AVFrame

[libav-devel] [PATCH 13/17] pcm: Drop av_unused attribute from variable that is always used

--- libavcodec/pcm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 2985156..e06712e 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -253,7 +253,7 @@ static av_cold int pcm_decode_init(AVCodecContext *avctx) #if HAVE_BIGENDIAN

[libav-devel] [PATCH 09/17] [RFC] vfwcap: Initialize framerate value

Otherwise the framerate is used uninitialized. --- This is surely not the right solution, but the code currently looks very wrong. libavdevice/vfwcap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/vfwcap.c b/libavdevice/vfwcap.c index c067be3..420fdb4 100644 --

[libav-devel] [PATCH 10/17] vc1: Add missing parentheses to conditions in vc1_decode_b_mb_intfr()

--- Not sure about this one, but it looks *very* suspicious. libavcodec/vc1dec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/vc1dec.c b/libavcodec/vc1dec.c index f0ea471..8ad4f0f 100644 --- a/libavcodec/vc1dec.c +++ b/libavcodec/vc1dec.c @@ -4570,9 +4570,9

[libav-devel] [PATCH 07/17] dxva2: Undefine _WIN32_WINNT before defining it

This avoids a number of redefinition warnings. --- libavcodec/dxva2_internal.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/dxva2_internal.h b/libavcodec/dxva2_internal.h index f35a076..d50c0ff 100644 --- a/libavcodec/dxva2_internal.h +++ b/libavcodec/dxva2_internal.h @@ -23,6 +2

[libav-devel] [PATCH 06/17] dxva2: Pass variable of correct type to IDirectXVideoDecoder_GetBuffer()

This avoids related incompatible pointer type warnings. --- A cast would be an alternative, but I'm not fond of casts. libavcodec/dxva2_h264.c | 7 +-- libavcodec/dxva2_mpeg2.c | 5 - libavcodec/dxva2_vc1.c | 4 +++- 3 files changed, 12 insertions(+), 4 deletions(-) diff --git a/liba

[libav-devel] [PATCH 12/17] pcm: Drop unused variable from DECODE_PLANAR macro

--- libavcodec/pcm.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/pcm.c b/libavcodec/pcm.c index 9fadcb7..2985156 100644 --- a/libavcodec/pcm.c +++ b/libavcodec/pcm.c @@ -264,7 +264,6 @@ static av_cold int pcm_decode_init(AVCodecContext *avctx) #else #define DECODE_PLANAR(size,

[libav-devel] [PATCH 08/17] vfwcap: Drop fallback VfW defines

The defines were added long ago when MinGW still lacked them. --- libavdevice/vfwcap.c | 8 1 file changed, 8 deletions(-) diff --git a/libavdevice/vfwcap.c b/libavdevice/vfwcap.c index 5fdda4a..c067be3 100644 --- a/libavdevice/vfwcap.c +++ b/libavdevice/vfwcap.c @@ -27,14 +27,6 @@ #inc

[libav-devel] [PATCH 15/17] asfdec: Drop unused variable from asf_build_simple_index()

--- libavformat/asfdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 85e800d..084b82f 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -1425,7 +1425,6 @@ static int asf_build_simple_index(AVFormatContext *s, int stream_index)

[libav-devel] MSVC / MinGW warning fixes

This is a series of patches that address warnings I noticed in the output of gcc for MinGW64 and MSVC. Many of them are just RFCs and should likely be resolved in other ways. [PATCH 01/17] configure: Suppress "potentially uninitialized [PATCH 02/17] os_support: Adjust an outdated #endif comment [

[libav-devel] [PATCH 03/17] os_support: Only define lseek/stat/fstat if they are undefined

This avoids a number of redefinition warnings on MinGW64. --- I'm assuming that they are not defined to anything silly, which I hope is safe to do. libavformat/os_support.h | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index 94cb0d3

[libav-devel] [PATCH 02/17] os_support: Adjust an outdated #endif comment

--- libavformat/os_support.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/os_support.h b/libavformat/os_support.h index ae8cef7..94cb0d3 100644 --- a/libavformat/os_support.h +++ b/libavformat/os_support.h @@ -36,7 +36,7 @@ # define lseek(f,p,w) _lseeki64((f),

[libav-devel] [PATCH 14/17] rtpdec_h264: Remove unused variable from h264_handle_packet()

--- libavformat/rtpdec_h264.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index abf1f39..8da8a96 100644 --- a/libavformat/rtpdec_h264.c +++ b/libavformat/rtpdec_h264.c @@ -277,7 +277,6 @@ static int h264_handle_packet(AVFormatContext *ct

[libav-devel] [PATCH 05/17] mov: Drop unused parameter from ff_mov_read_esds()

This is cleaner and avoids an uninitialized variable warning with MSVC. --- libavformat/cafdec.c | 3 +-- libavformat/isom.h | 2 +- libavformat/mov.c| 4 ++-- 3 files changed, 4 insertions(+), 5 deletions(-) diff --git a/libavformat/cafdec.c b/libavformat/cafdec.c index 6574623..0034f00 10

[libav-devel] [PATCH 16/17] vsrc_movie: Avoid a variable indirection in movie_get_frame()

This avoids an unused variable warning with MSVC since the variable is only used in a debug mode printf statement. --- libavfilter/vsrc_movie.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/vsrc_movie.c b/libavfilter/vsrc_movie.c index 8ebdd06..1ee0f16 100644

[libav-devel] [PATCH 17/17] eval: Discard return value from strtod()

The value is never used; this also avoids a warning from MSVC. --- There is probably a prettier solution. libavutil/eval.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/eval.c b/libavutil/eval.c index 31e9ebb..896f59d 100644 --- a/libavutil/eval.c +++ b/libavutil/

[libav-devel] [PATCH 01/17] configure: Suppress "potentially uninitialized variable" warnings from MSVC

The same is done for GCC and clang already. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index c073f30..b68b592 100755 --- a/configure +++ b/configure @@ -2688,7 +2688,7 @@ msvc_flags(){ -Wall)echo -W4 -wd4244

[libav-devel] [PATCH] libxvid: K&R formatting cosmetics

--- libavcodec/libxvid.c| 226 +--- libavcodec/libxvid_rc.c | 88 ++- 2 files changed, 162 insertions(+), 152 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index ad650dd..9e363f7 100644 --- a/libavcodec/libxv

Re: [libav-devel] [PATCH 2/2] fate: vidstab tests

Hi, On Friday 15 August 2014 12:55:50 you wrote: > vidstabtransform depends on what is output from vidstabdetect, so the two > are piped together. the '-' you have below in the cmdline is not supported as stdin/stdout. It will create a file called '-' now. You need to create a temporary file na

Re: [libav-devel] [PATCH 1/2] deshake/stabilisation filters

On Fri, Aug 15, 2014 at 4:55 AM, Vittorio Giovara wrote: > From: Georg Martius > > vid.stab support for libav consists of two filters: > vidstabdetect and vidstabtransform > > Signed-off-by: Vittorio Giovara > --- You need to acknowledge other people who touched these files in FFmpeg: Cle'ment

Re: [libav-devel] [PATCH 3/3] [WIP]pthread_frame: fix rv40 threaded decode of clip starting with a bframe

On 08/13/2014 03:55 PM, Luca Barbato wrote: > On 13/08/14 23:13, John Stebbins wrote: >> Finish setting thread state, even if there is an error returned by >> update_context_from_thread. >> --- >> libavcodec/pthread_frame.c | 11 +++ >> 1 file changed, 3 insertions(+), 8 deletions(-) >> >

Re: [libav-devel] [PATCH 2/2] fate: vidstab tests

On Fri, Aug 15, 2014 at 2:00 PM, Clément Bœsch wrote: > > BTW, your other patch is missing some authorship attributions. > Thanks for your review, Clément. Let me CC the author of the patch/filter, as I have no idea who else you are referring to. Georg, should we add any more authors to the filte

Re: [libav-devel] [PATCH 2/2] fate: vidstab tests

On Fri, Aug 15, 2014 at 12:55:50PM +0100, Vittorio Giovara wrote: > vidstabtransform depends on what is output from vidstabdetect, so the two > are piped together. > --- > This is the first time a test depends on the ouput of another test, so I > did a one depend on the other and pipe the two. It s

[libav-devel] [PATCH 2/2] fate: vidstab tests

vidstabtransform depends on what is output from vidstabdetect, so the two are piped together. --- This is the first time a test depends on the ouput of another test, so I did a one depend on the other and pipe the two. It seems to work but I don't know if there are better solutions. Cheers, Vi

[libav-devel] [PATCH 1/2] deshake/stabilisation filters

From: Georg Martius vid.stab support for libav consists of two filters: vidstabdetect and vidstabtransform Signed-off-by: Vittorio Giovara --- Here is the filter kindly provided by the author, please keep him in CC. I just added version bump, changelog entry and a few minor cosmetics. Cheers,

[libav-devel] [PATCH] adts: return correct error code from extradata

--- libavformat/adtsenc.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/libavformat/adtsenc.c b/libavformat/adtsenc.c index bf7a62a..bb54658 100644 --- a/libavformat/adtsenc.c +++ b/libavformat/adtsenc.c @@ -57,23 +57,23 @@ static int adts_decode_extradata(AVF

[libav-devel] [PATCH 0/6] matroska 3d

Here is the set with the changes and the comments received. 1 and 2 did not change, so they should be already OK. Cheers, Vittorio Vittorio Giovara (6): matroska: list supported extensions stereo3d: expand the list of supported types avcodec: add stream-level stereo3d side data mkv: pa

[libav-devel] [PATCH 2/6] stereo3d: expand the list of supported types

Add multiview mode and the anaglyph modes supported by Matroska. --- doc/APIchanges| 3 +++ libavfilter/vf_showinfo.c | 3 +++ libavutil/stereo3d.h | 19 +++ libavutil/version.h | 2 +- 4 files changed, 26 insertions(+), 1 deletion(-) diff --git a/doc/API

[libav-devel] [PATCH 4/6] mkv: parse stereo mode on decoding

Convert the Matroska stereo format to the Stereo3D format, and add a Stereo3D side data to the stream. Bump the doctype version supported. --- libavformat/matroska.c| 70 +++ libavformat/matroska.h| 3 ++ libavformat/matroskadec.c | 10 +--

[libav-devel] [PATCH 5/6] mkv: convert avstream stereo3d side data during encoding

Write the StereoMode Embl to bitstream. --- libavformat/matroskaenc.c | 96 ++- 1 file changed, 78 insertions(+), 18 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index b55ad35..3693883 100644 --- a/libavformat/matroska

[libav-devel] [PATCH 1/6] matroska: list supported extensions

--- libavformat/matroskadec.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index f15b0b3..9ffb80a 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -2601,6 +2601,7 @@ static int matroska_read_close(AVFormatContext

[libav-devel] [PATCH 6/6] mkv: support multistream stereo tracks

Partially based on a patch by Aurelien Jacobs . --- libavformat/matroska.h| 7 +++ libavformat/matroskadec.c | 110 ++ 2 files changed, 117 insertions(+) diff --git a/libavformat/matroska.h b/libavformat/matroska.h index d8f4f8e..81f4dfd 100644 --

[libav-devel] [PATCH 3/6] avcodec: add stream-level stereo3d side data

--- doc/APIchanges | 3 +++ libavcodec/avcodec.h | 6 + libavcodec/utils.c | 9 libavcodec/version.h | 2 +- libavformat/dump.c | 63 5 files changed, 82 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/

Re: [libav-devel] [PATCH] build: Add explanatory comments to (optimization) blocks in the Makefiles

On 31/07/14 16:43, Diego Biurrun wrote: > --- > libavcodec/Makefile | 2 +- > libavcodec/arm/Makefile | 18 ++ > libavcodec/ppc/Makefile | 2 ++ > libavcodec/x86/Makefile | 10 ++ > 4 files changed, 31 insertions(+), 1 deletion(-) > Ok, better add this part also in

Re: [libav-devel] [PATCH] build: Add explanatory comments to (optimization) blocks in the Makefiles

On Thu, Jul 31, 2014 at 07:43:21AM -0700, Diego Biurrun wrote: > --- > libavcodec/Makefile | 2 +- > libavcodec/arm/Makefile | 18 ++ > libavcodec/ppc/Makefile | 2 ++ > libavcodec/x86/Makefile | 10 ++ > 4 files changed, 31 insertions(+), 1 deletion(-) ping Diego _