Re: [libav-devel] [PATCH 1/2] movenc: Add a flag for indicating a discontinuous fragment

2014-11-23 Thread Luca Barbato
On 22/11/14 22:55, Martin Storsjö wrote: This allows creating a later mp4 fragment without sequentially writing the earlier ones before (when called from a segmenter). Normally when writing a fragmented mp4 file sequentially, the first timestamps of a fragment are adjusted to match the end of

Re: [libav-devel] [PATCH 2/2] movenc: Expose the fragment index as an avoption

2014-11-23 Thread Luca Barbato
On 22/11/14 22:55, Martin Storsjö wrote: This allows setting the right fragment number if doing random-access writing of fragments, and also allows reading the current sequence number. --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c

Re: [libav-devel] [PATCH] v210enc: Add x86 SIMD

2014-11-23 Thread Luca Barbato
On 22/11/14 21:58, Kieran Kunhya wrote: --- libavcodec/v210enc.c | 78 ++- libavcodec/v210enc.h | 31 + libavcodec/x86/Makefile | 2 ++ libavcodec/x86/v210enc.asm| 76

Re: [libav-devel] [PATCH 1/2] movenc: Add a flag for indicating a discontinuous fragment

2014-11-23 Thread Martin Storsjö
On Sun, 23 Nov 2014, Luca Barbato wrote: On 22/11/14 22:55, Martin Storsjö wrote: This allows creating a later mp4 fragment without sequentially writing the earlier ones before (when called from a segmenter). Normally when writing a fragmented mp4 file sequentially, the first timestamps of a

Re: [libav-devel] [PATCH 1/2] movenc: Add a flag for indicating a discontinuous fragment

2014-11-23 Thread Martin Storsjö
On Sat, 22 Nov 2014, Bryan Huh wrote: On Sat, Nov 22, 2014 at 1:55 PM, Martin Storsjö mar...@martin.st wrote: This allows creating a later mp4 fragment without sequentially writing the earlier ones before (when called from a segmenter). Normally when writing a fragmented mp4 file

Re: [libav-devel] [PATCH 1/2] movenc: Add a flag for indicating a discontinuous fragment

2014-11-23 Thread Luca Barbato
On 23/11/14 14:51, Martin Storsjö wrote: On Sun, 23 Nov 2014, Luca Barbato wrote: On 22/11/14 22:55, Martin Storsjö wrote: This allows creating a later mp4 fragment without sequentially writing the earlier ones before (when called from a segmenter). Normally when writing a fragmented mp4

[libav-devel] [PATCH] cook: Make sure there is enough extradata

2014-11-23 Thread Luca Barbato
At least 8 bytes are needed (Mono audio). Bug-Id: CID 741418 CC: libav-sta...@libav.org --- I guess is quicker getting you the patch =P cook uses the first 8 bytes to setup for mono, then 8 more for stereo and random number for multichannel. libavcodec/cook.c | 2 +- 1 file changed, 1

[libav-devel] [PATCH] sidxindex: Write mimeType=audio/mp4 for audio-only representations

2014-11-23 Thread Martin Storsjö
This fixes playback with dash.js, when the input is one separate mp4 file per track. --- tools/sidxindex.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/sidxindex.c b/tools/sidxindex.c index da41d09..cb1b6c9 100644 --- a/tools/sidxindex.c +++ b/tools/sidxindex.c

[libav-devel] [PATCH] flvdec: Document how the duration is retrieved at the end of the file

2014-11-23 Thread Uwe L. Korn
--- libavformat/flvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 2d5e50e..e235c55 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -845,9 +845,13 @@ skip: if (s-pb-seekable (!s-duration || s-duration ==

Re: [libav-devel] [PATCH] flvdec: Document how the duration is retrieved at the end of the file

2014-11-23 Thread Luca Barbato
On 23/11/14 19:36, Uwe L. Korn wrote: --- libavformat/flvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 2d5e50e..e235c55 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -845,9 +845,13 @@ skip: if

Re: [libav-devel] [PATCH] sidxindex: Write mimeType=audio/mp4 for audio-only representations

2014-11-23 Thread Luca Barbato
On 23/11/14 16:41, Martin Storsjö wrote: This fixes playback with dash.js, when the input is one separate mp4 file per track. --- tools/sidxindex.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/sidxindex.c b/tools/sidxindex.c index da41d09..cb1b6c9 100644 ---

Re: [libav-devel] [PATCH] sidxindex: Write mimeType=audio/mp4 for audio-only representations

2014-11-23 Thread Martin Storsjö
On Sun, 23 Nov 2014, Martin Storsjö wrote: This fixes playback with dash.js, when the input is one separate mp4 file per track. --- tools/sidxindex.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/sidxindex.c b/tools/sidxindex.c index da41d09..cb1b6c9 100644 ---

Re: [libav-devel] [PATCH] sidxindex: Write mimeType=audio/mp4 for audio-only representations

2014-11-23 Thread Luca Barbato
On 23/11/14 20:31, Martin Storsjö wrote: On Sun, 23 Nov 2014, Martin Storsjö wrote: This fixes playback with dash.js, when the input is one separate mp4 file per track. --- tools/sidxindex.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/sidxindex.c

[libav-devel] [PATCH 2/2] lavu: fix memory leaks by using a mutex instead of atomics

2014-11-23 Thread Anton Khirnov
From: wm4 nfx...@googlemail.com The buffer pool has to atomically add and remove entries from the linked list of available buffers. This was done by removing the entire list with a CAS operation, working on it, and then setting it back again (using a retry-loop in case another thread was doing

[libav-devel] [PATCH 1/2] lavu: add wrappers for the pthreads mutex API

2014-11-23 Thread Anton Khirnov
Also add no-op fallbacks when threading is disabled. This helps keeping the code clean if Libav is compiled for targets without threading. Since we assume that no threads of any kind are used in such configurations, doing nothing is ok by definition. Based on a patch by wm4

Re: [libav-devel] [PATCH] flvdec: Document how the duration is retrieved at the end of the file

2014-11-23 Thread Martin Storsjö
On Sun, 23 Nov 2014, Uwe L. Korn wrote: --- libavformat/flvdec.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/flvdec.c b/libavformat/flvdec.c index 2d5e50e..e235c55 100644 --- a/libavformat/flvdec.c +++ b/libavformat/flvdec.c @@ -845,9 +845,13 @@ skip: if

Re: [libav-devel] [PATCH 1/2] lavu: add wrappers for the pthreads mutex API

2014-11-23 Thread Luca Barbato
On 23/11/14 21:31, Anton Khirnov wrote: Also add no-op fallbacks when threading is disabled. This helps keeping the code clean if Libav is compiled for targets without threading. Since we assume that no threads of any kind are used in such configurations, doing nothing is ok by definition.

Re: [libav-devel] [PATCH 2/2] lavu: fix memory leaks by using a mutex instead of atomics

2014-11-23 Thread Luca Barbato
On 23/11/14 21:31, Anton Khirnov wrote: From: wm4 nfx...@googlemail.com The buffer pool has to atomically add and remove entries from the linked list of available buffers. This was done by removing the entire list with a CAS operation, working on it, and then setting it back again (using a

Re: [libav-devel] [PATCH 09/10] mpegenc: prevent a NULL pointer dereference

2014-11-23 Thread Vittorio Giovara
On Sat, Nov 22, 2014 at 12:55 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: On Fri, Nov 21, 2014 at 4:14 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: g On Fri, Nov 21, 2014 at 3:55 PM, Martin Storsjö mar...@martin.st wrote: On Fri, 21 Nov 2014, Vittorio Giovara wrote: On

Re: [libav-devel] [PATCH] cook: Make sure there is enough extradata

2014-11-23 Thread Vittorio Giovara
On Sun, Nov 23, 2014 at 3:09 PM, Luca Barbato lu_z...@gentoo.org wrote: At least 8 bytes are needed (Mono audio). Bug-Id: CID 741418 CC: libav-sta...@libav.org --- I guess is quicker getting you the patch =P cook uses the first 8 bytes to setup for mono, then 8 more for stereo and random

Re: [libav-devel] ff_combine_frame usage fixes

2014-11-23 Thread Luca Barbato
On 20/11/14 16:41, Vittorio Giovara wrote: And with the power of git am and sed, here is the updated set, with small cosmetic fixes here and there. I reorder the set in three chapters, and I'd not mind to squash the cosmetics in a single one. Vittorio If there isn't any other comment I'd

[libav-devel] [PATCH] v210enc: Directly encode YUV422P to v210. About 6 times faster than existing (broken) swscale based path

2014-11-23 Thread Kieran Kunhya
--- libavcodec/v210enc.c | 151 +++--- libavcodec/v210enc.h | 4 +- libavcodec/x86/v210enc.asm| 104 - libavcodec/x86/v210enc_init.c | 13 +++- libavutil/x86/x86util.asm | 5 ++ 5 files changed, 218

Re: [libav-devel] [PATCH] v210enc: Directly encode YUV422P to v210. About 6 times faster than existing (broken) swscale based path

2014-11-23 Thread Luca Barbato
On 23/11/14 23:13, Kieran Kunhya wrote: --- libavcodec/v210enc.c | 151 +++--- libavcodec/v210enc.h | 4 +- libavcodec/x86/v210enc.asm| 104 - libavcodec/x86/v210enc_init.c | 13 +++-

Re: [libav-devel] [PATCH 01/10] vc1: fix bad shift operations

2014-11-23 Thread Luca Barbato
On 21/11/14 13:57, Vittorio Giovara wrote: From: Michael Niedermayer michae...@gmx.at CC: libav-sta...@libav.org Bug-Id: CID 1194380 / CID 1194381 --- libavcodec/vc1_block.c | 12 First, what's the value of v-is_intra ? vc1_block.c 1560 block_intra |=

[libav-devel] [PATCH 1/3] lavc: Add DSS_SP decoder

2014-11-23 Thread Vittorio Giovara
From: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Luca Barbato lu_z...@gentoo.org Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com --- Updated patch with version and changelog entry and placed the public entry in the right

[libav-devel] [PATCH 2/3] lavf: Add DSS demuxer

2014-11-23 Thread Vittorio Giovara
From: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Luca Barbato lu_z...@gentoo.org Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com --- Changelog and version bump. Vittorio Changelog| 2 +-

[libav-devel] [PATCH 3/3] fate: Add tests for DSS

2014-11-23 Thread Vittorio Giovara
--- Using the test the author provided. They are going to be tested on oracle too before pushing. Vittorio tests/fate/audio.mak | 4 + tests/ref/fate/dss-lp | 737 ++ tests/ref/fate/dss-sp | 334 +++ 3 files changed, 1075

Re: [libav-devel] [PATCH 3/3] fate: Add tests for DSS

2014-11-23 Thread Timothy Gu
On Sun, Nov 23, 2014 at 2:59 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Using the test the author provided. They are going to be tested on oracle too before pushing. Vittorio tests/fate/audio.mak | 4 + tests/ref/fate/dss-lp | 737

Re: [libav-devel] [PATCH 3/3] fate: Add tests for DSS

2014-11-23 Thread Vittorio Giovara
On Sun, Nov 23, 2014 at 11:20 PM, Timothy Gu timothyg...@gmail.com wrote: On Sun, Nov 23, 2014 at 2:59 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Using the test the author provided. They are going to be tested on oracle too before pushing. Vittorio tests/fate/audio.mak |

[libav-devel] [PATCH 1/3] vc1: Simplify a little setting the intra variables

2014-11-23 Thread Luca Barbato
The code currently set the information in at least 4 places, spare some pointless loops. Make the code in the loop a little uniform to make easier factorize it out later. --- libavcodec/vc1_block.c | 26 +++--- 1 file changed, 11 insertions(+), 15 deletions(-) diff --git

[libav-devel] [PATCH 2/3] vc1: Set the is_intra bitfield to all 1 when needed

2014-11-23 Thread Luca Barbato
Keep the code as similar as possible across the codepaths to ease spotting it for factorization. Based on a patch from Michael Niedermayer michae...@gmx.at. --- libavcodec/vc1_block.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/vc1_block.c

[libav-devel] [PATCH 3/3] vc1: Use the correct shift amount

2014-11-23 Thread Luca Barbato
From: Michael Niedermayer michae...@gmx.at `is_intra` is a 6bits bitfield. CC: libav-sta...@libav.org Bug-Id: CID 1194380 / CID 1194381 Signed-off-by: Luca Barbato lu_z...@gentoo.org --- libavcodec/vc1_loopfilter.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff

[libav-devel] [PATCH] hnm4: Use av_image_check_size

2014-11-23 Thread Luca Barbato
As done for all the other codecs not calling it indirectly. Bug-Id: CID 1135770 / CID 1135771 CC: libav-sta...@libav.org --- Looks like we weren't checking. libavcodec/hnm4video.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavcodec/hnm4video.c b/libavcodec/hnm4video.c index

[libav-devel] [PATCH] mpeg4video_parser: check return values in header decoding

2014-11-23 Thread Vittorio Giovara
Also make sure not to reuse the same variable. CC: libav-sta...@libav.org Bug-Id: CID 1238840 --- From the parsers batch, got left behind. Vittorio libavcodec/h263dec.c | 4 +++- libavcodec/mpeg4video_parser.c | 12 ++-- 2 files changed, 13 insertions(+), 3 deletions(-) diff

[libav-devel] [PATCH] mpegvideo_parser: check ff_set_dimensions return value

2014-11-23 Thread Vittorio Giovara
Also correctly propagate errors to mpegvideo_parse. CC: libav-sta...@libav.org Bug-Id: CID 1135741 --- Another lost patch. Vittorio libavcodec/mpegvideo_parser.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/libavcodec/mpegvideo_parser.c

Re: [libav-devel] [PATCH 01/10] apedec: fix bit shift typo check, prevent undefined behavior

2014-11-23 Thread Luca Barbato
On 12/11/14 19:10, Vittorio Giovara wrote: From: Michael Niedermayer michae...@gmx.at CC: libav-sta...@libav.org Bug-Id: CID 1206639 Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com --- libavcodec/apedec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH] mpegvideo_parser: check ff_set_dimensions return value

2014-11-23 Thread Luca Barbato
On 24/11/14 01:19, Vittorio Giovara wrote: Also correctly propagate errors to mpegvideo_parse. CC: libav-sta...@libav.org Bug-Id: CID 1135741 --- Another lost patch. Vittorio libavcodec/mpegvideo_parser.c | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-)

Re: [libav-devel] [PATCH] mpeg4video_parser: check return values in header decoding

2014-11-23 Thread Luca Barbato
On 24/11/14 01:10, Vittorio Giovara wrote: Also make sure not to reuse the same variable. CC: libav-sta...@libav.org Bug-Id: CID 1238840 --- From the parsers batch, got left behind. Vittorio Ok ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 10/11] roqaudioenc: Fix crash with very small roq files

2014-11-23 Thread Luca Barbato
On 12/11/14 11:13, Vittorio Giovara wrote: From: Michael Niedermayer michae...@gmx.at Also remove redundant check. roqaudio: Always use the frame buffer on flush Prevent NULL dereference. The patch itself looks fine. ___ libav-devel mailing list

Re: [libav-devel] [PATCH 04/10] aacsbr: always initialize max_qmf_subbands

2014-11-23 Thread Luca Barbato
On 21/11/14 13:57, Vittorio Giovara wrote: Fixes a wordly warning from clang -Wsometimes-uninitialized. --- libavcodec/aacsbr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aacsbr.c b/libavcodec/aacsbr.c index 76c1014..52ebe65 100644 --- a/libavcodec/aacsbr.c

Re: [libav-devel] [PATCH 04/12] mpegaudio_tablegen: refactor to avoid casting

2014-11-23 Thread Luca Barbato
On 04/11/14 15:36, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1238835 --- libavcodec/mpegaudio_tablegen.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegaudio_tablegen.h b/libavcodec/mpegaudio_tablegen.h index 8a3e51a..110d4f2 100644

[libav-devel] [PATCH] vc1pred: remove logically dead code

2014-11-23 Thread Vittorio Giovara
CC: libav-sta...@libav.org Bug-Id: CID 1245699 / CID 1245700 --- libavcodec/vc1_pred.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index 6a54fe4..87efcd2 100644 --- a/libavcodec/vc1_pred.c +++ b/libavcodec/vc1_pred.c

Re: [libav-devel] [PATCH] vc1pred: remove logically dead code

2014-11-23 Thread Luca Barbato
On 24/11/14 02:38, Vittorio Giovara wrote: CC: libav-sta...@libav.org Bug-Id: CID 1245699 / CID 1245700 --- libavcodec/vc1_pred.c | 9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/libavcodec/vc1_pred.c b/libavcodec/vc1_pred.c index 6a54fe4..87efcd2 100644 ---

Re: [libav-devel] [PATCH 1/3] lavc: Add DSS_SP decoder

2014-11-23 Thread Oleksij Rempel
Am 23.11.2014 um 23:59 schrieb Vittorio Giovara: From: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Oleksij Rempel li...@rempel-privat.de Signed-off-by: Luca Barbato lu_z...@gentoo.org Signed-off-by: Vittorio Giovara vittorio.giov...@gmail.com --- Updated patch with version and

Re: [libav-devel] [PATCH 3/3] fate: Add tests for DSS

2014-11-23 Thread Oleksij Rempel
Am 24.11.2014 um 00:37 schrieb Vittorio Giovara: On Sun, Nov 23, 2014 at 11:20 PM, Timothy Gu timothyg...@gmail.com wrote: On Sun, Nov 23, 2014 at 2:59 PM, Vittorio Giovara vittorio.giov...@gmail.com wrote: --- Using the test the author provided. They are going to be tested on oracle too