[libav-devel] [PATCH] avfilter: Return more meaningful error codes

2015-02-22 Thread Himangi Saraogi
--- libavfilter/avfilter.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 4098973..bfe8cb3 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter/avfilter.c @@ -79,7 +79,7 @@ int avfilter_link(AVFilterContext *src, uns

[libav-devel] [PATCH] vaapi: Return more meaningful error codes

2015-02-22 Thread Himangi Saraogi
--- libavcodec/vaapi_h264.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) diff --git a/libavcodec/vaapi_h264.c b/libavcodec/vaapi_h264.c index 651a50b..06173a6 100644 --- a/libavcodec/vaapi_h264.c +++ b/libavcodec/vaapi_h264.c @@ -95,7 +95,7 @@ static int dpb_add(DPB *dp

Re: [libav-devel] [PATCH 1/4] avcodec/a64multienc: use av_frame_ref instead of copying the frame

2015-02-22 Thread Andreas Cadhalpun
On 22.02.2015 23:23, Luca Barbato wrote: On 22/02/15 21:56, Andreas Cadhalpun wrote: using the a64multienc encoder currently results in a crash due to a double free. This seems to be broken since [1]. I would expect that an unref would be needed somewhere, do we have a fate test for it? The

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Vittorio Giovara
On Sun, Feb 22, 2015 at 8:41 PM, Timothy Gu wrote: > On Sun Feb 22 2015 at 12:33:29 PM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> Since not all systems need the libraw1394 dependency, > > > …for example? Well homebrew on OSX is one, there might be others though. > let pkg-confi

Re: [libav-devel] [PATCH 1/4] avcodec/a64multienc: use av_frame_ref instead of copying the frame

2015-02-22 Thread Luca Barbato
On 22/02/15 21:56, Andreas Cadhalpun wrote: Hi, using the a64multienc encoder currently results in a crash due to a double free. This seems to be broken since [1]. I would expect that an unref would be needed somewhere, do we have a fate test for it? lu

Re: [libav-devel] [PATCH] rtsp: punch holes again after pause

2015-02-22 Thread Thomas Volkert
On 22.02.2015 22:19, Martin Storsjö wrote: From: Gilles Chanteperdrix When a client behind a NAT issues a pause command, and stay paused for a long time, the router may stop the RTP/RTCP port redirection. Resend the hole punching packets before each PLAY command to cause the router to restart

Re: [libav-devel] [PATCH] rtpdec_hevc: Skip 1 byte (DOND) instead of 2 (DONL) between aggregation units

2015-02-22 Thread Thomas Volkert
On 22.02.2015 22:26, Martin Storsjö wrote: Only the first aggregation unit has 2 bytes (DONL) prepended, if such a field is in use. --- libavformat/rtpdec_h264.c | 9 +++-- libavformat/rtpdec_hevc.c | 8 +++- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavformat

[libav-devel] [PATCH] rtpdec_hevc: Skip 1 byte (DOND) instead of 2 (DONL) between aggregation units

2015-02-22 Thread Martin Storsjö
Only the first aggregation unit has 2 bytes (DONL) prepended, if such a field is in use. --- libavformat/rtpdec_h264.c | 9 +++-- libavformat/rtpdec_hevc.c | 8 +++- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c index

Re: [libav-devel] [PATCH] rtsp: punch holes again after pause

2015-02-22 Thread Gilles Chanteperdrix
On Sun, Feb 22, 2015 at 11:07:20PM +0200, Martin Storsjö wrote: > -/* Try to initialize the connection state in a > - * potential NAT router by sending dummy packets. > - * RTP/RTCP dummy packets are used for RDT, too. > - */ > -if (CONFIG

[libav-devel] [PATCH] rtsp: punch holes again after pause

2015-02-22 Thread Martin Storsjö
From: Gilles Chanteperdrix When a client behind a NAT issues a pause command, and stay paused for a long time, the router may stop the RTP/RTCP port redirection. Resend the hole punching packets before each PLAY command to cause the router to restart the port redirection in that case. Move the e

Re: [libav-devel] [PATCH] rtsp: punch holes again after pause

2015-02-22 Thread Martin Storsjö
On Sun, 22 Feb 2015, Gilles Chanteperdrix wrote: On Sun, Feb 22, 2015 at 11:07:20PM +0200, Martin Storsjö wrote: -/* Try to initialize the connection state in a - * potential NAT router by sending dummy packets. - * RTP/RTCP dummy packets are used for RDT, to

[libav-devel] [PATCH] rtsp: punch holes again after pause

2015-02-22 Thread Martin Storsjö
From: Gilles Chanteperdrix When a client behind a NAT issues a pause command, and stay paused for a long time, the router may stop the RTP/RTCP port redirection. Resend the hole punching packets before each PLAY command to cause the router to restart the port redirection in that case. Move the e

[libav-devel] [PATCH 4/4] avcodec/a64multienc: fix use of uninitialised values in, to_meta_with_crop

2015-02-22 Thread Andreas Cadhalpun
Hi, this patch fixes another case of using uninitialized values. Best regards, Andreas >From 469ebfec4f33b807d7e27abfc38d8f392481b792 Mon Sep 17 00:00:00 2001 From: Andreas Cadhalpun Date: Sun, 22 Feb 2015 20:48:38 +0100 Subject: [PATCH 4/4] avcodec/a64multienc: fix use of uninitialized values

[libav-devel] [PATCH 3/4] avcodec/a64multienc: initialize mc_meta_charset to zero

2015-02-22 Thread Andreas Cadhalpun
Hi, without this patch valgrind complains loudly about 'Conditional jump or move depends on uninitialised value(s)' in avpriv_do_elbg. (This patch applies to libav after cherry-picking [1].) Best regards, Andreas 1: https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=e4c180c05ac9aed33c16

[libav-devel] [PATCH 2/4] avcodec/a64multienc: don't set incorrect packet size

2015-02-22 Thread Andreas Cadhalpun
Hi, increasing the packet size without enlarging the packet buffer can't be correct... This seems to be broken since [1]. Best regards, Andreas 1: https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=7340008f18dc7d1557efbf5a331c9452913f7f61 >From c1bc01a84654df6a0e9ec4ea62f95920bfb80e32 Mon

[libav-devel] [PATCH 1/4] avcodec/a64multienc: use av_frame_ref instead of copying the frame

2015-02-22 Thread Andreas Cadhalpun
Hi, using the a64multienc encoder currently results in a crash due to a double free. This seems to be broken since [1]. Attached patch fixes this. Best regards, Andreas 1: https://git.videolan.org/?p=ffmpeg.git;a=commitdiff;h=13e9cc9ce0646ba8e31d837b5e6372ec80fa7a73 >From 78b5bdd67c72fbb316

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Timothy Gu
On Sun Feb 22 2015 at 12:33:29 PM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > Since not all systems need the libraw1394 dependency, …for example? let pkg-config > provide the list of libraries actually needed. > > The libdc1394-2.pc file has been included since version 2, so it >

Re: [libav-devel] [PATCH] Add a QSV decoding example.

2015-02-22 Thread Luca Barbato
On 22/02/15 18:52, Anton Khirnov wrote: --- Now with the va-x11 dependency --- configure | 7 + doc/Makefile | 1 + doc/examples/qsvdec.c | 484 ++ 3 files changed, 492 insertions(+) create mode 100644 doc/examples/qs

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Martin Storsjö
On Sun, 22 Feb 2015, Vittorio Giovara wrote: Since not all systems need the libraw1394 dependency, let pkg-config provide the list of libraries actually needed. Ok, this is a good reason. // Martin ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] libschroedinger: Check memory allocations

2015-02-22 Thread Luca Barbato
On 22/02/15 20:49, Vittorio Giovara wrote: --- libavcodec/libschroedinger.c| 2 ++ libavcodec/libschroedingerdec.c | 2 ++ libavcodec/libschroedingerenc.c | 4 3 files changed, 8 insertions(+) Fine. ___ libav-devel mailing list libav-d

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Luca Barbato
On 22/02/15 21:33, Vittorio Giovara wrote: Since not all systems need the libraw1394 dependency, let pkg-config provide the list of libraries actually needed. The libdc1394-2.pc file has been included since version 2, so it should be safe to use. --- Amended commit log as instructed. Vittorio

Re: [libav-devel] [PATCH] configure: Properly fail when libcdio/cdparanoia is not found

2015-02-22 Thread Luca Barbato
On 22/02/15 20:49, Vittorio Giovara wrote: --- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 4543b00..c1d673c 100755 --- a/configure +++ b/configure @@ -4298,7 +4298,8 @@ enabled_any sndio_indev sndio_outdev && check_lib2 sndio.h s

[libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Vittorio Giovara
Since not all systems need the libraw1394 dependency, let pkg-config provide the list of libraries actually needed. The libdc1394-2.pc file has been included since version 2, so it should be safe to use. --- Amended commit log as instructed. Vittorio configure | 2 +- 1 file changed, 1 insertio

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Martin Storsjö
On Sun, 22 Feb 2015, Vittorio Giovara wrote: On Sun, Feb 22, 2015 at 7:27 PM, Martin Storsjö wrote: On Sun, 22 Feb 2015, Vittorio Giovara wrote: --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ... because libdc1394 can have other dependencies, which we need to know abou

[libav-devel] [PATCH] configure: Properly fail when libcdio/cdparanoia is not found

2015-02-22 Thread Vittorio Giovara
--- configure | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 4543b00..c1d673c 100755 --- a/configure +++ b/configure @@ -4298,7 +4298,8 @@ enabled_any sndio_indev sndio_outdev && check_lib2 sndio.h sio_open -lsndio if enabled libcdio; then

[libav-devel] [PATCH] libschroedinger: Check memory allocations

2015-02-22 Thread Vittorio Giovara
--- libavcodec/libschroedinger.c| 2 ++ libavcodec/libschroedingerdec.c | 2 ++ libavcodec/libschroedingerenc.c | 4 3 files changed, 8 insertions(+) diff --git a/libavcodec/libschroedinger.c b/libavcodec/libschroedinger.c index fc9188c..157433e 100644 --- a/libavcodec/libschroedinger.c

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Vittorio Giovara
On Sun, Feb 22, 2015 at 7:27 PM, Martin Storsjö wrote: > On Sun, 22 Feb 2015, Vittorio Giovara wrote: > >> --- >> configure | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > > ... because libdc1394 can have other dependencies, which we need to know > about if linking statically? > ... be

Re: [libav-devel] [PATCH] Canopus HQX decoder

2015-02-22 Thread Luca Barbato
On 22/02/15 19:38, Vittorio Giovara wrote: Based on work by Kostya Shishkov . --- Now without leaks on init failure. Cheers, Vittorio Changelog |1 + doc/general.texi |1 + libavcodec/Makefile|1 + libavcodec/allcodecs.c

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Luca Barbato
On 22/02/15 20:27, Martin Storsjö wrote: On Sun, 22 Feb 2015, Vittorio Giovara wrote: --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ... because libdc1394 can have other dependencies, which we need to know about if linking statically? Might in certain cases. ... becaus

[libav-devel] [PATCH 1/2] xcbgrab: Provide better names for the y and x option

2015-02-22 Thread Luca Barbato
Incidentally `-y` also collides with avconv global options. Update x11grab to match and document the option. CC: libav-sta...@libav.org --- doc/indevs.texi | 10 ++ libavdevice/x11grab.c | 2 ++ libavdevice/xcbgrab.c | 2 ++ 3 files changed, 14 insertions(+) diff --git a/doc/in

[libav-devel] [PATCH 2/2] xcbgrab: Unbreak parsing filename options

2015-02-22 Thread Luca Barbato
CC: libav-sta...@libav.org --- I would deprecate this soon. libavdevice/xcbgrab.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/libavdevice/xcbgrab.c b/libavdevice/xcbgrab.c index 032bbcc..6c5b872 100644 --- a/libavdevice/xcbgrab.c +++ b/libavdevice/xc

Re: [libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Martin Storsjö
On Sun, 22 Feb 2015, Vittorio Giovara wrote: --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) ... because libdc1394 can have other dependencies, which we need to know about if linking statically? ... because we prefer pkg-config for other reasons? ... because something else

[libav-devel] [PATCH] configure: Use pkg-config for libdc1394 discovery

2015-02-22 Thread Vittorio Giovara
--- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 8c618be..4543b00 100755 --- a/configure +++ b/configure @@ -4248,7 +4248,7 @@ fi # libdc1394 check if enabled libdc1394; then -{ check_lib dc1394/dc1394.h dc1394_new -ldc1394 -lraw

Re: [libav-devel] [PATCH] Canopus HQX decoder

2015-02-22 Thread Anton Khirnov
Quoting Vittorio Giovara (2015-02-22 19:38:31) > Based on work by Kostya Shishkov . > --- > Now without leaks on init failure. > Cheers, > Vittorio > > Changelog |1 + > doc/general.texi |1 + > libavcodec/Makefile|1 + > libavcodec/a

Re: [libav-devel] [PATCH] Add a QSV decoding example.

2015-02-22 Thread Luca Barbato
On 22/02/15 18:52, Anton Khirnov wrote: --- Now with the va-x11 dependency --- configure | 7 + doc/Makefile | 1 + doc/examples/qsvdec.c | 484 ++ 3 files changed, 492 insertions(+) create mode 100644 doc/examples/qs

[libav-devel] [PATCH] Add a QSV decoding example.

2015-02-22 Thread Anton Khirnov
--- Now with the va-x11 dependency --- configure | 7 + doc/Makefile | 1 + doc/examples/qsvdec.c | 484 ++ 3 files changed, 492 insertions(+) create mode 100644 doc/examples/qsvdec.c diff --git a/configure b/configure inde

Re: [libav-devel] [PATCH] hevc_deblock: Fix compilation with nasm

2015-02-22 Thread Luca Barbato
On 22/02/15 18:46, Vittorio Giovara wrote: From: Carl Eugen Hoyos CC: libav-sta...@libav.org Bug-Id: 795 Signed-off-by: Vittorio Giovara --- I don't have nasm, would be great if anyone could test. Vittorio libavcodec/x86/hevc_deblock.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletio

[libav-devel] [PATCH] hevc_deblock: Fix compilation with nasm

2015-02-22 Thread Vittorio Giovara
From: Carl Eugen Hoyos CC: libav-sta...@libav.org Bug-Id: 795 Signed-off-by: Vittorio Giovara --- I don't have nasm, would be great if anyone could test. Vittorio libavcodec/x86/hevc_deblock.asm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/x86/hevc_deblock

Re: [libav-devel] [PATCH 13/13] rtpdec_hevc: Implement parsing of aggregated packets

2015-02-22 Thread Thomas Volkert
On 19.02.2015 21:34, Martin Storsjö wrote: +res = ff_h264_handle_aggregated_packet(ctx, pkt, buf, len, + rtp_hevc_ctx->using_donl_field ? + RTP_HEVC_DONL_FIELD_SIZE : 0, +

Re: [libav-devel] [PATCH 1/2] Refactor msmpeg4_decode_dc() to return only an error code

2015-02-22 Thread Luca Barbato
On 22/02/15 07:22, Himangi Saraogi wrote: On 21 February 2015 at 07:19, Luca Barbato wrote: On 21/02/15 02:14, Himangi Saraogi wrote: On 21 February 2015 at 05:30, Luca Barbato wrote: On 21/02/15 00:55, Himangi Saraogi wrote: --- libavcodec/msmpeg4dec.c | 14 -- 1