On 12/05/15 6:00 PM, Luca Barbato wrote:
> On 11/05/15 17:25, Derek Buitenhuis wrote:
>> From: Gopu Govindaswamy
>
>
> The x265pic.bitDepth is set on encode_frame while I assume that this
> information should be used at init now.
>
> I'm not sure how recent is this api version, I hope it isn't
On 11/05/15 17:25, Derek Buitenhuis wrote:
> From: Gopu Govindaswamy
The x265pic.bitDepth is set on encode_frame while I assume that this
information should be used at init now.
I'm not sure how recent is this api version, I hope it isn't necessary
to consider adding a fallback path even if it
On 5/12/2015 6:55 PM, Diego Biurrun wrote:
> It would be nice if more people from your team worked in that spirit of
> cooperation instead of requiring that ffmpeg gsoc students not contribute
> to libav.
Requiring that students that air paid to work on ffmpeg, work on ffmpeg,
isn't exactly insane
On Wed, May 06, 2015 at 12:02:20PM +0200, Nicolas George wrote:
> Hi. I suspect that this bug affects you too, so in the spirit of cooperation
> here is the mail I sent about to ffmpeg-devel.
Thank you, Nicolas.
It would be nice if more people from your team worked in that spirit of
cooperation i
On Tue, May 12, 2015 at 08:31:39PM +0300, Martin Storsjö wrote:
> On Tue, 12 May 2015, Diego Biurrun wrote:
> >On Tue, May 12, 2015 at 05:55:35PM +0200, Luca Barbato wrote:
> >>--- a/libavcodec/libxvid.c
> >>+++ b/libavcodec/libxvid.c
> >>@@ -276,6 +276,8 @@ static int xvid_strip_vol_header(AVCodec
On 12/05/15 18:54, Diego Biurrun wrote:
> ---
>
> Not yet tested, sending as RFC...
>
> libavcodec/eatgv.c | 25 ++---
> 1 file changed, 14 insertions(+), 11 deletions(-)
>
Sounds good.
___
libav-devel mailing list
libav-devel@li
On 12/05/15 19:34, Diego Biurrun wrote:
> From: Vittorio Giovara
>
> Signed-off-by: Diego Biurrun
> ---
>
> Frees memory on svq1_encode_plane() failure, still needs testing.
>
> libavcodec/svq1enc.c | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/libavcodec/svq1enc.c b/
From: Vittorio Giovara
Signed-off-by: Diego Biurrun
---
Frees memory on svq1_encode_plane() failure, still needs testing.
libavcodec/svq1enc.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c
index f49f487..4f2d6e5 100644
--- a/libav
On Tue, 12 May 2015, Diego Biurrun wrote:
On Tue, May 12, 2015 at 05:55:35PM +0200, Luca Barbato wrote:
--- a/libavcodec/libxvid.c
+++ b/libavcodec/libxvid.c
@@ -276,6 +276,8 @@ static int xvid_strip_vol_header(AVCodecContext *avctx,
AVPacket *pkt,
/* We need to store the header, so e
On Tue, May 12, 2015 at 05:55:37PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/pthread_frame.c | 7 +++
> 1 file changed, 7 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav
On Tue, May 12, 2015 at 05:55:35PM +0200, Luca Barbato wrote:
> --- a/libavcodec/libxvid.c
> +++ b/libavcodec/libxvid.c
> @@ -276,6 +276,8 @@ static int xvid_strip_vol_header(AVCodecContext *avctx,
> AVPacket *pkt,
> /* We need to store the header, so extract it */
> if (!avctx->
On Tue, May 12, 2015 at 05:55:34PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/libx264.c | 4
> 1 file changed, 4 insertions(+)
Cleans up on failed init, hence OK.
Diego
___
libav-devel mailing list
libav-devel@libav
On Tue, May 12, 2015 at 05:55:32PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/lclenc.c | 2 ++
> 1 file changed, 2 insertions(+)
Does cleanup on init failure, hence OK.
Diego
___
libav-devel mailing list
libav-devel@liba
On Tue, May 12, 2015 at 05:55:30PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/huffyuvenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Does cleanup on init failure, hence OK.
Diego
___
libav-devel mailing lis
---
Not yet tested, sending as RFC...
libavcodec/eatgv.c | 25 ++---
1 file changed, 14 insertions(+), 11 deletions(-)
diff --git a/libavcodec/eatgv.c b/libavcodec/eatgv.c
index c400b56..2b10a45 100644
--- a/libavcodec/eatgv.c
+++ b/libavcodec/eatgv.c
@@ -151,7 +151,7 @@ sta
On Tue, May 12, 2015 at 05:55:29PM +0200, Luca Barbato wrote:
> --- a/libavcodec/eatgv.c
> +++ b/libavcodec/eatgv.c
> @@ -174,6 +174,8 @@ static int tgv_decode_inter(TgvContext *s, AVFrame *frame,
> /* allocate codebook buffers as necessary */
> if (num_mvs > s->num_mvs) {
> s->m
On Tue, May 12, 2015 at 05:55:27PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/asvenc.c | 2 ++
> 1 file changed, 2 insertions(+)
OK, does cleanup on init failure.
Diego
___
libav-devel mailing list
libav-devel@libav.org
On Tue, May 12, 2015 at 05:55:42PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/xsubdec.c | 13 +
> 1 file changed, 13 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.lib
On Tue, May 12, 2015 at 05:55:41PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/wmaenc.c | 4
> 1 file changed, 4 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailm
On Tue, May 12, 2015 at 05:55:40PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/truemotion2.c | 10 ++
> 1 file changed, 10 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.li
On 12/05/15 18:11, Diego Biurrun wrote:
> On Tue, May 12, 2015 at 05:55:33PM +0200, Luca Barbato wrote:
>> From: Vittorio Giovara
>>
>> ---
>> libavcodec/libtheoraenc.c | 6 ++
>> 1 file changed, 6 insertions(+)
>
> OK
Not ok, the capability is missing so it would leak.
lu
On Tue, May 12, 2015 at 05:55:38PM +0200, Luca Barbato wrote:
> --- a/libavcodec/ratecontrol.c
> +++ b/libavcodec/ratecontrol.c
> @@ -932,6 +934,11 @@ static int init_pass2(MpegEncContext *s)
>
> qscale = av_malloc(sizeof(double) * rcc->num_entries);
> blurred_qscale = av_malloc
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/xsubdec.c | 13 +
> 1 file changed, 13 insertions(+)
>
> diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c
> index d01b410..a7dd7ee 100644
> --- a/libavcodec/xsubdec.c
> +++ b/libavcodec/xsub
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/wmaenc.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c
> index e801663..c176daa 100644
> --- a/libavcodec/wmaenc.c
> +++ b/libavcodec/wmaenc.c
> @@ -62,1
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/truemotion2.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c
> index 122643d..094096e 100644
> --- a/libavcodec/truemotion2.c
> +++ b/li
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/svq1enc.c | 8
> 1 file changed, 8 insertions(+)
>
> diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c
> index f49f487..7620332 100644
> --- a/libavcodec/svq1enc.c
> +++ b/libavcodec/svq1enc.c
>
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/ratecontrol.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c
> index aae7570..6fe174a 100644
> --- a/libavcodec/ratecontrol.c
> +++ b/libavco
On Tue, May 12, 2015 at 05:55:36PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/psymodel.c | 12
> 1 file changed, 12 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.lib
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/pthread_frame.c | 7 +++
> 1 file changed, 7 insertions(+)
>
> diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c
> index effc9a5..d7f742b 100644
> --- a/libavcodec/pthread_frame.c
> +++ b
On Tue, May 12, 2015 at 05:55:33PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/libtheoraenc.c | 6 ++
> 1 file changed, 6 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.o
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/psymodel.c | 12
> 1 file changed, 12 insertions(+)
Ok.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/liba
On Tue, May 12, 2015 at 05:55:31PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/jpeglsdec.c | 6 ++
> 1 file changed, 6 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/libxvid.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
> index 46da773..97ff95b 100644
> --- a/libavcodec/libxvid.c
> +++ b/libavcodec/libxvid.c
> @
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/libx264.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
> index 841b824..d7d1df3 100644
> --- a/libavcodec/libx264.c
> +++ b/libavcodec/libx264.c
> @@
On Tue, May 12, 2015 at 05:55:28PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/dct.c | 2 ++
> 1 file changed, 2 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/li
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/libtheoraenc.c | 6 ++
> 1 file changed, 6 insertions(+)
Missing capability?
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/li
On Tue, May 12, 2015 at 05:55:26PM +0200, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/aacpsy.c | 6 ++
> 1 file changed, 6 insertions(+)
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mai
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/lclenc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/lclenc.c b/libavcodec/lclenc.c
> index 20841bc..2448b9e 100644
> --- a/libavcodec/lclenc.c
> +++ b/libavcodec/lclenc.c
> @@ -135,6
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/jpeglsdec.c | 6 ++
> 1 file changed, 6 insertions(+)
>
> diff --git a/libavcodec/jpeglsdec.c b/libavcodec/jpeglsdec.c
> index d9b08fb..3b93799 100644
> --- a/libavcodec/jpeglsdec.c
> +++ b/libavcodec/jpegl
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/huffyuvenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c
> index 6b3ff76..175b256 100644
> --- a/libavcodec/huffyuvenc.c
> +++ b/li
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/eatgv.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/eatgv.c b/libavcodec/eatgv.c
> index c400b56..5df4301 100644
> --- a/libavcodec/eatgv.c
> +++ b/libavcodec/eatgv.c
> @@ -174,6 +174,
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/dct.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/dct.c b/libavcodec/dct.c
> index 4dbbff8..180477e 100644
> --- a/libavcodec/dct.c
> +++ b/libavcodec/dct.c
> @@ -191,6 +191,8 @@ av_co
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/asvenc.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c
> index f8c52af..0879615 100644
> --- a/libavcodec/asvenc.c
> +++ b/libavcodec/asvenc.c
> @@ -299,6
On 12/05/15 17:55, Luca Barbato wrote:
> From: Vittorio Giovara
>
> ---
> libavcodec/aacpsy.c | 6 ++
> 1 file changed, 6 insertions(+)
>
Looks Ok.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav
From: Vittorio Giovara
---
libavcodec/pthread_frame.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/libavcodec/pthread_frame.c b/libavcodec/pthread_frame.c
index effc9a5..d7f742b 100644
--- a/libavcodec/pthread_frame.c
+++ b/libavcodec/pthread_frame.c
@@ -584,8 +584,15 @@ int ff_fra
From: Vittorio Giovara
---
libavcodec/xsubdec.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/libavcodec/xsubdec.c b/libavcodec/xsubdec.c
index d01b410..a7dd7ee 100644
--- a/libavcodec/xsubdec.c
+++ b/libavcodec/xsubdec.c
@@ -95,7 +95,13 @@ static int decode_frame(AVCodecCon
From: Vittorio Giovara
---
libavcodec/psymodel.c | 12
1 file changed, 12 insertions(+)
diff --git a/libavcodec/psymodel.c b/libavcodec/psymodel.c
index a2af611..5179ede 100644
--- a/libavcodec/psymodel.c
+++ b/libavcodec/psymodel.c
@@ -39,6 +39,12 @@ av_cold int ff_psy_init(FFPsyC
From: Vittorio Giovara
---
libavcodec/svq1enc.c | 8
1 file changed, 8 insertions(+)
diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c
index f49f487..7620332 100644
--- a/libavcodec/svq1enc.c
+++ b/libavcodec/svq1enc.c
@@ -293,6 +293,8 @@ static int svq1_encode_plane(SVQ1EncCont
From: Vittorio Giovara
---
libavcodec/ratecontrol.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/libavcodec/ratecontrol.c b/libavcodec/ratecontrol.c
index aae7570..6fe174a 100644
--- a/libavcodec/ratecontrol.c
+++ b/libavcodec/ratecontrol.c
@@ -163,6 +163,8 @@ av_cold int ff_rate_c
From: Vittorio Giovara
---
libavcodec/wmaenc.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/wmaenc.c b/libavcodec/wmaenc.c
index e801663..c176daa 100644
--- a/libavcodec/wmaenc.c
+++ b/libavcodec/wmaenc.c
@@ -62,11 +62,15 @@ static av_cold int encode_init(AVCodecContext *av
From: Vittorio Giovara
---
libavcodec/truemotion2.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libavcodec/truemotion2.c b/libavcodec/truemotion2.c
index 122643d..094096e 100644
--- a/libavcodec/truemotion2.c
+++ b/libavcodec/truemotion2.c
@@ -171,6 +171,10 @@ static int tm2_
From: Vittorio Giovara
---
libavcodec/libxvid.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c
index 46da773..97ff95b 100644
--- a/libavcodec/libxvid.c
+++ b/libavcodec/libxvid.c
@@ -276,6 +276,8 @@ static int xvid_strip_vol_header(AVCodecCo
From: Vittorio Giovara
---
libavcodec/libx264.c | 4
1 file changed, 4 insertions(+)
diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c
index 841b824..d7d1df3 100644
--- a/libavcodec/libx264.c
+++ b/libavcodec/libx264.c
@@ -542,6 +542,8 @@ static av_cold int X264_init(AVCodecContext
From: Vittorio Giovara
---
libavcodec/lclenc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/lclenc.c b/libavcodec/lclenc.c
index 20841bc..2448b9e 100644
--- a/libavcodec/lclenc.c
+++ b/libavcodec/lclenc.c
@@ -135,6 +135,8 @@ static av_cold int encode_init(AVCodecContext *avct
From: Vittorio Giovara
---
libavcodec/aacpsy.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/aacpsy.c b/libavcodec/aacpsy.c
index ac58968..6cfe3e3 100644
--- a/libavcodec/aacpsy.c
+++ b/libavcodec/aacpsy.c
@@ -298,6 +298,8 @@ static av_cold int psy_3gpp_init(FFPsyContext *
From: Vittorio Giovara
---
libavcodec/libtheoraenc.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c
index 462bc94..097336b 100644
--- a/libavcodec/libtheoraenc.c
+++ b/libavcodec/libtheoraenc.c
@@ -101,6 +101,8 @@ static int get_st
From: Vittorio Giovara
---
libavcodec/asvenc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c
index f8c52af..0879615 100644
--- a/libavcodec/asvenc.c
+++ b/libavcodec/asvenc.c
@@ -299,6 +299,8 @@ static av_cold int encode_init(AVCodecContext *avct
From: Vittorio Giovara
---
libavcodec/dct.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/dct.c b/libavcodec/dct.c
index 4dbbff8..180477e 100644
--- a/libavcodec/dct.c
+++ b/libavcodec/dct.c
@@ -191,6 +191,8 @@ av_cold int ff_dct_init(DCTContext *s, int nbits, enum
DCTTransfo
From: Vittorio Giovara
---
libavcodec/eatgv.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/libavcodec/eatgv.c b/libavcodec/eatgv.c
index c400b56..5df4301 100644
--- a/libavcodec/eatgv.c
+++ b/libavcodec/eatgv.c
@@ -174,6 +174,8 @@ static int tgv_decode_inter(TgvContext *s, AVFrame *fram
From: Vittorio Giovara
---
libavcodec/jpeglsdec.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/libavcodec/jpeglsdec.c b/libavcodec/jpeglsdec.c
index d9b08fb..3b93799 100644
--- a/libavcodec/jpeglsdec.c
+++ b/libavcodec/jpeglsdec.c
@@ -278,10 +278,16 @@ int ff_jpegls_decode_picture(M
From: Vittorio Giovara
---
libavcodec/huffyuvenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/huffyuvenc.c b/libavcodec/huffyuvenc.c
index 6b3ff76..175b256 100644
--- a/libavcodec/huffyuvenc.c
+++ b/libavcodec/huffyuvenc.c
@@ -155,7 +155,7 @@ static av_cold in
Now split in per-file patches... Review coming later.
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On 12/05/15 17:19, Vittorio Giovara wrote:
> ---
> libavcodec/dnxhddec.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
> index f821cb6..559fc3a 100644
> --- a/libavcodec/dnxhddec.c
> +++ b/libavcodec/dnxhddec.c
> @@ -119,
---
libavcodec/dnxhddec.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/libavcodec/dnxhddec.c b/libavcodec/dnxhddec.c
index f821cb6..559fc3a 100644
--- a/libavcodec/dnxhddec.c
+++ b/libavcodec/dnxhddec.c
@@ -119,7 +119,9 @@ static int dnxhd_decode_header(DNXHDContext *ctx,
On 5/12/2015 3:56 PM, Diego Biurrun wrote:
> I have no idea what you are trying to tell me. The reviewer should
> fix what the patch submitter failed to fix for n rounds of review?
I'll break it down. Please:
1) Be less condescending.
2) Be consistent between reviews in what you request.
3) Less
On Tue, May 12, 2015 at 03:49:52PM +0100, Derek Buitenhuis wrote:
> On 5/12/2015 3:45 PM, Diego Biurrun wrote:
> > Reviewer time is precious, so the onus is on the
> > patch submitter to ease the reviewer's burden.
>
> Everyone's time is precious,
Sure, but somehow it's difficult to find enough r
On 5/12/2015 3:45 PM, Diego Biurrun wrote:
> Reviewer time is precious, so the onus is on the
> patch submitter to ease the reviewer's burden.
Everyone's time is precious, and doing N rounds of review and
e.g. finding things the Nth time, that have been present since the
first revision, should not
On Tue, May 12, 2015 at 03:15:53PM +0100, Vittorio Giovara wrote:
> On Tue, May 12, 2015 at 9:10 AM, Diego Biurrun wrote:
> >> Because some parts were ok'd, some parts were rejected while they were
> >> actually ok, some parts needed to be redone. It was too confusing for
> >> me, I preferred a cl
On Tue, May 12, 2015 at 9:10 AM, Diego Biurrun wrote:
>> Because some parts were ok'd, some parts were rejected while they were
>> actually ok, some parts needed to be redone. It was too confusing for
>> me, I preferred a clean slate.
>
> The lesson here seems to be that the patch is too big and s
On Tue, May 12, 2015 at 2:53 PM, Derek Buitenhuis
wrote:
> On 5/12/2015 2:48 PM, Vittorio Giovara wrote:
>> buf is initialized with av_get_codec_tag_string which converts hex to
>> readable tags
>
> buf should be of size 21 then, no?
>
> e.g.: a tag of 0x -> [255][255][255][255] with null
On 5/12/2015 2:48 PM, Vittorio Giovara wrote:
> buf is initialized with av_get_codec_tag_string which converts hex to
> readable tags
buf should be of size 21 then, no?
e.g.: a tag of 0x -> [255][255][255][255] with null terminator.
- Derek
___
On Tue, May 12, 2015 at 2:29 PM, Derek Buitenhuis
wrote:
> On 5/11/2015 5:23 PM, Vittorio Giovara wrote:
>> +av_log(matroska->ctx, AV_LOG_ERROR,
>> + "mov FourCC not found %s.\n", buf);
>
> Is this guaranteed to be printable? Should it not be hex?
buf is init
On 5/11/2015 5:23 PM, Vittorio Giovara wrote:
> +av_log(matroska->ctx, AV_LOG_ERROR,
> + "mov FourCC not found %s.\n", buf);
Is this guaranteed to be printable? Should it not be hex?
- Derek
___
libav-devel mailing
On 12/05/15 14:20, Martin Storsjö wrote:
> On Tue, 12 May 2015, Luca Barbato wrote:
>
>> In short, I'd spend even more time to make sure that everything gets
>> standardized to pkg-config in the medium/short term.
>
> That sounds like a good plan to me - how many of our common dependency
> libs d
On Tue, 12 May 2015, Luca Barbato wrote:
In short, I'd spend even more time to make sure that everything gets
standardized to pkg-config in the medium/short term.
That sounds like a good plan to me - how many of our common dependency
libs don't provide pkg-config?
// Martin
On 12/05/15 12:24, Martin Storsjö wrote:
>
> But if you think it's a hack, I'll keep on feeling that using pkg-config
> for libs is slightly more work than when relying on include/lib paths
> (except for the cases with libraries with transitive dependencies where
> pkg-config is a must), for my us
On Tue, 12 May 2015, Diego Biurrun wrote:
On Tue, May 12, 2015 at 12:34:25AM +0200, Luca Barbato wrote:
On 11/05/15 23:09, Diego Biurrun wrote:
On Wed, May 06, 2015 at 01:37:31PM +0200, Luca Barbato wrote:
Useful to have `make config` work with custom pkgconf path.
---
configure | 6 ++
On 12/05/15 10:26, Diego Biurrun wrote:
> On Tue, May 12, 2015 at 12:34:25AM +0200, Luca Barbato wrote:
>> On 11/05/15 23:09, Diego Biurrun wrote:
>>> On Wed, May 06, 2015 at 01:37:31PM +0200, Luca Barbato wrote:
Useful to have `make config` work with custom pkgconf path.
---
config
On Tue, May 12, 2015 at 12:34:25AM +0200, Luca Barbato wrote:
> On 11/05/15 23:09, Diego Biurrun wrote:
> > On Wed, May 06, 2015 at 01:37:31PM +0200, Luca Barbato wrote:
> >> Useful to have `make config` work with custom pkgconf path.
> >> ---
> >> configure | 6 ++
> >> 1 file changed, 6 inse
On Tue, May 12, 2015 at 02:15:32AM +0100, Vittorio Giovara wrote:
> On Sat, May 2, 2015 at 4:25 PM, Diego Biurrun wrote:
> > On Wed, Apr 29, 2015 at 07:18:27PM +0100, Vittorio Giovara wrote:
> >> ---
> >> As the commented case were cleared in separate patches, this last version
> >> should address
80 matches
Mail list logo