[libav-devel] [PATCH] tls: fix compilation when both gnutls and openssl are enabled

2015-05-22 Thread Martin Storsjö
From: James Almer jamr...@gmail.com --- While such a configuration probably doesn't make much sense, we shouldn't fail to compile there. --- libavformat/tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/tls.c b/libavformat/tls.c index 7ce9817..00fe876 100644

[libav-devel] [PATCH 2/3] nutdec: always check the get_str return value

2015-05-22 Thread Andreas Cadhalpun
If it fails, the buffers can be (partially) uninitialized. This fixes 'Conditional jump or move depends on uninitialised value(s)' valgrind warnings. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/nutdec.c | 27 ++- 1 file changed, 22

[libav-devel] [PATCH 3/3] nutdec: fix various memleaks on failure

2015-05-22 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/nutdec.c | 77 +--- 1 file changed, 55 insertions(+), 22 deletions(-) diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c index 969f446..fc40f57 100644 ---

[libav-devel] [PATCH 1/3] nutdec: initialize has_keyframe[0]

2015-05-22 Thread Andreas Cadhalpun
If x is 2 it is not initialized before it is used. This fixes 'Conditional jump or move depends on uninitialised value(s)' valgrind warnings. Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavformat/nutdec.c | 1 + 1 file changed, 1 insertion(+) diff --git

[libav-devel] [PATCH] x86/cpu: add AV_CPU_FLAG_AVXSLOW flag

2015-05-22 Thread James Almer
Signed-off-by: James Almer jamr...@gmail.com --- doc/APIchanges | 3 +++ libavutil/cpu.c | 3 +++ libavutil/cpu.h | 1 + libavutil/version.h | 4 ++-- libavutil/x86/cpu.c | 17 ++--- 5 files changed, 23 insertions(+), 5 deletions(-) diff --git a/doc/APIchanges

Re: [libav-devel] [PATCH] tls: fix compilation when both gnutls and openssl are enabled

2015-05-22 Thread Luca Barbato
On 22/05/15 08:40, Martin Storsjö wrote: From: James Almer jamr...@gmail.com --- While such a configuration probably doesn't make much sense, we shouldn't fail to compile there. --- libavformat/tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Configure should pick one

Re: [libav-devel] [PATCH] tls: fix compilation when both gnutls and openssl are enabled

2015-05-22 Thread wm4
On Fri, 22 May 2015 09:40:49 +0300 Martin Storsjö mar...@martin.st wrote: From: James Almer jamr...@gmail.com --- While such a configuration probably doesn't make much sense, we shouldn't fail to compile there. --- libavformat/tls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libav-devel] [PATCH] configure: Prefer GNUTLS over OpenSSL if both available

2015-05-22 Thread Luca Barbato
And warn about it. --- OpenSSL requires nonfree. configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 5bcc2df..70b3e84 100755 --- a/configure +++ b/configure @@ -4289,6 +4289,11 @@ if enabled gnutls; then { check_lib gcrypt.h gcry_mpi_new -lgcrypt

Re: [libav-devel] [PATCH 1/3] lavc: Introduce a DXTC module

2015-05-22 Thread Vittorio Giovara
On Thu, May 21, 2015 at 2:04 PM, Tom Butterworth bangno...@gmail.com wrote: Hi Vittorio +++ b/libavcodec/dxtc_dec.c Couldn't the existing s3tc.c be refactored and extended instead of rewritten from scratch? there are a lot of limitations in s3tc, and it's quite unmaintained I went for the

[libav-devel] [PATCH 1/2] lavf: split tls.c

2015-05-22 Thread wm4
Move the OpenSSL and GnuTLS implementations to their own files. Other than the connection code (including options) and some boilerplate, no code is actually shared. --- There is a minor change in behavior: now the equivalent of TLS_shutdown is called both on normal closing, and closing on the

[libav-devel] [PATCH 2/2] lavf: remove TLS related ifdeffery to library specific files

2015-05-22 Thread wm4
There is no need to have this mess in network.c. --- libavformat/network.c | 83 +++ libavformat/tls_common.h | 6 libavformat/tls_gnutls.c | 26 +++ libavformat/tls_openssl.c | 64 4 files

Re: [libav-devel] [PATCH 1/2] lavf: split tls.c

2015-05-22 Thread Luca Barbato
On 22/05/15 14:15, wm4 wrote: Move the OpenSSL and GnuTLS implementations to their own files. Other than the connection code (including options) and some boilerplate, no code is actually shared. --- There is a minor change in behavior: now the equivalent of TLS_shutdown is called both on

Re: [libav-devel] [PATCH 2/3] HAP decoder and encoder

2015-05-22 Thread Vittorio Giovara
On Thu, May 21, 2015 at 4:18 PM, Tom Butterworth bangno...@gmail.com wrote: diff --git a/Changelog b/Changelog index 9d73449..f7c59e9 100644 --- a/Changelog +++ b/Changelog @@ -30,6 +30,7 @@ version next: - Canopus HQ/HQA decoder - Automatically rotate videos based on metadata in avconv

Re: [libav-devel] [PATCH 1/4] mpegvideo: Drop flags and flags2

2015-05-22 Thread Luca Barbato
On 19/05/15 11:13, Vittorio Giovara wrote: I'd queue this for end of this week if no objections. Looks like there are not. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 2/3] HAP decoder and encoder

2015-05-22 Thread Luca Barbato
On 22/05/15 16:07, Vittorio Giovara wrote: On Thu, May 21, 2015 at 4:18 PM, Tom Butterworth bangno...@gmail.com wrote: diff --git a/Changelog b/Changelog index 9d73449..f7c59e9 100644 --- a/Changelog +++ b/Changelog @@ -30,6 +30,7 @@ version next: - Canopus HQ/HQA decoder - Automatically

[libav-devel] [PATCH 2/5] mpegvideo: Move ff_*_rl functions to a separate file

2015-05-22 Thread Vittorio Giovara
From: Anton Khirnov an...@khirnov.net --- libavcodec/Makefile| 2 +- libavcodec/mpegvideo.c | 92 --- libavcodec/mpegvideo.h | 1 - libavcodec/rl.c| 115 + 4 files changed, 116 insertions(+), 94

[libav-devel] [PATCH 5/5] rl: Add error checking to ff_rl_init().

2015-05-22 Thread Vittorio Giovara
From: Anton Khirnov an...@khirnov.net --- libavcodec/rl.c | 26 -- libavcodec/rl.h | 2 +- 2 files changed, 21 insertions(+), 7 deletions(-) diff --git a/libavcodec/rl.c b/libavcodec/rl.c index c0ec8ec..5bc1f91 100644 --- a/libavcodec/rl.c +++ b/libavcodec/rl.c @@ -34,8

[libav-devel] [PATCH 1/5] mpegvideo: Drop exchange_uv() function and use its code directly

2015-05-22 Thread Vittorio Giovara
Code is small enough that there is no advantage in a separate function. --- libavcodec/mpegvideo.c | 27 ++- 1 file changed, 14 insertions(+), 13 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index f81e357..10ace8d 100644 ---

[libav-devel] [PATCH 4/5] rl: Add a function for freeing dynamically allocated tables.

2015-05-22 Thread Vittorio Giovara
From: Anton Khirnov an...@khirnov.net Such tables are not used anywhere currently, but that should change. --- libavcodec/rl.c | 12 libavcodec/rl.h | 5 + 2 files changed, 17 insertions(+) diff --git a/libavcodec/rl.c b/libavcodec/rl.c index 942b7a6..c0ec8ec 100644 ---

[libav-devel] [PATCH 3/5] rl: Rename ff_*_rl() to ff_rl_*()

2015-05-22 Thread Vittorio Giovara
From: Anton Khirnov an...@khirnov.net --- libavcodec/h261.c | 2 +- libavcodec/ituh263dec.c| 4 ++-- libavcodec/ituh263enc.c| 4 ++-- libavcodec/mpeg12.c| 4 ++-- libavcodec/mpeg12enc.c | 4 ++-- libavcodec/mpeg4videodec.c | 6 +++--- libavcodec/mpeg4videoenc.c | 2

Re: [libav-devel] [PATCH 1/2] lavf: split tls.c

2015-05-22 Thread Martin Storsjö
On Fri, 22 May 2015, wm4 wrote: Move the OpenSSL and GnuTLS implementations to their own files. Other than the connection code (including options) and some boilerplate, no code is actually shared. Well, the read/write/close functions are (still) pretty much identical with just one single

Re: [libav-devel] [PATCH] configure: Prefer GNUTLS over OpenSSL if both available

2015-05-22 Thread Martin Storsjö
On Fri, 22 May 2015, Luca Barbato wrote: And warn about it. --- OpenSSL requires nonfree. configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 5bcc2df..70b3e84 100755 --- a/configure +++ b/configure @@ -4289,6 +4289,11 @@ if enabled gnutls; then {

Re: [libav-devel] [PATCH 1/2] lavf: split tls.c

2015-05-22 Thread Martin Storsjö
On Fri, 22 May 2015, Martin Storsjö wrote: On Fri, 22 May 2015, wm4 wrote: Move the OpenSSL and GnuTLS implementations to their own files. Other than the connection code (including options) and some boilerplate, no code is actually shared. Well, the read/write/close functions are (still)

Re: [libav-devel] [PATCH 2/2] lavf: remove TLS related ifdeffery to library specific files

2015-05-22 Thread Martin Storsjö
On Fri, 22 May 2015, wm4 wrote: There is no need to have this mess in network.c. --- libavformat/network.c | 83 +++ libavformat/tls_common.h | 6 libavformat/tls_gnutls.c | 26 +++ libavformat/tls_openssl.c | 64