Re: [libav-devel] [PATCH] DirectDraw Surface image decoder

2015-06-12 Thread Luca Barbato
On 13/06/15 01:52, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > Amended to avoid using frame linesize for writing. > > If this is ok, I'll push it together with the hap series since they've been > on review for enough time. > Seems ok for me, we'd have then about 1 month to

[libav-devel] [PATCH] DirectDraw Surface image decoder

2015-06-12 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- Amended to avoid using frame linesize for writing. If this is ok, I'll push it together with the hap series since they've been on review for enough time. Cheers, Vittorio Changelog | 1 + configure

Re: [libav-devel] [PATCH] libx264: Factor out the reconfiguration code

2015-06-12 Thread Luca Barbato
On 12/06/15 21:58, Tim W. wrote: > On Fri, Jun 12, 2015 at 12:10 AM, Luca Barbato wrote: > >> --- >> >> libavcodec/libx264.c | 164 >> +++ >> 1 file changed, 86 insertions(+), 78 deletions(-) > > > Looks good. Would it hurt to use a variable to k

Re: [libav-devel] [PATCH] riff: Add MNM4 FourCC as mpeg4

2015-06-12 Thread Luca Barbato
On 12/06/15 20:12, Vittorio Giovara wrote: > --- > libavformat/riff.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/riff.c b/libavformat/riff.c > index 6e77453..e1f76b2 100644 > --- a/libavformat/riff.c > +++ b/libavformat/riff.c > @@ -110,6 +110,7 @@ const AVCodecTag ff_co

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Vittorio Giovara
On Fri, Jun 12, 2015 at 9:01 PM, Andreas Cadhalpun wrote: > On 12.06.2015 21:51, Hendrik Leppkes wrote: >> On Fri, Jun 12, 2015 at 9:23 PM, Andreas Cadhalpun >>> I agree that it is not really elegant, but removing the assumption that >>> the avctx width/height/pix_fmt are from the last decoded fra

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Andreas Cadhalpun
On 12.06.2015 22:03, Hendrik Leppkes wrote: > On Fri, Jun 12, 2015 at 10:01 PM, Andreas Cadhalpun > wrote: >> That's not currently documented, so it would effectively be an API change. >> And since the h264 decoder is the only one misbehaving in this way, >> fixing it is the better alternative. >>

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Hendrik Leppkes
On Fri, Jun 12, 2015 at 10:01 PM, Andreas Cadhalpun wrote: > On 12.06.2015 21:51, Hendrik Leppkes wrote: >> On Fri, Jun 12, 2015 at 9:23 PM, Andreas Cadhalpun >>> I agree that it is not really elegant, but removing the assumption that >>> the avctx width/height/pix_fmt are from the last decoded fr

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Andreas Cadhalpun
On 12.06.2015 21:51, Hendrik Leppkes wrote: > On Fri, Jun 12, 2015 at 9:23 PM, Andreas Cadhalpun >> I agree that it is not really elegant, but removing the assumption that >> the avctx width/height/pix_fmt are from the last decoded frame instead >> of the last returned frame from the h264 decoder i

Re: [libav-devel] [PATCH] libx264: Factor out the reconfiguration code

2015-06-12 Thread Tim W.
On Fri, Jun 12, 2015 at 12:10 AM, Luca Barbato wrote: > --- > > libavcodec/libx264.c | 164 > +++ > 1 file changed, 86 insertions(+), 78 deletions(-) Looks good. Would it hurt to use a variable to keep track of reconfiguration and calling x264_en

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Hendrik Leppkes
On Fri, Jun 12, 2015 at 9:23 PM, Andreas Cadhalpun wrote: > On 12.06.2015 20:40, Michael Niedermayer wrote: >> On Fri, Jun 12, 2015 at 06:19:47PM +0200, Andreas Cadhalpun wrote: >>> On 10.06.2015 21:50, Michael Niedermayer wrote: On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wro

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Andreas Cadhalpun
On 12.06.2015 20:40, Michael Niedermayer wrote: > On Fri, Jun 12, 2015 at 06:19:47PM +0200, Andreas Cadhalpun wrote: >> On 10.06.2015 21:50, Michael Niedermayer wrote: >>> On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wrote: Could these be fixed to use a new H264Context field ins

[libav-devel] [PATCH] riff: Add MNM4 FourCC as mpeg4

2015-06-12 Thread Vittorio Giovara
--- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index 6e77453..e1f76b2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -110,6 +110,7 @@ const AVCodecTag ff_codec_bmp_tags[] = { { AV_CODEC_ID_MPEG4,MKTAG('P'

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Luca Barbato
It is getting a bit too much. Let's try to recap and see the issues and the solutions. That I can see we do not have examples suggesting to ignore the frame dimension for the codec dimensions btw... lu ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [FFmpeg-devel] [PATCH] h264: update avctx width/height when flushing

2015-06-12 Thread Andreas Cadhalpun
On 10.06.2015 21:50, Michael Niedermayer wrote: > On Wed, Jun 10, 2015 at 09:10:31PM +0200, Andreas Cadhalpun wrote: >> On 10.06.2015 12:01, Michael Niedermayer wrote: also avctx->pix_fmt would then still potentially not match the last output frame, also pix_fmt has the same problem as ab

Re: [libav-devel] [PATCH] fft-test: Use the float fabs() version

2015-06-12 Thread Luca Barbato
On 12/06/15 18:04, Vittorio Giovara wrote: > Fixes clang warning "absolute value function 'fabsf' given an argument > of type 'double' but has parameter of type 'float' which may cause > truncation of value [-Wabsolute-value]". > --- > libavcodec/fft-test.c | 2 +- > 1 file changed, 1 insertion(+)

[libav-devel] [PATCH] fft-test: Use the float fabs() version

2015-06-12 Thread Vittorio Giovara
Fixes clang warning "absolute value function 'fabsf' given an argument of type 'double' but has parameter of type 'float' which may cause truncation of value [-Wabsolute-value]". --- libavcodec/fft-test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/fft-test.c b/l

Re: [libav-devel] [PATCH] cws2fws: Close file handles on error

2015-06-12 Thread Luca Barbato
On 12/06/15 15:01, Vittorio Giovara wrote: > Reported-By: infer > --- > simpler version > Vittorio > > tools/cws2fws.c | 21 - > 1 file changed, 12 insertions(+), 9 deletions(-) Ok. ___ libav-devel mailing list libav-devel@libav.or

[libav-devel] [PATCH] cws2fws: Close file handles on error

2015-06-12 Thread Vittorio Giovara
Reported-By: infer --- simpler version Vittorio tools/cws2fws.c | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/tools/cws2fws.c b/tools/cws2fws.c index 74588c1..72980f4 100644 --- a/tools/cws2fws.c +++ b/tools/cws2fws.c @@ -31,6 +31,7 @@ int main(int arg

[libav-devel] [PATCH] cws2fws: Close file handles on error

2015-06-12 Thread Vittorio Giovara
Reported-By: infer --- tools/cws2fws.c | 25 - 1 file changed, 16 insertions(+), 9 deletions(-) diff --git a/tools/cws2fws.c b/tools/cws2fws.c index 74588c1..71e51ec 100644 --- a/tools/cws2fws.c +++ b/tools/cws2fws.c @@ -31,6 +31,7 @@ int main(int argc, char *argv[])

Re: [libav-devel] [PATCH 1/2] segment: Check open_null_ctx() return value

2015-06-12 Thread Luca Barbato
On 12/06/15 14:39, Vittorio Giovara wrote: > Reported-By: infer > --- > libavformat/segment.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/segment.c b/libavformat/segment.c > index 55ba656..3479134 100644 > --- a/libavformat/segment.c > +++ b/libavformat/

Re: [libav-devel] [PATCH 2/2] avconv_opt: Check localtime() return value

2015-06-12 Thread Luca Barbato
On 12/06/15 14:39, Vittorio Giovara wrote: > Reported-By: infer > --- > avconv_opt.c | 5 + > 1 file changed, 5 insertions(+) > > diff --git a/avconv_opt.c b/avconv_opt.c > index 29fc2be..74307bf 100644 > --- a/avconv_opt.c > +++ b/avconv_opt.c > @@ -1899,6 +1899,11 @@ static int opt_vstats(v

[libav-devel] [PATCH 2/2] avconv_opt: Check localtime() return value

2015-06-12 Thread Vittorio Giovara
Reported-By: infer --- avconv_opt.c | 5 + 1 file changed, 5 insertions(+) diff --git a/avconv_opt.c b/avconv_opt.c index 29fc2be..74307bf 100644 --- a/avconv_opt.c +++ b/avconv_opt.c @@ -1899,6 +1899,11 @@ static int opt_vstats(void *optctx, const char *opt, const char *arg) time_t tod

[libav-devel] [PATCH 1/2] segment: Check open_null_ctx() return value

2015-06-12 Thread Vittorio Giovara
Reported-By: infer --- libavformat/segment.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 55ba656..3479134 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -351,7 +351,8 @@ static int seg_write_trailer(st

Re: [libav-devel] [PATCH] mpegvideo: h263: Move all tables to a single file

2015-06-12 Thread Luca Barbato
On 12/06/15 13:26, Vittorio Giovara wrote: > --- > I spotted a couple of leftovers from various other headers, now removed. > Vittorio still ok if fate is happy. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo

Re: [libav-devel] [PATCH] h264_weight: Fix SSSE3 biweight code with weights of 128

2015-06-12 Thread Luca Barbato
On 12/06/15 13:58, Vittorio Giovara wrote: > From: Michael Niedermayer > > CC: libav-sta...@libav.org > Sample-Id: test_bref.mp4 > > Signed-off-by: Vittorio Giovara > --- > libavcodec/x86/h264_weight.asm | 10 ++ > 1 file changed, 10 insertions(+) > > diff --git a/libavcodec/x86/h264_

Re: [libav-devel] [PATCH] h264_qpel: Use the correct header

2015-06-12 Thread Luca Barbato
On 12/06/15 13:29, Vittorio Giovara wrote: > --- > libavcodec/x86/h264_qpel.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/x86/h264_qpel.c b/libavcodec/x86/h264_qpel.c > index 9ca6d7e..76d2ab0 100644 > --- a/libavcodec/x86/h264_qpel.c > +++ b/libavcodec/x86/

[libav-devel] [PATCH] h264_weight: Fix SSSE3 biweight code with weights of 128

2015-06-12 Thread Vittorio Giovara
From: Michael Niedermayer CC: libav-sta...@libav.org Sample-Id: test_bref.mp4 Signed-off-by: Vittorio Giovara --- libavcodec/x86/h264_weight.asm | 10 ++ 1 file changed, 10 insertions(+) diff --git a/libavcodec/x86/h264_weight.asm b/libavcodec/x86/h264_weight.asm index d1873af..9ad26d

Re: [libav-devel] [PATCH] on2avc: Use the integer abs() version

2015-06-12 Thread Kieran Kunhya
On 12 June 2015 at 12:33, Vittorio Giovara wrote: > Fixes clang warning "floating point absolute value function 'fabsf' > when argument is of integer type [-Wabsolute-value]". LGTM ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.o

[libav-devel] [PATCH] on2avc: Use the integer abs() version

2015-06-12 Thread Vittorio Giovara
Fixes clang warning "floating point absolute value function 'fabsf' when argument is of integer type [-Wabsolute-value]". --- libavcodec/on2avc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/on2avc.c b/libavcodec/on2avc.c index c00339f..287ecfb 100644 --- a/libavc

[libav-devel] [PATCH] h264_qpel: Use the correct header

2015-06-12 Thread Vittorio Giovara
--- libavcodec/x86/h264_qpel.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/x86/h264_qpel.c b/libavcodec/x86/h264_qpel.c index 9ca6d7e..76d2ab0 100644 --- a/libavcodec/x86/h264_qpel.c +++ b/libavcodec/x86/h264_qpel.c @@ -23,8 +23,8 @@ #include "libavutil/cpu.h"

[libav-devel] [PATCH] mpegvideo: h263: Move all tables to a single file

2015-06-12 Thread Vittorio Giovara
--- I spotted a couple of leftovers from various other headers, now removed. Vittorio libavcodec/Makefile| 2 +- libavcodec/flvenc.c| 1 + libavcodec/h263.c | 3 - libavcodec/h263.h | 30 + libavcodec/h263data.c | 292 +

Re: [libav-devel] [PATCH 1/2] libvpx: Support all pixel formats available in encoding and decoding

2015-06-12 Thread Vittorio Giovara
On Thu, Jun 11, 2015 at 3:56 PM, Luca Barbato wrote: > From: Vittorio Giovara > > Bump the minimum libvpx version to 1.4.0 so that all pixel > formats are present. Add new VP9 profiles. > > Signed-off-by: Vittorio Giovara > Signed-off-by: Luca Barbato You did most of the work now, this patch a