Re: [libav-devel] [PATCH] Revert "mov: Double-check that alias path is not an absolute path"

On Fri, Jul 10, 2015 at 8:12 PM, Luca Barbato wrote: > On 10/07/15 19:46, Vittorio Giovara wrote: >> This reverts commit 9286de045968ad456d4e752651eec22de5e89060. >> The change broke support for legit absolute file paths. >> >> Reported-by: Maksym Veremeyenko . >> --- >> It looks like there are mo

Re: [libav-devel] [PATCH] Revert "mov: Double-check that alias path is not an absolute path"

On Fri, Jul 10, 2015 at 7:41 PM, Hendrik Leppkes wrote: > On Fri, Jul 10, 2015 at 7:46 PM, Vittorio Giovara > wrote: >> This reverts commit 9286de045968ad456d4e752651eec22de5e89060. >> The change broke support for legit absolute file paths. >> >> Reported-by: Maksym Veremeyenko . >> --- >> It loo

[libav-devel] [PATCH 1/2] x86: bswapdsp: Don't treat 32-bit integers as 64-bit

The upper halves are not guaranteed to be zero in x86-64. Also use `test` instead of `and` when the result isn't used for anything other than as a branch condition, this allows some register moves to be eliminated. --- libavcodec/x86/bswapdsp.asm | 23 ++- 1 file changed, 10 i

[libav-devel] [PATCH 2/2] checkasm: add unit tests for bswapdsp

--- tests/checkasm/Makefile | 1 + tests/checkasm/bswapdsp.c | 73 +++ tests/checkasm/checkasm.c | 3 ++ tests/checkasm/checkasm.h | 1 + 4 files changed, 78 insertions(+) create mode 100644 tests/checkasm/bswapdsp.c diff --git a/tests/checkasm/Ma

[libav-devel] [PATCH] libx262: Add support for the MPEG2 encoder

--- As Anton suggested now x262 is a subfeature of x264 configure | 5 +++- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1 + libavcodec/libx264.c | 62 +++--- 4 files changed, 60 insertions(+), 9 deletions(-) diff --git a/

[libav-devel] [PATCH 04/15] proresenc: Do not entangle coded_frame

--- libavcodec/proresenc.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/libavcodec/proresenc.c b/libavcodec/proresenc.c index 3a5524a..b71a7db 100644 --- a/libavcodec/proresenc.c +++ b/libavcodec/proresenc.c @@ -195,6 +195,7 @@ typedef struct ProresContext {

[libav-devel] [PATCH 13/15] Gather all coded_frame allocations and free functions to a single place

Allocating coded_frame is what most encoders do anyway, so it makes sense to always allocate it in a single place. This bring uniformity to encoder behaviour and prevents applications from erroneusly accessing this field when not allocated. Additionally this helps isolating encoders that export in

[libav-devel] [PATCH 15/15] Deprecate avctx.coded_frame

The rationale is that coded_frame was only used to communicate key_frame, pict_type and quality to the caller, as well as a few other random fields, in a non predictable, let alone consistent way. There was agreement that there was no use case for coded_frame, as it is a full-sized AVFrame contain

[libav-devel] [PATCH 10/15] ffv1enc: Keep coded_frame.key_frame a write-only variable

--- libavcodec/ffv1.h| 1 + libavcodec/ffv1enc.c | 11 ++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/ffv1.h b/libavcodec/ffv1.h index bc433bc..6e8c798 100644 --- a/libavcodec/ffv1.h +++ b/libavcodec/ffv1.h @@ -78,6 +78,7 @@ typedef struct FFV1Context {

[libav-devel] [PATCH 03/15] a64multienc: Do not entangle coded_frame

This change (and the following ones of the same kind) is mainly to simplify wrapping this section with an #if block later on. No functional changes are applied, the context coded_frame fields are initialized instead of keeping a reference to it. Signed-off-by: Vittorio Giovara --- libavcodec/a6

[libav-devel] [PATCH 14/15] Add a quality factor packet side data

This is necessary to preserve the quality information currently exported with coded_frame. Add the new side data to every encoder that needs it, and use it in avconv. Signed-off-by: Vittorio Giovara --- avconv.c | 13 ++--- avconv.h | 3 +++ doc/APIch

[libav-devel] [PATCH 11/15] ffv1enc: Use input frame to set SAR and interlacing

--- libavcodec/ffv1enc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index ad52f15..28289fb 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec/ffv1enc.c @@ -863,12 +863,12 @@ static void encode_slice_header(FFV1Context *f,

[libav-devel] [PATCH 00/15] coded_frame

This version of the set is just for review commodity, with all the amendment requested (thanks Anton). Vittorio Vittorio Giovara (15): mpegvideo_enc: Drop unnneded initialization roqvideoenc: Drop unneeded initialization a64multienc: Do not entangle coded_frame proresenc: Do not entangle

[libav-devel] [PATCH 08/15] libtheoraenc: Keep coded_frame.key_frame a write-only variable

--- libavcodec/libtheoraenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libtheoraenc.c b/libavcodec/libtheoraenc.c index 097336b..612a808 100644 --- a/libavcodec/libtheoraenc.c +++ b/libavcodec/libtheoraenc.c @@ -349,7 +349,7 @@ static int encode_frame(AVCodecC

[libav-devel] [PATCH 09/15] qtrleenc: Keep coded_frame.key_frame a write-only variable

--- libavcodec/qtrleenc.c | 22 ++ 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/libavcodec/qtrleenc.c b/libavcodec/qtrleenc.c index 7c98bea..fe1fafc 100644 --- a/libavcodec/qtrleenc.c +++ b/libavcodec/qtrleenc.c @@ -57,6 +57,9 @@ typedef struct QtrleEncContext

[libav-devel] [PATCH 05/15] svq1enc: Do not entangle coded_frame

--- libavcodec/svq1enc.c | 32 +--- libavcodec/svq1enc.h | 4 2 files changed, 21 insertions(+), 15 deletions(-) diff --git a/libavcodec/svq1enc.c b/libavcodec/svq1enc.c index 08d85b8..ffc9b42 100644 --- a/libavcodec/svq1enc.c +++ b/libavcodec/svq1enc.c @@ -238,1

[libav-devel] [PATCH 06/15] libxvid: Do not entangle coded_frame

--- libavcodec/libxvid.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/libxvid.c b/libavcodec/libxvid.c index 97ff95b..0012876 100644 --- a/libavcodec/libxvid.c +++ b/libavcodec/libxvid.c @@ -663,7 +663,6 @@ static int xvid_encode_frame(AVCodecCo

[libav-devel] [PATCH 12/15] flashsvenc: Keep coded_frame.key_frame a write-only variable

--- libavcodec/flashsvenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/flashsvenc.c b/libavcodec/flashsvenc.c index 971ce1b..1c87ae3 100644 --- a/libavcodec/flashsvenc.c +++ b/libavcodec/flashsvenc.c @@ -275,7 +275,7 @@ static int flashsv_encode_frame(AVCodecCon

[libav-devel] [PATCH 07/15] libvpxenc: Do not entangle coded_frame

Keep coded_frame.key_frame a write-only variable. --- libavcodec/libvpxenc.c | 30 +++--- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index f690de1..e8c7327 100644 --- a/libavcodec/libvpxenc.c +++ b/libavco

[libav-devel] [PATCH 01/15] mpegvideo_enc: Drop unnneded initialization

coded_frame is already initialized where needed. --- libavcodec/mpegvideo_enc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/mpegvideo_enc.c b/libavcodec/mpegvideo_enc.c index f88e009..35c7839 100644 --- a/libavcodec/mpegvideo_enc.c +++ b/libavcodec/mpegvideo_enc.c @@ -722,8 +72

[libav-devel] [PATCH 02/15] roqvideoenc: Drop unneeded initialization

Its fields are never initialized to begin with. --- libavcodec/roqvideoenc.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/roqvideoenc.c b/libavcodec/roqvideoenc.c index 872bee8..32dabae 100644 --- a/libavcodec/roqvideoenc.c +++ b/libavcodec/roqvideoenc.c @@ -955,8 +955,6 @@ stat

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

Quoting James Almer (2015-07-15 19:26:08) > On 15/07/15 2:06 PM, Anton Khirnov wrote: > > Quoting James Almer (2015-07-15 18:26:28) > >> On 14/07/15 7:36 AM, Luca Barbato wrote: > >>> --- > >>> > >>> Properly rebased version > >>> > >>> libavcodec/hevc_ps.c | 258 > >>> ++-

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

On 15/07/15 19:26, James Almer wrote: > Function call overhead. ff_hevc_decode_nal_pps() is not an init function, it > may > or may not be called for every decoded frame. Actually the function is a tad big and will get bigger so probably won't hurt leaving to the compiler the task to decide if in

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

On 15/07/15 2:06 PM, Anton Khirnov wrote: > Quoting James Almer (2015-07-15 18:26:28) >> On 14/07/15 7:36 AM, Luca Barbato wrote: >>> --- >>> >>> Properly rebased version >>> >>> libavcodec/hevc_ps.c | 258 >>> ++- >>> 1 file changed, 131 insertions

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

Quoting James Almer (2015-07-15 18:26:28) > On 14/07/15 7:36 AM, Luca Barbato wrote: > > --- > > > > Properly rebased version > > > > libavcodec/hevc_ps.c | 258 > > ++- > > 1 file changed, 131 insertions(+), 127 deletions(-) > > > > diff --git a

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

On 15/07/15 1:46 PM, Luca Barbato wrote: > On 15/07/15 18:26, James Almer wrote: >> If this is done only for readability's sake and not because this function >> will be >> used somewhere else, then making sure the compiler always inlines this >> function may >> be a good idea. > > Good idea, the

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

On 15/07/15 18:26, James Almer wrote: > If this is done only for readability's sake and not because this function > will be > used somewhere else, then making sure the compiler always inlines this > function may > be a good idea. Good idea, the idea itself is fine? lu __

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

On 14/07/15 7:36 AM, Luca Barbato wrote: > --- > > Properly rebased version > > libavcodec/hevc_ps.c | 258 > ++- > 1 file changed, 131 insertions(+), 127 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c > index a5a2ace..

[libav-devel] [PATCH 2/2] asfdec: ommit the wrong condition

--- libavformat/asfdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 34841e9..ab230e7 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -903,7 +903,7 @@ static int asf_read_data(AVFormatContext *s, const GUIDP

[libav-devel] [PATCH 1/2] asfdec: align object position only if its size is not too big

if size is invalid seek to the Data or return error --- libavformat/asfdec.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 7af3728..34841e9 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -1660,7 +166

Re: [libav-devel] [PATCH] asfdec: factor out seeking to the Data

when !pb->seekable happens, while breaks after reading Data Object header, just before first data packet and asf_read_packet is called On Wed, Jul 15, 2015 at 11:34 AM, Luca Barbato wrote: > On 15/07/15 09:48, Alexandra Hájková wrote: >> --- >> libavformat/asfdec.c | 27 +++--

Re: [libav-devel] [PATCH] hevc: Split the struct setup from the pps parsing

On 14/07/15 12:36, Luca Barbato wrote: > --- > > Properly rebased version > Ping. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] asfdec: factor out seeking to the Data

On 15/07/15 09:48, Alexandra Hájková wrote: > --- > libavformat/asfdec.c | 27 +++ > 1 file changed, 15 insertions(+), 12 deletions(-) What happens when you have non-seekable streams? +/* Data are skipped for the first time, Index object is processed, + * EOF is r

[libav-devel] [PATCH] asfdec: factor out seeking to the Data

--- libavformat/asfdec.c | 27 +++ 1 file changed, 15 insertions(+), 12 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 7af3728..24dde87 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -1633,25 +1633,21 @@ static int asf_read_hea