Re: [libav-devel] [PATCH] h264: Parse only the x264 info unregisterd sei

2015-07-30 Thread Anton Khirnov
Quoting Luca Barbato (2015-07-29 22:51:05) > And restrict the string to ascii text. > > CC: libav-sta...@libav.org > > Signed-off-by: Luca Barbato > --- > libavcodec/h264_sei.c | 57 > ++- > 1 file changed, 47 insertions(+), 10 deletions(-) > >

Re: [libav-devel] [RFC PATCH 3/3] rtsp: Use buffered IO for reading from the control channel

2015-07-30 Thread Anton Khirnov
Quoting Martin Storsjö (2015-01-21 14:41:27) > Since R/W AVIOContexts aren't fully supported (it only > supports one single buffer, either for reading or writing), > we open this with the read flag only, and keep doing all the writes > directly to the underlying URLContext, bypassing the read buffe

Re: [libav-devel] [PATCH] asfdec: prevent the memory leak while reading metadata

2015-07-30 Thread Anton Khirnov
Quoting Alexandra Hájková (2015-07-30 19:28:13) > --- > libavformat/asfdec.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-) > > diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c > index 13133b6..a112741 100644 > --- a/libavformat/asfdec.c > +++ b/libavformat/asfdec.

[libav-devel] [PATCH] asfdec: free AVDictionaries properly when closing the demuxer

2015-07-30 Thread Alexandra Hájková
--- libavformat/asfdec.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index a112741..4e94cd4 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -1458,10 +1458,12 @@ static int asf_read_close(AVFormatContext *s)

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Anton Khirnov
Quoting Andreas Cadhalpun (2015-07-30 19:10:12) > On 30.07.2015 18:26, Anton Khirnov wrote: > > > There's a bunch of reasons why I think keeping them is a bad idea: > > - some of the changes involve adding prefixes for proper namespacing, so > > libav does not randomly conflict with other librar

[libav-devel] [PATCH] asfdec: prevent the memory leak while reading metadata

2015-07-30 Thread Alexandra Hájková
--- libavformat/asfdec.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c index 13133b6..a112741 100644 --- a/libavformat/asfdec.c +++ b/libavformat/asfdec.c @@ -326,7 +326,6 @@ static int asf_read_generic_value(AVFormat

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Andreas Cadhalpun
On 30.07.2015 18:26, Anton Khirnov wrote: > Quoting Andreas Cadhalpun (2015-07-30 17:49:51) >> I think that keeping some of these APIs "forever" is much less of a problem >> then breaking the majority of reverse dependencies. > > The API breaks are not done for the fun of it. I hope so. ;) > The

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Andreas Cadhalpun
On 30.07.2015 18:10, Luca Barbato wrote: > On 30/07/15 17:49, Andreas Cadhalpun wrote: >> Have you tried sending them patches before breaking compatibility? > > We did in the past. Great, so please do it again. > Needless to say distributors then did not pick up the updated releases > of those s

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Andreas Cadhalpun
On 30.07.2015 18:00, Hendrik Leppkes wrote: > Patching dozens of downstream projects is clearly not in the scope of what > should be expected from any Libav or FFmpeg developer. But keeping the API usable is. Regularly breaking the majority of reverse dependencies makes an API much less usable. S

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Anton Khirnov
Quoting Andreas Cadhalpun (2015-07-30 17:49:51) > On 30.07.2015 17:38, Anton Khirnov wrote: > > Quoting Andreas Cadhalpun (2015-07-30 17:05:12) > >> Ideally you should make sure that patches for all of them are available, > >> before these APIs get removed. > >> > >> Considering how widespread the

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Luca Barbato
On 30/07/15 17:49, Andreas Cadhalpun wrote: > Have you tried sending them patches before breaking compatibility? We did in the past. Needless to say distributors then did not pick up the updated releases of those softwares making it sort of a meaningless endeavor. lu

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Hendrik Leppkes
Am 30.07.2015 17:50 schrieb "Andreas Cadhalpun" < andreas.cadhal...@googlemail.com>: > > On 30.07.2015 17:38, Anton Khirnov wrote: > > Quoting Andreas Cadhalpun (2015-07-30 17:05:12) > >> Ideally you should make sure that patches for all of them are available, > >> before these APIs get removed. >

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Andreas Cadhalpun
On 30.07.2015 17:38, Anton Khirnov wrote: > Quoting Andreas Cadhalpun (2015-07-30 17:05:12) >> Ideally you should make sure that patches for all of them are available, >> before these APIs get removed. >> >> Considering how widespread the use of FF_API_PIX_FMT and FF_API_AVFRAME_LAVC >> still is, i

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Anton Khirnov
Quoting Andreas Cadhalpun (2015-07-30 17:05:12) > Hi, > > On 28.07.2015 15:36, Vittorio Giovara wrote: > > This set contains the removal of all deprecated features marked as > > such until 2012/early 2013. This was announced several times in the > > past months and agreed at several meetings (sinc

Re: [libav-devel] [PATCH 7/7] dnxhddata: Add tables for missing DNx100 profiles

2015-07-30 Thread Kostya Shishkov
On Thu, Jul 30, 2015 at 03:55:39PM +0100, Vittorio Giovara wrote: > 1440x1080@8 progressive (1259) and interlaced (1260). > > Signed-off-by: Vittorio Giovara > --- > Note that profile 1260 suffers from a dct overflow, which corrupts the > decoded frame entirely. The bug is unrelated to the tables

Re: [libav-devel] [PATCH 3/7] dnxhddata: Group together DC-related tables

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > This helps in finding duplicates. > --- > libavcodec/dnxhddata.c | 102 > + > 1 file changed, 52 insertions(+), 50 deletions(-) Ok. ___ libav-devel mailing li

Re: [libav-devel] [PATCH 7/7] dnxhddata: Add tables for missing DNx100 profiles

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > 1440x1080@8 progressive (1259) and interlaced (1260). > > Signed-off-by: Vittorio Giovara > --- > Note that profile 1260 suffers from a dct overflow, which corrupts the > decoded frame entirely. The bug is unrelated to the tables, so a separate > fix m

Re: [libav-devel] [PATCH 6/7] dnxhddata: Merge a few duplicated RUN tables

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > --- > libavcodec/dnxhddata.c | 37 ++--- > 1 file changed, 6 insertions(+), 31 deletions(-) The patch does not show all the context, so probably ok. lu ___ libav-devel mailin

Re: [libav-devel] [PATCH 2/7] dnxhddata: List the reused tables in a comment

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > --- > libavcodec/dnxhddata.c | 48 ++-- > 1 file changed, 38 insertions(+), 10 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists

Re: [libav-devel] [PATCH 5/7] dnxhddata: Group together RUN-related tables

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > This helps in finding duplicates. > --- > libavcodec/dnxhddata.c | 229 > + > 1 file changed, 116 insertions(+), 113 deletions(-) > Ok. ___ libav-devel maili

Re: [libav-devel] [PATCH 4/7] dnxhddata: Merge a few duplicated DC tables

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > --- > libavcodec/dnxhddata.c | 62 > -- > 1 file changed, 10 insertions(+), 52 deletions(-) > Ok. ___ libav-devel mailing list libav-devel@libav.org https://

Re: [libav-devel] [PATCH 1/7] dnxhddata: Keep a single CID in the table names

2015-07-30 Thread Luca Barbato
On 30/07/15 16:55, Vittorio Giovara wrote: > Use a comment to list the reused tables, since it's more flexible than a > table name to keep information like this. The list will expand in later > commits. > --- > libavcodec/dnxhddata.c | 58 > +- > 1

Re: [libav-devel] [PATCH 0/20] removal of deprecated features

2015-07-30 Thread Andreas Cadhalpun
Hi, On 28.07.2015 15:36, Vittorio Giovara wrote: > This set contains the removal of all deprecated features marked as > such until 2012/early 2013. This was announced several times in the > past months and agreed at several meetings (since fosdem and recently > at the sprint). > > With more than

[libav-devel] [PATCH 7/7] dnxhddata: Add tables for missing DNx100 profiles

2015-07-30 Thread Vittorio Giovara
1440x1080@8 progressive (1259) and interlaced (1260). Signed-off-by: Vittorio Giovara --- Note that profile 1260 suffers from a dct overflow, which corrupts the decoded frame entirely. The bug is unrelated to the tables, so a separate fix might be applied afterwards. Vittorio Changelog

[libav-devel] [PATCH 4/7] dnxhddata: Merge a few duplicated DC tables

2015-07-30 Thread Vittorio Giovara
--- libavcodec/dnxhddata.c | 62 -- 1 file changed, 10 insertions(+), 52 deletions(-) diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c index de89410..dc38bb8 100644 --- a/libavcodec/dnxhddata.c +++ b/libavcodec/dnxhddata.c @@ -256,68 +25

[libav-devel] [PATCH 5/7] dnxhddata: Group together RUN-related tables

2015-07-30 Thread Vittorio Giovara
This helps in finding duplicates. --- libavcodec/dnxhddata.c | 229 + 1 file changed, 116 insertions(+), 113 deletions(-) diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c index dc38bb8..11820fa 100644 --- a/libavcodec/dnxhddata.c +++ b/l

[libav-devel] [PATCH 2/7] dnxhddata: List the reused tables in a comment

2015-07-30 Thread Vittorio Giovara
--- libavcodec/dnxhddata.c | 48 ++-- 1 file changed, 38 insertions(+), 10 deletions(-) diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c index c4d4676..e53d4f6 100644 --- a/libavcodec/dnxhddata.c +++ b/libavcodec/dnxhddata.c @@ -23,6 +23,7 @

[libav-devel] [PATCH 1/7] dnxhddata: Keep a single CID in the table names

2015-07-30 Thread Vittorio Giovara
Use a comment to list the reused tables, since it's more flexible than a table name to keep information like this. The list will expand in later commits. --- libavcodec/dnxhddata.c | 58 +- 1 file changed, 34 insertions(+), 24 deletions(-) diff --gi

[libav-devel] [PATCH 6/7] dnxhddata: Merge a few duplicated RUN tables

2015-07-30 Thread Vittorio Giovara
--- libavcodec/dnxhddata.c | 37 ++--- 1 file changed, 6 insertions(+), 31 deletions(-) diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c index 11820fa..9a0f9e0 100644 --- a/libavcodec/dnxhddata.c +++ b/libavcodec/dnxhddata.c @@ -1051,6 +1051,7 @@ static

[libav-devel] [PATCH 3/7] dnxhddata: Group together DC-related tables

2015-07-30 Thread Vittorio Giovara
This helps in finding duplicates. --- libavcodec/dnxhddata.c | 102 + 1 file changed, 52 insertions(+), 50 deletions(-) diff --git a/libavcodec/dnxhddata.c b/libavcodec/dnxhddata.c index e53d4f6..de89410 100644 --- a/libavcodec/dnxhddata.c +++ b/lib

Re: [libav-devel] [PATCH 1/3] rtsp: Only interpret $ as interleaved packet indicator at the start of replies

2015-07-30 Thread Martin Storsjö
On Thu, 30 Jul 2015, Martin Storsjö wrote: On Wed, 21 Jan 2015, Luca Barbato wrote: On 21/01/15 14:41, Martin Storsjö wrote: Allow $ as character anywhere within normal RTSP replies - both within the lines, and as the first character of RTSP header lines. (The existing old comment indicated t

Re: [libav-devel] [PATCH] avcodec: h264: Extract decoder methods

2015-07-30 Thread Luca Barbato
On 30/07/15 13:58, David Holm wrote: > Extract two methods from decode_registered_user_data in order to improve > code readability. Also make memory allocation constant unsigned 64-bit > integer. I guess the commit message is missing some information, I'll amend it. "Also make sure that the memo

Re: [libav-devel] [PATCH] avcodec: h264: Extract decoder methods

2015-07-30 Thread Hendrik Leppkes
On Thu, Jul 30, 2015 at 1:58 PM, David Holm wrote: > Extract two methods from decode_registered_user_data in order to improve > code readability. Also make memory allocation constant unsigned 64-bit > integer. > > Bug-Id: CID1312090 > --- > libavcodec/h264_sei.c | 123 >

[libav-devel] [PATCH] avcodec: h264: Extract decoder methods

2015-07-30 Thread David Holm
Extract two methods from decode_registered_user_data in order to improve code readability. Also make memory allocation constant unsigned 64-bit integer. Bug-Id: CID1312090 --- libavcodec/h264_sei.c | 123 -- 1 file changed, 69 insertions(+), 54 del

Re: [libav-devel] [PATCH] asfdec: prevent the memory leak while reading metadata

2015-07-30 Thread Anton Khirnov
Quoting Alexandra Hájková (2015-07-29 11:37:51) > --- > libavformat/asfdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/asfdec.c b/libavformat/asfdec.c > index 69c9ecb..46545b3 100644 > --- a/libavformat/asfdec.c > +++ b/libavformat/asfdec.c > @@ -542,6 +542,7 @@ static

Re: [libav-devel] [PATCH 1/3] rtsp: Only interpret $ as interleaved packet indicator at the start of replies

2015-07-30 Thread Martin Storsjö
On Wed, 21 Jan 2015, Luca Barbato wrote: On 21/01/15 14:41, Martin Storsjö wrote: Allow $ as character anywhere within normal RTSP replies - both within the lines, and as the first character of RTSP header lines. (The existing old comment indicated that an inline packet could start at any line

Re: [libav-devel] [PATCH] hmac: add missing version bump and APIChanges entry

2015-07-30 Thread Martin Storsjö
On Thu, 30 Jul 2015, James Almer wrote: Signed-off-by: James Almer --- Forgot about this, my bad. doc/APIchanges | 3 +++ libavutil/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) Ok // Martin ___ libav-devel mailing list liba

[libav-devel] [PATCH] hmac: add missing version bump and APIChanges entry

2015-07-30 Thread James Almer
Signed-off-by: James Almer --- Forgot about this, my bad. doc/APIchanges | 3 +++ libavutil/version.h | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 4ee7f41..17a6d88 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,6 +13,9