On Fri, Aug 21, 2015 at 06:31:22AM +0200, Luca Barbato wrote:
> On 20/08/15 22:37, Henrik Gramner wrote:
> >> +report("%s", "qpel");
> >> +report("%s", "epel");
> >> +report("%s", "unweighted_pred");
> >> +report("%s", "weighted_pred");
> >
> > The "%s" is redundant
On 20/08/15 22:37, Henrik Gramner wrote:
>> +report("%s", "qpel");
>> +report("%s", "epel");
>> +report("%s", "unweighted_pred");
>> +report("%s", "weighted_pred");
>
> The "%s" is redundant with string literals.
It is good practice do always do that and recent com
On Wed, Aug 19, 2015 at 9:43 PM, Anton Khirnov wrote:
> +const int srcstride = FFALIGN(width, 16) * sizeof(*src0);
> +const int dststride = FFALIGN(width, 16) * PIXEL_SIZE(bit_depth);
Strides, and any other pointer-sized value, should be ptrdiff_t - or
more preferable, review/push my che
On 20/08/15 3:35 AM, Anton Khirnov wrote:
> Quoting James Almer (2015-08-20 00:34:58)
>> On 19/08/15 4:43 PM, Anton Khirnov wrote:
>>> ---
>>> libavcodec/hevc.c | 6 +-
>>> libavcodec/hevc.h | 2 +-
>>> libavcodec/hevcdsp.c | 24 +-
>>> libavcodec/hevcdsp.h
Now we no longer have to rely on function pointers intentionally
declared without specified argument types.
This makes it easier to support functions with floating point parameters
or return values as well as functions returning 64-bit values on 32-bit
architectures. It also avoids having to expli
On 20/08/15 16:24, Janne Grunau wrote:
> ---
> tests/fate/microsoft.mak| 6 ++
> tests/ref/fate/asf-repldata | 28 ++--
> 2 files changed, 16 insertions(+), 18 deletions(-)
>
Sure.
___
libav-devel mailing list
libav-de
---
tests/fate/microsoft.mak| 6 ++
tests/ref/fate/asf-repldata | 28 ++--
2 files changed, 16 insertions(+), 18 deletions(-)
diff --git a/tests/fate/microsoft.mak b/tests/fate/microsoft.mak
index 6f83d2e..30bd35a 100644
--- a/tests/fate/microsoft.mak
+++ b/tests/
On Thu, Aug 20, 2015 at 02:55:56PM +0200, Anton Khirnov wrote:
> Quoting Janne Grunau (2015-08-20 14:47:45)
> > ---
> > tests/fate/microsoft.mak| 2 +-
> > tests/ref/fate/asf-repldata | 28 ++--
> > 2 files changed, 15 insertions(+), 15 deletions(-)
> >
> > diff --git
Quoting Janne Grunau (2015-08-20 14:47:45)
> ---
> tests/fate/microsoft.mak| 2 +-
> tests/ref/fate/asf-repldata | 28 ++--
> 2 files changed, 15 insertions(+), 15 deletions(-)
>
> diff --git a/tests/fate/microsoft.mak b/tests/fate/microsoft.mak
> index 6f83d2e..fad03
---
tests/fate/microsoft.mak| 2 +-
tests/ref/fate/asf-repldata | 28 ++--
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/tests/fate/microsoft.mak b/tests/fate/microsoft.mak
index 6f83d2e..fad033f 100644
--- a/tests/fate/microsoft.mak
+++ b/tests/fate
Quoting Anton Khirnov (2015-08-20 08:35:29)
> Quoting James Almer (2015-08-20 00:34:58)
> > On 19/08/15 4:43 PM, Anton Khirnov wrote:
> > > ---
> > > libavcodec/hevc.c | 6 +-
> > > libavcodec/hevc.h | 2 +-
> > > libavcodec/hevcdsp.c | 24 +-
> > > libavcodec
On 19/08/15 21:43, Anton Khirnov wrote:
> ---
> tests/checkasm/Makefile | 1 +
> tests/checkasm/checkasm.c | 3 +
> tests/checkasm/checkasm.h | 1 +
> tests/checkasm/hevc_mc.c | 294
> ++
> 4 files changed, 299 insertions(+)
> create mode 1006
On 20/08/15 09:36, Anton Khirnov wrote:
> How is it any better? It's still a random number.
Ideally who is using an unsupported pixel format will get an error from
the other functions.
If you crash there you just crash, if you return a value the caller will
get an error later if hadn't get it soo
Quoting Luca Barbato (2015-08-20 09:27:06)
> On 19/08/15 21:49, Anton Khirnov wrote:
> > Quoting Luca Barbato (2015-08-18 16:22:19)
> >> Avoid a NULL dereference.
> >>
> >> CC: libav-sta...@libav.org
> >> ---
> >> libavcodec/imgconvert.c | 4 +---
> >> 1 file changed, 1 insertion(+), 3 deletions(-
On 19/08/15 21:43, Anton Khirnov wrote:
> This should allow for more efficient SIMD.
> ---
> libavcodec/hevc.c | 29 --
> libavcodec/hevcdsp.c | 18 ---
> libavcodec/hevcdsp.h | 6 ++--
> libavcodec/hevcdsp_template.c | 71
> +
On 19/08/15 21:43, Anton Khirnov wrote:
> This should allow for more efficient SIMD.
>
> Keep the C versions as they are now, to allow the compiler to inline the
> interpolation coefficients.
> ---
> libavcodec/hevc.c | 19 -
> libavcodec/hevcdsp.c | 30 ++
On 19/08/15 21:43, Anton Khirnov wrote:
> put_weighted_pred_avg should be put_unweighted_pred_avg, there is no
> weighting there.
> ---
> libavcodec/hevc.c | 8
> libavcodec/hevcdsp.c | 2 +-
> libavcodec/hevcdsp.h | 6 +++---
> libavcodec/hevcdsp_template.c
On 19/08/15 21:43, Anton Khirnov wrote:
> ---
> libavcodec/hevc.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/libavcodec/hevc.c b/libavcodec/hevc.c
> index 0dfe7a2..6395563 100644
> --- a/libavcodec/hevc.c
> +++ b/libavcodec/hevc.c
> @@ -1494,7 +1494,7 @@ static
On 19/08/15 21:49, Anton Khirnov wrote:
> Quoting Luca Barbato (2015-08-18 16:22:19)
>> Avoid a NULL dereference.
>>
>> CC: libav-sta...@libav.org
>> ---
>> libavcodec/imgconvert.c | 4 +---
>> 1 file changed, 1 insertion(+), 3 deletions(-)
>>
>> diff --git a/libavcodec/imgconvert.c b/libavcodec/i
19 matches
Mail list logo
