[libav-devel] [PATCH 3/3] hls: Don't persist http options that haven't been set

2015-12-07 Thread Martin Storsjö
By default, av_opt_get returns the empty string for options that aren't set. This avoids warnings about "No trailing CRLF found in HTTP header." --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index dc3ab87..ab08365 1

[libav-devel] [PATCH 2/3] opt: Add flag to return NULL when applicable in av_opt_get

2015-12-07 Thread Martin Storsjö
From: Rodger Combs --- doc/APIchanges | 3 +++ libavutil/opt.c | 12 ++-- libavutil/opt.h | 10 ++ libavutil/version.h | 2 +- 4 files changed, 24 insertions(+), 3 deletions(-) diff --git a/doc/APIchanges b/doc/APIchanges index 4c5e32e..bbffbb4 100644 --- a/doc/AP

[libav-devel] [PATCH 1/3] opt: Fix a typo in av_opt_get* doxy

2015-12-07 Thread Martin Storsjö
From: Stefano Sabatini --- libavutil/opt.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index 8413206..6d3f1fe 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -519,7 +519,7 @@ int av_opt_set_dict_val(void *obj, const char *name, cons

Re: [libav-devel] [PATCH] hls: Don't persist http options that haven't been set

2015-12-07 Thread Martin Storsjö
On Mon, 7 Dec 2015, Martin Storsjö wrote: av_opt_get does return the empty string for options that aren't set. This avoids warnings about "No trailing CRLF found in HTTP header." --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavfo

Re: [libav-devel] [PATCH] swfdec: support compressed swf

2015-12-07 Thread Luca Barbato
On 07/12/15 22:26, Vittorio Giovara wrote: > From: Clément Bœsch > > Signed-off-by: Vittorio Giovara > --- > Added Changelog entry and modified the inflate return value check as discussed > with Luca. > Vittorio > Fine for me obviously =) lu ___ li

[libav-devel] [PATCH] swfdec: support compressed swf

2015-12-07 Thread Vittorio Giovara
From: Clément Bœsch Signed-off-by: Vittorio Giovara --- Added Changelog entry and modified the inflate return value check as discussed with Luca. Vittorio Changelog| 1 + configure| 1 + libavformat/swf.h| 13 libavformat/swfdec.c | 86 +++

Re: [libav-devel] [PATCH] swfdec: support compressed swf

2015-12-07 Thread Luca Barbato
On 03/12/15 00:41, Vittorio Giovara wrote: > +if (ret < 0) > +return AVERROR(EINVAL); > +if (ret == Z_STREAM_END) > +return AVERROR_EOF; I'd swap those two, and maybe do ret = buf_size - z->avail_out; if (ret) return ret; else goto retry; for the rest I do not rem

Re: [libav-devel] [PATCH] swfdec: support compressed swf

2015-12-07 Thread Vittorio Giovara
On Fri, Dec 4, 2015 at 6:13 AM, Hendrik Leppkes wrote: > On Fri, Dec 4, 2015 at 12:06 PM, Diego Biurrun wrote: >> On Wed, Dec 02, 2015 at 06:41:00PM -0500, Vittorio Giovara wrote: >>> >>> --- a/libavformat/swfdec.c >>> +++ b/libavformat/swfdec.c >>> @@ -61,6 +67,39 @@ static int swf_probe(AVProbe

Re: [libav-devel] [PATCH 026/264] flvdec: do not create any streams in read_header()

2015-12-07 Thread Vittorio Giovara
On Sun, Dec 6, 2015 at 4:59 AM, Anton Khirnov wrote: > The current muxer behaviour is to create streams in read_header() based > on the audio/video presence flags, but fill in the stream parameters > later when we actually get some packets for them. This is rather shady, > since other demuxers set

Re: [libav-devel] [PATCH] parser: Suppress spurious warnings

2015-12-07 Thread Vittorio Giovara
On Mon, Dec 7, 2015 at 11:03 AM, Luca Barbato wrote: > On 07/12/15 16:55, Anton Khirnov wrote: >> Yes, so the API is broken. The right solution is to fix the API (which >> I'm going to do after TEP2). I think keeping the warning there is >> better, it should remind us of the broken api. > > As lon

Re: [libav-devel] [PATCH] parser: Suppress spurious warnings

2015-12-07 Thread Luca Barbato
On 07/12/15 16:55, Anton Khirnov wrote: > Yes, so the API is broken. The right solution is to fix the API (which > I'm going to do after TEP2). I think keeping the warning there is > better, it should remind us of the broken api. As long there is agreement on this sure. DonDiego did more work on t

Re: [libav-devel] [PATCH] parser: Suppress spurious warnings

2015-12-07 Thread Anton Khirnov
Quoting Luca Barbato (2015-12-07 16:32:39) > On 07/12/15 11:45, Anton Khirnov wrote: > > Quoting Luca Barbato (2015-12-05 17:16:54) > >> The pattern of that code is similar to strstr. > >> --- > >> > >> libavcodec/parser.c | 4 ++-- > >> 1 file changed, 2 insertions(+), 2 deletions(-) > >> > >> di

Re: [libav-devel] [PATCH] parser: Suppress spurious warnings

2015-12-07 Thread Luca Barbato
On 07/12/15 11:45, Anton Khirnov wrote: > Quoting Luca Barbato (2015-12-05 17:16:54) >> The pattern of that code is similar to strstr. >> --- >> >> libavcodec/parser.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/parser.c b/libavcodec/parser.c >> index

Re: [libav-devel] [PATCH] hls: Don't persist http options that haven't been set

2015-12-07 Thread Luca Barbato
On 07/12/15 13:35, Martin Storsjö wrote: > av_opt_get does return the empty string for options that aren't set. > > This avoids warnings about "No trailing CRLF found in HTTP header." > --- > libavformat/hls.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavformat/h

[libav-devel] [PATCH] hls: Don't persist http options that haven't been set

2015-12-07 Thread Martin Storsjö
av_opt_get does return the empty string for options that aren't set. This avoids warnings about "No trailing CRLF found in HTTP header." --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index dc3ab87..db4da31 100644 --

Re: [libav-devel] [PATCH 2/2] rtsp: free opts dictionary on failure of getnameinfo

2015-12-07 Thread Ganesh Ajjanagadde
On Mon, Dec 7, 2015 at 2:21 AM, Martin Storsjö wrote: > On Mon, 7 Dec 2015, Anton Khirnov wrote: > >> Quoting Ganesh Ajjanagadde (2015-12-07 00:44:37) >>> >>> On Sun, Dec 6, 2015 at 6:17 PM, Luca Barbato wrote: >>> > On 06/12/15 20:30, Martin Storsjö wrote: >>> >> From: Ganesh Ajjanagadde >>> >>

Re: [libav-devel] [PATCH] log: Use a do {} while (0) for tlog

2015-12-07 Thread Anton Khirnov
Quoting Luca Barbato (2015-12-05 17:08:28) > Avoid the warning `-Wempty-body`. Sure. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] parser: Suppress spurious warnings

2015-12-07 Thread Anton Khirnov
Quoting Luca Barbato (2015-12-05 17:16:54) > The pattern of that code is similar to strstr. > --- > > libavcodec/parser.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/parser.c b/libavcodec/parser.c > index 431dc7b..3ddcdb8 100644 > --- a/libavcodec/pars