Re: [libav-devel] [PATCH 2/2] eatqi: Remove mpegvideo dependency

2016-01-25 Thread Diego Biurrun
On Mon, Jan 25, 2016 at 12:55:05PM -0500, Vittorio Giovara wrote: > On Fri, Jan 22, 2016 at 1:36 AM, Diego Biurrun wrote: > > On Thu, Jan 21, 2016 at 04:53:56PM -0500, Vittorio Giovara wrote: > >> --- a/libavcodec/eatqi.c > >> +++ b/libavcodec/eatqi.c > >> @@ -137,15 +149,15 @@ static int tqi_deco

Re: [libav-devel] [FFmpeg-devel] [PATCHv3] avcodec: Cineform HD Decoder

2016-01-25 Thread Kieran Kunhya
On Mon, Jan 25, 2016 at 2:42 PM, Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 24, 2016 at 7:34 PM, Kieran Kunhya wrote: > >> +static inline void filter(int16_t *output, ptrdiff_t out_stride, int16_t >> *low, ptrdiff_t low_stride, >> + int16_t *high, ptrdiff_t high_stride

Re: [libav-devel] [FFmpeg-devel] [PATCH] svq1enc: fix out of bounds reads

2016-01-25 Thread Andreas Cadhalpun
On 22.01.2016 00:57, Michael Niedermayer wrote: > On Thu, Jan 21, 2016 at 11:04:14PM +0100, Andreas Cadhalpun wrote: >> level can be up to 5, but there are only four codebooks. >> >> Fixes ubsan runtime error: index 5 out of bounds for type 'int8_t >> [4][96]' >> >> Signed-off-by: Andreas Cadhalpun

Re: [libav-devel] [PATCH] lavf: remove the concat protocol

2016-01-25 Thread Andreas Cadhalpun
On 22.01.2016 00:34, Luca Barbato wrote: > Let's try to make sure we are talking about the same problem here. > > by using hls you might craft a playlist containing a concat of a > playlist w/out a final new line. > > So you would send the initial part of the file together with the url. > > This

Re: [libav-devel] [PATCHv3] avcodec: Cineform HD Decoder

2016-01-25 Thread Kieran Kunhya
On Mon, Jan 25, 2016 at 4:51 PM, Vittorio Giovara wrote: > On Sun, Jan 24, 2016 at 7:34 PM, Kieran Kunhya wrote: >> Decodes YUV 4:2:2 10-bit and RGB 12-bit files. >> Older files with more subbands, skips, Bayer, alpha not supported. >> Alpha requires addition of GBRAP12 pixel format. > > Actually

[libav-devel] [PATCH] mpeg12dec: Always close reader on error

2016-01-25 Thread Vittorio Giovara
A reader left open may lead to hangs. Signed-off-by: Vittorio Giovara --- libavcodec/mpeg12dec.c | 63 ++ 1 file changed, 48 insertions(+), 15 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 711b310..882fdf3 100644

[libav-devel] [PATCH 2/3] mpeg1: Make intra-block decoding independent of MpegEncContext

2016-01-25 Thread Vittorio Giovara
This allows untangling the eatqi decoder from the MPEG-1 decoder. Signed-off-by: Vittorio Giovara --- libavcodec/eatqi.c | 9 - libavcodec/mpeg12.c| 89 +++ libavcodec/mpeg12.h| 6 ++- libavcodec/mpeg12dec.c | 101 +++--

[libav-devel] [PATCH 3/3] eatqi: Remove MpegEncContext dependency

2016-01-25 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara --- configure | 2 +- libavcodec/Makefile | 2 +- libavcodec/eatqi.c | 90 ++--- 3 files changed, 53 insertions(+), 41 deletions(-) diff --git a/configure b/configure index c5bcb78..b819945 100755 --- a/

[libav-devel] [PATCH 1/3] mpeg12dec: Always close reader on error

2016-01-25 Thread Vittorio Giovara
A reader left open may lead to hangs. Signed-off-by: Vittorio Giovara --- libavcodec/mpeg12dec.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 711b310..1e1e4a5 100644 --- a/libavcodec/mpeg12dec.c +++ b/libavcode

Re: [libav-devel] [PATCH 2/2] eatqi: Remove mpegvideo dependency

2016-01-25 Thread Vittorio Giovara
On Fri, Jan 22, 2016 at 1:36 AM, Diego Biurrun wrote: > On Thu, Jan 21, 2016 at 04:53:56PM -0500, Vittorio Giovara wrote: >> --- a/libavcodec/eatqi.c >> +++ b/libavcodec/eatqi.c >> @@ -137,15 +149,15 @@ static int tqi_decode_frame(AVCodecContext *avctx, >> - >> -s->last_dc[0] = s->last_dc[1] =

Re: [libav-devel] [PATCH 3/3] pixdesc: Use AV_CEIL_RSHIFT in documentation

2016-01-25 Thread Vittorio Giovara
On Thu, Jan 21, 2016 at 6:00 PM, Vittorio Giovara wrote: > --- > libavutil/pixdesc.h | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavutil/pixdesc.h b/libavutil/pixdesc.h > index fe06d94..f52c434 100644 > --- a/libavutil/pixdesc.h > +++ b/libavutil/pixdesc.h > @

Re: [libav-devel] [PATCHv3] avcodec: Cineform HD Decoder

2016-01-25 Thread Vittorio Giovara
On Sun, Jan 24, 2016 at 7:34 PM, Kieran Kunhya wrote: > Decodes YUV 4:2:2 10-bit and RGB 12-bit files. > Older files with more subbands, skips, Bayer, alpha not supported. > Alpha requires addition of GBRAP12 pixel format. Actually you could set AV_PIX_FMT_GBRAP16 and tweak the bits_per_raw_sampl

Re: [libav-devel] [FFmpeg-devel] [PATCHv3] avcodec: Cineform HD Decoder

2016-01-25 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 7:34 PM, Kieran Kunhya wrote: > +static inline void filter(int16_t *output, ptrdiff_t out_stride, int16_t > *low, ptrdiff_t low_stride, > + int16_t *high, ptrdiff_t high_stride, int len, > uint8_t clip) Should this be a DSP function? (That i

Re: [libav-devel] [PATCH 1/2] mpeg1: Make intra-block decoding independent of mpegvideoenc

2016-01-25 Thread Diego Biurrun
On Fri, Jan 22, 2016 at 10:24:09AM -0500, Vittorio Giovara wrote: > On Fri, Jan 22, 2016 at 1:47 AM, Diego Biurrun wrote: > > On Thu, Jan 21, 2016 at 04:53:55PM -0500, Vittorio Giovara wrote: > >> --- a/libavcodec/mpeg12.c > >> +++ b/libavcodec/mpeg12.c > >> @@ -236,3 +236,92 @@ int ff_mpeg1_find_

Re: [libav-devel] [PATCH 2/2] configure: add missing avx2 support check

2016-01-25 Thread Luca Barbato
On 25/01/16 10:45, Diego Biurrun wrote: > Those are 4-5 years old; bump requirements instead? I already added the guards, it is more consistent with the rest of the codebase and I guess whoever wants to build w/out a specific optional component might like not having stray code even if he could bui

Re: [libav-devel] [PATCH 2/2] configure: add missing avx2 support check

2016-01-25 Thread Diego Biurrun
On Sun, Jan 24, 2016 at 02:10:44AM -0300, James Almer wrote: > AVX2 support was introduced in Yasm 1.2.0 and NASM 2.10, and the > oldest versions currently supported are Yasm 0.8.0 and NASM 2.03 Those are 4-5 years old; bump requirements instead? Diego