[libav-devel] [RFC] [PATCH 2/2] img2dec: Handle query parameters when checking extensions

A webserver omits the Content-Type or if mime-magic fails for unexpected reasons, probing an image HTTP URL with query parameters will fail in the extension match. So check the protocol used is http or https, and drop anything after the first query parameter when evaluating an image URL.

[libav-devel] [PATCH 1/2] img2: Drop av_ prefix for a static function

This prefix is reserved for public functions only. --- libavformat/img2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/img2.c b/libavformat/img2.c index 9f462d0..3cfc08e 100644 --- a/libavformat/img2.c +++ b/libavformat/img2.c @@ -82,7 +82,7 @@ static const

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

On 2/23/2016 1:17 AM, Vittorio Giovara wrote: > --- > The test sample is already on FATE strangely enough. > Vittorio > > tests/fate/microsoft.mak| 3 + > tests/ref/fate/wmv8-intrax8 | 475 > > 2 files changed, 478 insertions(+) > create mode

Re: [libav-devel] [PATCH 19/25] intrax8: Use the generic horizband function

On 23/02/16 02:17, Vittorio Giovara wrote: > This is assuming that intrax8 has no support for interlacing > (hence PICT_FRAME is set and last_frame is NULL). > --- > libavcodec/intrax8.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/intrax8.c

[libav-devel] [PATCH 3/3] simple_idct: x86: Move simple_idct_put/add_mmx to the only place they are used

Also drop silly ff_simple_idct_mmx wrapper function. --- libavcodec/x86/idctdsp_init.c | 18 -- libavcodec/x86/simple_idct.c | 20 +--- 2 files changed, 17 insertions(+), 21 deletions(-) diff --git a/libavcodec/x86/idctdsp_init.c b/libavcodec/x86/idctdsp_init.c

[libav-devel] [PATCH 1/3] idct: Move jpeg ref idct put/add wrappers to the only place they are used

--- libavcodec/dct.h | 2 -- libavcodec/idctdsp.c | 16 ++-- libavcodec/jrevdct.c | 12 3 files changed, 14 insertions(+), 16 deletions(-) diff --git a/libavcodec/dct.h b/libavcodec/dct.h index 4a31f54..3fd4e27 100644 --- a/libavcodec/dct.h +++ b/libavcodec/dct.h @@

Re: [libav-devel] [PATCH 20/25] intrax8: Keep a reference to the decoder blocks

On Tue, Feb 23, 2016 at 10:51 AM, Diego Biurrun wrote: > On Mon, Feb 22, 2016 at 08:17:44PM -0500, Vittorio Giovara wrote: >> --- >> NOTE: both these elements are not actually used by the decoders: >> vc1 modifies them only for intra (non-j) or interframes, wmv2 does >>

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

On Tue, Feb 23, 2016 at 10:37 AM, Diego Biurrun wrote: > On Tue, Feb 23, 2016 at 10:20:56AM -0500, Vittorio Giovara wrote: >> On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun wrote: >> > On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote: >> >> ---

Re: [libav-devel] [PATCH 1/4] lavu: Add a way to query hwcontext frame constraints.

Quoting Mark Thompson (2016-02-20 19:30:14) > --- > libavutil/hwcontext.c | 38 +++ > libavutil/hwcontext.h | 58 > ++ > libavutil/hwcontext_internal.h | 10 > 3 files changed, 106 insertions(+) > > diff

Re: [libav-devel] [PATCH 24/25] intrax8: Remove mpegvideo dependency

On Mon, Feb 22, 2016 at 08:17:48PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 7 +-- > libavcodec/intrax8.h | 10 +- > libavcodec/vc1dec.c | 3 +-- > libavcodec/wmv2dec.c | 2 +- > 4 files changed, 4 insertions(+), 18 deletions(-) OK Diego

Re: [libav-devel] [PATCH 23/25] intrax8: Drop MB emulation code

On Mon, Feb 22, 2016 at 08:17:47PM -0500, Vittorio Giovara wrote: > This is already performed in init_context_frame(). > --- > libavcodec/intrax8.c | 2 -- > 1 file changed, 2 deletions(-) probably OK Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 21/25] intrax8: Drop two unused variables

On Mon, Feb 22, 2016 at 08:17:45PM -0500, Vittorio Giovara wrote: > These are not changed in the function, nor in the dependent decoders. > --- > libavcodec/intrax8.c | 5 + > 1 file changed, 1 insertion(+), 4 deletions(-) probably OK Diego ___

Re: [libav-devel] [PATCH 22/25] intrax8: Keep a reference to the error resilience context

On Mon, Feb 22, 2016 at 08:17:46PM -0500, Vittorio Giovara wrote: > --- > This one bugs me since intrax8 decoding process requires no error resilience > whatsoever, and it's only there to make things work with mpegvideo. > > I'd really really like to remove error resilience altogether, but that >

Re: [libav-devel] [PATCH 20/25] intrax8: Keep a reference to the decoder blocks

On Mon, Feb 22, 2016 at 08:17:44PM -0500, Vittorio Giovara wrote: > --- > NOTE: both these elements are not actually used by the decoders: > vc1 modifies them only for intra (non-j) or interframes, wmv2 does > something similar. I'm not extremely confident in dropping the references, > at least

Re: [libav-devel] [PATCH 13/25] intrax8: Use a local buffer instead of a ScratchpadContext

On Tue, Feb 23, 2016 at 10:25:55AM -0500, Vittorio Giovara wrote: > On Tue, Feb 23, 2016 at 8:22 AM, Diego Biurrun wrote: > > On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote: > >> Sustain possible size changes via av_fast_malloc(). > > > > Sustain? That's not

Re: [libav-devel] [PATCH 07/25] vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

On Tue, Feb 23, 2016 at 10:23:37AM -0500, Vittorio Giovara wrote: > On Tue, Feb 23, 2016 at 6:09 AM, Diego Biurrun wrote: > > On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote: > >> --- a/libavcodec/vc1dec.c > >> +++ b/libavcodec/vc1dec.c > >> @@ -360,7 +360,7 @@

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

On Tue, Feb 23, 2016 at 10:20:56AM -0500, Vittorio Giovara wrote: > On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun wrote: > > On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote: > >> --- a/tests/fate/microsoft.mak > >> +++ b/tests/fate/microsoft.mak > >> @@ -38,6

Re: [libav-devel] [PATCH 13/25] intrax8: Use a local buffer instead of a ScratchpadContext

On Tue, Feb 23, 2016 at 8:22 AM, Diego Biurrun wrote: > On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote: >> Sustain possible size changes via av_fast_malloc(). > > Sustain? That's not the right word, but I'm a tad unsure what you are > trying to say here. If

Re: [libav-devel] [PATCH 07/25] vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

On Tue, Feb 23, 2016 at 6:09 AM, Diego Biurrun wrote: > On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote: >> --- a/libavcodec/vc1dec.c >> +++ b/libavcodec/vc1dec.c >> @@ -360,7 +360,7 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context >> *v) >> >> -

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun wrote: > On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote: >> --- a/tests/fate/microsoft.mak >> +++ b/tests/fate/microsoft.mak >> @@ -38,6 +38,9 @@ fate-wmv8-drm-nodec: CMD = framecrc -cryptokey >>

Re: [libav-devel] [PATCH] build: Add idct dependency to dct test

On 23/02/16 08:14, Luca Barbato wrote: > Not ok, the problem is quite interesting, the linker might not be > completely at fault here. > I was late for a meeting so I didn't get you more context, some explanations: f_j_rev_dct is used by the test the function lives in a file that also

Re: [libav-devel] [PATCH 18/25] intrax8: Carry over lowdelay value in ff_intrax8_decode_picture

On Mon, Feb 22, 2016 at 08:17:42PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 3 ++- > libavcodec/intrax8.h | 3 ++- > libavcodec/vc1_block.c | 2 +- > libavcodec/wmv2dec.c | 2 +- > 4 files changed, 6 insertions(+), 4 deletions(-) Why? Diego

Re: [libav-devel] [PATCH 17/25] intrax8: Pass macroblock size to ff_intrax8_common_init

On Mon, Feb 22, 2016 at 08:17:41PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 65 > ++-- > libavcodec/intrax8.h | 7 ++ > libavcodec/vc1dec.c | 4 +++- > libavcodec/wmv2dec.c | 3 ++- > 4 files changed, 44 insertions(+),

Re: [libav-devel] [PATCH 16/25] intrax8: Add a local BlockDSPContext and initialize it

On Mon, Feb 22, 2016 at 08:17:40PM -0500, Vittorio Giovara wrote: > --- > configure| 2 +- > libavcodec/intrax8.c | 3 ++- > libavcodec/intrax8.h | 2 ++ > 3 files changed, 5 insertions(+), 2 deletions(-) Why? Diego ___ libav-devel mailing

Re: [libav-devel] [PATCH 25/25] build: Add a formal dependency to intrax8

On Mon, Feb 22, 2016 at 08:17:49PM -0500, Vittorio Giovara wrote: > intrax8 needs tables from msmpeg4, which are normally supplied by either > VC1 or WMV2. It just needs a single table (ff_wmv1_scantable), it would be cleaner to split that one out. Diego

Re: [libav-devel] [PATCH 15/25] intrax8: Reference the currect AVCodecContext decoder

curreNt Not sure what you mean by "AVCodecContext decoder". Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 14/25] intrax8: Keep a reference to the GetBitContext reader

On Mon, Feb 22, 2016 at 08:17:38PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 35 --- > libavcodec/intrax8.h | 4 +++- > libavcodec/vc1_block.c | 2 +- > libavcodec/wmv2dec.c | 2 +- > 4 files changed, 21 insertions(+), 22 deletions(-)

Re: [libav-devel] [PATCH 05/25] intrax8: Let x8_vlc_init report errors

On Tue, 23 Feb 2016, Diego Biurrun wrote: On Tue, Feb 23, 2016 at 03:21:29PM +0200, Martin Storsjö wrote: On Tue, 23 Feb 2016, Diego Biurrun wrote: >On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote: >>--- >> libavcodec/intrax8.c | 8 ++-- >> 1 file changed, 6 insertions(+),

Re: [libav-devel] [PATCH 05/25] intrax8: Let x8_vlc_init report errors

On Tue, Feb 23, 2016 at 03:21:29PM +0200, Martin Storsjö wrote: > On Tue, 23 Feb 2016, Diego Biurrun wrote: > > >On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote: > >>--- > >> libavcodec/intrax8.c | 8 ++-- > >> 1 file changed, 6 insertions(+), 2 deletions(-) > > > >OK > > >

Re: [libav-devel] [PATCH 13/25] intrax8: Use a local buffer instead of a ScratchpadContext

On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote: > Sustain possible size changes via av_fast_malloc(). Sustain? That's not the right word, but I'm a tad unsure what you are trying to say here. > --- a/libavcodec/intrax8.c > +++ b/libavcodec/intrax8.c > @@ -773,6 +773,7 @@ int

Re: [libav-devel] [PATCH 05/25] intrax8: Let x8_vlc_init report errors

On Tue, 23 Feb 2016, Diego Biurrun wrote: On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote: --- libavcodec/intrax8.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) OK --- a/libavcodec/intrax8.c +++ b/libavcodec/intrax8.c @@ -115,9 +115,13 @@ static av_cold

Re: [libav-devel] [PATCH 12/25] intrax8: Pass the output frame to the decoding function

On Mon, Feb 22, 2016 at 08:17:36PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 21 +++-- > libavcodec/intrax8.h | 7 +-- > libavcodec/vc1_block.c | 4 +++- > libavcodec/wmv2dec.c | 3 ++- > 4 files changed, 21 insertions(+), 14 deletions(-) Why?

Re: [libav-devel] [PATCH 11/25] intrax8: Carry over the loopfilter value in ff_intrax8_decode_picture

On Mon, Feb 22, 2016 at 08:17:35PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 5 +++-- > libavcodec/intrax8.h | 7 +-- > libavcodec/vc1_block.c | 2 +- > libavcodec/wmv2dec.c | 3 ++- > 4 files changed, 11 insertions(+), 6 deletions(-) Why? Diego

Re: [libav-devel] [PATCH 10/25] intrax8: Keep a reference to the context idctdsp

On Mon, Feb 22, 2016 at 08:17:34PM -0500, Vittorio Giovara wrote: > --- a/libavcodec/intrax8.c > @@ -736,12 +736,14 @@ static void x8_init_block_index(IntraX8Context *w, > AVFrame *frame, int mb_y) > w->dest[2] += (mb_y & (~1)) * uvlinesize << 2; > } > > -av_cold int

Re: [libav-devel] [PATCH 09/25] intrax8: Make x8_init_block_index not use mpegvideo fields

On Mon, Feb 22, 2016 at 08:17:33PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 23 +++ > 1 file changed, 11 insertions(+), 12 deletions(-) You are saving a bunch of pointer dereferences, so this should be faster. OK Diego

Re: [libav-devel] [PATCH 08/25] intrax8: Use local destination buffers

On Mon, Feb 22, 2016 at 08:17:32PM -0500, Vittorio Giovara wrote: > This buffers are just a way to store frame pointers and be able to These OK Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 03/25] intrax8: K formatting cosmetics

On Mon, Feb 22, 2016 at 08:17:27PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c| 1035 ++- > libavcodec/intrax8.h| 28 +- > libavcodec/intrax8dsp.c | 608 > libavcodec/intrax8dsp.h |4 +- > libavcodec/intrax8huf.h | 1793 >

Re: [libav-devel] [PATCH] pthread_frame: do not unset AVCodecContext.codec on free

Disregard this patch, it breaks other things I didn't consider. I'll try to write a better fix. -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] pthread_frame: do not unset AVCodecContext.codec on free

It is intended to prevent the generic code from closing the context (which has already been closed by the pthread_frame code), but has other uninteded side effects, like leaking allocated private AVOptions. Instead, add an explicit check for frame threading to the generic code, which is the same

Re: [libav-devel] [PATCH 07/25] vc1dec: wmv2dec: Validate ff_intrax8_common_init return value

On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote: > --- a/libavcodec/vc1dec.c > +++ b/libavcodec/vc1dec.c > @@ -360,7 +360,7 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v) > > -ff_intrax8_common_init(>x8,s); > +ret = ff_intrax8_common_init(>x8, s); > >

Re: [libav-devel] [PATCH 06/25] intrax8: Check and propagate errors from ff_intrax8_common_init

On Mon, Feb 22, 2016 at 08:17:30PM -0500, Vittorio Giovara wrote: > This allows to drop the assert since it would be redundant. This allows dropping an afterwards redundant assert. > --- a/libavcodec/intrax8.h > +++ b/libavcodec/intrax8.h > @@ -61,8 +61,9 @@ typedef struct IntraX8Context { > *

Re: [libav-devel] [PATCH 05/25] intrax8: Let x8_vlc_init report errors

On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) OK > --- a/libavcodec/intrax8.c > +++ b/libavcodec/intrax8.c > @@ -115,9 +115,13 @@ static av_cold void x8_vlc_init(void) > > -if

Re: [libav-devel] [PATCH 04/25] intrax8: Move documentation from implementation to header files

On Mon, Feb 22, 2016 at 08:17:28PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 20 > libavcodec/intrax8.h | 24 > 2 files changed, 24 insertions(+), 20 deletions(-) Sure, if you prefer. Diego

Re: [libav-devel] [PATCH 02/25] intrax8: Wrap multiline macros in do{}while(0) clauses

On Mon, Feb 22, 2016 at 08:17:26PM -0500, Vittorio Giovara wrote: > --- > libavcodec/intrax8.c | 17 ++--- > 1 file changed, 10 insertions(+), 7 deletions(-) The log message could explain why. OK Diego ___ libav-devel mailing list

Re: [libav-devel] [PATCH 01/25] fate: Add test for WMV2 with jframes

On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote: > --- > The test sample is already on FATE strangely enough. > Vittorio > > tests/fate/microsoft.mak| 3 + > tests/ref/fate/wmv8-intrax8 | 475 > > 2 files changed, 478