A webserver omits the Content-Type or if mime-magic fails for unexpected
reasons, probing an image HTTP URL with query parameters will fail in
the extension match.
So check the protocol used is http or https, and drop anything after
the first query parameter when evaluating an image URL.
This prefix is reserved for public functions only.
---
libavformat/img2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/img2.c b/libavformat/img2.c
index 9f462d0..3cfc08e 100644
--- a/libavformat/img2.c
+++ b/libavformat/img2.c
@@ -82,7 +82,7 @@ static const
On 2/23/2016 1:17 AM, Vittorio Giovara wrote:
> ---
> The test sample is already on FATE strangely enough.
> Vittorio
>
> tests/fate/microsoft.mak| 3 +
> tests/ref/fate/wmv8-intrax8 | 475
>
> 2 files changed, 478 insertions(+)
> create mode
On 23/02/16 02:17, Vittorio Giovara wrote:
> This is assuming that intrax8 has no support for interlacing
> (hence PICT_FRAME is set and last_frame is NULL).
> ---
> libavcodec/intrax8.c | 5 -
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/libavcodec/intrax8.c
Also drop silly ff_simple_idct_mmx wrapper function.
---
libavcodec/x86/idctdsp_init.c | 18 --
libavcodec/x86/simple_idct.c | 20 +---
2 files changed, 17 insertions(+), 21 deletions(-)
diff --git a/libavcodec/x86/idctdsp_init.c b/libavcodec/x86/idctdsp_init.c
---
libavcodec/dct.h | 2 --
libavcodec/idctdsp.c | 16 ++--
libavcodec/jrevdct.c | 12
3 files changed, 14 insertions(+), 16 deletions(-)
diff --git a/libavcodec/dct.h b/libavcodec/dct.h
index 4a31f54..3fd4e27 100644
--- a/libavcodec/dct.h
+++ b/libavcodec/dct.h
@@
On Tue, Feb 23, 2016 at 10:51 AM, Diego Biurrun wrote:
> On Mon, Feb 22, 2016 at 08:17:44PM -0500, Vittorio Giovara wrote:
>> ---
>> NOTE: both these elements are not actually used by the decoders:
>> vc1 modifies them only for intra (non-j) or interframes, wmv2 does
>>
On Tue, Feb 23, 2016 at 10:37 AM, Diego Biurrun wrote:
> On Tue, Feb 23, 2016 at 10:20:56AM -0500, Vittorio Giovara wrote:
>> On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun wrote:
>> > On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote:
>> >> ---
Quoting Mark Thompson (2016-02-20 19:30:14)
> ---
> libavutil/hwcontext.c | 38 +++
> libavutil/hwcontext.h | 58
> ++
> libavutil/hwcontext_internal.h | 10
> 3 files changed, 106 insertions(+)
>
> diff
On Mon, Feb 22, 2016 at 08:17:48PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 7 +--
> libavcodec/intrax8.h | 10 +-
> libavcodec/vc1dec.c | 3 +--
> libavcodec/wmv2dec.c | 2 +-
> 4 files changed, 4 insertions(+), 18 deletions(-)
OK
Diego
On Mon, Feb 22, 2016 at 08:17:47PM -0500, Vittorio Giovara wrote:
> This is already performed in init_context_frame().
> ---
> libavcodec/intrax8.c | 2 --
> 1 file changed, 2 deletions(-)
probably OK
Diego
___
libav-devel mailing list
On Mon, Feb 22, 2016 at 08:17:45PM -0500, Vittorio Giovara wrote:
> These are not changed in the function, nor in the dependent decoders.
> ---
> libavcodec/intrax8.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
probably OK
Diego
___
On Mon, Feb 22, 2016 at 08:17:46PM -0500, Vittorio Giovara wrote:
> ---
> This one bugs me since intrax8 decoding process requires no error resilience
> whatsoever, and it's only there to make things work with mpegvideo.
>
> I'd really really like to remove error resilience altogether, but that
>
On Mon, Feb 22, 2016 at 08:17:44PM -0500, Vittorio Giovara wrote:
> ---
> NOTE: both these elements are not actually used by the decoders:
> vc1 modifies them only for intra (non-j) or interframes, wmv2 does
> something similar. I'm not extremely confident in dropping the references,
> at least
On Tue, Feb 23, 2016 at 10:25:55AM -0500, Vittorio Giovara wrote:
> On Tue, Feb 23, 2016 at 8:22 AM, Diego Biurrun wrote:
> > On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote:
> >> Sustain possible size changes via av_fast_malloc().
> >
> > Sustain? That's not
On Tue, Feb 23, 2016 at 10:23:37AM -0500, Vittorio Giovara wrote:
> On Tue, Feb 23, 2016 at 6:09 AM, Diego Biurrun wrote:
> > On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote:
> >> --- a/libavcodec/vc1dec.c
> >> +++ b/libavcodec/vc1dec.c
> >> @@ -360,7 +360,7 @@
On Tue, Feb 23, 2016 at 10:20:56AM -0500, Vittorio Giovara wrote:
> On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun wrote:
> > On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote:
> >> --- a/tests/fate/microsoft.mak
> >> +++ b/tests/fate/microsoft.mak
> >> @@ -38,6
On Tue, Feb 23, 2016 at 8:22 AM, Diego Biurrun wrote:
> On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote:
>> Sustain possible size changes via av_fast_malloc().
>
> Sustain? That's not the right word, but I'm a tad unsure what you are
> trying to say here.
If
On Tue, Feb 23, 2016 at 6:09 AM, Diego Biurrun wrote:
> On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote:
>> --- a/libavcodec/vc1dec.c
>> +++ b/libavcodec/vc1dec.c
>> @@ -360,7 +360,7 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context
>> *v)
>>
>> -
On Tue, Feb 23, 2016 at 2:05 AM, Diego Biurrun wrote:
> On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote:
>> --- a/tests/fate/microsoft.mak
>> +++ b/tests/fate/microsoft.mak
>> @@ -38,6 +38,9 @@ fate-wmv8-drm-nodec: CMD = framecrc -cryptokey
>>
On 23/02/16 08:14, Luca Barbato wrote:
> Not ok, the problem is quite interesting, the linker might not be
> completely at fault here.
>
I was late for a meeting so I didn't get you more context, some
explanations:
f_j_rev_dct is used by the test
the function lives in a file that also
On Mon, Feb 22, 2016 at 08:17:42PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 3 ++-
> libavcodec/intrax8.h | 3 ++-
> libavcodec/vc1_block.c | 2 +-
> libavcodec/wmv2dec.c | 2 +-
> 4 files changed, 6 insertions(+), 4 deletions(-)
Why?
Diego
On Mon, Feb 22, 2016 at 08:17:41PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 65
> ++--
> libavcodec/intrax8.h | 7 ++
> libavcodec/vc1dec.c | 4 +++-
> libavcodec/wmv2dec.c | 3 ++-
> 4 files changed, 44 insertions(+),
On Mon, Feb 22, 2016 at 08:17:40PM -0500, Vittorio Giovara wrote:
> ---
> configure| 2 +-
> libavcodec/intrax8.c | 3 ++-
> libavcodec/intrax8.h | 2 ++
> 3 files changed, 5 insertions(+), 2 deletions(-)
Why?
Diego
___
libav-devel mailing
On Mon, Feb 22, 2016 at 08:17:49PM -0500, Vittorio Giovara wrote:
> intrax8 needs tables from msmpeg4, which are normally supplied by either
> VC1 or WMV2.
It just needs a single table (ff_wmv1_scantable), it would be cleaner
to split that one out.
Diego
curreNt
Not sure what you mean by "AVCodecContext decoder".
Diego
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
On Mon, Feb 22, 2016 at 08:17:38PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 35 ---
> libavcodec/intrax8.h | 4 +++-
> libavcodec/vc1_block.c | 2 +-
> libavcodec/wmv2dec.c | 2 +-
> 4 files changed, 21 insertions(+), 22 deletions(-)
On Tue, 23 Feb 2016, Diego Biurrun wrote:
On Tue, Feb 23, 2016 at 03:21:29PM +0200, Martin Storsjö wrote:
On Tue, 23 Feb 2016, Diego Biurrun wrote:
>On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote:
>>---
>> libavcodec/intrax8.c | 8 ++--
>> 1 file changed, 6 insertions(+),
On Tue, Feb 23, 2016 at 03:21:29PM +0200, Martin Storsjö wrote:
> On Tue, 23 Feb 2016, Diego Biurrun wrote:
>
> >On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote:
> >>---
> >> libavcodec/intrax8.c | 8 ++--
> >> 1 file changed, 6 insertions(+), 2 deletions(-)
> >
> >OK
> >
>
On Mon, Feb 22, 2016 at 08:17:37PM -0500, Vittorio Giovara wrote:
> Sustain possible size changes via av_fast_malloc().
Sustain? That's not the right word, but I'm a tad unsure what you are
trying to say here.
> --- a/libavcodec/intrax8.c
> +++ b/libavcodec/intrax8.c
> @@ -773,6 +773,7 @@ int
On Tue, 23 Feb 2016, Diego Biurrun wrote:
On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote:
---
libavcodec/intrax8.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
OK
--- a/libavcodec/intrax8.c
+++ b/libavcodec/intrax8.c
@@ -115,9 +115,13 @@ static av_cold
On Mon, Feb 22, 2016 at 08:17:36PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 21 +++--
> libavcodec/intrax8.h | 7 +--
> libavcodec/vc1_block.c | 4 +++-
> libavcodec/wmv2dec.c | 3 ++-
> 4 files changed, 21 insertions(+), 14 deletions(-)
Why?
On Mon, Feb 22, 2016 at 08:17:35PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 5 +++--
> libavcodec/intrax8.h | 7 +--
> libavcodec/vc1_block.c | 2 +-
> libavcodec/wmv2dec.c | 3 ++-
> 4 files changed, 11 insertions(+), 6 deletions(-)
Why?
Diego
On Mon, Feb 22, 2016 at 08:17:34PM -0500, Vittorio Giovara wrote:
> --- a/libavcodec/intrax8.c
> @@ -736,12 +736,14 @@ static void x8_init_block_index(IntraX8Context *w,
> AVFrame *frame, int mb_y)
> w->dest[2] += (mb_y & (~1)) * uvlinesize << 2;
> }
>
> -av_cold int
On Mon, Feb 22, 2016 at 08:17:33PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 23 +++
> 1 file changed, 11 insertions(+), 12 deletions(-)
You are saving a bunch of pointer dereferences, so this should be faster.
OK
Diego
On Mon, Feb 22, 2016 at 08:17:32PM -0500, Vittorio Giovara wrote:
> This buffers are just a way to store frame pointers and be able to
These
OK
Diego
___
libav-devel mailing list
libav-devel@libav.org
On Mon, Feb 22, 2016 at 08:17:27PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c| 1035 ++-
> libavcodec/intrax8.h| 28 +-
> libavcodec/intrax8dsp.c | 608
> libavcodec/intrax8dsp.h |4 +-
> libavcodec/intrax8huf.h | 1793
>
Disregard this patch, it breaks other things I didn't consider. I'll
try to write a better fix.
--
Anton Khirnov
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
It is intended to prevent the generic code from closing the context
(which has already been closed by the pthread_frame code), but has other
uninteded side effects, like leaking allocated private AVOptions.
Instead, add an explicit check for frame threading to the generic code,
which is the same
On Mon, Feb 22, 2016 at 08:17:31PM -0500, Vittorio Giovara wrote:
> --- a/libavcodec/vc1dec.c
> +++ b/libavcodec/vc1dec.c
> @@ -360,7 +360,7 @@ av_cold int ff_vc1_decode_init_alloc_tables(VC1Context *v)
>
> -ff_intrax8_common_init(>x8,s);
> +ret = ff_intrax8_common_init(>x8, s);
>
>
On Mon, Feb 22, 2016 at 08:17:30PM -0500, Vittorio Giovara wrote:
> This allows to drop the assert since it would be redundant.
This allows dropping an afterwards redundant assert.
> --- a/libavcodec/intrax8.h
> +++ b/libavcodec/intrax8.h
> @@ -61,8 +61,9 @@ typedef struct IntraX8Context {
> *
On Mon, Feb 22, 2016 at 08:17:29PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 8 ++--
> 1 file changed, 6 insertions(+), 2 deletions(-)
OK
> --- a/libavcodec/intrax8.c
> +++ b/libavcodec/intrax8.c
> @@ -115,9 +115,13 @@ static av_cold void x8_vlc_init(void)
>
> -if
On Mon, Feb 22, 2016 at 08:17:28PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 20
> libavcodec/intrax8.h | 24
> 2 files changed, 24 insertions(+), 20 deletions(-)
Sure, if you prefer.
Diego
On Mon, Feb 22, 2016 at 08:17:26PM -0500, Vittorio Giovara wrote:
> ---
> libavcodec/intrax8.c | 17 ++---
> 1 file changed, 10 insertions(+), 7 deletions(-)
The log message could explain why.
OK
Diego
___
libav-devel mailing list
On Mon, Feb 22, 2016 at 08:17:25PM -0500, Vittorio Giovara wrote:
> ---
> The test sample is already on FATE strangely enough.
> Vittorio
>
> tests/fate/microsoft.mak| 3 +
> tests/ref/fate/wmv8-intrax8 | 475
>
> 2 files changed, 478
45 matches
Mail list logo