Re: [libav-devel] [PATCH] mov: check atom nesting depth and limit it to 10

On 03/03/16 01:23, Vittorio Giovara wrote: > On Tue, Feb 9, 2016 at 5:45 PM, Luca Barbato wrote: >> On 09/02/16 23:23, Vittorio Giovara wrote: >>> From: Michael Niedermayer >>> >>> Fixes call stack overflow >>> Fixes: case1_call_stack_overflow.mp4 >>>

Re: [libav-devel] [PATCH] mov: check atom nesting depth and limit it to 10

On Tue, Feb 9, 2016 at 5:45 PM, Luca Barbato wrote: > On 09/02/16 23:23, Vittorio Giovara wrote: >> From: Michael Niedermayer >> >> Fixes call stack overflow >> Fixes: case1_call_stack_overflow.mp4 >> Found-by: Michal Zalewski >>

Re: [libav-devel] [PATCH 1/3] mpegvideo: Fix undefined negative shifts in ff_init_block_index

On 03/03/16 00:52, Vittorio Giovara wrote: > From: Luca Barbato > > Found-by: gcc5-ubsan. > > Signed-off-by: Vittorio Giovara > --- > libavcodec/mpegvideo.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git

Re: [libav-devel] [PATCH 2/3] mpegvideo_motion: Fix undefined negative shifts in mpeg_motion_internal

On 03/03/16 00:52, Vittorio Giovara wrote: > From: Michael Niedermayer > > Found-by: Clang -fsanitize=shift > Reported-by: Thierry Foucu > Signed-off-by: Vittorio Giovara > --- > libavcodec/mpegvideo_motion.c | 8 +--- > 1

Re: [libav-devel] [PATCH] mov: Trim dref absolute path

On Wed, Feb 24, 2016 at 5:16 PM, Luca Barbato wrote: > On 24/02/16 18:23, Vittorio Giovara wrote: >> Which way? Patch as is or the other version that trims by 1 character only? >> > > As is, it is fine. Adding this to the push queue, any more comments/objections? -- Vittorio

Re: [libav-devel] [PATCH 3/3] idct8x8: Fix undefined negative shifts

On 03/03/16 00:52, Vittorio Giovara wrote: > From: Katerina Barone-Adesi > > The original code left-shifts negative values, which is undefined > in the C99 specification (the one used during normal Libav compilation). > This change multiplies by (1 << shift), which is

[libav-devel] [PATCH 2/3] mpegvideo_motion: Fix undefined negative shifts in mpeg_motion_internal

From: Michael Niedermayer Found-by: Clang -fsanitize=shift Reported-by: Thierry Foucu Signed-off-by: Vittorio Giovara --- libavcodec/mpegvideo_motion.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git

[libav-devel] [PATCH 1/3] mpegvideo: Fix undefined negative shifts in ff_init_block_index

From: Luca Barbato Found-by: gcc5-ubsan. Signed-off-by: Vittorio Giovara --- libavcodec/mpegvideo.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index e0787a6..5974e18

[libav-devel] [PATCH 3/3] idct8x8: Fix undefined negative shifts

From: Katerina Barone-Adesi The original code left-shifts negative values, which is undefined in the C99 specification (the one used during normal Libav compilation). This change multiplies by (1 << shift), which is functionally equivalent, but has defined behavior. With