Re: [libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread James Almer
On 6/11/2016 5:55 PM, Martin Storsjö wrote: > On Sat, 11 Jun 2016, James Almer wrote: > >> On 6/11/2016 5:32 PM, Martin Storsjö wrote: >>> --- >>> libavcodec/x86/h264_idct.asm | 5 + >>> libavcodec/x86/h264_idct_10bit.asm | 4 >>> 2 files changed, 9 insertions(+) >>> >>> diff

Re: [libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread Martin Storsjö
On Sat, 11 Jun 2016, James Almer wrote: On 6/11/2016 5:32 PM, Martin Storsjö wrote: --- libavcodec/x86/h264_idct.asm | 5 + libavcodec/x86/h264_idct_10bit.asm | 4 2 files changed, 9 insertions(+) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index

Re: [libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread James Almer
On 6/11/2016 5:32 PM, Martin Storsjö wrote: > --- > libavcodec/x86/h264_idct.asm | 5 + > libavcodec/x86/h264_idct_10bit.asm | 4 > 2 files changed, 9 insertions(+) > > diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm > index 313791a..9abed3c 100644 > ---

Re: [libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread Martin Storsjö
On Sat, 11 Jun 2016, Martin Storsjö wrote: --- libavcodec/x86/h264_idct.asm | 5 + libavcodec/x86/h264_idct_10bit.asm | 4 2 files changed, 9 insertions(+) The subject could be amended with "... in h264 idct". I guess I should add, that I guess there's other cases as well where

[libav-devel] [PATCH 2/2] checkasm: Add tests for h264 idct

2016-06-11 Thread Martin Storsjö
The forward dcts are based partially on x264. The idct tests themselves are inspired by similar tests for vp9 by Ronald Bultje. --- Should we mark this as GPL, or are x264 people ok with picking this part (which is more or less straight from the spec)? I'm a little unsure about the scaling for

[libav-devel] [PATCH 1/2] x86: Add missing movsxd for the int stride parameter

2016-06-11 Thread Martin Storsjö
--- libavcodec/x86/h264_idct.asm | 5 + libavcodec/x86/h264_idct_10bit.asm | 4 2 files changed, 9 insertions(+) diff --git a/libavcodec/x86/h264_idct.asm b/libavcodec/x86/h264_idct.asm index 313791a..9abed3c 100644 --- a/libavcodec/x86/h264_idct.asm +++

Re: [libav-devel] [PATCH 17/28] h264_sei: drop an unnecessary h264dec.h include

2016-06-11 Thread Diego Biurrun
On Sat, Jun 11, 2016 at 12:26:04PM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-06-09 11:10:39) > > On Thu, Jun 09, 2016 at 10:30:03AM +0200, Anton Khirnov wrote: > > > The code does not depend on the h264 decoder anymore and only needs > > > information from h264_ps > > > --- > > >

Re: [libav-devel] [PATCH] avpacket: Error out when creating 0-sized side data

2016-06-11 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-06-10 00:35:03) > This mimics the behaviour of other av_*_new_side_data(). > This is not caught by the malloc check, since AV_INPUT_BUFFER_PADDING_SIZE > is always added to the allocated size. > > Signed-off-by: Vittorio Giovara > --- >

Re: [libav-devel] [PATCH 17/28] h264_sei: drop an unnecessary h264dec.h include

2016-06-11 Thread Anton Khirnov
Quoting Diego Biurrun (2016-06-09 11:10:39) > On Thu, Jun 09, 2016 at 10:30:03AM +0200, Anton Khirnov wrote: > > The code does not depend on the h264 decoder anymore and only needs > > information from h264_ps > > --- > > libavcodec/h264_sei.c | 2 +- > > 1 file changed, 1 insertion(+), 1

Re: [libav-devel] [PATCH 02/28] h264: move the block starting a new field out of slice_header_parse()

2016-06-11 Thread Anton Khirnov
Quoting Vittorio Giovara (2016-06-09 18:08:23) > On Thu, Jun 9, 2016 at 4:29 AM, Anton Khirnov wrote: > > There is no bitstream parsing in that block and messing with > > decoder-global state is not something that belongs into header parsing. > > > > Nothing else in this

Re: [libav-devel] [PATCH 001/115] attributes: Add av_unlikely macro

2016-06-11 Thread Anton Khirnov
Quoting Diego Biurrun (2016-06-09 17:11:43) > From: Alexandra Hájková > > --- > doc/APIchanges | 3 +++ > libavutil/attributes.h | 6 ++ > libavutil/version.h| 2 +- > 3 files changed, 10 insertions(+), 1 deletion(-) > My tests on x86 (haswell refresh,