Re: [libav-devel] [PATCHv4] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On Thu, Aug 25, 2016 at 7:42 PM, James Almer wrote: > On 8/25/2016 6:53 PM, Burt P. wrote: >> On Thu, Aug 25, 2016 at 8:56 AM, Diego Biurrun wrote: >>> The _t namespace is reserved for POSIX, the library should not invade it. >> >> Um, I think it is too late

Re: [libav-devel] [PATCHv4] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On 8/25/2016 6:53 PM, Burt P. wrote: > On Thu, Aug 25, 2016 at 8:56 AM, Diego Biurrun wrote: >> On Wed, Aug 24, 2016 at 07:34:22AM -0500, Burt P wrote: >> >> This probably deserves a mention in doc/general.texi and a version bump >> for libavfilter. >> >>> +typedef struct

Re: [libav-devel] [PATCHv3] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On Thu, Aug 25, 2016 at 5:46 PM, Jean-Baptiste Kempf wrote: > On 25 Aug, Burt P. wrote : >> HDCD coding is hidden in some CD audio, but not all, and using it is >> completely optional. > > But you can detect that, cannot you? Yes, but it requires scanning the whole audio to

Re: [libav-devel] [PATCHv3] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On 25 Aug, Burt P. wrote : > On Thu, Aug 25, 2016 at 5:00 PM, Jean-Baptiste Kempf > wrote: > > On 22 Aug, Burt P wrote : > > Why is it a filter and not a decoder? > > It was a choice made by someone else at ffmpeg. > I think it makes sense, because of the nature of HDCD. I

Re: [libav-devel] [PATCHv3] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On Thu, Aug 25, 2016 at 5:00 PM, Jean-Baptiste Kempf wrote: > On 22 Aug, Burt P wrote : > Why is it a filter and not a decoder? It was a choice made by someone else at ffmpeg. I think it makes sense, because of the nature of HDCD. HDCD coding is hidden in some CD audio, but

Re: [libav-devel] [PATCHv3] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On 22 Aug, Burt P wrote : > A new filter that provides HDCD decoding, using libhdcd. > https://github.com/bp0/libhdcd Why is it a filter and not a decoder? With my kindest regards, -- Jean-Baptiste Kempf http://www.jbkempf.com/ - +33 672 704 734 Sent from my Electronic Device

Re: [libav-devel] [PATCHv4] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

Hi, On Thu, Aug 25, 2016 at 8:56 AM, Diego Biurrun wrote: > On Wed, Aug 24, 2016 at 07:34:22AM -0500, Burt P wrote: > > This probably deserves a mention in doc/general.texi and a version bump > for libavfilter. > Done. >> --- a/doc/filters.texi >> +++ b/doc/filters.texi >> @@

[libav-devel] [PATCHv5] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

A new filter that provides HDCD decoding, using libhdcd. https://github.com/bp0/libhdcd Requires ./configure --enable-libhdcd Signed-off-by: Burt P --- Changelog| 1 + configure| 4 + doc/filters.texi | 47 +++

Re: [libav-devel] [PATCH] Changelog: Mention mov with multiple stsd

On 25/08/16 17:59, Vittorio Giovara wrote: > --- > Changelog | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/Changelog b/Changelog > index 0d04f47..2a012db 100644 > --- a/Changelog > +++ b/Changelog > @@ -60,6 +60,7 @@ version : > - MagicYUV decoder > - Duck TrueMotion 2.0 Real Time

Re: [libav-devel] [PATCH 5/6] Add AV1 video decoding support through libaom

Seems you didn't see another post above I tested this patch with videos encoded by aomenc, and found that for 10/12-bit av1 videos this patch decodes incorrectly. I found that ff_aom_imgfmt_to_pixfmt might not work as supposed for high bit depth. Like libvpx, avctx->pix_fmt should be set by

Re: [libav-devel] [PATCH 5/6] Add AV1 video decoding support through libaom

Please don't top-post. On Fri, Aug 26, 2016 at 12:43:08AM +0800, Harfe Leier wrote: > Ah I see the following patch templatizing the sharing img<->pix fmt > conversion between vpx and aom. But it seems to be a problem here. "it"? What is the problem? Diego

Re: [libav-devel] [PATCH 5/6] Add AV1 video decoding support through libaom

Ah I see the following patch templatizing the sharing img<->pix fmt conversion between vpx and aom. But it seems to be a problem here. On 26 August 2016 at 00:10, Harfe Leier wrote: > Hi, > > I tested this patch with videos encoded by aomenc, and found that for > 10/12-bit

Re: [libav-devel] [PATCH 5/6] Add AV1 video decoding support through libaom

Hi, I tested this patch with videos encoded by aomenc, and found that for 10/12-bit av1 videos this patch decodes incorrectly. I found that ff_aom_imgfmt_to_pixfmt might not work as supposed for high bit depth. Like libvpx, avctx->pix_fmt should be set by both img->fmt and img->bit_depth. Also it

[libav-devel] [PATCH] Changelog: Mention mov with multiple stsd

--- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 0d04f47..2a012db 100644 --- a/Changelog +++ b/Changelog @@ -60,6 +60,7 @@ version : - MagicYUV decoder - Duck TrueMotion 2.0 Real Time decoder - Intel QSV video scaling and deinterlacing filter +-

[libav-devel] [PATCH 3/6] libvpx: Deduplicate priv_class declaration for VP8 and VP9

--- libavcodec/libvpxenc.c | 25 + 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index c6c9105..754a4c5 100644 --- a/libavcodec/libvpxenc.c +++ b/libavcodec/libvpxenc.c @@ -632,19 +632,19 @@ static const

[libav-devel] [PATCH 2/6] libvpx: Cast a pointer to const to squelch a warning

libavcodec/libvpxdec.c:100:57: warning: passing argument 3 of 'av_image_copy' from incompatible pointer type av_image_copy(picture->data, picture->linesize, img->planes, libavutil/imgutils.h:116:6: note: expected 'const uint8_t **' but argument is of type 'unsigned char **' void

[libav-devel] [PATCH 5/6] Add AV1 video decoding support through libaom

From: Luca Barbato Signed-off-by: Diego Biurrun --- some minor changes, version bump Changelog | 1 + configure | 4 ++ doc/general.texi | 10 libavcodec/Makefile| 2 + libavcodec/allcodecs.c | 1 +

[libav-devel] [PATCH 4/6] libvpx: Generalize name prefixes to no longer apply for VP8 only

--- libavcodec/libvpxdec.c | 28 ++-- libavcodec/libvpxenc.c | 40 2 files changed, 34 insertions(+), 34 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index 804875f..50f9660 100644 ---

[libav-devel] [PATCH 6/6] libaom: Templatize code shared with libvpx to avoid code duplication

--- Now templatizes the decoder along with the shared code. libavcodec/libaom.c | 57 +--- libavcodec/libaom.c_template.c | 111 +++ libavcodec/libaom.h | 12 +-- libavcodec/{libaom.h =>

[libav-devel] [PATCH 1/6] libvpx: Require at least version 1.5.0

This allows dropping some compatibility ifdefs, which will simplify sharing code with the libaom wrapper. --- Bumping the requirement up to 1.5.0 instead of 1.4.0. configure | 2 +- libavcodec/libvpx.c| 4 libavcodec/libvpxdec.c | 2 -- libavcodec/libvpxenc.c | 2 -- 4

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

On Thu, Aug 25, 2016 at 9:47 AM, Vittorio Giovara wrote: > On Thu, Aug 25, 2016 at 4:07 AM, Anton Khirnov wrote: >> Quoting Vittorio Giovara (2016-08-24 16:58:12) >>> also, does it have to be a separate function? If so, what does the old >>>

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

On Thu, Aug 25, 2016 at 4:07 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-08-24 16:58:12) >> also, does it have to be a separate function? If so, what does the old >> function do that the new one does not? > > The doxy says what the difference is -- mainly that

Re: [libav-devel] [PATCHv4] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On Wed, Aug 24, 2016 at 07:34:22AM -0500, Burt P wrote: > A new filter that provides HDCD decoding, using libhdcd. > https://github.com/bp0/libhdcd > > Requires ./configure --enable-libhdcd > > Signed-off-by: Burt P > --- > Changelog| 1 + > configure

Re: [libav-devel] [PATCH 4/5] libaom: Templatize code shared with libvpx to avoid code duplication

On Thu, Aug 25, 2016 at 03:16:19PM +0200, Luca Barbato wrote: > On 25/08/16 10:45, Diego Biurrun wrote: > > On Wed, Aug 24, 2016 at 08:01:52PM +0200, Luca Barbato wrote: > >> On 24/08/16 18:28, Diego Biurrun wrote: > >>> --- a/libavcodec/libvpxenc.c > >>> +++ b/libavcodec/libvpxenc.c > >>> @@

Re: [libav-devel] [PATCHv4] New filter af_hdcd: High Definition Compatible Digital (HDCD) decoder

On 24/08/16 14:34, Burt P wrote: > A new filter that provides HDCD decoding, using libhdcd. > https://github.com/bp0/libhdcd > > Requires ./configure --enable-libhdcd > > Signed-off-by: Burt P > --- > Changelog| 1 + > configure| 4 + >

Re: [libav-devel] [PATCH 4/5] libaom: Templatize code shared with libvpx to avoid code duplication

On 25/08/16 10:45, Diego Biurrun wrote: > On Wed, Aug 24, 2016 at 08:01:52PM +0200, Luca Barbato wrote: >> On 24/08/16 18:28, Diego Biurrun wrote: >>> --- a/libavcodec/libvpxenc.c >>> +++ b/libavcodec/libvpxenc.c >>> @@ -375,7 +375,7 @@ FF_ENABLE_DEPRECATION_WARNINGS >>> codecctl_int(avctx,

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

Quoting Diego Biurrun (2016-08-25 10:43:03) > On Thu, Aug 25, 2016 at 10:40:43AM +0200, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-08-25 10:36:31) > > > On Thu, Aug 25, 2016 at 10:07:03AM +0200, Anton Khirnov wrote: > > > > Quoting Vittorio Giovara (2016-08-24 16:58:12) > > > > > On Wed,

Re: [libav-devel] [PATCH 5/6] cavs: Change type of stride parameters to ptrdiff_t

On Wed, 24 Aug 2016, Diego Biurrun wrote: This avoids SIMD-optimized functions having to sign-extend their line size argument manually to be able to do pointer arithmetic. --- libavcodec/cavs.c| 18 libavcodec/cavs.h| 4 ++-- libavcodec/cavsdec.c | 2 +-

Re: [libav-devel] [PATCH 4/5] libaom: Templatize code shared with libvpx to avoid code duplication

On Wed, Aug 24, 2016 at 08:01:52PM +0200, Luca Barbato wrote: > On 24/08/16 18:28, Diego Biurrun wrote: > > --- a/libavcodec/libvpxenc.c > > +++ b/libavcodec/libvpxenc.c > > @@ -375,7 +375,7 @@ FF_ENABLE_DEPRECATION_WARNINGS > > codecctl_int(avctx, VP8E_SET_CQ_LEVEL, ctx->crf); > >

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

On Thu, Aug 25, 2016 at 10:40:43AM +0200, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-08-25 10:36:31) > > On Thu, Aug 25, 2016 at 10:07:03AM +0200, Anton Khirnov wrote: > > > Quoting Vittorio Giovara (2016-08-24 16:58:12) > > > > On Wed, Aug 24, 2016 at 6:06 AM, Diego Biurrun

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

Quoting Diego Biurrun (2016-08-25 10:36:31) > On Thu, Aug 25, 2016 at 10:07:03AM +0200, Anton Khirnov wrote: > > Quoting Vittorio Giovara (2016-08-24 16:58:12) > > > On Wed, Aug 24, 2016 at 6:06 AM, Diego Biurrun wrote: > > > > On Wed, Aug 24, 2016 at 11:24:01AM +0200, Anton

Re: [libav-devel] [PATCH] prores: Change type of stride parameters to ptrdiff_t

On Thu, 25 Aug 2016, Diego Biurrun wrote: This avoids SIMD-optimized functions having to sign-extend their line size argument manually to be able to do pointer arithmetic. Also adjust parameter names to be "linesize" everywhere. --- Log message updated. Ok with me // Martin

Re: [libav-devel] [PATCH] vp3: Change type of stride parameters to ptrdiff_t

On Thu, 25 Aug 2016, Diego Biurrun wrote: This avoids SIMD-optimized functions having to sign-extend their stride argument manually to be able to do pointer arithmetic. Also adjust parameter names to be "stride" everywhere. --- Log message updated. libavcodec/arm/vp3dsp_init_arm.c | 6

Re: [libav-devel] [PATCH] vp8: Update some assembly comments left unchanged in bd66f073fe7286bd3c

On Thu, 25 Aug 2016, Diego Biurrun wrote: --- Log message updated. libavcodec/arm/vp8dsp_armv6.S| 24 libavcodec/x86/vp8dsp.asm| 12 ++-- libavcodec/x86/vp8dsp_loopfilter.asm | 6 +++--- 3 files changed, 21 insertions(+), 21 deletions(-) Ok

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

On Thu, Aug 25, 2016 at 10:07:03AM +0200, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-08-24 16:58:12) > > On Wed, Aug 24, 2016 at 6:06 AM, Diego Biurrun wrote: > > > On Wed, Aug 24, 2016 at 11:24:01AM +0200, Anton Khirnov wrote: > > >> --- /dev/null > > >> +++

[libav-devel] [PATCH] vp3: Change type of stride parameters to ptrdiff_t

This avoids SIMD-optimized functions having to sign-extend their stride argument manually to be able to do pointer arithmetic. Also adjust parameter names to be "stride" everywhere. --- Log message updated. libavcodec/arm/vp3dsp_init_arm.c | 6 +++--- libavcodec/ppc/vp3dsp_altivec.c | 4

[libav-devel] [PATCH] prores: Change type of stride parameters to ptrdiff_t

This avoids SIMD-optimized functions having to sign-extend their line size argument manually to be able to do pointer arithmetic. Also adjust parameter names to be "linesize" everywhere. --- Log message updated. libavcodec/proresdsp.c | 6 +++--- libavcodec/proresdsp.h | 3

[libav-devel] [PATCH] vp8: Update some assembly comments left unchanged in bd66f073fe7286bd3c

--- Log message updated. libavcodec/arm/vp8dsp_armv6.S| 24 libavcodec/x86/vp8dsp.asm| 12 ++-- libavcodec/x86/vp8dsp_loopfilter.asm | 6 +++--- 3 files changed, 21 insertions(+), 21 deletions(-) diff --git a/libavcodec/arm/vp8dsp_armv6.S

Re: [libav-devel] [PATCH] Changelog: mark the release 12 branch

On Thu, 25 Aug 2016, Anton Khirnov wrote: --- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index 0d04f47..48537da 100644 --- a/Changelog +++ b/Changelog @@ -2,6 +2,9 @@ Entries are sorted chronologically from oldest to youngest within each release,

Re: [libav-devel] [RELEASE 12/PATCH 2/2] APIchanges: add the missing hash

On Thu, 25 Aug 2016, Anton Khirnov wrote: --- doc/APIchanges | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 1b65c4b..e8956e9 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,7 +13,7 @@ libavutil: 2015-08-28 API changes, most

Re: [libav-devel] [RELEASE 12/PATCH 1/2] Changelog: update for the release branch

On Thu, 25 Aug 2016, Anton Khirnov wrote: --- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 0d04f47..a6f2b21 100644 --- a/Changelog +++ b/Changelog @@ -1,7 +1,7 @@ Entries are sorted chronologically from oldest to youngest within each

Re: [libav-devel] [PATCH 1/3] imgutils: add a function for copying image data from GPU mapped memory

Quoting Vittorio Giovara (2016-08-24 16:58:12) > On Wed, Aug 24, 2016 at 6:06 AM, Diego Biurrun wrote: > > On Wed, Aug 24, 2016 at 11:24:01AM +0200, Anton Khirnov wrote: > >> --- /dev/null > >> +++ b/libavutil/x86/imgutils_init.c > >> @@ -0,0 +1,49 @@ > >> + > >> +void

[libav-devel] [RELEASE 12/PATCH 1/2] Changelog: update for the release branch

--- Changelog | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Changelog b/Changelog index 0d04f47..a6f2b21 100644 --- a/Changelog +++ b/Changelog @@ -1,7 +1,7 @@ Entries are sorted chronologically from oldest to youngest within each release, releases are sorted from youngest

[libav-devel] [RELEASE 12/PATCH 2/2] APIchanges: add the missing hash

--- doc/APIchanges | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 1b65c4b..e8956e9 100644 --- a/doc/APIchanges +++ b/doc/APIchanges @@ -13,7 +13,7 @@ libavutil: 2015-08-28 API changes, most recent first: -2016-07-20 - xxx -

[libav-devel] [PATCH] Changelog: mark the release 12 branch

--- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index 0d04f47..48537da 100644 --- a/Changelog +++ b/Changelog @@ -2,6 +2,9 @@ Entries are sorted chronologically from oldest to youngest within each release, releases are sorted from youngest to oldest.

Re: [libav-devel] [PATCH 1/6] vp3: Change type of stride parameters to ptrdiff_t

On Wed, Aug 24, 2016 at 09:45:13PM +0300, Martin Storsjö wrote: > On Wed, 24 Aug 2016, Diego Biurrun wrote: > > > On Wed, Aug 24, 2016 at 02:10:05PM +0300, Martin Storsjö wrote: > >> On Wed, 24 Aug 2016, Diego Biurrun wrote: > >> > --- a/libavcodec/arm/vp3dsp_init_arm.c > >> > +++