Re: [libav-devel] [PATCH 06/12] Change license of yadif from GPL to LGPL

2016-10-20 Thread Diego Biurrun
On Sun, Oct 16, 2016 at 08:10:56PM +0200, Janne Grunau wrote: > From: Robert Krüger > > Signed-off-by: Robert Krüger > Signed-off-by: Michael Niedermayer > Signed-off-by: Janne Grunau > --- >

Re: [libav-devel] [PATCH 03/12] fate: yadif: add >8 bit tests

2016-10-20 Thread Diego Biurrun
On Sun, Oct 16, 2016 at 08:10:53PM +0200, Janne Grunau wrote: > From: Christophe Gisquet > > Signed-off-by: Janne Grunau > --- > tests/fate/filter-video.mak | 6 ++ > tests/ref/fate/filter-yadif10 | 31 +++

Re: [libav-devel] [PATCH 02/12] yadif: x86 assembly for 9 to 14-bit samples

2016-10-20 Thread Diego Biurrun
On Sun, Oct 16, 2016 at 08:10:52PM +0200, Janne Grunau wrote: > --- > libavfilter/x86/vf_yadif_init.c | 21 ++- > libavfilter/x86/Makefile| 2 +- > libavfilter/x86/yadif-10.asm| 284 > > 3 files changed, 305 insertions(+), 2 deletions(-) >

Re: [libav-devel] [PATCH 01/12] yadif: x86 assembly for 16-bit samples

2016-10-20 Thread Diego Biurrun
On Sun, Oct 16, 2016 at 08:10:51PM +0200, Janne Grunau wrote: > --- a/libavfilter/vf_yadif.c > +++ b/libavfilter/vf_yadif.c > @@ -473,10 +473,10 @@ static int config_props(AVFilterLink *link) > } else { > s->filter_line = filter_line_c; > s->filter_edges = filter_edges; > +

Re: [libav-devel] [PATCH 21/24] examples/decode_video: remove a stray unrelated comment

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:39PM +0200, Anton Khirnov wrote: > --- a/doc/examples/decode_video.c > +++ b/doc/examples/decode_video.c > @@ -99,8 +99,6 @@ int main(int argc, char **argv) > exit(1); > } > > -/* the codec gives us the frame size, in samples */ > - > f =

Re: [libav-devel] [PATCH 20/24] examples/decode_video: constify the AVCodec instance

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:38PM +0200, Anton Khirnov wrote: > --- > doc/examples/decode_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM if it does not add any warnings. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 07/24] examples/avcodec: split audio decoding into a separate example

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:25PM +0200, Anton Khirnov wrote: > --- /dev/null > +++ b/doc/examples/decode_audio.c > @@ -0,0 +1,137 @@ > + > +#include > +#include > +#include nit: order LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 03/24] examples/avcodec: split audio encoding into a separate example

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:21PM +0200, Anton Khirnov wrote: > --- /dev/null > +++ b/doc/examples/encode_audio.c > @@ -0,0 +1,211 @@ > + > +#include > +#include > +#include nit: order LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 15/24] examples/encode_video: constify the AVCodec instance

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:33PM +0200, Anton Khirnov wrote: > --- > doc/examples/encode_video.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM if it does not add warnings. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 14/24] examples/avcodec: split the remaining two examples into separate files

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:32PM +0200, Anton Khirnov wrote: > --- a/doc/Makefile > +++ b/doc/Makefile > @@ -16,16 +16,17 @@ DOCS-$(CONFIG_POD2MAN) += > $(MANPAGES) $(PODPAGES) > > -ALL_DOC_EXAMPLES = avcodec decode_audio encode_audio filter_audio metadata \ > -

Re: [libav-devel] [PATCH 08/24] examples/decode_audio: constify the AVCodec instance

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:26PM +0200, Anton Khirnov wrote: > --- > doc/examples/decode_audio.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM if it adds no warnings. Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 24/24] examples/decode_video: allocate the packet dynamically

2016-10-20 Thread Luca Barbato
On 20/10/2016 16:07, Anton Khirnov wrote: > AVPackets on stack are discouraged. > --- > doc/examples/decode_video.c | 13 - > 1 file changed, 8 insertions(+), 5 deletions(-) > Looks fine ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 04/24] examples/encode_audio: constify AVCodec instances

2016-10-20 Thread Diego Biurrun
On Thu, Oct 20, 2016 at 04:07:22PM +0200, Anton Khirnov wrote: > --- > doc/examples/encode_audio.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 1/3] vaapi_h264: fix RefPicList[] field flags.

2016-10-20 Thread Anton Khirnov
Quoting Mark Thompson (2016-10-20 00:57:26) > From: Gwenole Beauchesne > > Use new H264Ref.reference field to track field picture flags. The > H264Picture.reference flag in DPB is now irrelevant here. > > This is a regression from git commit d8151a7, and that

[libav-devel] [PATCH 03/24] examples/avcodec: split audio encoding into a separate example

2016-10-20 Thread Anton Khirnov
The four examples (audio/video encoding/decoding) are completely independent so it makes little sense to have them all in one file. --- configure | 2 + doc/Makefile| 3 +- doc/examples/avcodec.c | 170 ---

[libav-devel] [PATCH 21/24] examples/decode_video: remove a stray unrelated comment

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_video.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index 40d838d..0c3eeff 100644 --- a/doc/examples/decode_video.c +++ b/doc/examples/decode_video.c @@ -99,8 +99,6 @@ int main(int argc, char **argv)

[libav-devel] [PATCH 22/24] examples/decode_video: use a parser for splitting the input

2016-10-20 Thread Anton Khirnov
Do not rely on the decoder handling this, as it's not guaranteed to work. --- doc/examples/decode_video.c | 113 ++-- 1 file changed, 56 insertions(+), 57 deletions(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index

[libav-devel] [PATCH 09/24] examples/decode_audio: use a parser for splitting the input

2016-10-20 Thread Anton Khirnov
Do not rely on the decoder handling this, as it's not guaranteed to work. --- doc/examples/decode_audio.c | 82 + 1 file changed, 54 insertions(+), 28 deletions(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index

[libav-devel] [PATCH 19/24] examples/encode_video: allocate the packet dynamically

2016-10-20 Thread Anton Khirnov
AVPackets on stack are discouraged. --- doc/examples/encode_video.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index fb863c5..6f5cd01 100644 --- a/doc/examples/encode_video.c +++

[libav-devel] [PATCH 07/24] examples/avcodec: split audio decoding into a separate example

2016-10-20 Thread Anton Khirnov
The four examples (audio/video encoding/decoding) are completely independent so it makes little sense to have them all in one file. --- configure | 2 + doc/Makefile| 4 +- doc/examples/avcodec.c | 97 ---

[libav-devel] [PATCH 23/24] examples/decode_video: switch to the new decoding API

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_video.c | 43 +++ 1 file changed, 23 insertions(+), 20 deletions(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index 7563049..7d7e4ba 100644 --- a/doc/examples/decode_video.c +++

[libav-devel] [PATCH 10/24] examples/decode_audio: use the new audio decoding API

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_audio.c | 34 -- 1 file changed, 20 insertions(+), 14 deletions(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index ca6075f..a9b9c0a 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@

[libav-devel] [PATCH 18/24] examples/encode_video: switch to the new encoding API

2016-10-20 Thread Anton Khirnov
--- doc/examples/encode_video.c | 59 - 1 file changed, 31 insertions(+), 28 deletions(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index b8c9631..fb863c5 100644 --- a/doc/examples/encode_video.c +++

[libav-devel] [PATCH 05/24] examples/encode_audio: use the AVFrame API for allocating the data

2016-10-20 Thread Anton Khirnov
It is simpler and more efficient. --- doc/examples/encode_audio.c | 28 +++- 1 file changed, 11 insertions(+), 17 deletions(-) diff --git a/doc/examples/encode_audio.c b/doc/examples/encode_audio.c index 42c3a6f..503c6ba 100644 --- a/doc/examples/encode_audio.c +++

[libav-devel] [PATCH 16/24] examples/encode_video: set the framerate

2016-10-20 Thread Anton Khirnov
--- doc/examples/encode_video.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index 72020e0..bd10d40 100644 --- a/doc/examples/encode_video.c +++ b/doc/examples/encode_video.c @@ -69,7 +69,9 @@ int main(int argc,

[libav-devel] [PATCH 02/24] examples/qsvdec: convert to the new decoding API

2016-10-20 Thread Anton Khirnov
--- doc/examples/qsvdec.c | 48 +--- 1 file changed, 25 insertions(+), 23 deletions(-) diff --git a/doc/examples/qsvdec.c b/doc/examples/qsvdec.c index 141c581..46e6ddc 100644 --- a/doc/examples/qsvdec.c +++ b/doc/examples/qsvdec.c @@ -92,41 +92,43 @@

[libav-devel] [PATCH 15/24] examples/encode_video: constify the AVCodec instance

2016-10-20 Thread Anton Khirnov
--- doc/examples/encode_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index 72599c8..72020e0 100644 --- a/doc/examples/encode_video.c +++ b/doc/examples/encode_video.c @@ -37,7 +37,7 @@ int main(int argc,

[libav-devel] [PATCH 06/24] examples/encode_audio: switch to the new audio encoding API

2016-10-20 Thread Anton Khirnov
--- doc/examples/encode_audio.c | 59 + 1 file changed, 43 insertions(+), 16 deletions(-) diff --git a/doc/examples/encode_audio.c b/doc/examples/encode_audio.c index 503c6ba..b493628 100644 --- a/doc/examples/encode_audio.c +++

[libav-devel] [PATCH 11/24] examples/decode_audio: handle planar audio now produced by the MP2 decoder

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_audio.c | 30 +- 1 file changed, 25 insertions(+), 5 deletions(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index a9b9c0a..982aadb 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -31,6

[libav-devel] [PATCH 17/24] examples/encode_video: use the AVFrame API for allocating the frame

2016-10-20 Thread Anton Khirnov
It is more efficient and so preferred over allocating the buffers manually. --- doc/examples/encode_video.c | 19 --- 1 file changed, 12 insertions(+), 7 deletions(-) diff --git a/doc/examples/encode_video.c b/doc/examples/encode_video.c index bd10d40..b8c9631 100644 ---

[libav-devel] [PATCH 01/24] examples/qsvdec: switch to the hwcontext API

2016-10-20 Thread Anton Khirnov
The code now does not depend on VA and will work on windows as well. --- configure | 2 +- doc/examples/qsvdec.c | 317 -- 2 files changed, 52 insertions(+), 267 deletions(-) diff --git a/configure b/configure index ac20cfa..3bf74cf

[libav-devel] [PATCH 14/24] examples/avcodec: split the remaining two examples into separate files

2016-10-20 Thread Anton Khirnov
--- configure | 6 +- doc/Makefile | 7 +- doc/examples/{avcodec.c => decode_video.c} | 174 +++-- doc/examples/encode_video.c| 164 +++ 4 files changed, 186

[libav-devel] [PATCH 08/24] examples/decode_audio: constify the AVCodec instance

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_audio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index 83b3bbd..25d40d9 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -39,7 +39,7 @@ int main(int argc,

[libav-devel] [PATCH 12/24] examples/decode_audio: allocate the packet dynamically

2016-10-20 Thread Anton Khirnov
AVPackets on stack are discouraged now. --- doc/examples/decode_audio.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index 982aadb..8164cfc 100644 --- a/doc/examples/decode_audio.c +++

[libav-devel] [PATCH 24/24] examples/decode_video: allocate the packet dynamically

2016-10-20 Thread Anton Khirnov
AVPackets on stack are discouraged. --- doc/examples/decode_video.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index 7d7e4ba..44271d3 100644 --- a/doc/examples/decode_video.c +++

[libav-devel] [PATCH 04/24] examples/encode_audio: constify AVCodec instances

2016-10-20 Thread Anton Khirnov
--- doc/examples/encode_audio.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/doc/examples/encode_audio.c b/doc/examples/encode_audio.c index 04a074f..42c3a6f 100644 --- a/doc/examples/encode_audio.c +++ b/doc/examples/encode_audio.c @@ -37,7 +37,7 @@ #include

[libav-devel] [PATCH 13/24] examples/decode_audio: flush the decoder

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_audio.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/doc/examples/decode_audio.c b/doc/examples/decode_audio.c index 8164cfc..454a8fe 100644 --- a/doc/examples/decode_audio.c +++ b/doc/examples/decode_audio.c @@ -178,6 +178,9 @@ int main(int argc, char **argv)

[libav-devel] [PATCH 20/24] examples/decode_video: constify the AVCodec instance

2016-10-20 Thread Anton Khirnov
--- doc/examples/decode_video.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/examples/decode_video.c b/doc/examples/decode_video.c index e840f76..40d838d 100644 --- a/doc/examples/decode_video.c +++ b/doc/examples/decode_video.c @@ -53,7 +53,7 @@ static void

Re: [libav-devel] [PATCH 3/3] vaapi_decode: Remove vestigial unmap code

2016-10-20 Thread Luca Barbato
On 20/10/2016 01:00, Mark Thompson wrote: > The buffer map/unmap code was in an early version of this before it > was committed, but the unmap was never removed. While wrong, this > was harmless (and therefore unnoticed) because the buffers can't be > mapped at this point - all drivers just did

Re: [libav-devel] [PATCH 2/3] vaapi_decode: Clear parameter buffers to fix picture reuse

2016-10-20 Thread Luca Barbato
On 20/10/2016 00:59, Mark Thompson wrote: > When decoding interlaced pictures, the structure is reused to render > to the same surface twice. The parameter buffers were not being > cleared, which caused the i965 driver to error out. > --- > This fixes the error Luca was seeing (unrelated to the

[libav-devel] [PATCH] hevcdsp: Consistent parameter names for add_residual()

2016-10-20 Thread Diego Biurrun
--- I think this could be squashed into the pending add_residual() optimization work. libavcodec/hevcdsp.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevcdsp.h b/libavcodec/hevcdsp.h index 199e5a9..49cb711 100644 --- a/libavcodec/hevcdsp.h +++

Re: [libav-devel] [PATCH 1/3] vaapi_h264: fix RefPicList[] field flags.

2016-10-20 Thread Mark Thompson
On 20/10/16 11:56, Diego Biurrun wrote: > On Wed, Oct 19, 2016 at 11:57:26PM +0100, Mark Thompson wrote: >> From: Gwenole Beauchesne >> >> Use new H264Ref.reference field to track field picture flags. The >> H264Picture.reference flag in DPB is now irrelevant here.

Re: [libav-devel] [PATCH 1/3] vaapi_h264: fix RefPicList[] field flags.

2016-10-20 Thread Diego Biurrun
On Wed, Oct 19, 2016 at 11:57:26PM +0100, Mark Thompson wrote: > From: Gwenole Beauchesne > > Use new H264Ref.reference field to track field picture flags. The > H264Picture.reference flag in DPB is now irrelevant here. > > This is a regression from git commit