Re: [libav-devel] [PATCH 2/2] aarch64: vp9: loop_filter: fix typo in skip flatout8 check

2016-11-13 Thread Martin Storsjö
On Mon, 14 Nov 2016, Janne Grunau wrote: The 16_16 loop filter functions could miss an early exit before flatout8. --- libavcodec/aarch64/vp9lpf_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/vp9lpf_neon.S b/libavcodec/aarch64/vp9lpf_neon.S index 3a8

Re: [libav-devel] [PATCH 1/3] lavfi: Work around warning in avfilter_get_by_name

2016-11-13 Thread Vittorio Giovara
On Sun, Nov 13, 2016 at 1:27 PM, Diego Biurrun wrote: > libavfilter/avfilter.c:295:20: warning: return discards ‘const’ qualifier > from pointer target type [-Wdiscarded-qualifiers] > --- > libavfilter/avfilter.c | 4 > 1 file changed, 4 insertions(+) > > diff --git a/libavfilter/avfilter.c

[libav-devel] [PATCH 2/2] aarch64: vp9: loop_filter: fix typo in skip flatout8 check

2016-11-13 Thread Janne Grunau
The 16_16 loop filter functions could miss an early exit before flatout8. --- libavcodec/aarch64/vp9lpf_neon.S | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/aarch64/vp9lpf_neon.S b/libavcodec/aarch64/vp9lpf_neon.S index 3a82bd4..392794b 100644 --- a/libavcodec/aarc

[libav-devel] [PATCH 1/2] aarch64: vp9: use alternative returns in the core loop filter function

2016-11-13 Thread Janne Grunau
Since aarch64 has enough free general purpose registers use them to branch to the appropiate storage code. 1-2 cycles faster for the functions using loop_filter 8/16, ... on a cortex-a53. Mixed results (up to 2 cycles faster/slower) on a cortex-a57. --- libavcodec/aarch64/vp9lpf_neon.S | 48 ++

Re: [libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-13 Thread Luca Barbato
On 13/11/2016 19:23, Andreas Cadhalpun wrote: > avc->channels can be 0. 0 and less than zero shouldn't be an error? lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH 2/2] libschroedingerdec: fix leaking of framewithpts

2016-11-13 Thread Andreas Cadhalpun
Signed-off-by: Andreas Cadhalpun --- libavcodec/libschroedingerdec.c | 26 +- 1 file changed, 17 insertions(+), 9 deletions(-) diff --git a/libavcodec/libschroedingerdec.c b/libavcodec/libschroedingerdec.c index 1e392b3..83c790c 100644 --- a/libavcodec/libschroedingerdec.

[libav-devel] [PATCH] arm: Error out if movrelx is invoked with bad register parameters

2016-11-13 Thread Martin Storsjö
Check these constraints even for non-pic-elf configurations, to catch the issues without having to build/test a pic-elf configuration to find out. --- This would have caught the issue in the vp9mc, without actually having to test a pic configuration. --- libavutil/arm/asm.S | 8 1 file ch

[libav-devel] [PATCH 1/2] libschroedingerdec: don't produce empty frames

2016-11-13 Thread Andreas Cadhalpun
They are not valid and can cause problems/crashes for API users. Signed-off-by: Andreas Cadhalpun --- libavcodec/libschroedingerdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libschroedingerdec.c b/libavcodec/libschroedingerdec.c index c9930c7..1e392b3 10064

[libav-devel] [PATCH] arm: vp9itxfm: Simplify the arm/thumb stack alignment code

2016-11-13 Thread Martin Storsjö
The subtraction directly on sp is one of the operations that are allowed in thumb mode. --- libavcodec/arm/vp9itxfm_neon.S | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/arm/vp9itxfm_neon.S b/libavcodec/arm/vp9itxfm_neon.S index cdb43b5..46fd010 100644 --- a/l

Re: [libav-devel] [PATCH 2/3] af_asyncts: Use llabs instead of labs for 64-bit variable

2016-11-13 Thread Janne Grunau
On 2016-11-13 19:27:32 +0100, Diego Biurrun wrote: > libavfilter/af_asyncts.c:212:9: warning: absolute value function 'labs' given > an argument of type 'int64_t' (aka 'long long') but has parameter of type > 'long' which may cause truncation of value [-Wabsolute-value] > --- > libavfilter/af_as

Re: [libav-devel] [PATCH] arm: vp9itxfm: Simplify txfm string comparisons

2016-11-13 Thread Janne Grunau
On 2016-11-13 00:36:56 +0200, Martin Storsjö wrote: > --- > This comes from the review of the aarch64 version. > --- > libavcodec/arm/vp9itxfm_neon.S | 45 > ++ > 1 file changed, 10 insertions(+), 35 deletions(-) > > diff --git a/libavcodec/arm/vp9itxfm_ne

Re: [libav-devel] [PATCH 3/3] Replace __PRETTY_FUNCTION__ by __func__

2016-11-13 Thread Janne Grunau
On 2016-11-13 19:27:33 +0100, Diego Biurrun wrote: the subject is a little unspecific. "golomb: replace __PRETTY_FUNCTION__ with __func__ for tracing" > The former is a GNU extension and for C both work the same at least > for gcc. __func__ is specified in C99/C++11 to this behavior. Since thi

Re: [libav-devel] [PATCH 2/2] aarch64: vp9: Implement NEON loop filters

2016-11-13 Thread Martin Storsjö
On Sun, 13 Nov 2016, Janne Grunau wrote: On 2016-11-11 21:43:09 +0200, Martin Storsjö wrote: This work is sponsored by, and copyright, Google. These are ported from the ARM version; thanks to the larger amount of registers available, we can do the loop filters with 16 pixels at a time. The imp

[libav-devel] [PATCH 1/3] lavfi: Work around warning in avfilter_get_by_name

2016-11-13 Thread Diego Biurrun
libavfilter/avfilter.c:295:20: warning: return discards ‘const’ qualifier from pointer target type [-Wdiscarded-qualifiers] --- libavfilter/avfilter.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 99531e5..9ddb648 100644 --- a/libavf

[libav-devel] [PATCH 3/3] Replace __PRETTY_FUNCTION__ by __func__

2016-11-13 Thread Diego Biurrun
The former is a GNU extension and for C both work the same at least for gcc. --- libavcodec/golomb.h | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/golomb.h b/libavcodec/golomb.h index bf80fae..9fafbcd 100644 --- a/libavcodec/golomb.h +++ b/libavcodec/golomb

[libav-devel] [PATCH 2/3] af_asyncts: Use llabs instead of labs for 64-bit variable

2016-11-13 Thread Diego Biurrun
libavfilter/af_asyncts.c:212:9: warning: absolute value function 'labs' given an argument of type 'int64_t' (aka 'long long') but has parameter of type 'long' which may cause truncation of value [-Wabsolute-value] --- libavfilter/af_asyncts.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[libav-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-11-13 Thread Andreas Cadhalpun
avc->channels can be 0. Signed-off-by: Andreas Cadhalpun --- libavcodec/libopusdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/libopusdec.c b/libavcodec/libopusdec.c index acc62f1..505ed57 100644 --- a/libavcodec/libopusdec.c +++ b/libavcodec/libopusdec.c @@

Re: [libav-devel] [PATCHv3] aarch64: vp9: Add NEON itxfm routines

2016-11-13 Thread Janne Grunau
On 2016-11-13 00:32:17 +0200, Martin Storsjö wrote: > This work is sponsored by, and copyright, Google. > > These are ported from the ARM version; thanks to the larger > amount of registers available, we can do the 16x16 and 32x32 > transforms in slices 8 pixels wide instead of 4. This gives > a s

Re: [libav-devel] [PATCH 2/2] aarch64: vp9: Implement NEON loop filters

2016-11-13 Thread Janne Grunau
On 2016-11-11 21:43:09 +0200, Martin Storsjö wrote: > This work is sponsored by, and copyright, Google. > > These are ported from the ARM version; thanks to the larger > amount of registers available, we can do the loop filters with > 16 pixels at a time. The implementation is fully templated, wit

Re: [libav-devel] [PATCH 5/8] qsv: Add VC-1 decoder

2016-11-13 Thread Anton Khirnov
Quoting Mark Thompson (2016-10-28 11:38:53) > It uses the same code as the MPEG-2 decoder, so the file is renamed > to contain all "other" (that is, not H.26[45]) codecs. > --- > The same patch regenerated with renames = copy, as suggested by Diego. > Looks trivial enough to be ok. -- Anton Khi

Re: [libav-devel] [PATCH 3/3] configure: Drop version information from library name in require() calls

2016-11-13 Thread Luca Barbato
On 11/11/2016 14:45, Diego Biurrun wrote: > The version is not checked for and multiple words in the name parameter > of require() calls can cause side effects down the call chain. > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > The *pkg_config checks do work. Th

Re: [libav-devel] [PATCH 3/3] configure: Drop version information from library name in require() calls

2016-11-13 Thread Arttu Ylä-Outinen
On 2016-11-12 00:30, Diego Biurrun wrote: On Fri, Nov 11, 2016 at 04:26:28PM +0100, Hendrik Leppkes wrote: On Fri, Nov 11, 2016 at 4:21 PM, Diego Biurrun wrote: On Fri, Nov 11, 2016 at 09:36:26AM -0500, Vittorio Giovara wrote: On Fri, Nov 11, 2016 at 8:45 AM, Diego Biurrun wrote: The versio

Re: [libav-devel] [PATCH 8/8] qsv_h265: Use hardware H.265 plugins by default

2016-11-13 Thread Hendrik Leppkes
On Sun, Nov 13, 2016 at 11:03 AM, Mark Thompson wrote: > Hardware support is now widespread for both decode (since Braswell) > and encode (since Skylake), so change to using the hardware codec > plugins by default. > --- > The previous version only changed the decoder, the encoder should be change

[libav-devel] [PATCH 8/8] qsv_h265: Use hardware H.265 plugins by default

2016-11-13 Thread Mark Thompson
Hardware support is now widespread for both decode (since Braswell) and encode (since Skylake), so change to using the hardware codec plugins by default. --- The previous version only changed the decoder, the encoder should be changed in the same way too. libavcodec/qsvdec_h2645.c | 2 +- libavc