Re: [libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-12-01 Thread Diego Biurrun
On Thu, Dec 01, 2016 at 09:59:20PM +0100, Alexandra Hájková wrote: > From: Alexandra Hajkova > > --- > libavcodec/hevcdsp.c | 2 + > libavcodec/hevcdsp.h | 1 + > libavcodec/ppc/Makefile | 1 + > libavcodec/ppc/hevcdsp.c

Re: [libav-devel] [PATCH] lavu: Document the color properties enumeration values origin

2016-12-01 Thread Nicolas George
Le primidi 11 frimaire, an CCXXV, Vittorio Giovara a écrit : > Subject: Re: [libav-devel] [PATCH] lavu: Document the color properties > enumeration values origin As I already said on ffmpeg-devel (the discussion is relevant here too), I think making this part of the API a bad decision. It makes

[libav-devel] [PATCH] hevc: Add HEVC IDCT 4x4 for PPC

2016-12-01 Thread Alexandra Hájková
From: Alexandra Hajkova --- libavcodec/hevcdsp.c | 2 + libavcodec/hevcdsp.h | 1 + libavcodec/ppc/Makefile | 1 + libavcodec/ppc/hevcdsp.c | 110 ++ libavcodec/ppc/hevcdsp_template.c |

[libav-devel] [PATCH] avutil/tests: Add the cpu_init.c test

2016-12-01 Thread Wan-Teh Chang
cpu_init.c checks whether the one-time initialization in av_get_cpu_flags() has data races. When running under ThreadSanitizer, this test program demonstrates the current av_get_cpu_flags() code has data races: ./configure --toolchain=clang-tsan make libavutil/tests/cpu_init

[libav-devel] [PATCH] configure: Pass extralibs through ldflags_filter to fix Windows build

2016-12-01 Thread Diego Biurrun
--- This makes MSVC happy. Not sending squashed to avoid spam with large patches. configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index cfd19d5..6b512c0 100755 --- a/configure +++ b/configure @@ -5197,7 +5197,7 @@ for linkunit in $LIBRARY_LIST

[libav-devel] [PATCH] lavu: Document the color properties enumeration values origin

2016-12-01 Thread Vittorio Giovara
--- libavutil/pixfmt.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/pixfmt.h b/libavutil/pixfmt.h index 2a0c85e..41498cc 100644 --- a/libavutil/pixfmt.h +++ b/libavutil/pixfmt.h @@ -313,6 +313,7 @@ enum AVPixelFormat { /** * Chromaticity coordinates of the source

Re: [libav-devel] [PATCH 10/13] build: Drop support for configuring library name suffixes

2016-12-01 Thread Luca Barbato
On 01/12/2016 19:54, Diego Biurrun wrote: > On Thu, Dec 01, 2016 at 07:11:09PM +0100, Luca Barbato wrote: >> On 29/11/2016 19:34, Diego Biurrun wrote: >>> It is of doubtful utility, adds complexity and no known users exist. >>> --- >>> common.mak | 3 +-- >>> configure | 34

Re: [libav-devel] [PATCH] avutil/tests: Add the cpu_init.c test

2016-12-01 Thread James Almer
On 12/1/2016 3:47 PM, Diego Biurrun wrote: > On Thu, Dec 01, 2016 at 10:22:24AM -0800, Wan-Teh Chang wrote: >> --- /dev/null >> +++ b/libavutil/tests/cpu_init.c >> @@ -0,0 +1,72 @@ >> +int main(int argc, char **argv) > > argc and argv are unused. > >> +{ >> +#if HAVE_PTHREADS >> +int

Re: [libav-devel] [PATCH 11/13] Remove Plan 9 support

2016-12-01 Thread Diego Biurrun
On Tue, Nov 29, 2016 at 03:30:18PM -0500, Vittorio Giovara wrote: > On Tue, Nov 29, 2016 at 1:34 PM, Diego Biurrun wrote: > > Supporting the system was a nice joke for the 9 release, but it has > > run its course. Nowadays Plan 9 receives no testing and has no > > practical

Re: [libav-devel] [PATCH 10/13] build: Drop support for configuring library name suffixes

2016-12-01 Thread Diego Biurrun
On Thu, Dec 01, 2016 at 07:11:09PM +0100, Luca Barbato wrote: > On 29/11/2016 19:34, Diego Biurrun wrote: > > It is of doubtful utility, adds complexity and no known users exist. > > --- > > common.mak | 3 +-- > > configure | 34 +- > > library.mak | 2 +- > >

Re: [libav-devel] [PATCH 09/13] build: Drop support for old versions of libdc1394

2016-12-01 Thread Diego Biurrun
On Thu, Dec 01, 2016 at 01:12:45PM +0100, Diego Biurrun wrote: > On Thu, Dec 01, 2016 at 01:05:18PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-11-30 21:49:26) > > > On Tue, Nov 29, 2016 at 03:29:17PM -0500, Vittorio Giovara wrote: > > > > On Tue, Nov 29, 2016 at 1:34 PM, Diego

Re: [libav-devel] [PATCH] avutil/tests: Add the cpu_init.c test

2016-12-01 Thread Diego Biurrun
On Thu, Dec 01, 2016 at 10:22:24AM -0800, Wan-Teh Chang wrote: > --- /dev/null > +++ b/libavutil/tests/cpu_init.c > @@ -0,0 +1,72 @@ > +int main(int argc, char **argv) argc and argv are unused. > +{ > +#if HAVE_PTHREADS > +int cpu_flags1; > +int cpu_flags2; > +int ret; > +

[libav-devel] [PATCH] avutil/tests: Add the cpu_init.c test

2016-12-01 Thread Wan-Teh Chang
cpu_init.c checks whether the one-time initialization in av_get_cpu_flags() has data races. When running under ThreadSanitizer, this test program demonstrates the current av_get_cpu_flags() code has data races: ./configure --toolchain=clang-tsan make libavutil/tests/cpu_init

Re: [libav-devel] [PATCH 08/13] configure: Drop bogus xcb_event variables

2016-12-01 Thread Luca Barbato
On 29/11/2016 19:34, Diego Biurrun wrote: > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 72ea4e0..808e860 100755 > --- a/configure > +++ b/configure > @@ -4797,8 +4797,8 @@ if enabled libxcb; then >

Re: [libav-devel] [PATCH 10/13] build: Drop support for configuring library name suffixes

2016-12-01 Thread Luca Barbato
On 29/11/2016 19:34, Diego Biurrun wrote: > It is of doubtful utility, adds complexity and no known users exist. > --- > common.mak | 3 +-- > configure | 34 +- > library.mak | 2 +- > 3 files changed, 15 insertions(+), 24 deletions(-) > I'm not against.

Re: [libav-devel] [PATCH] mmaldec: initialize refcount using atomic_init().

2016-12-01 Thread Luca Barbato
On 30/11/2016 20:52, Wan-Teh Chang wrote: > This is how we initialize refcount in libavutil/buffer.c. > > Signed-off-by: Wan-Teh Chang > --- > libavcodec/mmaldec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/mmaldec.c

[libav-devel] [PATCH 1/2] avprobe: Allow specifying multiple stream entries to be shown

2016-12-01 Thread Vittorio Giovara
--- Needed so that we can run the test in the following patch only once. Vittorio avprobe.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/avprobe.c b/avprobe.c index 8142ce2..f0c942a 100644 --- a/avprobe.c +++ b/avprobe.c @@ -1033,6 +1033,8 @@ static int

[libav-devel] [PATCH 2/2] fate: Add spherical and stereo3d mov tests

2016-12-01 Thread Vittorio Giovara
--- Updated to the new avprobe -show_stream_entry syntax. Vittorio tests/fate/mov.mak | 6 ++ tests/ref/fate/mov-spherical | 4 tests/ref/fate/mov-stereo3d | 1 + 3 files changed, 11 insertions(+) create mode 100644 tests/ref/fate/mov-spherical create mode 100644

Re: [libav-devel] [PATCH] build: Fine-grained link-time dependency settings

2016-12-01 Thread Luca Barbato
On 01/12/2016 15:39, Diego Biurrun wrote: > - Possibly I should still investigate Janne's idea of using the > function name as variable name instead of adding a library name > parameter to things like check_lib(). That could require extra care in picking the function.

[libav-devel] [PATCH] build: Fine-grained link-time dependency settings

2016-12-01 Thread Diego Biurrun
Previously, all link-time dependencies were added for all libraries, resulting in bogus link-time dependencies since not all dependencies are shared across libraries. Also, in some cases like libavutil, not all dependencies were taken into account, resulting in some cases of underlinking. To

Re: [libav-devel] [PATCH 1/2] build: Add -Wpedantic and -Wextra to extra warning flags

2016-12-01 Thread Luca Barbato
On 01/12/2016 08:38, Diego Biurrun wrote: > Also drop -Winline from set of warning flags as it only produces noise. > --- > configure | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/configure b/configure > index 71141c2..f2f96e5 100755 > --- a/configure > +++

[libav-devel] [PATCH] configure: Simplify and fix avfoundation indev handling

2016-12-01 Thread Diego Biurrun
Handle extralibs in the standard way, add missing pthreads dependency. Also globally check for -fobj-arc with Objective-C compilers since that option is useful for other Objective-C code as well. --- Needs some testing on OS X. configure | 10 +- 1 file changed, 5 insertions(+), 5

Re: [libav-devel] [PATCH 09/13] build: Drop support for old versions of libdc1394

2016-12-01 Thread Diego Biurrun
On Thu, Dec 01, 2016 at 01:05:18PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-11-30 21:49:26) > > On Tue, Nov 29, 2016 at 03:29:17PM -0500, Vittorio Giovara wrote: > > > On Tue, Nov 29, 2016 at 1:34 PM, Diego Biurrun wrote: > > > > --- a/libavdevice/libdc1394.c >

Re: [libav-devel] [PATCH 09/13] build: Drop support for old versions of libdc1394

2016-12-01 Thread Anton Khirnov
Quoting Diego Biurrun (2016-11-30 21:49:26) > On Tue, Nov 29, 2016 at 03:29:17PM -0500, Vittorio Giovara wrote: > > On Tue, Nov 29, 2016 at 1:34 PM, Diego Biurrun wrote: > > > --- a/libavdevice/libdc1394.c > > > +++ b/libavdevice/libdc1394.c > > > @@ -104,9 +79,6 @@ struct

Re: [libav-devel] [PATCH 07/13] configure: Add -lm to libxavs linker flags

2016-12-01 Thread Diego Biurrun
On Tue, Nov 29, 2016 at 07:34:07PM +0100, Diego Biurrun wrote: > --- > > Yes, libxavs has a broken pkg-config file, in case you wondered.. > > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) I'm dropping this patch. You can actually build a shared library of libxavs and avoid

[libav-devel] [PATCH 2/5] arm: vp9itxfm: Do separate functions for half/quarter idct16 and idct32 (alternative 2)

2016-12-01 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This makes it easier to avoid filling the temp buffer with zeros for the skipped slices, and leads to slightly more straightforward code for these cases (for the 16x16 case, where the special case pass functions are written out instead of

[libav-devel] [PATCH 3/5] aarch64: vp9itxfm: Make the larger core transforms standalone functions

2016-12-01 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This reduces the code size of libavcodec/aarch64/vp9itxfm_neon.o from 19496 to 14740 bytes. This gives a small slowdown of a couple of tens of cycles, but makes it more feasible to add more optimized versions of these transforms. Before:

[libav-devel] [PATCH 5/5] aarch64: vp9itxfm: Do separate functions for half/quarter idct16 and idct32 (alternative 2)

2016-12-01 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This makes it easier to avoid filling the temp buffer with zeros for the skipped slices, and leads to slightly more straightforward code for these cases (for the 16x16 case, where the special case pass functions are written out instead of

[libav-devel] [PATCH 1/5] arm: vp9itxfm: Make the larger core transforms standalone functions

2016-12-01 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This reduces the code size of libavcodec/arm/vp9itxfm_neon.o from 15324 to 12388 bytes. This gives a small slowdown of a couple tens of cycles, up to around 150 cycles for the full case of the largest transform, but makes it more feasible to add

[libav-devel] [PATCH 5/5] aarch64: vp9itxfm: Do a simpler half/quarter idct16/idct32 when possible (alternative 1)

2016-12-01 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This increases the code size of libavcodec/aarch64/vp9itxfm_neon.o from 14740 to 18504 bytes. Before: vp9_inv_dct_dct_16x16_sub1_add_neon: 235.3 vp9_inv_dct_dct_16x16_sub2_add_neon:1051.0 vp9_inv_dct_dct_16x16_sub4_add_neon:1051.0

[libav-devel] [PATCH 2/5] arm: vp9itxfm: Do a simpler half/quarter idct16/idct32 when possible (alternative 1)

2016-12-01 Thread Martin Storsjö
This work is sponsored by, and copyright, Google. This increases the code size of libavcodec/arm/vp9itxfm_neon.o from 12388 to 15064 bytes. Before: Cortex A7 A8 A9 A53 vp9_inv_dct_dct_16x16_sub1_add_neon: 273.0189.7211.9235.8

[libav-devel] [PATCH 4/5] aarch64: vp9itxfm: Restructure the idct32 store macros

2016-12-01 Thread Martin Storsjö
This avoids concatenation, which can't be used if the whole macro is wrapped within another macro. --- libavcodec/aarch64/vp9itxfm_neon.S | 80 +++--- 1 file changed, 40 insertions(+), 40 deletions(-) diff --git a/libavcodec/aarch64/vp9itxfm_neon.S