Re: [libav-devel] [PATCH] compat/atomics: add typecasts in atomic_compare_exchange_strong()

2016-12-07 Thread Sean McGovern
Hi, On Wed, Dec 7, 2016 at 8:37 PM, Luca Barbato wrote: > On 03/12/2016 01:56, Wan-Teh Chang wrote: >> The Solaris and Windows emulations of atomic_compare_exchange_strong() >> need typecasts to avoid compiler warnings, because the functions they >> call expect a void* pointer but an intptr_t int

Re: [libav-devel] [PATCH] pthread_frame: use better memory orders for frame progress

2016-12-07 Thread Luca Barbato
On 30/11/2016 23:13, Wan-Teh Chang wrote: > This patch is intended to avoid confusion when one inspects the source code. > > ff_thread_report_progress() and ff_thread_await_progress() form a > pair. ff_thread_await_progress() reads progress[field] with the > "acquire" memory order (in the fast cod

Re: [libav-devel] [PATCH] compat/atomics: add typecasts in atomic_compare_exchange_strong()

2016-12-07 Thread Luca Barbato
On 03/12/2016 01:56, Wan-Teh Chang wrote: > The Solaris and Windows emulations of atomic_compare_exchange_strong() > need typecasts to avoid compiler warnings, because the functions they > call expect a void* pointer but an intptr_t integer is passed. > > Note that the emulations of atomic_compare

Re: [libav-devel] [PATCH] avutil: fix data race in av_get_cpu_flags()

2016-12-07 Thread Luca Barbato
On 08/12/2016 01:16, Wan-Teh Chang wrote: > Make the one-time initialization in av_get_cpu_flags() thread-safe. The > static variables |flags|, |cpuflags_mask|, and |checked| in > libavutil/cpu.c are read and written using normal load and store > operations. These are considered as data races. The

[libav-devel] [PATCH] avutil: fix data race in av_get_cpu_flags()

2016-12-07 Thread Wan-Teh Chang
Make the one-time initialization in av_get_cpu_flags() thread-safe. The static variables |flags|, |cpuflags_mask|, and |checked| in libavutil/cpu.c are read and written using normal load and store operations. These are considered as data races. The fix is to use atomic load and store operations. R

Re: [libav-devel] [PATCH] Remove deprecated XvMC support hacks

2016-12-07 Thread Diego Biurrun
On Wed, Dec 07, 2016 at 04:14:10PM -0500, Vittorio Giovara wrote: > On Wed, Dec 7, 2016 at 2:18 AM, Diego Biurrun wrote: > > Deprecated in 11/2013. > > --- > > > > These are not the droids you are looking for. > > > > configure | 3 - > > libavcodec/4xm.c | 2

Re: [libav-devel] [FFmpeg-devel] [PATCH] libopusdec: fix out-of-bounds read

2016-12-07 Thread Luca Barbato
On 24/11/2016 01:06, Andreas Cadhalpun wrote: Seems ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] APIChanges: Mention where release 12 was cut

2016-12-07 Thread Luca Barbato
On 05/12/2016 23:45, Vittorio Giovara wrote: > Signed-off-by: Vittorio Giovara > --- > doc/APIchanges | 4 > 1 file changed, 4 insertions(+) Sure ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-d

Re: [libav-devel] [PATCH] Remove deprecated XvMC support hacks

2016-12-07 Thread Vittorio Giovara
On Wed, Dec 7, 2016 at 2:18 AM, Diego Biurrun wrote: > Deprecated in 11/2013. > --- > > These are not the droids you are looking for. > > configure | 3 - > libavcodec/4xm.c | 2 +- > libavcodec/Makefile | 3 - > libavcodec/allcodecs.c| 3

Re: [libav-devel] [PATCH] configure: Fail if cuda was enabled and is not available

2016-12-07 Thread Luca Barbato
On 07/12/2016 19:44, Diego Biurrun wrote: > This is the standard behavior for external libraries. > --- > configure | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/configure b/configure > index 78cf546..d85b3f8 100755 > --- a/configure > +++ b/configure > @@ -4616,7 +4616

Re: [libav-devel] [PATCH 01/41] Bump major versions of all libraries

2016-12-07 Thread Vittorio Giovara
On Tue, Dec 6, 2016 at 5:15 PM, Diego Biurrun wrote: > On Tue, Dec 06, 2016 at 04:23:09PM -0500, Vittorio Giovara wrote: >> On Tue, Dec 6, 2016 at 2:43 AM, Diego Biurrun wrote: >> > On Tue, Dec 06, 2016 at 12:27:22AM -0500, Vittorio Giovara wrote: >> >> --- a/libavdevice/version.h >> >> +++ b/lib

Re: [libav-devel] [PATCH 2/2] build: Drop stray golomb dependencies

2016-12-07 Thread Vittorio Giovara
On Wed, Dec 7, 2016 at 12:18 PM, Diego Biurrun wrote: > --- > configure | 11 --- > 1 file changed, 4 insertions(+), 7 deletions(-) set should be ok -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman

[libav-devel] [PATCH] configure: Fail if cuda was enabled and is not available

2016-12-07 Thread Diego Biurrun
This is the standard behavior for external libraries. --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index 78cf546..d85b3f8 100755 --- a/configure +++ b/configure @@ -4616,7 +4616,7 @@ done # these are off by default, so fail if requested a

[libav-devel] [PATCH 2/2] build: Drop stray golomb dependencies

2016-12-07 Thread Diego Biurrun
--- configure | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 7f48ba9..78cf546 100755 --- a/configure +++ b/configure @@ -1971,13 +1971,13 @@ eamad_decoder_select="aandcttables blockdsp bswapdsp idctdsp mpegvideo" eatgq_decoder_select="

[libav-devel] [PATCH 1/2] build: Add an internal component for hevc_ps code

2016-12-07 Thread Diego Biurrun
This allows expressing dependencies in a more correct way. --- This is a cleaner way of fixing the QSV HEVC encoder link failure. configure | 10 ++ libavcodec/Makefile | 7 --- 2 files changed, 10 insertions(+), 7 deletions(-) diff --git a/configure b/configure index 5b9

Re: [libav-devel] [PATCH] build: Ensure that the "all" target appears before all Makefile includes

2016-12-07 Thread Luca Barbato
On 07/12/2016 15:43, Diego Biurrun wrote: > Otherwise builds without explicit target result in silent no-ops. > --- > > Next round of $cold_beverage at FOSDEM is on me I guess .. > Ok. ___ libav-devel mailing list libav-devel@libav.org https://lists.l

[libav-devel] [PATCH] build: Ensure that the "all" target appears before all Makefile includes

2016-12-07 Thread Diego Biurrun
Otherwise builds without explicit target result in silent no-ops. --- Next round of $cold_beverage at FOSDEM is on me I guess .. Makefile | 3 +++ common.mak | 3 --- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Makefile b/Makefile index b090007..ec04d19 100644 --- a/Makefile

Re: [libav-devel] [libav-commits] build: Move entries related to building TOOLS to a subdirectory Makefile

2016-12-07 Thread Diego Biurrun
On Wed, Dec 07, 2016 at 04:06:50PM +0200, Martin Storsjö wrote: > On Wed, 7 Dec 2016, Diego Biurrun wrote: > > >Module: libav > >Branch: master > >Commit: 3e105d08848162b90d886bde59c010d4b0362a4b > > > >Author:Diego Biurrun > >Committer: Diego Biurrun > >Date: Mon Dec 5 18:38:53 2016

Re: [libav-devel] [libav-commits] build: Move entries related to building TOOLS to a subdirectory Makefile

2016-12-07 Thread Martin Storsjö
On Wed, 7 Dec 2016, Diego Biurrun wrote: Module: libav Branch: master Commit: 3e105d08848162b90d886bde59c010d4b0362a4b Author:Diego Biurrun Committer: Diego Biurrun Date: Mon Dec 5 18:38:53 2016 +0100 build: Move entries related to building TOOLS to a subdirectory Makefile --- M

Re: [libav-devel] [PATCH] build: Add missing Makefile entries and ifdefs for QSV hwaccels

2016-12-07 Thread Diego Biurrun
On Wed, Dec 07, 2016 at 12:51:27PM +0100, Diego Biurrun wrote: > On Wed, Dec 07, 2016 at 12:11:22PM +0100, Luca Barbato wrote: > > On 03/12/2016 16:59, Diego Biurrun wrote: > > > --- > > > > > > Now the actually working version ... > > > > > > libavcodec/Makefile | 5 + > > > libavcode

Re: [libav-devel] [PATCH] build: Add missing Makefile entries and ifdefs for QSV hwaccels

2016-12-07 Thread Diego Biurrun
On Wed, Dec 07, 2016 at 12:11:22PM +0100, Luca Barbato wrote: > On 03/12/2016 16:59, Diego Biurrun wrote: > > --- > > > > Now the actually working version ... > > > > libavcodec/Makefile | 5 + > > libavcodec/qsvdec_h2645.c | 8 ++-- > > 2 files changed, 11 insertions(+), 2 deletio

Re: [libav-devel] [PATCH 3/3] pthread_frame: do not run hwaccel decoding asynchronously unless it's safe

2016-12-07 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-06 23:20:45) > On Sat, Dec 03, 2016 at 05:34:34PM +0100, Anton Khirnov wrote: > > --- /dev/null > > +++ b/libavcodec/hwaccel.h > > @@ -0,0 +1,24 @@ > > +#ifndef AVCODEC_HWACCEL_H > > +#define AVCODEC_HWACCEL_H > > + > > +#define HWACCEL_CAP_ASYNC_SAFE (1 << 0) >

Re: [libav-devel] [PATCH] build: Add missing Makefile entries and ifdefs for QSV hwaccels

2016-12-07 Thread Luca Barbato
On 03/12/2016 16:59, Diego Biurrun wrote: > --- > > Now the actually working version ... > > libavcodec/Makefile | 5 + > libavcodec/qsvdec_h2645.c | 8 ++-- > 2 files changed, 11 insertions(+), 2 deletions(-) > The qsv hwaccel and decoder should be always enabled at the same tim

Re: [libav-devel] [PATCH] build: Have old H.264/HEVC nvenc encoders select their new counterparts

2016-12-07 Thread Diego Biurrun
On Sat, Dec 03, 2016 at 03:40:26PM +0100, Diego Biurrun wrote: > This makes sense and takes care of missing build dependencies. > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) OKed by Luca on IRC. Diego ___ libav-devel mai