Re: [libav-devel] [PATCH 1/5] avconv: dxva2: factorize some code that can be common with d3d11va

2016-12-15 Thread James Almer
On 12/15/2016 2:52 PM, Diego Biurrun wrote: > On Thu, Dec 15, 2016 at 06:01:42PM +0100, Steve Lhomme wrote: >> From: Steve Lhomme >> >> avconv_dxva.h has to be included and misc. typedefs have to be set to use the >> proper DXVA2 structures. >> >> initguid.h is included in avconv_dxva.h so any inc

[libav-devel] [PATCH] dump: be more verbose when printing spherical metadata information

2016-12-15 Thread James Almer
Signed-off-by: James Almer --- This prints spherical: equirectangular, yaw=0.00, pitch=0.00, roll=0.00 Instead of spherical: equirectangular (0.00/0.00/0.00) libavformat/dump.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/dump.c

[libav-devel] [PATCH] avconv: Do not pass NULL to avio_tell

2016-12-15 Thread Luca Barbato
The null demuxer does not have a backing AVIOContext. --- avconv.c | 23 --- 1 file changed, 12 insertions(+), 11 deletions(-) diff --git a/avconv.c b/avconv.c index 5c31332..fe60625 100644 --- a/avconv.c +++ b/avconv.c @@ -909,7 +909,7 @@ static void print_report(int is_last_

[libav-devel] [PATCH 1/3] configure: Disentangle vfw32 and user32 lib handling

2016-12-15 Thread Diego Biurrun
Check for and link against user32 instead, which also fixes the missing dependency of dxva2 on user32 with MSVC. --- configure | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/configure b/configure index fb82fc4..5151c94 100755 --- a/configure +++ b/configure @@ -2387,7 +23

Re: [libav-devel] [PATCH 1/5] avconv: dxva2: factorize some code that can be common with d3d11va

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 06:01:42PM +0100, Steve Lhomme wrote: > From: Steve Lhomme > > avconv_dxva.h has to be included and misc. typedefs have to be set to use the > proper DXVA2 structures. > > initguid.h is included in avconv_dxva.h so any includes after that will also > define GUIDs locally.

Re: [libav-devel] [PATCH 1/2] configure: put d3d11 check in alphabetical order

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 06:00:55PM +0100, Steve Lhomme wrote: > From: Steve Lhomme > > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/m

Re: [libav-devel] [PATCH 2/2] configure: fix linking with MSVC when using --disable-optimizations

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 06:00:56PM +0100, Steve Lhomme wrote: > From: Steve Lhomme > > Without any optimization flags, MSVC does no dead code elimination (DCE) at > all, even for the most trivial cases. DCE is a prerequisite for building libav > correctly, otherwise there are undefined references

[libav-devel] [PATCH 2/5] libautil: add support for AV_HWDEVICE_TYPE_D3D11VA

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme --- libavutil/Makefile | 3 + libavutil/hwcontext.c | 3 + libavutil/hwcontext.h | 1 + libavutil/hwcontext_d3d11va.c | 456 + libavutil/hwcontext_d3d11va.h | 81 libavutil/hwcontext_intern

[libav-devel] [PATCH 4/5] avconv_dxva2: remove unused initial values

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme --- avconv_dxva2.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/avconv_dxva2.c b/avconv_dxva2.c index 6a56f3a..027285a 100644 --- a/avconv_dxva2.c +++ b/avconv_dxva2.c @@ -124,8 +124,8 @@ static int dxva2_get_decoder_configuration(AVCodecCon

[libav-devel] [PATCH 5/5] avconv: use the typedefs more to make comparison between dxva2 and d3d11va

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme --- avconv_d3d11va.c | 24 +--- avconv_dxva2.c | 22 +++--- 2 files changed, 24 insertions(+), 22 deletions(-) diff --git a/avconv_d3d11va.c b/avconv_d3d11va.c index 4799017..ca7f2e8 100644 --- a/avconv_d3d11va.c +++ b/avconv_d3d11va.c @@

[libav-devel] [PATCH 3/5] avconv: add avconv_d3d11va

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme The code is similar to avconv_dxva2. The decoded output needs to be copied into a staging texture that can be accessed by the CPU as the decoder texture can't be accessed by the CPU. --- Changelog| 1 + Makefile | 1 + avconv.h | 2 + avconv_d3d11

[libav-devel] [PATCH 1/5] avconv: dxva2: factorize some code that can be common with d3d11va

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme avconv_dxva.h has to be included and misc. typedefs have to be set to use the proper DXVA2 structures. initguid.h is included in avconv_dxva.h so any includes after that will also define GUIDs locally. --- avconv_dxva.h | 294 +

[libav-devel] [PATCH 1/2] configure: put d3d11 check in alphabetical order

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme --- configure | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index fb82fc4..25640eb 100755 --- a/configure +++ b/configure @@ -1514,6 +1514,7 @@ HEADERS_LIST=" arpa_inet_h cdio_paranoia_h cdio_paranoia_paranoia_h +

[libav-devel] [PATCH 2/2] configure: fix linking with MSVC when using --disable-optimizations

2016-12-15 Thread Steve Lhomme
From: Steve Lhomme Without any optimization flags, MSVC does no dead code elimination (DCE) at all, even for the most trivial cases. DCE is a prerequisite for building libav correctly, otherwise there are undefined references to functions for other architectures and disabled components. -O1 is t

Re: [libav-devel] [PATCH] rtmppkt: Check for packet size mismatches

2016-12-15 Thread Luca Barbato
On 15/12/2016 14:22, Martin Storsjö wrote: > From: Michael Niedermayer > > When receiving fragmented packets, the first packet declares the size, > and the later ones normally are small follow-on packets that don't repeat > the size and the other header fields. But technically, the later fragment

[libav-devel] [PATCH] rtmppkt: Check for packet size mismatches

2016-12-15 Thread Martin Storsjö
From: Michael Niedermayer When receiving fragmented packets, the first packet declares the size, and the later ones normally are small follow-on packets that don't repeat the size and the other header fields. But technically, the later fragments also can have a full header, declaring a different

Re: [libav-devel] [PATCH] rtmppkt: Check for packet size mismatches

2016-12-15 Thread Luca Barbato
On 15/12/2016 13:53, Martin Storsjö wrote: > I guess we can and should return an error here directly as well. I agree =) lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtmppkt: Check for packet size mismatches

2016-12-15 Thread Martin Storsjö
On Thu, 15 Dec 2016, Luca Barbato wrote: On 15/12/2016 09:12, Martin Storsjö wrote: From: Michael Niedermayer Fixes out of array access. Found-by: Paul Cher Reviewed-by: Paul Cher CC: libav-sta...@libav.org --- libavformat/rtmppkt.c | 7 +++ 1 file changed, 7 insertions(+) diff --gi

Re: [libav-devel] [PATCH 1/2] Changelog: add some missing entries

2016-12-15 Thread Mark Thompson
On 15/12/16 09:32, Anton Khirnov wrote: > --- > Changelog | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Changelog b/Changelog > index feb151c..ab7f1b6 100644 > --- a/Changelog > +++ b/Changelog > @@ -3,6 +3,9 @@ releases are sorted from youngest to oldest. > > version : > - Supp

Re: [libav-devel] [PATCH] rtmppkt: Check for packet size mismatches

2016-12-15 Thread Luca Barbato
On 15/12/2016 09:12, Martin Storsjö wrote: > From: Michael Niedermayer > > Fixes out of array access. > > Found-by: Paul Cher > Reviewed-by: Paul Cher > > CC: libav-sta...@libav.org > --- > libavformat/rtmppkt.c | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/libavformat/rtm

[libav-devel] [PATCH] hmac: Explicitly convert types at function pointer assignment

2016-12-15 Thread Diego Biurrun
Fixes a number of warnings of the type libavutil/hmac.c:61:21: warning: assignment from incompatible pointer type --- Ifdeffed the function pointer signature for hmac_update to match API, according to Martin's review. libavutil/hmac.c | 35 +++ 1 file changed, 23

Re: [libav-devel] [PATCH 2/2] hmac: Explicitly convert types at function pointer assignment

2016-12-15 Thread Martin Storsjö
On Thu, 15 Dec 2016, Diego Biurrun wrote: Fixes a number of warnings of the type libavutil/hmac.c:61:21: warning: assignment from incompatible pointer type --- Now with the preliminaries requested by Anton. libavutil/hmac.c | 30 ++ 1 file changed, 18 insertions(+),

Re: [libav-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 01:03:41PM +0100, Hendrik Leppkes wrote: > On Thu, Dec 15, 2016 at 12:57 PM, Diego Biurrun wrote: > > On Thu, Dec 15, 2016 at 08:43:16AM +0100, Steve Lhomme wrote: > >> On Wed, Dec 14, 2016 at 5:12 PM, Diego Biurrun wrote: > >> > On Wed, Dec 14, 2016 at 04:46:54PM +0100, S

[libav-devel] [PATCH 1/2] crypto: consistently use size_t as type for length parameters

2016-12-15 Thread Diego Biurrun
size_t is the correct type to use for sizes. --- libavutil/md5.c | 8 libavutil/md5.h | 8 +++- libavutil/sha.c | 6 +- libavutil/sha.h | 9 +++-- libavutil/version.h | 3 +++ 5 files changed, 30 insertions(+), 4 deletions(-) diff --git a/libavutil/md5.c b/lib

[libav-devel] [PATCH 2/2] hmac: Explicitly convert types at function pointer assignment

2016-12-15 Thread Diego Biurrun
Fixes a number of warnings of the type libavutil/hmac.c:61:21: warning: assignment from incompatible pointer type --- Now with the preliminaries requested by Anton. libavutil/hmac.c | 30 ++ 1 file changed, 18 insertions(+), 12 deletions(-) diff --git a/libavutil/hma

Re: [libav-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-15 Thread Hendrik Leppkes
On Thu, Dec 15, 2016 at 12:57 PM, Diego Biurrun wrote: > On Thu, Dec 15, 2016 at 08:43:16AM +0100, Steve Lhomme wrote: >> On Wed, Dec 14, 2016 at 5:12 PM, Diego Biurrun wrote: >> > On Wed, Dec 14, 2016 at 04:46:54PM +0100, Steve Lhomme wrote: >> >> From: Steve Lhomme >> >> >> >> Without any opti

Re: [libav-devel] [PATCH] configure: fix linking with MSVC when using --disable-optimizations

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 08:43:16AM +0100, Steve Lhomme wrote: > On Wed, Dec 14, 2016 at 5:12 PM, Diego Biurrun wrote: > > On Wed, Dec 14, 2016 at 04:46:54PM +0100, Steve Lhomme wrote: > >> From: Steve Lhomme > >> > >> Without any optimization flags, MSVC does no dead code elimination (DCE) at > >

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 12:38:51PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-12-15 12:18:44) > > On Thu, Dec 15, 2016 at 12:03:36PM +0100, Anton Khirnov wrote: > > > Quoting Diego Biurrun (2016-12-15 10:58:52) > > > > On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: >

Re: [libav-devel] [PATCH] vaapi_decode: use the correct logging context

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 12:47:48PM +0100, Anton Khirnov wrote: > From: elenril The author is wrong. > --- > libavcodec/vaapi_decode.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) LGTM Diego ___ libav-devel mailing list libav-devel@l

[libav-devel] [PATCH] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Partially based on a patch by Timo Rothenpieler . Additional scaling list handling fix by Jun Zhao . --- Changelog | 2 +- configure | 3 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/hevcdec.c | 6 +- libavcodec/vaapi

[libav-devel] [PATCH] vaapi_decode: use the correct logging context

2016-12-15 Thread Anton Khirnov
From: elenril --- libavcodec/vaapi_decode.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/vaapi_decode.c b/libavcodec/vaapi_decode.c index 88bd889..42f03ab 100644 --- a/libavcodec/vaapi_decode.c +++ b/libavcodec/vaapi_decode.c @@ -306,7 +306,7 @@ static int

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-15 12:18:44) > On Thu, Dec 15, 2016 at 12:03:36PM +0100, Anton Khirnov wrote: > > Quoting Diego Biurrun (2016-12-15 10:58:52) > > > On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: > > > > Partially based on a patch by Timo Rothenpieler > > > > --- > >

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 12:03:36PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-12-15 10:58:52) > > On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: > > > Partially based on a patch by Timo Rothenpieler > > > --- > > > Changelog | 2 +- > > > configure

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Quoting Diego Biurrun (2016-12-15 10:58:52) > On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: > > Partially based on a patch by Timo Rothenpieler > > --- > > Changelog | 2 +- > > configure | 3 + > > libavcodec/Makefile | 1 + > > libavc

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 10:32:09AM +0100, Anton Khirnov wrote: > Partially based on a patch by Timo Rothenpieler > --- > Changelog | 2 +- > configure | 3 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c| 1 + > libavcodec/hevcdec.c |

Re: [libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Mark Thompson
On 15/12/16 09:32, Anton Khirnov wrote: > +VAIQMatrixBufferHEVC iq_matrix; > +int j, pos; > + > +for (i = 0; i < 6; i++) { > +for (j = 0; j < 16; j++) { > +pos = 4 * ff_hevc_diag_scan4x4_y[j] + > ff_hevc_diag_scan4x4_x[j]; > +iq_m

[libav-devel] [PATCH 2/2] hevcdec: add a VAAPI hwaccel

2016-12-15 Thread Anton Khirnov
Partially based on a patch by Timo Rothenpieler --- Changelog | 2 +- configure | 3 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/hevcdec.c | 6 +- libavcodec/vaapi_decode.c | 1 + libavcodec/vaapi_hevc.c | 443 +

[libav-devel] [PATCH 1/2] Changelog: add some missing entries

2016-12-15 Thread Anton Khirnov
--- Changelog | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Changelog b/Changelog index feb151c..ab7f1b6 100644 --- a/Changelog +++ b/Changelog @@ -3,6 +3,9 @@ releases are sorted from youngest to oldest. version : - Support for spherical videos +- Intel QSV-accelerated VP8 and VC-1 d

Re: [libav-devel] [PATCH] libavformat: Fix a faulty api deprecation guard in prepare_input_packet

2016-12-15 Thread Diego Biurrun
On Thu, Dec 15, 2016 at 09:53:09AM +0200, Martin Storsjö wrote: > This seems to have been added by mistake in 11de006b, by not > noticing the negation for the existing condition. This block does > not contain any code that accesses the codec field in AVStream. > > This function is meant to serve a

[libav-devel] [PATCH] rtmppkt: Check for packet size mismatches

2016-12-15 Thread Martin Storsjö
From: Michael Niedermayer Fixes out of array access. Found-by: Paul Cher Reviewed-by: Paul Cher CC: libav-sta...@libav.org --- libavformat/rtmppkt.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c index f8c51d0..373c3ea 100644 --- a/li