Re: [libav-devel] [PATCH 3/4] mpeg12dec: avoid signed overflow in bitrate calculation

2016-12-17 Thread Luca Barbato
On 17/12/2016 18:17, Anton Khirnov wrote: > CC: libav-sta...@libav.org > Bug-Id: 981 > Found-By: Agostino Sarubbo > --- > libavcodec/mpeg12dec.c | 13 +++-- > 1 file changed, 11 insertions(+), 2 deletions(-) > Ok (same as 2/4) lu ___

Re: [libav-devel] [PATCH 4/4] mpeg12dec: move setting first_field to mpeg_field_start()

2016-12-17 Thread Luca Barbato
On 17/12/2016 18:17, Anton Khirnov wrote: > For field picture, the first_field is set based on its previous value. > Before this commit, first_field is set when reading the picture > coding extension. However, in corrupted files there may be multiple > picture coding extension headers, so the

Re: [libav-devel] [PATCH 2/4] mpegvideo_parser: avoid signed overflow in bitrate calculation

2016-12-17 Thread Luca Barbato
On 17/12/2016 18:17, Anton Khirnov wrote: > CC: libav-sta...@libav.org > Bug-Id: 981 > Found-By: Agostino Sarubbo > --- > libavcodec/mpegvideo_parser.c | 9 - > 1 file changed, 8 insertions(+), 1 deletion(-) > Sounds fine, not sure if it is worth to make a function to share it across

Re: [libav-devel] [PATCH 1/4] mov: fix a possible invalid read in mov_read_mac_string()

2016-12-17 Thread Luca Barbato
On 17/12/2016 18:17, Anton Khirnov wrote: > When the input string is too large, so the second condition in if () > fails, the code will erroneously execute the else branch, indexing the > mac_to_unicode table with a negative index. > > CC: libav-sta...@libav.org > Bug-Id: 1000 > Found-By: Kamil

Re: [libav-devel] [PATCH 4/4] mpeg12dec: move setting first_field to mpeg_field_start()

2016-12-17 Thread Sean McGovern
Hi Anton, On Dec 17, 2016 12:17, "Anton Khirnov" wrote: For field picture, the first_field is set based on its previous value. Before this commit, first_field is set when reading the picture coding extension. However, in corrupted files there may be multiple picture coding

[libav-devel] [PATCH 1/4] mov: fix a possible invalid read in mov_read_mac_string()

2016-12-17 Thread Anton Khirnov
When the input string is too large, so the second condition in if () fails, the code will erroneously execute the else branch, indexing the mac_to_unicode table with a negative index. CC: libav-sta...@libav.org Bug-Id: 1000 Found-By: Kamil Frankowicz --- libavformat/mov.c | 6 +- 1 file

[libav-devel] [PATCH 2/4] mpegvideo_parser: avoid signed overflow in bitrate calculation

2016-12-17 Thread Anton Khirnov
CC: libav-sta...@libav.org Bug-Id: 981 Found-By: Agostino Sarubbo --- libavcodec/mpegvideo_parser.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/libavcodec/mpegvideo_parser.c b/libavcodec/mpegvideo_parser.c index 27f2985..500d124 100644 ---

[libav-devel] [PATCH 4/4] mpeg12dec: move setting first_field to mpeg_field_start()

2016-12-17 Thread Anton Khirnov
For field picture, the first_field is set based on its previous value. Before this commit, first_field is set when reading the picture coding extension. However, in corrupted files there may be multiple picture coding extension headers, so the final value of first_field that is actually used

[libav-devel] [PATCH 3/4] mpeg12dec: avoid signed overflow in bitrate calculation

2016-12-17 Thread Anton Khirnov
CC: libav-sta...@libav.org Bug-Id: 981 Found-By: Agostino Sarubbo --- libavcodec/mpeg12dec.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c index 2d9c99d..310169b 100644 --- a/libavcodec/mpeg12dec.c +++

Re: [libav-devel] [PATCH 01/31] Bump major versions of all libraries

2016-12-17 Thread Diego Biurrun
On Sat, Dec 17, 2016 at 09:31:05AM +0100, Vittorio Giovara wrote: > > Every major version number is aligned to 60, to facilitate distributions > and downstream users in identifying which release number corresponds to > any given library version. I guess the time for discussing a unified version

[libav-devel] [PATCH 29/31] lavc: Drop deprecated avctx codec name

2016-12-17 Thread Vittorio Giovara
Deprecated in 04/2014. --- libavcodec/avcodec.h | 7 --- libavcodec/version.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 3d4d0f4..e3be872 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1326,13 +1326,6 @@ typedef

[libav-devel] [PATCH 30/31] lavu: Drop deprecated VDPAU pixel formats

2016-12-17 Thread Vittorio Giovara
Deprecated in 07/2013. --- libavutil/pixdesc.c | 38 -- libavutil/pixfmt.h | 10 -- libavutil/version.h | 3 --- 3 files changed, 51 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index b4797bb..5ce6c42 100644 ---

[libav-devel] [PATCH 27/31] lavc: Drop deprecated unused public members

2016-12-17 Thread Vittorio Giovara
Deprecated in 07/2014. --- libavcodec/avcodec.h | 18 -- libavcodec/options_table.h | 12 libavcodec/version.h | 3 --- 3 files changed, 33 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index be53df7..1117dc1 100644 ---

[libav-devel] [PATCH 04/31] lavfi: Drop deprecated filter initialization

2016-12-17 Thread Vittorio Giovara
Deprecated in 03/2013. --- libavfilter/avfilter.c | 7 --- libavfilter/avfilter.h | 15 --- libavfilter/version.h | 3 --- 3 files changed, 25 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index d6bddef..439eee4 100644 --- a/libavfilter/avfilter.c

[libav-devel] [PATCH 31/31] lavu: Drop deprecated option type

2016-12-17 Thread Vittorio Giovara
Deprecated in 02/2014. --- libavutil/opt.h | 3 --- libavutil/version.h | 3 --- 2 files changed, 6 deletions(-) diff --git a/libavutil/opt.h b/libavutil/opt.h index a65c4f4..b68a396 100644 --- a/libavutil/opt.h +++ b/libavutil/opt.h @@ -263,9 +263,6 @@ typedef struct AVOption { int

[libav-devel] [PATCH 09/31] lavf: Drop deprecated hint to set muxer timebase

2016-12-17 Thread Vittorio Giovara
Deprecated in 05/2014. --- libavformat/mux.c | 11 --- libavformat/version.h | 4 +--- 2 files changed, 1 insertion(+), 14 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 982e33b..40091db 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -110,17 +110,6

[libav-devel] [PATCH 28/31] lavc: Drop deprecated codec flags

2016-12-17 Thread Vittorio Giovara
Deprecated in 04/2014. --- libavcodec/avcodec.h | 27 --- libavcodec/libxvid.c | 6 -- libavcodec/mpegvideo_enc.c | 14 -- libavcodec/options_table.h | 12 libavcodec/version.h | 12 5 files changed, 71

[libav-devel] [PATCH 03/31] lavfi: Drop deprecated functions to open a filter or a filterchain

2016-12-17 Thread Vittorio Giovara
Deprecated in 03/2013. --- libavfilter/avfilter.c | 8 libavfilter/avfilter.h | 30 -- libavfilter/avfiltergraph.c | 17 - libavfilter/version.h | 3 --- 4 files changed, 58 deletions(-) diff --git a/libavfilter/avfilter.c

[libav-devel] [PATCH 08/31] lavf: Drop deprecated AVFract type and related field

2016-12-17 Thread Vittorio Giovara
Deprecated in 05/2014. --- libavformat/avformat.h | 21 - libavformat/version.h | 3 --- 2 files changed, 24 deletions(-) diff --git a/libavformat/avformat.h b/libavformat/avformat.h index 547b88b..1bf66b1 100644 --- a/libavformat/avformat.h +++ b/libavformat/avformat.h @@

[libav-devel] [PATCH 19/31] lavc: Drop deprecated extended aspect ratio symbol

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavcodec/avcodec.h | 4 libavcodec/h263.h| 2 -- libavcodec/version.h | 3 --- 3 files changed, 9 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ce8c86e..39e80e7 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@

[libav-devel] [PATCH 25/31] lavc: Drop deprecated av_fast_malloc() compatibility

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavcodec/avcodec.h | 5 - libavcodec/version.h | 3 --- 2 files changed, 8 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 716cef9..85e11ff 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -41,11 +41,6 @@ #include

[libav-devel] [PATCH 24/31] lavc: Drop deprecated macroblock type symbols

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavcodec/avcodec.h | 26 -- libavcodec/mpegutils.h | 2 -- libavcodec/version.h | 3 --- 3 files changed, 31 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 9ec5f32..716cef9 100644 --- a/libavcodec/avcodec.h

[libav-devel] [PATCH 21/31] Remove deprecated XvMC support hacks

2016-12-17 Thread Vittorio Giovara
From: Diego Biurrun Deprecated in 11/2013. --- configure | 3 - libavcodec/4xm.c | 2 +- libavcodec/Makefile | 3 - libavcodec/allcodecs.c| 3 - libavcodec/asvdec.c | 2 +- libavcodec/avcodec.h |

[libav-devel] [PATCH 22/31] lavc: Drop deprecated error rate option

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavcodec/avcodec.h | 9 - libavcodec/mpegvideo_enc.c | 7 --- libavcodec/options_table.h | 3 --- libavcodec/version.h | 3 --- 4 files changed, 22 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index ff6a1df..1011ce6

[libav-devel] [PATCH 14/31] lavc: Drop deprecated VDPAU buffer fields

2016-12-17 Thread Vittorio Giovara
Deprecated in 07/2013. --- libavcodec/vdpau.h | 44 libavcodec/version.h | 3 --- 2 files changed, 47 deletions(-) diff --git a/libavcodec/vdpau.h b/libavcodec/vdpau.h index 2f4fa86..a5d31cb 100644 --- a/libavcodec/vdpau.h +++ b/libavcodec/vdpau.h

[libav-devel] [PATCH 26/31] lavc: Drop deprecated emu edge functionality

2016-12-17 Thread Vittorio Giovara
Deprecated in 01/2014. --- libavcodec/avcodec.h | 22 -- libavcodec/options_table.h | 3 --- libavcodec/utils.c | 7 --- libavcodec/version.h | 3 --- 4 files changed, 35 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index

[libav-devel] [PATCH 20/31] lavc: Drop deprecated architectures symbols

2016-12-17 Thread Vittorio Giovara
Alpha deprecated in 11/2013. Sh4 and sparc deprecated in 01/2014. --- libavcodec/avcodec.h | 9 - libavcodec/options_table.h | 6 -- libavcodec/version.h | 9 - 3 files changed, 24 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index

[libav-devel] [PATCH 07/31] lavf: Drop deprecated bitexact functionality

2016-12-17 Thread Vittorio Giovara
Deprecated in 05/2014. --- libavformat/mux.c | 7 --- libavformat/version.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/libavformat/mux.c b/libavformat/mux.c index 2561a6d..982e33b 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -99,13 +99,6 @@ static int

[libav-devel] [PATCH 16/31] lavc: Drop deprecated way of setting codec dimensions

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavcodec/avcodec.h | 8 libavcodec/utils.c | 7 --- libavcodec/version.h | 3 --- 3 files changed, 18 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 297c6e2..c107eea 100644 --- a/libavcodec/avcodec.h +++

[libav-devel] [PATCH 01/31] Bump major versions of all libraries

2016-12-17 Thread Vittorio Giovara
This disables everything that was deprecated in the past 18 months, with a couple of minor (but sensible) exceptions. Every major version number is aligned to 60, to facilitate distributions and downstream users in identifying which release number corresponds to any given library version.

[libav-devel] [PATCH 18/31] lavc: Drop deprecated workaround bugs options

2016-12-17 Thread Vittorio Giovara
Illegal ac_vlc and old msmpeg4 detection deprecated in 10/2013. --- libavcodec/avcodec.h | 6 -- libavcodec/options_table.h | 6 -- libavcodec/version.h | 6 -- 3 files changed, 18 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index

[libav-devel] [PATCH 00/31] Post release version bump v2

2016-12-17 Thread Vittorio Giovara
In this version of the set I squashed a couple of patches that were too similar to keep separated. Then I added Diego's version for xvmc removal. Finally I unified the version libraries we're bumping to as discussed on ML and on IRC. Diego Biurrun (1): Remove deprecated XvMC support hacks

[libav-devel] [PATCH 17/31] lavc: Drop deprecated debug mv functionality

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavcodec/avcodec.h | 21 - libavcodec/options_table.h | 13 - libavcodec/version.h | 3 --- 3 files changed, 37 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index c107eea..8935312 100644 ---

[libav-devel] [PATCH 02/31] lavfi: Drop deprecated way of passing options for a few filters

2016-12-17 Thread Vittorio Giovara
Deprecated in 02/2013. --- libavfilter/af_channelmap.c | 7 - libavfilter/af_join.c | 8 - libavfilter/avfilter.c | 76 - libavfilter/buffersrc.c | 8 - libavfilter/version.h | 3 -- libavfilter/vf_aspect.c | 46

[libav-devel] [PATCH 15/31] lavc: Drop deprecated voxware codec entry

2016-12-17 Thread Vittorio Giovara
Deprecated in 08/2013. --- libavcodec/avcodec.h| 3 --- libavcodec/codec_desc.c | 9 - libavcodec/version.h| 3 --- 3 files changed, 15 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index def8716..297c6e2 100644 --- a/libavcodec/avcodec.h +++

[libav-devel] [PATCH 11/31] lavc: Drop deprecated missing sample log function

2016-12-17 Thread Vittorio Giovara
Deprecated in 01/2013. --- libavcodec/avcodec.h | 30 -- libavcodec/utils.c | 29 - libavcodec/version.h | 3 --- 3 files changed, 62 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 4c4649f..51d5385 100644 ---

[libav-devel] [PATCH 12/31] lavc: Drop deprecated lowres option

2016-12-17 Thread Vittorio Giovara
Deprecated in 04/2013. --- libavcodec/avcodec.h | 14 -- libavcodec/version.h | 3 --- 2 files changed, 17 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 51d5385..f340f4c 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -2786,17 +2786,6 @@

[libav-devel] [PATCH 23/31] lavc: Drop deprecated public symbols

2016-12-17 Thread Vittorio Giovara
qscale types and maximum number of bframes deprecated in 10/2013. Negative linesizes deprecated in 11/2013. xvidmmx deprecated in 08/2014. --- libavcodec/avcodec.h | 23 --- libavcodec/options_table.h | 3 --- libavcodec/version.h | 12 3 files

[libav-devel] [PATCH 13/31] lavc: Drop deprecated VDPAU codec capability

2016-12-17 Thread Vittorio Giovara
Deprecated in 07/2013. --- libavcodec/avcodec.h | 6 -- libavcodec/vdpau.h | 34 -- libavcodec/version.h | 3 --- 3 files changed, 43 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index f340f4c..def8716 100644 ---

[libav-devel] [PATCH 05/31] lavfi: Drop deprecated filter registration

2016-12-17 Thread Vittorio Giovara
Deprecated in 04/2013. --- libavfilter/avfilter.c | 11 --- libavfilter/avfilter.h | 18 -- libavfilter/version.h | 3 --- 3 files changed, 32 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 439eee4..3ae7a59 100644 ---

[libav-devel] [PATCH 06/31] lavfi: Drop deprecated non-const filter retrieval

2016-12-17 Thread Vittorio Giovara
Deprecated in 10/2013. --- libavfilter/avfilter.c | 5 + libavfilter/avfilter.h | 5 + libavfilter/version.h | 4 3 files changed, 2 insertions(+), 12 deletions(-) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 3ae7a59..83c1a7c 100644 ---

[libav-devel] [PATCH 10/31] lavc: Drop deprecated chroma subsample function

2016-12-17 Thread Vittorio Giovara
Deprecated in 11/2012. --- libavcodec/avcodec.h| 6 -- libavcodec/imgconvert.c | 9 - libavcodec/version.h| 3 --- 3 files changed, 18 deletions(-) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index 0997141..4c4649f 100644 --- a/libavcodec/avcodec.h +++