Re: [libav-devel] [PATCH] aarch64: Add parentheses around the offset parameter in movrel

On Thu, Feb 16, 2017 at 09:19:07AM +0200, Martin Storsjö wrote: > This fixes building with clang for linux with PIC enabled. > --- > libavutil/aarch64/asm.S | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) probably OK Diego ___ libav-devel

[libav-devel] [PATCH] aarch64: Add parentheses around the offset parameter in movrel

This fixes building with clang for linux with PIC enabled. --- libavutil/aarch64/asm.S | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/aarch64/asm.S b/libavutil/aarch64/asm.S index 0fc649a..86d36cd 100644 --- a/libavutil/aarch64/asm.S +++

Re: [libav-devel] [PATCH] matroskaenc: factor ts_offset in block timecode computation

On 15/02/2017 23:29, John Stebbins wrote: > ts_offset was added to cluster timecode, but then effectively subtracted > back off the block timecode > --- > libavformat/matroskaenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c >

Re: [libav-devel] [PATCH] vaapi_encode: Discard output buffer if picture submission fails

On 16/02/2017 01:26, Mark Thompson wrote: > Previously this was leaking, though it actually hit an assert making > sure that the buffer had already been cleared when freeing the picture. > --- > libavcodec/vaapi_encode.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git

[libav-devel] [PATCH] vaapi_encode: Discard output buffer if picture submission fails

Previously this was leaking, though it actually hit an assert making sure that the buffer had already been cleared when freeing the picture. --- libavcodec/vaapi_encode.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/vaapi_encode.c b/libavcodec/vaapi_encode.c index

[libav-devel] [PATCH] matroskaenc: factor ts_offset in block timecode computation

ts_offset was added to cluster timecode, but then effectively subtracted back off the block timecode --- libavformat/matroskaenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index e951a0f..2fe6e0e 100644 ---

Re: [libav-devel] [PATCH] avconv: Move rescale to stream timebase before monotonisation

On 14/02/17 20:12, Anton Khirnov wrote: > Quoting Mark Thompson (2017-02-13 00:53:59) >> If the stream timebase is coarser than the muxing timebase then the >> monotonisation process may fail because adding one to the timestamp >> need not actually produce a different timestamp after the rescale.

Re: [libav-devel] [PATCH] libopenh264dec: Let the framework use the h264_mp4toannexb bitstream filter

Quoting Martin Storsjö (2017-02-15 10:09:12) > This avoids a lot of boilerplate code within the decoder wrapper itself. > --- > The diff for the decode_frame function is much smaller if ignoring > whitespace (or if doing the reindenting later). > --- > libavcodec/libopenh264dec.c | 144 >

Re: [libav-devel] [PATCH] libopenh264dec: Let the framework use the h264_mp4toannexb bitstream filter

On 15/02/2017 10:09, Martin Storsjö wrote: > This avoids a lot of boilerplate code within the decoder wrapper itself. > --- > The diff for the decode_frame function is much smaller if ignoring > whitespace (or if doing the reindenting later). > --- > libavcodec/libopenh264dec.c | 144 >

Re: [libav-devel] [PATCH 3/3] configure: Restructure the way check_pkg_config() operates

On Sat, Feb 11, 2017 at 07:08:37PM +0100, Diego Biurrun wrote: > --- a/configure > +++ b/configure > @@ -4732,9 +4721,8 @@ enabled omx_rpi && { check_header OMX_Core.h > || > +enabled openssl && { { check_pkg_config "" openssl openssl/ssl.h > OPENSSL_init_ssl || > +

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, 15 Feb 2017 17:37:32 +0100 Diego Biurrun wrote: > On Wed, Feb 15, 2017 at 11:32:47AM -0500, Vittorio Giovara wrote: > > On Wed, Feb 15, 2017 at 11:29 AM, wm4 wrote: > > > On Wed, 15 Feb 2017 11:16:40 -0500 > > > Vittorio Giovara

Re: [libav-devel] [PATCH] configure: Handle SDL version check through pkg-config

On Wed, Feb 15, 2017 at 01:21:42PM +0100, Diego Biurrun wrote: > --- > > Now keeps the check_pkg_config call to ensure that the SDL libs are > actually usable. > > configure | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) OKed by Luca on IRC. Diego

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, Feb 15, 2017 at 11:32:47AM -0500, Vittorio Giovara wrote: > On Wed, Feb 15, 2017 at 11:29 AM, wm4 wrote: > > On Wed, 15 Feb 2017 11:16:40 -0500 > > Vittorio Giovara wrote: > > > >> On Wed, Feb 15, 2017 at 11:12 AM, wm4

[libav-devel] [PATCH] h264_sei: Check actual presence of picture timing SEI message

From: Michael Niedermayer Signed-off-by: Michael Niedermayer --- This should hopefully be a better fix for the undetected interlaced samples I reported a couple of days ago. Vittorio libavcodec/h264_parser.c | 4 ++-- libavcodec/h264_sei.c|

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, Feb 15, 2017 at 11:29 AM, wm4 wrote: > On Wed, 15 Feb 2017 11:16:40 -0500 > Vittorio Giovara wrote: > >> On Wed, Feb 15, 2017 at 11:12 AM, wm4 wrote: >> > On Fri, 10 Feb 2017 16:08:10 -0500 >> > Vittorio Giovara

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, 15 Feb 2017 11:16:40 -0500 Vittorio Giovara wrote: > On Wed, Feb 15, 2017 at 11:12 AM, wm4 wrote: > > On Fri, 10 Feb 2017 16:08:10 -0500 > > Vittorio Giovara wrote: > >> @@ -3369,6 +3393,26 @@ static int

[libav-devel] [PATCHv2 4/6] mov: Export bounds and padding from spherical metadata

Update the fate test as needed. Signed-off-by: Vittorio Giovara --- Validate bounding rectangle in spec v2. Use James' suggestion about UINT32_MAX. Vittorio libavformat/mov.c| 53 +++- tests/fate/mov.mak

[libav-devel] [PATCHv2 5/6] mkv: Export bounds and padding from spherical metadata

Signed-off-by: Vittorio Giovara --- Update according to James' review. Vittorio libavformat/matroskadec.c | 65 +-- 1 file changed, 63 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c

[libav-devel] [PATCH 6/6] mov: Validate spherical metadata version

--- Patch suggested by James. Vittorio libavformat/mov.c | 26 ++ 1 file changed, 22 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d727612..0d9e83a 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c @@ -3229,7 +3229,7 @@

[libav-devel] [PATCHv2 1/6] mov: Fix spherical metadata_source parsing

From: Aaron Colwell Signed-off-by: James Almer --- Updated to the right chunks. Vittorio libavformat/mov.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 11bcff0..6d1b2b2 100644 ---

[libav-devel] [PATCHv2 3/6] spherical: Add tiled equirectangular type and projection-specific properties

Signed-off-by: Vittorio Giovara --- Modified names and applied other comments. Vittorio avprobe.c | 15 +++--- doc/APIchanges| 5 + libavformat/dump.c| 10 + libavutil/spherical.h | 56

[libav-devel] [PATCHv2 2/6] matroskadec: add support for Spherical Video elements

From: James Almer Signed-off-by: James Almer Signed-off-by: Vittorio Giovara --- Updated according review. Vittorio libavformat/matroska.h| 14 ++ libavformat/matroskadec.c | 69

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, Feb 15, 2017 at 11:12 AM, wm4 wrote: > On Fri, 10 Feb 2017 16:08:10 -0500 > Vittorio Giovara wrote: >> @@ -3369,6 +3393,26 @@ static int mov_parse_uuid_spherical(MOVStreamContext >> *sc, AVIOContext *pb, size_ >> val =

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Fri, 10 Feb 2017 16:08:10 -0500 Vittorio Giovara wrote: > Update the fate test as needed. > --- > libavformat/mov.c| 46 > +++- > tests/fate/mov.mak | 2 +- > tests/ref/fate/mov-spherical | 6 +-

Re: [libav-devel] [PATCH 4/5] mov: Export bounds and padding from spherical metadata

On Wed, Feb 15, 2017 at 2:46 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2017-02-10 22:08:10) >> Update the fate test as needed. >> --- >> libavformat/mov.c| 46 >> +++- >> tests/fate/mov.mak | 2 +- >>

Re: [libav-devel] [PATCH 1/5] mov: Fix spherical metadata_source parsing

On Wed, Feb 15, 2017 at 2:22 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2017-02-10 22:08:07) >> From: Aaron Colwell >> >> Signed-off-by: James Almer >> --- >> libavformat/mov.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2

Re: [libav-devel] [PATCH] fate: Add another SVQ3 test to increase coverage

On Tue, Feb 14, 2017 at 09:08:14PM +0100, Anton Khirnov wrote: > Quoting Diego Biurrun (2017-02-05 13:14:46) > > --- /dev/null > > +++ b/tests/ref/fate/svq3-2 > > @@ -0,0 +1,20 @@ > > +#tb 0: 1/19200 > > +0, -2, -2,0, 185280, 0x061c0d85 > > +0, -19200, -19200,

Re: [libav-devel] [PATCH 2/5] matroskadec: add support for Spherical Video elements

On 2/15/2017 4:28 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2017-02-10 22:08:08) >> From: James Almer >> >> Signed-off-by: James Almer >> Signed-off-by: Vittorio Giovara >> --- >> libavformat/matroska.h| 14

[libav-devel] [PATCH] configure: Handle SDL version check through pkg-config

--- Now keeps the check_pkg_config call to ensure that the SDL libs are actually usable. configure | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/configure b/configure index b8cbe17..4635b73 100755 --- a/configure +++ b/configure @@ -4748,9 +4748,7 @@ if enabled nvenc;

[libav-devel] [PATCH] libopenh264dec: Let the framework use the h264_mp4toannexb bitstream filter

This avoids a lot of boilerplate code within the decoder wrapper itself. --- The diff for the decode_frame function is much smaller if ignoring whitespace (or if doing the reindenting later). --- libavcodec/libopenh264dec.c | 144 1 file changed, 25

Re: [libav-devel] [PATCH 2/2] apetag: account for header size if present when returning the start position

Quoting James Almer (2017-02-11 00:24:27) > The size field in the header/footer accounts for the entire APE tag > structure except the 32 bytes from header, for compatibility with > APEv1. > > Signed-off-by: James Almer > --- > libavformat/apetag.c | 7 ++- > 1 file