Re: [libav-devel] [PATCH] caf: add an Opus tag

2017-07-21 Thread Luca Barbato
On 21/07/2017 21:59, Anton Khirnov wrote: > CC: libav-sta...@libav.org > --- > libavformat/caf.c| 1 + > libavformat/cafdec.c | 8 > 2 files changed, 9 insertions(+) > > diff --git a/libavformat/caf.c b/libavformat/caf.c > index cf128d5..c299cad 100644 > --- a/libavformat/caf.c > +++

Re: [libav-devel] [PATCH v2] imgutils: add function to clear an image to black

2017-07-21 Thread Anton Khirnov
Quoting wm4 (2017-07-16 12:41:59) > Black isn't always just memset(ptr, 0, size). Limited YUV in particular > requires relatively non-obvious values, and filling a frame with > repeating 0 bytes is disallowed in some contexts. With component sizes > larger than 8 or packed YUV, this can become rela

Re: [libav-devel] [PATCH v2] lavc, lavu: move frame cropping to a convenience function

2017-07-21 Thread wm4
On Fri, 21 Jul 2017 23:02:12 +0200 Anton Khirnov wrote: > Quoting wm4 (2017-07-21 22:56:43) > > On Fri, 21 Jul 2017 22:32:43 +0200 > > Anton Khirnov wrote: > > > > > Quoting wm4 (2017-07-12 17:02:49) > > > > +int av_frame_apply_cropping(AVFrame *frame, int flags) > > > > +{ > > > > +con

Re: [libav-devel] [PATCH v2] lavc, lavu: move frame cropping to a convenience function

2017-07-21 Thread Anton Khirnov
Quoting wm4 (2017-07-21 22:56:43) > On Fri, 21 Jul 2017 22:32:43 +0200 > Anton Khirnov wrote: > > > Quoting wm4 (2017-07-12 17:02:49) > > > +int av_frame_apply_cropping(AVFrame *frame, int flags) > > > +{ > > > +const AVPixFmtDescriptor *desc; > > > +size_t offsets[4]; > > > +int i; >

Re: [libav-devel] [PATCH v2] lavc, lavu: move frame cropping to a convenience function

2017-07-21 Thread wm4
On Fri, 21 Jul 2017 22:32:43 +0200 Anton Khirnov wrote: > Quoting wm4 (2017-07-12 17:02:49) > > +int av_frame_apply_cropping(AVFrame *frame, int flags) > > +{ > > +const AVPixFmtDescriptor *desc; > > +size_t offsets[4]; > > +int i; > > + > > +if (!(frame->width > 0 && frame->heigh

Re: [libav-devel] [PATCH] lavf: allow avformat_close_input() with NULL

2017-07-21 Thread wm4
On Fri, 21 Jul 2017 22:09:03 +0200 Anton Khirnov wrote: > Quoting wm4 (2017-07-16 12:43:09) > > Behaves more like FFmpeg, makes some API users not crash on exit. > > --- > > libavformat/utils.c | 7 ++- > > 1 file changed, 6 insertions(+), 1 deletion(-) > > > > diff --git a/libavformat/util

Re: [libav-devel] [PATCH v2] lavc, lavu: move frame cropping to a convenience function

2017-07-21 Thread Anton Khirnov
Quoting wm4 (2017-07-12 17:02:49) > +int av_frame_apply_cropping(AVFrame *frame, int flags) > +{ > +const AVPixFmtDescriptor *desc; > +size_t offsets[4]; > +int i; > + > +if (!(frame->width > 0 && frame->height > 0)) > +return AVERROR(EINVAL); > + > +/* make sure we are

Re: [libav-devel] [PATCH] lavf: allow avformat_close_input() with NULL

2017-07-21 Thread Anton Khirnov
Quoting wm4 (2017-07-16 12:43:09) > Behaves more like FFmpeg, makes some API users not crash on exit. > --- > libavformat/utils.c | 7 ++- > 1 file changed, 6 insertions(+), 1 deletion(-) > > diff --git a/libavformat/utils.c b/libavformat/utils.c > index eaba473914..24a4335016 100644 > --- a/

[libav-devel] [PATCH] caf: add an Opus tag

2017-07-21 Thread Anton Khirnov
CC: libav-sta...@libav.org --- libavformat/caf.c| 1 + libavformat/cafdec.c | 8 2 files changed, 9 insertions(+) diff --git a/libavformat/caf.c b/libavformat/caf.c index cf128d5..c299cad 100644 --- a/libavformat/caf.c +++ b/libavformat/caf.c @@ -49,6 +49,7 @@ const AVCodecTag ff_cod

Re: [libav-devel] [PATCH] rmdec: properly initialize ret to 0

2017-07-21 Thread Martin Storsjö
On Thu, 20 Jul 2017, Sean McGovern wrote: After 95ce02b35d3d1bb16111031df1d82a6e4d894d36, the value of ret was not guaranteed to be 0 by some compilers. This description raises quite a bit of questions. The root cause for the issue seems to be something different. I'm pretty sure the issue li

Re: [libav-devel] [PATCH 5/5] h264dec: add a CUVID hwaccel

2017-07-21 Thread Luca Barbato
On 21/07/2017 15:19, Anton Khirnov wrote: > Some parts of the code are based on a patch by > Timo Rothenpieler > --- Seems fine, once I manage to boot the desktop I can test it. lu PS: Do you have plans for hevc as well? ___ libav-devel mailing lis

Re: [libav-devel] [PATCH] caf: add an Opus tag

2017-07-21 Thread Anton Khirnov
Quoting James Almer (2017-07-21 17:49:33) > On 7/21/2017 9:19 AM, Anton Khirnov wrote: > > Quoting Anton Khirnov (2017-07-21 13:59:41) > >> CC: libav-sta...@libav.org > >> --- > >> libavformat/caf.c | 1 + > >> 1 file changed, 1 insertion(+) > >> > >> diff --git a/libavformat/caf.c b/libavformat/c

Re: [libav-devel] [PATCH] caf: add an Opus tag

2017-07-21 Thread James Almer
On 7/21/2017 9:19 AM, Anton Khirnov wrote: > Quoting Anton Khirnov (2017-07-21 13:59:41) >> CC: libav-sta...@libav.org >> --- >> libavformat/caf.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/libavformat/caf.c b/libavformat/caf.c >> index cf128d5..c299cad 100644 >> --- a/libavformat

Re: [libav-devel] [PATCH] lavf/vf_deinterlace_qsv: Enable the qsv deinterlace vpp

2017-07-21 Thread Maxym Dmytrychenko
the same and seems to be working just fine On Fri, Jul 21, 2017 at 12:36 PM, Luca Barbato wrote: > On 21/07/2017 08:35, Huang, Zhengxu wrote: > > > > Looks good. The documentation should be updated as well, but can happen > on a second time. > > lu > > ___

Re: [libav-devel] [PATCH 4/5] decode: add a per-frame private data for hwaccel use

2017-07-21 Thread Luca Barbato
On 21/07/2017 15:19, Anton Khirnov wrote: > This will be useful in the CUVID hwaccel. It should also eventually > replace current decoder-specific mechanisms used by various other > hwaccels. > --- > libavcodec/decode.c | 3 +++ > libavcodec/decode.h | 6 ++ > 2 files changed, 9 insertions(+)

Re: [libav-devel] [PATCH 3/5] decode: add a mechanism for performing delayed processing on the decoded frames

2017-07-21 Thread Luca Barbato
On 21/07/2017 15:19, Anton Khirnov wrote: > This will be useful in the CUVID hwaccel. > --- > libavcodec/decode.c | 11 +++ > libavcodec/decode.h | 15 +++ > 2 files changed, 26 insertions(+) > Ok. ___ libav-devel mailing list liba

Re: [libav-devel] [PATCH 2/5] decode: add a method for attaching lavc-internal data to frames

2017-07-21 Thread Luca Barbato
On 21/07/2017 15:19, Anton Khirnov wrote: > Use the AVFrame.opaque_ref field. The original user's opaque_ref is > wrapped in the lavc struct and then unwrapped before the frame is > returned to the caller. > > This new struct will be useful in the following commits. > --- > libavcodec/decode.c |

Re: [libav-devel] [PATCH 1/5] decode: avoid leaks on failure in ff_get_buffer()

2017-07-21 Thread Luca Barbato
On 21/07/2017 15:19, Anton Khirnov wrote: > If the get_buffer() call fails, the frame might have some side data > already set. Make sure it gets freed. > --- > libavcodec/decode.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/libavcodec/decode.c b/libavcodec/decode.c > index 175a6fa

[libav-devel] [PATCH 2/5] decode: add a method for attaching lavc-internal data to frames

2017-07-21 Thread Anton Khirnov
Use the AVFrame.opaque_ref field. The original user's opaque_ref is wrapped in the lavc struct and then unwrapped before the frame is returned to the caller. This new struct will be useful in the following commits. --- libavcodec/decode.c | 57 +

[libav-devel] [PATCH 4/5] decode: add a per-frame private data for hwaccel use

2017-07-21 Thread Anton Khirnov
This will be useful in the CUVID hwaccel. It should also eventually replace current decoder-specific mechanisms used by various other hwaccels. --- libavcodec/decode.c | 3 +++ libavcodec/decode.h | 6 ++ 2 files changed, 9 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c

[libav-devel] [PATCH 3/5] decode: add a mechanism for performing delayed processing on the decoded frames

2017-07-21 Thread Anton Khirnov
This will be useful in the CUVID hwaccel. --- libavcodec/decode.c | 11 +++ libavcodec/decode.h | 15 +++ 2 files changed, 26 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 9cd3081..01e4dd2 100644 --- a/libavcodec/decode.c +++ b/libavcodec/decode.c

[libav-devel] [PATCH 1/5] decode: avoid leaks on failure in ff_get_buffer()

2017-07-21 Thread Anton Khirnov
If the get_buffer() call fails, the frame might have some side data already set. Make sure it gets freed. --- libavcodec/decode.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/decode.c b/libavcodec/decode.c index 175a6fa..89a6d34 100644 --- a/libavcodec/decode.c +++ b/libavcode

[libav-devel] [PATCH 5/5] h264dec: add a CUVID hwaccel

2017-07-21 Thread Anton Khirnov
Some parts of the code are based on a patch by Timo Rothenpieler --- Changelog | 1 + avtools/avconv.h| 1 + avtools/avconv_opt.c| 4 + configure | 9 +- libavcodec/Makefile | 2 + libavcodec/allcodecs.c | 1 + libavcodec/cuvid.c | 410

Re: [libav-devel] [PATCH] caf: add an Opus tag

2017-07-21 Thread Anton Khirnov
Quoting Anton Khirnov (2017-07-21 13:59:41) > CC: libav-sta...@libav.org > --- > libavformat/caf.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/caf.c b/libavformat/caf.c > index cf128d5..c299cad 100644 > --- a/libavformat/caf.c > +++ b/libavformat/caf.c > @@ -49,6 +49,7 @@

[libav-devel] [PATCH] caf: add an Opus tag

2017-07-21 Thread Anton Khirnov
CC: libav-sta...@libav.org --- libavformat/caf.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/caf.c b/libavformat/caf.c index cf128d5..c299cad 100644 --- a/libavformat/caf.c +++ b/libavformat/caf.c @@ -49,6 +49,7 @@ const AVCodecTag ff_codec_caf_tags[] = { { AV_CODEC_ID_QCE

Re: [libav-devel] [PATCH] lavf/vf_deinterlace_qsv: Enable the qsv deinterlace vpp

2017-07-21 Thread Luca Barbato
On 21/07/2017 08:35, Huang, Zhengxu wrote: > Looks good. The documentation should be updated as well, but can happen on a second time. lu ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH V3] libavcodec/mjpeg_qsv: Add QSV MJPEG encoder

2017-07-21 Thread Maxym Dmytrychenko
besides some syntax issues: align the = It seems to be working with default input as well as from hwaccel qsv: -hwaccel qsv -c:v h264_qsv -i input_file -vcodec mjpeg_qsv -r 30 -f mjpeg output On Fri, Jul 21, 2017 at 6:12 AM, Huang, Zhengxu wrote: > --- > Changes from v2: > * modify some coding-