Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common option

2017-11-16 Thread Li, Zhong
> From: libav-devel [mailto:libav-devel-boun...@libav.org] On Behalf Of > Maxym Dmytrychenko > Sent: Thursday, November 16, 2017 6:23 AM > To: libav development > Subject: Re: [libav-devel] [PATCH 1/2] qsvenc: move cavlc out of common > option > > I would leave it as it is now Yeah, it is not hi

Re: [libav-devel] [PATCH] makedef: Pass EXTERN_PREFIX from configure to makedef

2017-11-16 Thread James Almer
On 11/16/2017 5:00 AM, Martin Storsjö wrote: > This avoids having to use either "dumpbin -headers" to find out > the current architecture, or pass $ARCH from configure to deduce it. > > When configuring with --disable-asm, ARCH is equal to "c", which doesn't > give any indication of what symbol pr

Re: [libav-devel] [PATCH] configure: export extern_prefix to use with makedef

2017-11-16 Thread James Almer
On 11/16/2017 11:17 AM, James Almer wrote: > No point in trying to guess it from within makedef when configure > already did it before. > > Fixes linking failures on x86_32 when "arch" isn't one of the values > makedef was expecting. > > Signed-off-by: James Almer > --- > compat/windows/makedef

[libav-devel] [PATCH] configure: export extern_prefix to use with makedef

2017-11-16 Thread James Almer
No point in trying to guess it from within makedef when configure already did it before. Fixes linking failures on x86_32 when "arch" isn't one of the values makedef was expecting. Signed-off-by: James Almer --- compat/windows/makedef | 29 ++--- configure |

[libav-devel] [PATCH] libavcodec: Don't use dllexport, only dllimport when building DLLs

2017-11-16 Thread Martin Storsjö
The only purpose of dllexport (which is set while building the library that exports the symbols) is to have the linker automatically export such symbols into a DLL without using a def file - it doesn't affect the generated code. For MSVC builds, this isn't essential since we override what symbols

[libav-devel] [PATCH] makedef: Pass EXTERN_PREFIX from configure to makedef

2017-11-16 Thread Martin Storsjö
This avoids having to use either "dumpbin -headers" to find out the current architecture, or pass $ARCH from configure to deduce it. When configuring with --disable-asm, ARCH is equal to "c", which doesn't give any indication of what symbol prefix is to be used. --- compat/windows/makedef | 28 +-