On 6/7/2018 6:01 PM, Diego Biurrun wrote:
> On Thu, Jun 07, 2018 at 03:03:21PM +0300, Martin Storsjö wrote:
>> Commit 8c893aa3cd5 removed quotes that were required to detect
>> inline asm:
>>
>> check_insn armv5te qadd r0, r0, r0
>> .../test.c:1:34: error: expected string literal in 'asm'
>> void f
Use a common way to control target_usage, keeping consistent with vaapi
encoders. The private option preset is kept only for compatibility.
Signed-off-by: Zhong Li
---
libavcodec/qsvenc.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/libavcodec/qsvenc.c b/liba
agree, Luca.
will close it shortly.
On Thu, Jun 7, 2018 at 5:04 PM, Luca Barbato wrote:
> On 07/06/2018 10:51, Zhong Li wrote:
> > 1. vcm mode is only available for H264.
> > 2. vcm is not supported on Linux, but it is shown when run "./avconv -h
> > encoder=h264_qsv |grep vcm". This shouldn't
On Thu, Jun 07, 2018 at 03:03:21PM +0300, Martin Storsjö wrote:
> Commit 8c893aa3cd5 removed quotes that were required to detect
> inline asm:
>
> check_insn armv5te qadd r0, r0, r0
> .../test.c:1:34: error: expected string literal in 'asm'
> void foo(void){ __asm__ volatile(qadd r0, r0, r0); }
>
On 07/06/2018 14:03, Martin Storsjö wrote:
> From: John Cox
>
> Commit 8c893aa3cd5 removed quotes that were required to detect
> inline asm:
>
> check_insn armv5te qadd r0, r0, r0
> .../test.c:1:34: error: expected string literal in 'asm'
> void foo(void){ __asm__ volatile(qadd r0, r0, r0); }
>
On 07/06/2018 10:51, Zhong Li wrote:
> 1. vcm mode is only available for H264.
> 2. vcm is not supported on Linux, but it is shown when run "./avconv -h
> encoder=h264_qsv |grep vcm". This shouldn't happen.
>
> Signed-off-by: Zhong Li
> ---
> libavcodec/qsvenc.h | 1 -
> libavcodec/qsvenc_h
From: John Cox
Commit 8c893aa3cd5 removed quotes that were required to detect
inline asm:
check_insn armv5te qadd r0, r0, r0
.../test.c:1:34: error: expected string literal in 'asm'
void foo(void){ __asm__ volatile(qadd r0, r0, r0); }
The correct code is:
void foo(void){ __asm__ volatile("qadd
1. vcm mode is only available for H264.
2. vcm is not supported on Linux, but it is shown when run "./avconv -h
encoder=h264_qsv |grep vcm". This shouldn't happen.
Signed-off-by: Zhong Li
---
libavcodec/qsvenc.h | 1 -
libavcodec/qsvenc_h264.c | 3 +++
2 files changed, 3 insertions(+), 1 de
