Re: [libav-devel] [PATCH] x11grab: Check the XQueryPointer return value

2014-09-26 Thread Antonio Ospite
On Fri, 26 Sep 2014 21:20:15 +0200 Luca Barbato wrote: > Disable follow_mouse and draw_mouse accordingly to prevent spurious > updates on multi screen setups. > > Developed from an initial patch from Antonio Ospite . > > CC: libav-sta...@libav.org > --- > >

Re: [libav-devel] [PATCH] x11grab: Check the XQueryPointer return value

2014-09-26 Thread Antonio Ospite
On Fri, 26 Sep 2014 00:49:03 +0200 Luca Barbato wrote: > And disable follow_mouse and draw_mouse accordingly. > > Prevent spurious updates on multi screen setups. > > Reported-By: Antonio Ospite Only Reported-By? > --- > > Eventually I had time to reload X11 an

[libav-devel] [PATCHv2] x11grab: fix drawing cursor in multi-screen setup

2014-09-19 Thread Antonio Ospite
don't draw the cursor. Also, don't follow the mouse or redraw the region when the pointer is on another screen. Signed-off-by: Antonio Ospite --- Hey Luca, let me know if/when you manage to test this yourself, some more feedback is always welcome. Changes since v1: - rework

Re: [libav-devel] [PATCH] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-15 Thread Antonio Ospite
On Fri, 12 Sep 2014 18:05:38 +0200 Luca Barbato wrote: > On 12/09/14 17:06, Antonio Ospite wrote: > > What do you think? > > I prepared a couple of patches that _should_ fix that. The main idea is > to just register to get the mouse event for the right window (the > select

Re: [libav-devel] [PATCH 1/2] x11grab: Check XFixesGetCursorImage return value

2014-09-12 Thread Antonio Ospite
1cc954 However I found out they are NOT strictly needed to fix follow_mouse in a multi-screen setup as I previously thought. Thanks, Antonio -- Antonio Ospite http://ao2.it A: Because it messes up the order in which people normally read text. See http://en.wikipedia.org/wiki/Posting_styl

Re: [libav-devel] [PATCH 2/2] x11grab: Check for XFixes availability at runtime

2014-09-12 Thread Antonio Ospite
vailable, cannot draw the mouse cursor\n"); > +x11grab->draw_mouse = 0; > +} > + > x11grab->frame_size = x11grab->width * x11grab->height * > image->bits_per_pixel / 8; > x11grab->dpy= dpy; > x11grab->time_base = (AVRat

Re: [libav-devel] [PATCH] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-12 Thread Antonio Ospite
On Mon, 8 Sep 2014 18:05:02 +0200 Antonio Ospite wrote: > On Mon, 08 Sep 2014 17:26:13 +0200 > Luca Barbato wrote: > > > On 08/09/14 13:39, Antonio Ospite wrote: > > > The code uses XFixes to retrieve the cursor coordinates, but XFixes > > > gives no informat

Re: [libav-devel] [PATCH] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-09 Thread Antonio Ospite
On Tue, 9 Sep 2014 12:41:39 +0200 Diego Biurrun wrote: > On Tue, Sep 09, 2014 at 12:28:43PM +0200, Antonio Ospite wrote: > > > > In the future I think I'll just prepare patches for one project > > (either libav or ffmpeg), it's not funny at all to deal with two &

Re: [libav-devel] [PATCH] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-09 Thread Antonio Ospite
On Mon, 08 Sep 2014 18:58:50 +0200 Luca Barbato wrote: > On 08/09/14 18:05, Antonio Ospite wrote: > > On Mon, 08 Sep 2014 17:26:13 +0200 > > Luca Barbato wrote: > > > >> On 08/09/14 13:39, Antonio Ospite wrote: [...] > >> The patch makes sense (pendin

Re: [libav-devel] [PATCH] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-08 Thread Antonio Ospite
On Mon, 08 Sep 2014 17:26:13 +0200 Luca Barbato wrote: > On 08/09/14 13:39, Antonio Ospite wrote: > > The code uses XFixes to retrieve the cursor coordinates, but XFixes > > gives no information of what screen the pointer is on; this results in > > always drawing the c

[libav-devel] [PATCH] avdevice/x11grab: fix cursor drawing in multi-screen setup

2014-09-08 Thread Antonio Ospite
-i ":0.1") the cursor was being drawn in the captured image even when the mouse pointer was actually on screen 0, which is wrong and visually confusing. Use XQueryPointer to check that the pointer is actually on the screen which is being captured. Signed-off-by: Antonio Ospite --- H

[libav-devel] [PATCH] x11grab: fix a memory leak exposed by valgrind

2012-03-16 Thread Antonio Ospite
When using "-f x11grab -i :0.0" valgrind reports a definitely lost memory block with this message: ==31544== 5 bytes in 1 blocks are definitely lost in loss record 1 of 2 ==31544==at 0x4026E68: memalign (in /usr/lib/valgrind/vgpreload_memcheck-amd64-linux.so) ==31544==by 0x4026F17: posix_