Thanks for the review
On 21/01/13 22:55, Diego Biurrun wrote:
> Thanks for getting back to this decoder!
>
> On Mon, Jan 21, 2013 at 08:25:39PM +0100, Jordi Ortiz wrote:
>> ---
>> Use VideoDSPContext.emulated_edge_mc() instead of ff_emultated_edge_mc_8()
>> Use
eachable from diracdec.c and diracdsp.c, then we can drop it.
--
Jordi Ortiz
nenjo...@gmail.com
http://www.jordiortiz.es
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
--- /dev/null
+++ b/libavcodec/dirac_dwt.c
@@ -0,0 +1,608 @@
+/*
+ * Copyright (C) 2009 David Conrad
+ * Copyright (C) 2012 Jordi Ortiz
+ *
+ * This file is part of Libav.
+ *
+ * Libav is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
2012/11/28 Måns Rullgård :
> Jordi Ortiz writes:
>
>> ---
>> Cosmetic changes to last version.
>>
>> libavcodec/dsputil.c | 8
>> libavcodec/dsputil.h | 27 +++
>> 2 files changed, 35 insertions(+)
>>
>> di
@@
+/*
+ * Copyright (C) 2009 David Conrad
+ * Copyright (C) 2012 Jordi Ortiz
+ *
+ * This file is part of Libav.
+ *
+ * Libav is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
---
Cosmetic changes to last version.
libavcodec/dsputil.c | 8
libavcodec/dsputil.h | 27 +++
2 files changed, 35 insertions(+)
diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c
index d4471dc..b0522c9 100644
--- a/libavcodec/dsputil.c
+++ b/libavcodec/ds
>>
>> Does the Dirac decoder compile standalone?
>
> It should, I'll follow the checklist in webpage carefully.
It compiles but when configured with arguments --disable-everything
--enable-decoder=dirac --enable-demuxer=dirac the drc files aren't
opened
./avconv -formats | grep dirac
avconv versi
n ...
Ok.
>> +static int dirac_unpack_prediction_parameters(DiracContext *s)
>> +{
>> +if (idx == 0) {
>> +s->plane[0].xblen = svq3_get_ue_golomb(gb);
>> +s->plane[0].yblen = svq3_get_ue_golomb(gb);
>> + s->plane[0].xbsep = svq3_get_ue_g
2012/11/5 Diego Biurrun :
> On Sat, Nov 03, 2012 at 10:14:05PM +0100, Jordi Ortiz wrote:
>> +static void spatial_compose97i_init2(DiracDWTCompose *cs, IDWTELEM *buffer,
>> + int height, int stride)
>> +
>> +static void spatial_compo
---
These modifications are (imho) the minimal needed for dirac.
libavcodec/dsputil.c | 8
libavcodec/dsputil.h | 6 ++
2 files changed, 14 insertions(+)
diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c
index 7a3fdba..66b4cc7 100644
--- a/libavcodec/dsputil.c
+++ b/libavcode
@@
+/*
+ * Copyright (C) 2009 David Conrad
+ * Copyright (C) 2012 Jordi Ortiz
+ *
+ * This file is part of Libav.
+ *
+ * Libav is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU Lesser General Public
+ * License as published by the Free Software Foundation; either
These modifications are (imho) the minimal needed for dirac.
---
libavcodec/dsputil.c |8
libavcodec/dsputil.h |6 ++
2 files changed, 14 insertions(+)
diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c
index 7a3fdba..2e2bda9 100644
--- a/libavcodec/dsputil.c
+++ b/liba
2012/10/18 Diego Biurrun
> On Thu, Oct 18, 2012 at 05:08:16PM +0300, Martin Storsjö wrote:
> > ---
> > libavformat/rtsp.h |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> OK
>
>
OK
Jordi
___
libav-devel mailing list
libav-devel@libav.o
---
libavcodec/Makefile |4 +--
libavcodec/dwt.c | 53 +
libavcodec/dwt.h | 12
libavcodec/snow.c|3 +-
libavcodec/snow_dwt.c| 73 ++
libavcodec/snow_dwt.h| 36
2012/9/23 Luca Barbato
> On 09/23/2012 07:00 PM, Jordi Ortiz wrote:
> > ---
> > libavcodec/x86/Makefile |2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
>
> I'd squash with 1
>
I have just sent another vers
---
libavcodec/Makefile |4 +--
libavcodec/dwt.c | 53 +
libavcodec/dwt.h | 12
libavcodec/snow.c|1 +
libavcodec/snow_dwt.c| 73 ++
libavcodec/snow_dwt.h| 36 +
2012/9/24 Luca Barbato
> On 09/24/2012 12:18 AM, Måns Rullgård wrote:
> > Why can't dirac call the function pointers in DSPContext like everything
> > else?
>
> IIRC those functions aren't exposed at all and used as building block
> for something else.
>
>
I can try to define a couple of new arra
> diff --git a/libavcodec/dirac_dwt.h b/libavcodec/dirac_dwt.h
> > new file mode 100644
> > index 000..ff0e4ba
> > --- /dev/null
> > +++ b/libavcodec/dirac_dwt.h
> > @@ -0,0 +1,74 @@
> > +#include "dwt.h"
> > +
> > +enum dwt_type {
> > +DWT_SNOW_DAUB9_7,
> > +DWT_SNOW_LEGALL5_3,
> > +
---
libavcodec/dirac_dwt.c | 571
libavcodec/dirac_dwt.h | 74 +++
libavcodec/dwt.h |7 +-
3 files changed, 650 insertions(+), 2 deletions(-)
create mode 100644 libavcodec/dirac_dwt.c
create mode 100644 libavcodec/dirac_dwt.h
dif
---
libavcodec/dsputil.c | 85 ++
libavcodec/dsputil.h | 36 +
2 files changed, 121 insertions(+)
diff --git a/libavcodec/dsputil.c b/libavcodec/dsputil.c
index 5c705ea..39360c5 100644
--- a/libavcodec/dsputil.c
+++ b/libavco
---
libavcodec/Makefile |4 ++--
libavcodec/dwt.c | 49 +++---
libavcodec/dwt.h |9 -
libavcodec/snow.c|2 +-
libavcodec/snow_dwt.c| 44 +
libavcodec/snow_dwt.h
Dirac needs this function
---
libavcodec/dwt.c |8
libavcodec/dwt.h |3 +++
2 files changed, 7 insertions(+), 4 deletions(-)
diff --git a/libavcodec/dwt.c b/libavcodec/dwt.c
index 4f43819..0e69acb 100644
--- a/libavcodec/dwt.c
+++ b/libavcodec/dwt.c
@@ -377,8 +377,8 @@ static voi
---
libavcodec/x86/Makefile |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/x86/Makefile b/libavcodec/x86/Makefile
index be4fd54..4bf0b70 100644
--- a/libavcodec/x86/Makefile
+++ b/libavcodec/x86/Makefile
@@ -16,7 +16,6 @@ MMX-OBJS +=
---
libavcodec/libschroedingerenc.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/libavcodec/libschroedingerenc.c b/libavcodec/libschroedingerenc.c
index 865b093..53dbb13 100644
--- a/libavcodec/libschroedingerenc.c
+++ b/libavcodec/libschroedingerenc.c
@@ -74,6 +74,9 @@ typ
2012/8/22 Diego Biurrun :
> On Wed, Aug 22, 2012 at 01:24:34PM +0200, Jordi Ortiz wrote:
>> From: Jordi Ortiz
^^
It seems that I created the original patch at uni =s
>
> LGTM, queued.
May I still change that? Can you amend it to nen
---
libavcodec/libschroedingerenc.c |9 +
1 file changed, 9 insertions(+)
diff --git a/libavcodec/libschroedingerenc.c b/libavcodec/libschroedingerenc.c
index 63d354e..ccfb145 100644
--- a/libavcodec/libschroedingerenc.c
+++ b/libavcodec/libschroedingerenc.c
@@ -220,6 +220,15 @@ stati
---
libavcodec/libschroedingerenc.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/libavcodec/libschroedingerenc.c b/libavcodec/libschroedingerenc.c
index 63d354e..1c7a418 100644
--- a/libavcodec/libschroedingerenc.c
+++ b/libavcodec/libschroedingerenc.c
@@ -220,6 +220,16 @@ sta
From: Jordi Ortiz
---
libavcodec/dirac.c | 80 +++-
1 file changed, 61 insertions(+), 19 deletions(-)
diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c
index 3b5d177..489b1f5 100644
--- a/libavcodec/dirac.c
+++ b/libavcodec/dirac.c
@@ -58,6
---
libavformat/avio.h| 11 +++
libavformat/aviobuf.c | 28
2 files changed, 39 insertions(+)
diff --git a/libavformat/avio.h b/libavformat/avio.h
index 10c0a12..526351f 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -346,6 +346,17 @@ int
---
libavformat/avio.h|9 +
libavformat/aviobuf.c | 24
2 files changed, 33 insertions(+)
diff --git a/libavformat/avio.h b/libavformat/avio.h
index 526351f..657357c 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -346,6 +346,15 @@ int avio_o
---
libavformat/avio.h| 11 +++
libavformat/aviobuf.c | 28
2 files changed, 39 insertions(+)
diff --git a/libavformat/avio.h b/libavformat/avio.h
index 10c0a12..0bfef89 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -346,6 +346,17 @@ int
> > +#if CONFIG_DIRAC_DECODER
> > +#define
> > DIRAC_MC(OPNAME)\
> > +void ff_ ## OPNAME ## _dirac_pixels8_c(uint8_t
> > *dst,\
> > + const uint8_t
> > *src[5], \
> > +
This is a reviewed version of the dirac decoder already sent to the ml
in May http://lists.libav.org/pipermail/libav-devel/2012-May/027302.html
This version has code style improvements and is in line with the actual
coding style of the libav project.
The code isn't bitexact if mv-precision is gre
From: Jordi Ortiz
---
libavcodec/dirac.c | 95 +---
1 file changed, 76 insertions(+), 19 deletions(-)
diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c
index 3b5d177..96915c8 100644
--- a/libavcodec/dirac.c
+++ b/libavcodec/dirac.c
@@ -58,6
---
libavcodec/diracdsp.c | 216 +++
libavcodec/diracdsp.h | 89
libavcodec/dsputil.c | 75 +++
libavcodec/dwt.c | 570 +
libavcodec/dwt.h | 98 -
5 files changed, 1047 insertions(+), 1 deletion
Missing patch in patchset.
Sorry
2012/8/21 Jordi Ortiz
> From: Jordi Ortiz
>
> ---
> libavcodec/dirac.c | 95
> +---
> 1 file changed, 76 insertions(+), 19 deletions(-)
>
> diff --git a/libavcodec/dirac.c b/libavcodec
Missing patch in patchset.
Sorry
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
From: Jordi Ortiz
---
libavcodec/dirac.c | 95 +---
1 file changed, 76 insertions(+), 19 deletions(-)
diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c
index 3b5d177..96915c8 100644
--- a/libavcodec/dirac.c
+++ b/libavcodec/dirac.c
@@ -58,6
---
libavcodec/dirac.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/libavcodec/dirac.c b/libavcodec/dirac.c
index 07329e3..3b5d177 100644
--- a/libavcodec/dirac.c
+++ b/libavcodec/dirac.c
@@ -123,20 +123,20 @@ static int parse_source_parameters(
Align =
---
libavformat/rtsp.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 7506d39..02c42dd 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1695,6 +1695,7 @@ static int udp_read_packet(AVFor
---
libavformat/rtsp.c | 21 +
1 file changed, 17 insertions(+), 4 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 7506d39..21be736 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1695,6 +1695,7 @@ static int udp_read_packet(AVFormatConte
---
libavformat/rtpdec.h |5 -
libavformat/rtpproto.c |5 -
2 files changed, 10 deletions(-)
diff --git a/libavformat/rtpdec.h b/libavformat/rtpdec.h
index 81b6f63..20257a7 100644
--- a/libavformat/rtpdec.h
+++ b/libavformat/rtpdec.h
@@ -71,11 +71,6 @@ void ff_rtp_send_punch_pac
---
libavformat/rtsp.c | 16
1 file changed, 12 insertions(+), 4 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 7506d39..5d0b101 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1695,6 +1695,7 @@ static int udp_read_packet(AVFormatContext *s
---
libavformat/avio.c | 15 +++
libavformat/rtpproto.c | 30 ++
libavformat/url.h |9 +
3 files changed, 46 insertions(+), 8 deletions(-)
diff --git a/libavformat/avio.c b/libavformat/avio.c
index 5acaf30..c5be970 100644
--- a/liba
Use ffurl_get_multi_file_handle() from now.
---
libavformat/rtpdec.h |5 -
libavformat/rtpproto.c |5 -
libavformat/rtsp.c |8 ++--
3 files changed, 6 insertions(+), 12 deletions(-)
diff --git a/libavformat/rtpdec.h b/libavformat/rtpdec.h
index 81b6f63..20257a7 10064
---
libavformat/rtsp.c |9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 7506d39..d42525d 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -1695,6 +1695,7 @@ static int udp_read_packet(AVFormatContext *s, RTSPStr
---
libavformat/avio.c |7 +++
libavformat/rtpproto.c | 30 ++
libavformat/url.h |9 +
3 files changed, 38 insertions(+), 8 deletions(-)
diff --git a/libavformat/avio.c b/libavformat/avio.c
index 5acaf30..f4f6bc0 100644
--- a/libavformat/
---
libavformat/avio.h|9 +
libavformat/aviobuf.c | 24
2 files changed, 33 insertions(+)
diff --git a/libavformat/avio.h b/libavformat/avio.h
index 2bd3ffa..ea5e408 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -346,6 +346,15 @@ int avio_o
---
libavformat/avio.h| 11 +++
libavformat/aviobuf.c | 29 +
2 files changed, 40 insertions(+)
diff --git a/libavformat/avio.h b/libavformat/avio.h
index 10c0a12..2bd3ffa 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -346,6 +346,17 @@ int
2012/8/16 Andrey Utkin :
> 2012/8/13 Jordi Ortiz :
>> This mail starts a serie of patches that at the end will allow accepting
>> multiple connections to only one AVIOContext generating a new AVIOContext to
>> control the new connection.
>>
>> The motivation for t
---
doc/protocols.texi |5 +
libavformat/rtmpproto.c | 523 ++-
libavformat/version.h |4 +-
3 files changed, 525 insertions(+), 7 deletions(-)
diff --git a/doc/protocols.texi b/doc/protocols.texi
index ea5706f..086a249 100644
--- a/doc/
---
doc/protocols.texi |5 +
libavformat/rtmpproto.c | 520 ++-
libavformat/version.h |4 +-
3 files changed, 520 insertions(+), 9 deletions(-)
diff --git a/doc/protocols.texi b/doc/protocols.texi
index bdb3e8c..1194f3d 100644
--- a/doc/
Emacs config as it is doesn't work, introduces tabs and doesn't show trailing
whitespaces.
---
doc/developer.texi |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/developer.texi b/doc/developer.texi
index 60f6d05..ae9609d 100644
--- a/doc/developer.texi
+++ b/doc/dev
>
> I'm not sure how you meant this to be used. Do you open a normal tcp
> context (in which mode would you open, would you set the listen/accept
> flags?), and then call this afterwards? What is this then supposed to do?
>
Initially I added the listen flag to the tcp_open. Then I added the
accept
>> +int avio_accept(AVIOContext *srvavio, AVIOContext **clntavio, int
>> timeout) {
>> +URLContext *srvctx = srvavio->opaque;
>
>
> In general, you can't make this assumption - the AVIOContext could also be
> custom allocated with a different opaque context. A totally proper
> implementation of
>>
>> + * Use an initialized AVIOContext to accept an incomming new connection
>
>
> incoming
My right hand goes automatically for the double m =( Sorry.
>
>
> The commit message looks wrong and maybe you might rework the
the ...
>
>
>> +int avio_accept(AVIOContext *srvavio, AVIOContext **
---
libavformat/tcp.c | 106 ++---
1 file changed, 101 insertions(+), 5 deletions(-)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index 5888028..100e559 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -28,6 +28,8 @@
#include
#end
---
libavformat/url.h |1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/url.h b/libavformat/url.h
index d231dbf..05f94ae 100644
--- a/libavformat/url.h
+++ b/libavformat/url.h
@@ -86,6 +86,7 @@ typedef struct URLProtocol {
const AVClass *priv_data_class;
int flags;
---
libavformat/avio.h|9 +
libavformat/aviobuf.c | 22 ++
2 files changed, 31 insertions(+)
diff --git a/libavformat/avio.h b/libavformat/avio.h
index 703b913..f3c787e 100644
--- a/libavformat/avio.h
+++ b/libavformat/avio.h
@@ -346,6 +346,15 @@ int avio_ope
---
libavformat/tcp.c | 118 +
1 file changed, 118 insertions(+)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index bdaab7f..5888028 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -30,6 +30,9 @@
typedef struct TCPContext {
---
libavformat/url.h |1 +
1 file changed, 1 insertion(+)
diff --git a/libavformat/url.h b/libavformat/url.h
index 0f0de78..d231dbf 100644
--- a/libavformat/url.h
+++ b/libavformat/url.h
@@ -86,6 +86,7 @@ typedef struct URLProtocol {
const AVClass *priv_data_class;
int flags;
This mail starts a serie of patches that at the end will allow accepting
multiple connections to only one AVIOContext generating a new AVIOContext to
control the new connection.
The motivation for these patches is allowing a server to use any/some of the
possibilities offered by libavformat provi
>
> Here you need to set rt->out_chunk_size to AV_RB32(pkt->data). Namely, this
> is the hack that made it work (more or less) even if we had only one
> chunk_size variable before. When the server sets the chunk size, we here set
> our outgoing chunk size to the same, so that the code that only had
>
> Could you explain why it is needed ?
>
I'll try.
Martin pointed that the chunk_size isn't the same for both sides and
each could be changed at any time. Indeed in some cases in a single
packet with multiple chunks one of those could be a chunk size one,
which isn't supported right now but Mar
---
libavformat/rtmpproto.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index c85424e..0e6daf1 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -68,7 +68,8 @@ typedef struct
---
doc/protocols.texi |5 +
libavcodec/version.h|2 +-
libavformat/rtmp.h |1 +
libavformat/rtmpproto.c | 475 ++-
4 files changed, 476 insertions(+), 7 deletions(-)
diff --git a/doc/protocols.texi b/doc/protocols.texi
index
> > -//TODO: check for the messages sent for wrong state?
> > +if (pkt->data[0] != AMF_DATA_TYPE_STRING) {
> > +av_log(s, AV_LOG_ERROR, "No string method found in invoke
> > packet\n");
> > +return AVERROR_INVALIDDATA;
> > +}
> > +
May be you could use the ff_amf_read_s
> Some initial comments just by reading through, haven't gotten to testing
> it yet...
Thanks!
>> #define RTMP_HANDSHAKE_PACKET_SIZE 1536
>> +#define RTMP_HANDSHAKE_PACKET_ARRAY_SIZE 1528
>
>
> This doesn't feel too intuitive at all - a reader of this code won't have
> a clue about what this is
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 42 ++
2 files changed, 87 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..8228e28 100644
--- a/libavformat/rtm
Version with modifications suggested by Luca and Martin.
---
doc/protocols.texi |5 +
libavformat/rtmp.h |1 +
libavformat/rtmpproto.c | 534 +--
3 files changed, 519 insertions(+), 21 deletions(-)
diff --git a/doc/protocols.texi b/do
2012/7/29 Luca Barbato
>
> On 07/28/2012 09:12 PM, Jordi Ortiz wrote:
> > ---
> > doc/protocols.texi |5 +
> > libavformat/rtmp.h |1 +
> > libavformat/rtmpproto.c | 532
> > +--
> > 3 file
---
doc/protocols.texi |5 +
libavformat/rtmp.h |1 +
libavformat/rtmpproto.c | 532 +--
3 files changed, 517 insertions(+), 21 deletions(-)
diff --git a/doc/protocols.texi b/doc/protocols.texi
index ff872fc..cf15b36 100644
--- a/doc/
Enhanced doxygen
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 39 +++
2 files changed, 84 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..3c13709 100644
--- a/l
---
libavformat/rtmppkt.c | 45 +
libavformat/rtmppkt.h | 39 +++
2 files changed, 84 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..19ac890 100644
--- a/libavformat/rtmppk
>
> +str[stringlen] = '\0';
>> +*strlen = stringlen;
>>
>
> You could perhaps use the *strlen parameter both for the buffer size as
> both input and output, so you'd need one parameter less.
I dislike this. I feel it is much less intuitive accesing a pointer to
extract the maximum size o
2012/7/27 Luca Barbato
> On 07/27/2012 08:51 PM, Martin Storsjö wrote:
> >> +int ff_amf_read_bool(const uint8_t **src, int src_size, int *val)
> >> +{
> >> +GetByteContext bsc;
> >> +bytestream2_init(&bsc, *src, src_size);
> >> +if (bytestream2_get_byte(&bsc) != AMF_DATA_TYPE_BOOL)
>
---
libavformat/rtmppkt.c | 57 +
libavformat/rtmppkt.h | 43 +
2 files changed, 100 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..c592f61 100644
--- a/libavformat/rtm
Without this patch a user a bit absent-minded may not notice that the connection
doesn't work because port is missing.
---
libavformat/tcp.c |7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index 1d953e3..bdaab7f 100644
--- a/libav
Without this patch a user a bit absent-minded may not notice that the connection
doesn't work because port is missing.
---
libavformat/sctp.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/libavformat/sctp.c b/libavformat/sctp.c
index 7bcb5ae..b8ab63e 100644
--- a/liba
+ff_rtmp_packet_destroy(&rpkt);
> > +}
> > +return 0;
> > +}
>
>
> Might be nice having this function split in smaller ones.
>
ok
>
> > +
>
> > +rt->flv_off = 0;
> > +memcpy(rt->flv_data, "FLV\1\5\0\0\0\011\0\0\0\0&q
may be ping?
___
libav-devel mailing list
libav-devel@libav.org
https://lists.libav.org/mailman/listinfo/libav-devel
---
doc/protocols.texi |8 +
libavformat/rtsp.c | 30 ++-
libavformat/rtsp.h | 12 +
libavformat/rtspcodes.h | 14 +
libavformat/rtspdec.c | 662 ---
5 files changed, 688 insertions(+), 38 deletions(-)
diff --git a/doc/protoc
This is required for the upcoming RTSP listen mode.
---
libavformat/rtsp.c |6 +++---
libavformat/rtsp.h |5 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 551884b..d4206a1 100644
--- a/libavformat/rtsp.c
+++ b/libavformat
We need to support the nonstandard mode=receive, for compatibility with older
libavformat clients.
---
libavformat/rtsp.c |8
libavformat/rtsp.h |3 +++
2 files changed, 11 insertions(+)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 76b5df8..551884b 100644
--- a/lib
>>
>> Would it be better something like: ?
>>
>> -
>> rtsp: convert rtsp_open_transport_ctx() to non-static.
>>
>> The RTSP listen mode, which is implemented in rtspdec.c, needs this
>> functionality and in consequence more visibility for
>> rtsp_open_transport_ctx() is needed.
>> -
>
>
> Y
> Ok as well, but you might try to improve the commit message. You shouldn't
> try to cram everything into the first line - try to make that one as short as
> possible while still describing the commit. If you need to say more than
> that, add extra full sentences below.
>
Would it be better so
> Documentation missing ^^; The rest looks fine after a cursory look, I'll
> check better later.
Documentation is being written.
I have patched locally check_sessionid(). I have removed session_id
param as RTSPState (s->priv_data) contains the session to be used as
reference and also I added a wa
---
libavformat/rtsp.c | 30 ++-
libavformat/rtsp.h | 12 ++
libavformat/rtspcodes.h | 14 ++
libavformat/rtspdec.c | 549 ---
4 files changed, 566 insertions(+), 39 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
in
---
libavformat/rtsp.c |6 +++---
libavformat/rtsp.h |5 +
2 files changed, 8 insertions(+), 3 deletions(-)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 551884b..d4206a1 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -595,7 +595,7 @@ void ff_rtsp_close_strea
---
libavformat/rtspdec.c | 28 ++--
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c
index 063e825..6226f41 100644
--- a/libavformat/rtspdec.c
+++ b/libavformat/rtspdec.c
@@ -31,6 +31,20 @@
#include "rdt.h"
#
---
libavformat/rtsp.c |8
libavformat/rtsp.h |3 +++
2 files changed, 11 insertions(+)
diff --git a/libavformat/rtsp.c b/libavformat/rtsp.c
index 76b5df8..551884b 100644
--- a/libavformat/rtsp.c
+++ b/libavformat/rtsp.c
@@ -749,6 +749,14 @@ static void rtsp_parse_transport(RTSPM
This code allows receiving a stream from a client with the PUBLISH command.
---
libavformat/rtmpproto.c | 470 ---
1 file changed, 449 insertions(+), 21 deletions(-)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index 5342be8..e901b7e
---
libavformat/rtmppkt.c | 38 ++
libavformat/rtmppkt.h | 37 +
2 files changed, 75 insertions(+)
diff --git a/libavformat/rtmppkt.c b/libavformat/rtmppkt.c
index 4ce238d..3251b71 100644
--- a/libavformat/rtmppkt.c
+++ b
---
libavformat/tcp.c | 11 ++-
1 file changed, 10 insertions(+), 1 deletion(-)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index 6a65860..e5be465 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -43,7 +43,7 @@ static int tcp_open(URLContext *h, const char *uri, int flag
---
libavformat/rtmpproto.c |4
1 file changed, 4 insertions(+)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index b48274b..5342be8 100644
--- a/libavformat/rtmpproto.c
+++ b/libavformat/rtmpproto.c
@@ -959,6 +959,10 @@ static int rtmp_parse_result(URLContext *s, RTMPCo
I think that Samuel was right with his appreciation although the messages were
shown only on DEBUG.
---
libavformat/rtmpproto.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index b48274b..90345e4 100644
--- a/libavformat/rtmpproto.c
+
Without this patch "Unknown packet type received" message is shown and could
lead to confusion
---
libavformat/rtmpproto.c |6 ++
1 file changed, 6 insertions(+)
diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c
index b48274b..d96510c 100644
--- a/libavformat/rtmpproto.c
+++
---
libavformat/tcp.c |5 -
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index 1546446..c5677fe 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -66,7 +66,10 @@ static int tcp_open(URLContext *h, const char *uri, int
flags)
---
libavformat/tcp.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/libavformat/tcp.c b/libavformat/tcp.c
index e77e4c5..1546446 100644
--- a/libavformat/tcp.c
+++ b/libavformat/tcp.c
@@ -64,6 +64,8 @@ static int tcp_open(URLContext *h, const char *uri, int flags)
hints.ai_family =
> +if (listen_socket)
>> +hints.ai_flags |= AI_PASSIVE;
>>if (ret) {
>>
>
> You set the flag _after_ calling getaddrinfo?
>
> Ups, I did the modifications and then split the commits, that line go away
on the following commit. Patch comming.
__
1 - 100 of 159 matches
Mail list logo
