Re: [libav-devel] [PATCH 5/6] avconv: use stream copy by default when possible.

2011-08-16 Thread Rob
ld prefer mandatory explicit specification of the target format. I recognise that users might have other expectations and want to write a shorter command line or not have to think about what the command could do and expect it to do what they want it to do. Those two seem to suggest that p

Re: [libav-devel] [PATCH 2/2] Remove unused and non-compiling vestigial g729 decoder

2011-07-20 Thread Rob
> g729dec.c.) > + * uses 13017 instead. >  */ >  #define SHARP_MAX 0.79449462890625 I feel this information is useful - perhaps swap "g729dec.c" for "bit exact G.729". The rest is OK for me. Regards, Rob ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 1/2] Remove unused code under G729_BITEXACT #ifdef.

2011-07-20 Thread Rob
   4 -- >  3 files changed, 0 insertions(+), 100 deletions(-) Looks OK to me. Regards, Rob ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] Remove unused and non-compiling vestigial g729 decoder

2011-07-20 Thread Rob
On 20 July 2011 15:14, Diego Biurrun wrote: > On Wed, Jul 20, 2011 at 02:21:37PM +0200, Rob wrote: >> On 19 July 2011 15:39, Diego Biurrun wrote: >> > On Tue, Jul 19, 2011 at 08:48:07AM +0200, Rob wrote: >> >> On 15 July 2011 23:48, Diego Biurrun w

Re: [libav-devel] [PATCH] Remove unused and non-compiling vestigial g729 decoder

2011-07-20 Thread Rob
On 19 July 2011 15:39, Diego Biurrun wrote: > On Tue, Jul 19, 2011 at 08:48:07AM +0200, Rob wrote: >> On 15 July 2011 23:48, Diego Biurrun wrote: >> > Somebody please doublecheck that I was not overeager with the unused >> > functions in those *celp*.c files, pos

Re: [libav-devel] [PATCH] Remove unused and non-compiling vestigial g729 decoder

2011-07-18 Thread Rob
- */ > -int16_t ff_acelp_decode_gain_code( > -    DSPContext *dsp, > -    int gain_corr_factor, > -    const int16_t* fc_v, > -    int mr_energy, > -    const int16_t* quant_energy, > -    const int16_t* ma_prediction_coeff, > -    int subframe_size, > -    int max_pred_order); Because of the remark, I would suggest leaving this where it is. Regards, Rob ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] Ass missing mathematics.h includes

2011-07-03 Thread Rob
Hello, libavcodec/lib{vorbis,vpxenc}.c both require mathematics.h for av_rescale* usage. Regards, Rob From 2b2685b62fcde8def557b5abbfa3db7a6b0b2d78 Mon Sep 17 00:00:00 2001 From: Robert Swain Date: Mon, 4 Jul 2011 08:44:49 +0200 Subject: [PATCH] vorbis: vpxenc: Add missing include for

Re: [libav-devel] [PATCH] configure: Make vaapi configuration work

2011-06-05 Thread Rob
2011/5/22 Måns Rullgård : > Rob writes: >> $subj >> >> Perhaps just an addition of a default "enable vaapi" line is required, >> I'm not sure. Too much very convenient and useful macro indirection >> for me to want to sink time into

[libav-devel] [PATCH] configure: Make vaapi configuration work

2011-05-22 Thread Rob
$subj Perhaps just an addition of a default "enable vaapi" line is required, I'm not sure. Too much very convenient and useful macro indirection for me to want to sink time into finding out. :) Regards, Rob From 35fc282ada2b8f130d0b4d541b5ff57fd36a1244 Mon Sep 17 00:00:00 2001 Fro

Re: [libav-devel] [Announcement] FFmtech board of directors election

2011-05-19 Thread Rob
stitutes activity? I have been active on the mailing lists from time to time, I think I conducted a review or two and I mentored a student in last year's SoC - does that count? Regards, Rob ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] GPL License Violation

2011-05-17 Thread Rob
ra-cflags=-I/extlib/ > include --extra-ldflags=-L/extlib/lib --enable-libmp3lame --enable-libtheora > --enable-libvorbis --enable-gpl --enable-libx264 --enable-libxvid > --enable-libfaad --enable-nonfree --enable-libfaac Actually the nonfree option takes precedence. This binary is not

Re: [libav-devel] [PATCH] Announcement for 0.7_beta2

2011-05-12 Thread Rob
n SIMD instruction set. Yes, it is available in Sandy Bridge processors, but I don't think the term 'AVX processors' alone is correct. Perhaps 'AVX optimisations (available on, for example, Sandy Bridge processors)' Best regards, Rob