Re: [libav-devel] [FFmpeg-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

2016-12-26 Thread Ronald S. Bultje
Hi, On Mon, Dec 26, 2016 at 4:53 AM, Henrik Gramner <hen...@gramner.com> wrote: > On Mon, Dec 26, 2016 at 2:32 AM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > I know I'm terribly nitpicking here for the limited scope of the comment, > > but this only m

Re: [libav-devel] [PATCH] x86inc: Avoid using eax/rax for storing the stack pointer

2016-12-25 Thread Ronald S. Bultje
Hi, On Sun, Dec 25, 2016 at 2:24 PM, Henrik Gramner wrote: > When allocating stack space with an alignment requirement that is larger > than the current stack alignment we need to store a copy of the original > stack pointer in order to be able to restore it later. > > If we

Re: [libav-devel] [PATCH 2/3] vp9: Add bsf to recombine frames/superframes

2016-11-30 Thread Ronald S. Bultje
Hi, On Wed, Nov 30, 2016 at 6:48 AM, Mark Thompson <s...@jkqxz.net> wrote: > On 30/11/16 03:37, Ronald S. Bultje wrote: > > Hi, > > > > On Mon, Nov 28, 2016 at 6:50 PM, Mark Thompson <s...@jkqxz.net> wrote: > > > >> --- > >> I

Re: [libav-devel] [PATCH 2/3] vp9: Add bsf to recombine frames/superframes

2016-11-29 Thread Ronald S. Bultje
Hi, On Mon, Nov 28, 2016 at 6:50 PM, Mark Thompson wrote: > --- > Incomplete, but enough to work with the encoder in patch 3. > > Todo: > * Superframe splitting. > >From what I understand, Anton ported the vp9 parser into a BSF, which resolves this. > * More options to

Re: [libav-devel] [PATCH] checkasm: vp9dsp: Benchmark the dc-only version of idct_idct separately

2016-11-17 Thread Ronald S. Bultje
Hi, On Thu, Nov 17, 2016 at 7:37 AM, Martin Storsjö <mar...@martin.st> wrote: > On Thu, 17 Nov 2016, Ronald S. Bultje wrote: > > Hi, >> >> On Mon, Nov 14, 2016 at 4:46 PM, Martin Storsjö <mar...@martin.st> wrote: >> >> The dc-only mo

Re: [libav-devel] [PATCH] checkasm: vp9dsp: Benchmark the dc-only version of idct_idct separately

2016-11-17 Thread Ronald S. Bultje
Hi, On Mon, Nov 14, 2016 at 4:46 PM, Martin Storsjö wrote: > The dc-only mode is already checked to work correctly above, but this > allows benchmarking this mode for performance tuning, and allows making > sure that it actually is correctly hooked up. > --- >

Re: [libav-devel] [PATCH] checkasm: Add tests for vp8dsp

2016-07-09 Thread Ronald S. Bultje
Hi, On Fri, Jul 8, 2016 at 3:00 PM, Martin Storsjö <mar...@martin.st> wrote: > On Fri, 8 Jul 2016, Ronald S. Bultje wrote: > > Hi, >> >> On Thu, Jul 7, 2016 at 7:08 PM, Janne Grunau <janne-li...@jannau.net> >> wrote: >> >> +#define SRC_

Re: [libav-devel] [PATCH] checkasm: Add tests for vp8dsp

2016-07-08 Thread Ronald S. Bultje
Hi, On Thu, Jul 7, 2016 at 7:08 PM, Janne Grunau wrote: > > +#define SRC_BUF_STRIDE 32 > > +#define SRC_BUF_SIZE ((size + 5) * SRC_BUF_STRIDE) > > +// The 2 * stride + 2 offset is necessary to avoid reading out of > bounds, > > that sounds a little misleading. just

Re: [libav-devel] [PATCH 2/6] hevc: Separate adding residual to prediction from IDCT

2016-07-07 Thread Ronald S. Bultje
Hi, On Thu, Jul 7, 2016 at 10:53 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Thu, Jul 7, 2016 at 9:52 AM, Alexandra Hájková < > alexandra.khirn...@gmail.com> wrote: > >> On Thu, Jul 7, 2016 at 1:53 PM, Ronald S. Bultje <rsbul...@gmail.com

Re: [libav-devel] [PATCH 2/6] hevc: Separate adding residual to prediction from IDCT

2016-07-07 Thread Ronald S. Bultje
Hi, On Thu, Jul 7, 2016 at 9:52 AM, Alexandra Hájková < alexandra.khirn...@gmail.com> wrote: > On Thu, Jul 7, 2016 at 1:53 PM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > On Thu, Jul 7, 2016 at 5:25 AM, Alexandra Hájková < > > alexandra.khirn.

Re: [libav-devel] [PATCH 2/6] hevc: Separate adding residual to prediction from IDCT

2016-07-07 Thread Ronald S. Bultje
Hi, On Thu, Jul 7, 2016 at 5:25 AM, Alexandra Hájková < alexandra.khirn...@gmail.com> wrote: > else if (lc->cu.pred_mode == MODE_INTRA && c_idx == 0 && > log2_trafo_size == 2) > -s->hevcdsp.transform_4x4_luma_add(dst, coeffs, stride); > +

Re: [libav-devel] [PATCH] vp8dsp: Clarify the first dimension of the mc function tables

2016-07-05 Thread Ronald S. Bultje
Hi, one more thing... On Tue, Jul 5, 2016 at 6:36 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > On Tue, Jul 5, 2016 at 5:58 AM, Martin Storsjö <mar...@martin.st> wrote: > >> On Fri, 1 Jul 2016, Martin Storsjö wrote: >> >>> Index 0 is 16x16, 1 is 8

Re: [libav-devel] [PATCH] vp8dsp: Clarify the first dimension of the mc function tables

2016-07-05 Thread Ronald S. Bultje
Hi, On Tue, Jul 5, 2016 at 5:58 AM, Martin Storsjö wrote: > On Fri, 1 Jul 2016, Martin Storsjö wrote: > > Index 0 is 16x16, 1 is 8x8, 2 is 4x4. >> --- >> libavcodec/vp8dsp.h | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/libavcodec/vp8dsp.h

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-26 Thread Ronald S. Bultje
Hi, On Wed, May 25, 2016 at 7:38 PM, Kieran Kunhya <kier...@obe.tv> wrote: > On Wed, 25 May 2016 at 19:37 Vittorio Giovara <vittorio.giov...@gmail.com> > wrote: > > > On Wed, May 25, 2016 at 10:49 AM, Ronald S. Bultje <rsbul...@gmail.com> > > wrote: >

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-25 Thread Ronald S. Bultje
Hi, On Wed, May 25, 2016 at 10:59 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Wed, May 25, 2016 at 10:49:12AM -0400, Ronald S. Bultje wrote: > > It's not like this is to be committed tomorrow, right? So take your time, > > not urgent... > > Ummm, no; it's ove

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-25 Thread Ronald S. Bultje
Hi, On Wed, May 25, 2016 at 9:54 AM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 25/05/16 15:32, Ronald S. Bultje wrote: > > I agree, ARM 32bit results would be very interesting. > > The odroid images I have are arm64 only (and I'm still figuring out how > to set it u

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-25 Thread Ronald S. Bultje
Hi, On Wed, May 25, 2016 at 8:20 AM, Luca Barbato wrote: > On 25/05/16 12:31, Anton Khirnov wrote: > > All the results quoted here seem to be from x86 and 32bit x86 is not > > really all that relevant these days. Did anyone do any ARM tests? > > On power8 I'm seeing a 17%

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-24 Thread Ronald S. Bultje
Hi, On Tue, May 24, 2016 at 3:47 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 23/05/16 17:01, Ronald S. Bultje wrote: > > Howdy, > > Interesting. I spent a bit of time on it myself. > > I run some benchmark using a yuv422 file of the right size from the >

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-23 Thread Ronald S. Bultje
Howdy, On Sun, May 22, 2016 at 5:27 AM, Alexandra Hájková < alexandra.khirn...@gmail.com> wrote: > > Do you have a tree for testing somewhere? > > Yes, there's github branch: > https://github.com/sasshka/libav/tree/get_bits3. > Thanks! > If I find decoders that are slower on 32bit after the

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-21 Thread Ronald S. Bultje
Hi, On Sat, May 21, 2016 at 2:39 AM, Alexandra Hájková < alexandra.khirn...@gmail.com> wrote: > > > > I noticed proresdec (for example) is not converted to the new bitstream > > reader. Is there a reason for that? > > Not all the sets are sent yet, I'm sending them gradually to make the >

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-20 Thread Ronald S. Bultje
Hi, On Fri, May 20, 2016 at 4:11 PM, Alexandra Hájková < alexandra.khirn...@gmail.com> wrote: > This set is compilable together only. I noticed proresdec (for example) is not converted to the new bitstream reader. Is there a reason for that? Also, since this patch basically converts the

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-04-27 Thread Ronald S. Bultje
Hi, On Wed, Apr 27, 2016 at 7:37 AM, Alexandra Hájková < alexandra.khirn...@gmail.com> wrote: > --- > libavcodec/bitstream.h | 475 > + > 1 file changed, 475 insertions(+) > create mode 100644 libavcodec/bitstream.h > > diff --git

Re: [libav-devel] [PATCH 02/15] lavc: add a new bitstream filtering API

2016-02-25 Thread Ronald S. Bultje
Hi, On Thu, Feb 25, 2016 at 2:40 PM, Anton Khirnov <an...@khirnov.net> wrote: > Quoting Ronald S. Bultje (2016-02-25 19:48:10) > > Hi, > > > > given I'm writing a BSF right now... > > > > On Thu, Feb 25, 2016 at 10:05 AM, Anton Khirnov <an...@khirnov

Re: [libav-devel] [PATCH 02/15] lavc: add a new bitstream filtering API

2016-02-25 Thread Ronald S. Bultje
Hi, given I'm writing a BSF right now... On Thu, Feb 25, 2016 at 10:05 AM, Anton Khirnov wrote: > +int (*filter)(AVBSFContext *ctx, AVPacket *pkt); > How do we skip packets? Like, say we have a BSF that merges two packets together into one, how does that work? Maybe it

Re: [libav-devel] [FFmpeg-devel] [PATCHv3] avcodec: Cineform HD Decoder

2016-01-25 Thread Ronald S. Bultje
Hi, On Sun, Jan 24, 2016 at 7:34 PM, Kieran Kunhya wrote: > +static inline void filter(int16_t *output, ptrdiff_t out_stride, int16_t > *low, ptrdiff_t low_stride, > + int16_t *high, ptrdiff_t high_stride, int len, > uint8_t clip) Should this be a

Re: [libav-devel] [PATCH 4/8] x86inc: Preserve arguments when allocating stack space

2016-01-18 Thread Ronald S. Bultje
Hi, On Mon, Jan 18, 2016 at 9:37 AM, Henrik Gramner <hen...@gramner.com> wrote: > On Mon, Jan 18, 2016 at 2:35 PM, Ronald S. Bultje <rsbul...@gmail.com> > wrote: > > On Sun, Jan 17, 2016 at 6:21 PM, Henrik Gramner <hen...@gramner.com> > wrote: > >>

Re: [libav-devel] [PATCH 4/8] x86inc: Preserve arguments when allocating stack space

2016-01-18 Thread Ronald S. Bultje
Hi, On Sun, Jan 17, 2016 at 6:21 PM, Henrik Gramner wrote: > When allocating stack space with a larger alignment than the known stack > alignment a temporary register is used for storing the stack pointer. > Ensure that this isn't one of the registers used for passing

Re: [libav-devel] [PATCH 8/8] hevcdsp: add x86 SIMD for MC

2015-08-21 Thread Ronald S. Bultje
Hi, On Wed, Aug 19, 2015 at 7:31 PM, James Almer jamr...@gmail.com wrote: On 19/08/15 8:23 PM, Ronald S. Bultje wrote: Hi, On Wed, Aug 19, 2015 at 6:34 PM, James Almer jamr...@gmail.com wrote: On 19/08/15 4:43 PM, Anton Khirnov wrote: --- libavcodec/hevc.c | 6

Re: [libav-devel] [PATCH 8/8] hevcdsp: add x86 SIMD for MC

2015-08-21 Thread Ronald S. Bultje
Hi, On Fri, Aug 21, 2015 at 10:02 AM, Anton Khirnov an...@khirnov.net wrote: Quoting Ronald S. Bultje (2015-08-21 14:24:47) Hi, On Wed, Aug 19, 2015 at 7:31 PM, James Almer jamr...@gmail.com wrote: On 19/08/15 8:23 PM, Ronald S. Bultje wrote: Hi, On Wed, Aug 19, 2015 at 6

Re: [libav-devel] [PATCH 8/8] hevcdsp: add x86 SIMD for MC

2015-08-19 Thread Ronald S. Bultje
Hi, On Wed, Aug 19, 2015 at 6:34 PM, James Almer jamr...@gmail.com wrote: On 19/08/15 4:43 PM, Anton Khirnov wrote: --- libavcodec/hevc.c | 6 +- libavcodec/hevc.h | 2 +- libavcodec/hevcdsp.c | 24 +- libavcodec/hevcdsp.h | 5 +-

Re: [libav-devel] [PATCH 5/6] Postpone API-incompatible changes until the next bump

2015-08-16 Thread Ronald S. Bultje
Hi, On Sat, Aug 8, 2015 at 7:37 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: Signed-off-by: Andreas Cadhalpun andreas.cadhal...@googlemail.com --- libavcodec/version.h | 54 +-- libavfilter/version.h | 10 +-

Re: [libav-devel] [FFmpeg-devel] [PATCH 3/6] avutil: delay removal of the PIX_FMT_* flags

2015-08-09 Thread Ronald S. Bultje
Hi, On Sun, Aug 9, 2015 at 11:54 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: Hi, On 09.08.2015 12:57, Ronald S. Bultje wrote: Yeah, I'm with this. Andreas, the correct fix is to update applications, even if that means vendor-specific patches in Debian

Re: [libav-devel] Remote participation options for IETF session on MKV/FFV1 at July 22 @ 9 CEST

2015-07-21 Thread Ronald S. Bultje
Hi, On Tue, Jul 21, 2015 at 12:58 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Tue, Jul 21, 2015 at 11:52:55AM -0400, Dave Rice wrote: Hi all, [...] The FFV1 specification work may also be reviewed at github [5] with recent rendering in HTML [6] and PDF [7] available. To

Re: [libav-devel] [FFmpeg-devel] [PATCH] wmavoice: limit wmavoice_decode_packet return value to packet size

2015-06-28 Thread Ronald S. Bultje
Hi, On Sun, Jun 28, 2015 at 5:28 AM, Andreas Cadhalpun andreas.cadhal...@googlemail.com wrote: On 27.06.2015 23:01, Michael Niedermayer wrote: On Sat, Jun 27, 2015 at 08:36:15PM +0200, Andreas Cadhalpun wrote: Claiming to have decoded more bytes than the packet size is wrong.

Re: [libav-devel] [PATCH] h264_cabac: Break infinite loops

2015-01-14 Thread Ronald S. Bultje
Hi, On Tue, Jan 13, 2015 at 8:43 AM, Luca Barbato lu_z...@gentoo.org wrote: On 13/01/15 13:43, Martin Storsjö wrote: From: Michael Niedermayer michae...@gmx.at This fixes out of array reads and/or infinite loops. CC: libav-sta...@libav.org Found-by: Mateusz j00ru Jurczyk and Gynvael

Re: [libav-devel] [RFC] jpeg2000: MCT in SSE

2014-09-29 Thread Ronald S. Bultje
Hi, On Mon, Sep 29, 2014 at 7:07 AM, Luca Barbato lu_z...@gentoo.org wrote: On 29/09/14 11:35, Hendrik Leppkes wrote: On Mon, Sep 29, 2014 at 9:33 AM, Nicolas Bertrand nicoinatte...@gmail.com wrote: Finally a 1st optimization patch for jpeg2000! To start: an easy one. The main help I

Re: [libav-devel] livestream.com us-local news channels

2014-09-22 Thread Ronald S. Bultje
Hi, On Mon, Sep 22, 2014 at 12:35 PM, Georg Stein georg_st...@t-online.de wrote: when i call int result = avformat_open_input(this-avFormatContext, fileNameChar, fmt, NULL); the result is 0 but the AVFormatContext does not has any codec/stream in the command line tool from ffmepg can

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Ronald S. Bultje
Hi, On Fri, Aug 29, 2014 at 1:30 PM, Kieran Kunhya kier...@obe.tv wrote: You're throwing a blob at me without individual author's contribution, I don't think that's appropriate. You've decided to selectively ignore the second part of the message. As I read that it says he is not happy with

Re: [libav-devel] Common mailing-list for API evolutions

2014-08-29 Thread Ronald S. Bultje
Hi, On Fri, Aug 29, 2014 at 3:51 PM, Diego Biurrun di...@biurrun.de wrote: Am 29.08.2014 20:03 schrieb Ronald S. Bultje rsbul...@gmail.com: On Fri, Aug 29, 2014 at 1:30 PM, Kieran Kunhya kier...@obe.tv wrote: You're throwing a blob at me without individual author's contribution, I

Re: [libav-devel] [PATCH 2/2] lavc: Add a VP9 decoder

2013-11-14 Thread Ronald S. Bultje
Hi, On Thu, Nov 14, 2013 at 7:58 PM, Luca Barbato lu_z...@gentoo.org wrote: From: Ronald S. Bultje rsbul...@gmail.com Originally written by Ronald S. Bultje rsbul...@gmail.com and Clément Bœsch u...@pkh.me Further contributions by: Please define the further contributions. I am

Re: [libav-devel] [PATCH] lavc: Add a VP9 decoder

2013-11-04 Thread Ronald S. Bultje
Hi, On Mon, Nov 4, 2013 at 11:27 AM, Luca Barbato lu_z...@gentoo.org wrote: From: Ronald S. Bultje rsbul...@gmail.com Originally written by Ronald S. Bultje rsbul...@gmail.com with the help of Clément Bœsch ubi...@gmail.com. No. The decoder was written by A and B, not A with the help of B

Re: [libav-devel] FFV1.3 released: How is libav's implementation status?

2013-10-25 Thread Ronald S. Bultje
Hi, On Fri, Oct 25, 2013 at 4:35 AM, Peter B. p...@das-werkstatt.com wrote: On 10/24/2013 11:52 PM, Ronald S. Bultje wrote: Hi, On Thu, Oct 24, 2013 at 5:29 PM, Peter B. p...@das-werkstatt.com wrote: On 10/21/2013 12:43 AM, Luca Barbato wrote: Basically you should make sample files

Re: [libav-devel] FFV1.3 released: How is libav's implementation status?

2013-10-24 Thread Ronald S. Bultje
Hi, On Thu, Oct 24, 2013 at 5:29 PM, Peter B. p...@das-werkstatt.com wrote: On 10/21/2013 12:43 AM, Luca Barbato wrote: Basically you should make sample files (so 1 frame or 3 frame sample) that sports specific corner cases or common cases. e.g. all the kind of capture you want to make

Re: [libav-devel] [PATCH] h263dec: use init_get_bits8() and check its return code

2013-10-22 Thread Ronald S. Bultje
Hi, On Tue, Oct 22, 2013 at 7:19 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 10/22/2013 12:09 PM, Luca Barbato wrote: -init_get_bits(gb, s-avctx-extradata, s-avctx-extradata_size*8); -ret = ff_mpeg4_decode_picture_header(s, gb); +if

Re: [libav-devel] [PATCH] h263dec: use init_get_bits8() and check its return code

2013-10-22 Thread Ronald S. Bultje
Hi, On Tue, Oct 22, 2013 at 10:06 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 10/22/2013 2:47 PM, Ronald S. Bultje wrote: Right. So the thinking might be, should we perhaps take action based on this hypothetical error-like value of ret, such as perhaps aborting decoding

Re: [libav-devel] [PATCH] h263dec: use init_get_bits8() and check its return code

2013-10-22 Thread Ronald S. Bultje
Hi, On Tue, Oct 22, 2013 at 10:17 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 10/22/2013 3:08 PM, Ronald S. Bultje wrote: And that supposedly-magic doesn't concern you? Definitely does. Guess the consensus is to fail immediately? That sounds like an outstanding proposal

Re: [libav-devel] [PATCH] lavc: Edge emulation with dst/src linesize

2013-10-14 Thread Ronald S. Bultje
Hi, On Sun, Oct 13, 2013 at 11:55 PM, Luca Barbato lu_z...@gentoo.org wrote: -static av_noinline void emulated_edge_mc_sse(uint8_t *buf, const uint8_t *src, - ptrdiff_t linesize, +static av_noinline void emulated_edge_mc_sse(uint8_t * buf,const

Re: [libav-devel] [PATCH] lavc: Edge emulation with dst/src linesize

2013-10-14 Thread Ronald S. Bultje
Hi, On Mon, Oct 14, 2013 at 2:48 PM, Luca Barbato lu_z...@gentoo.org wrote: On 14/10/13 15:54, Ronald S. Bultje wrote: Hi, On Sun, Oct 13, 2013 at 11:55 PM, Luca Barbato lu_z...@gentoo.org wrote: -static av_noinline void emulated_edge_mc_sse(uint8_t *buf, const uint8_t *src

Re: [libav-devel] [PATCH 2/5] x86: lpc: simd av_evaluate_lls

2013-06-16 Thread Ronald S. Bultje
Hi Loren, On Sat, Jun 15, 2013 at 5:53 PM, Loren Merritt lor...@u.washington.eduwrote: 1.5x-1.8x faster on sandybridge --- libavutil/lls.c | 3 +++ libavutil/lls.h | 1 + libavutil/x86/lls.asm| 31 +++ libavutil/x86/lls_init.c | 6

Re: [libav-devel] [PATCH] x86: h264: Don't use redzone in AVX h264_deblock on Win64

2013-02-22 Thread Ronald S. Bultje
Hi, On Thu, Feb 21, 2013 at 1:11 AM, Martin Storsjö mar...@martin.st wrote: +%if WIN64 +cglobal deblock_%1_luma_intra_8, 4,6,16,0x10 +%else cglobal deblock_%1_luma_intra_8, 4,6,16,ARCH_X86_64*0x50-0x50 +%endif I believe this doesn't need a stack pointer, so you can use -0x10. Ronald

Re: [libav-devel] [PATCH] x86: h264: Don't use redzone in AVX h264_deblock on Win64

2013-02-22 Thread Ronald S. Bultje
Hi, On Fri, Feb 22, 2013 at 11:25 AM, Ronald S. Bultje rsbul...@gmail.com wrote: On Thu, Feb 21, 2013 at 1:11 AM, Martin Storsjö mar...@martin.st wrote: +%if WIN64 +cglobal deblock_%1_luma_intra_8, 4,6,16,0x10 +%else cglobal deblock_%1_luma_intra_8, 4,6,16,ARCH_X86_64*0x50-0x50 +%endif I

Re: [libav-devel] [PATCH] hpeldsp: x86: Convert dsputil_rnd_template to yasm

2013-02-14 Thread Ronald S. Bultje
Hi, On Feb 14, 2013 4:59 AM, Diego Biurrun di...@biurrun.de wrote: On Wed, Feb 13, 2013 at 05:53:36PM -0500, Daniel Kang wrote: @@ -56,6 +107,44 @@ PUT_PIXELS8_X2 +%macro PUT_PIXELS8_X2_MMX 0-1 +%if %0 == 1 +cglobal put%1_pixels8_x2, 4,4 +%else +cglobal put_pixels8_x2, 4,4

[libav-devel] [PATCH] h264: integrate clear_blocks calls with IDCT.

2013-02-09 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com In case of no-transform, integrate it with put_pixels4/8(). Intra PCM is changed to not use h-mb anymore (saves a memcpy). The one during update_thread_context() init is removed by removing the memcpy() that clobbered it in the first place. Together

Re: [libav-devel] [PATCH] hpel: split off halfpel MC from dsputil into new DSP context.

2013-01-29 Thread Ronald S. Bultje
Hi, On Jan 28, 2013 11:44 PM, Luca Barbato lu_z...@gentoo.org wrote: On 28/01/13 20:32, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This allows objects to use just halfpel MC without depending on all of dsputil. E.g. indeo3, interplayvideo and svq1dec become

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-28 Thread Ronald S. Bultje
Hi, On Mon, Jan 28, 2013 at 11:01 AM, Luca Barbato lu_z...@gentoo.org wrote: On 28/01/13 20:00, Diego Biurrun wrote: On Thu, Jan 24, 2013 at 11:44:00AM +0100, Diego Biurrun wrote: On Wed, Jan 23, 2013 at 04:45:22PM +0100, Luca Barbato wrote: From: Diego Biurrun di...@biurrun.de

Re: [libav-devel] [PATCH] x86: Simplify some arch conditionals

2013-01-28 Thread Ronald S. Bultje
Hi, On Mon, Jan 28, 2013 at 10:53 AM, Diego Biurrun di...@biurrun.de wrote: --- libavcodec/x86/h264_qpel.c |2 +- libavcodec/x86/idct_sse2_xvid.c |2 +- 2 files changed, 2 insertions(+), 2 deletions(-) OK. Ronald ___ libav-devel

[libav-devel] [PATCH] dsputil: remove unused functions copy_block{2, 4, 8, 16}.

2013-01-28 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/dsputil_template.c | 48 --- 1 file changed, 48 deletions(-) diff --git a/libavcodec/dsputil_template.c b/libavcodec/dsputil_template.c index f5811c1..a8e4e0b 100644 --- a/libavcodec

Re: [libav-devel] [PATCH] dsputil: Fix error by not using redzone and register name

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 1:28 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Daniel Kang daniel.d.k...@gmail.com Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavcodec/x86/hpeldsp.asm |6 +++--- libavcodec/x86/mpeg4qpel.asm |6 +++--- 2 files

Re: [libav-devel] [PATCH 1/5] sws: GBRP9, GBRP10 GBRP12 GBRP14 output support

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 1:25 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Michael Niedermayer michae...@gmx.at Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libswscale/output.c | 28

Re: [libav-devel] [PATCH 2/5] sws: use planarRgbToRgbWrapper only for 8bit per component

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 1:25 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Michael Niedermayer michae...@gmx.at The function doesnt support 8bit currently Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com ---

Re: [libav-devel] [PATCH 3/5] sws: dont enable chrSrcHSubSample for planar RGB

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 1:25 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Michael Niedermayer michae...@gmx.at This code path is not implemented and makes not much sense to implement either. Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Derek

Re: [libav-devel] [PATCH 5/5] sws: disable yuv2rgb warning for planar rgb.

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 1:25 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Michael Niedermayer michae...@gmx.at planar rgb formats do not use the table Signed-off-by: Michael Niedermayer michae...@gmx.at Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com ---

Re: [libav-devel] [PATCH 4/5] sws: add planar RGB formats to isAnyRGB

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 1:25 PM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: From: Michael Niedermayer michae...@gmx.at We have to make some symetric changes elsewhere as this increases the precission with which samples are stored. Signed-off-by: Michael Niedermayer

Re: [libav-devel] [PATCH] x86: hpeldsp: Fix a typo, use the right register

2013-01-27 Thread Ronald S. Bultje
Hi, On Sun, Jan 27, 2013 at 2:03 PM, Martin Storsjö mar...@martin.st wrote: From: Michael Niedermayer michae...@gmx.at This makes the code actually work. --- Allegedly. --- libavcodec/x86/hpeldsp.asm |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [libav-devel] [PATCH] swscale: GBRP output support

2013-01-26 Thread Ronald S. Bultje
Hi, On Sat, Jan 26, 2013 at 10:59 AM, Derek Buitenhuis derek.buitenh...@gmail.com wrote: On 2013-01-26 1:57 PM, Diego Biurrun wrote: Indentation is off, see the other function declarations in that file for how it should look like. Right. Fixed locally. Will re-send after more review.

Re: [libav-devel] [PATCH v2] dsputil: x86: Convert mpeg4 qpel and dsputil avg to yasm

2013-01-26 Thread Ronald S. Bultje
Hi, On Sat, Jan 26, 2013 at 10:01 AM, Daniel Kang daniel.d.k...@gmail.com wrote: On Sat, Jan 26, 2013 at 3:23 AM, Diego Biurrun di...@biurrun.de wrote: On Sat, Jan 26, 2013 at 12:32:16AM -0500, Daniel Kang wrote: --- a/libavcodec/x86/dsputil.asm +++ b/libavcodec/x86/dsputil.asm @@ -879,3

Re: [libav-devel] [PATCH] dsputil: x86: Convert mpeg4 qpel and dsputil avg to yasm

2013-01-26 Thread Ronald S. Bultje
Hi, On Sat, Jan 26, 2013 at 4:58 PM, Daniel Kang daniel.d.k...@gmail.com wrote: --- Make hpeldsp.asm --- libavcodec/x86/Makefile |2 + libavcodec/x86/dsputil.asm| 142 ++ libavcodec/x86/dsputil_avg_template.c | 789 ++---

Re: [libav-devel] [PATCH 1/1] h264: copy h264qpel dsp context to slice thread copies

2013-01-24 Thread Ronald S. Bultje
Hi, On Thu, Jan 24, 2013 at 7:56 AM, Janne Grunau janne-li...@jannau.net wrote: --- libavcodec/h264.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 9e9384b..38a6f5e 100644 --- a/libavcodec/h264.c +++ b/libavcodec/h264.c @@ -2556,6 +2556,7

[libav-devel] [PATCH] Move H264/QPEL specific asm from dsputil.asm to h264_qpel_*.asm.

2013-01-24 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/x86/dsputil.asm| 188 -- libavcodec/x86/h264_qpel_8bit.asm | 169 ++ 2 files changed, 169 insertions(+), 188 deletions(-) diff --git a/libavcodec/x86/dsputil.asm

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-23 Thread Ronald S. Bultje
Hi, On Wed, Jan 23, 2013 at 7:45 AM, Luca Barbato lu_z...@gentoo.org wrote: From: Diego Biurrun di...@biurrun.de Signed-off-by: Luca Barbato lu_z...@gentoo.org --- Rebased after the move to int16_t. En passant, adding the missing memsets as pointed by Ronald. libavcodec/bfin/Makefile

Re: [libav-devel] [PATCH v2] dsputil: x86: Convert mpeg4 qpel and dsputil avg to yasm

2013-01-23 Thread Ronald S. Bultje
Hi Daniel, On Tue, Jan 22, 2013 at 11:19 PM, Daniel Kang daniel.d.k...@gmail.com wrote: @@ -1330,10 +1087,12 @@ static void OPNAME ## qpel8_mc12_ ## MMX(uint8_t *dst, uint8_t *src,\ { \ uint64_t half[8 + 9];

Re: [libav-devel] [PATCH v2] dsputil: x86: Convert mpeg4 qpel and dsputil avg to yasm

2013-01-23 Thread Ronald S. Bultje
Hi, On Wed, Jan 23, 2013 at 1:16 PM, Daniel Kang daniel.d.k...@gmail.com wrote: On Wed, Jan 23, 2013 at 4:14 PM, Daniel Kang daniel.d.k...@gmail.com wrote: On Wed, Jan 23, 2013 at 12:36 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi Daniel, On Tue, Jan 22, 2013 at 11:19 PM, Daniel Kang

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 4:00 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:02:38PM -0800, Ronald S. Bultje wrote: --- a/libavcodec/dsputil.h +++ b/libavcodec/dsputil.h @@ -281,15 +281,15 @@ typedef struct DSPContext { /** * Halfpel motion compensation

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like

Re: [libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 8:59 AM, Diego Elio Pettenò flamee...@flameeyes.eu wrote: On 22/01/2013 03:02, Ronald S. Bultje wrote: This is never used. This has a strange effect on the other avg_pixels8_* functions, me and Luca have been looking into it today — it's not bad, but if we can

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 7:49 AM, Diego Biurrun di...@biurrun.de wrote: On Tue, Jan 22, 2013 at 07:12:21AM -0800, Ronald S. Bultje wrote: On Tue, Jan 22, 2013 at 1:53 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 06:18:22PM -0800, Ronald S. Bultje wrote: On Mon, Jan

[libav-devel] [PATCH] dsputil: remove 9/10 bits hpel functions.

2013-01-22 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com These are never used. --- libavcodec/dsputil.c | 31 - libavcodec/dsputil_template.c | 64 --- 2 files changed, 54 insertions(+), 41 deletions(-) diff --git a/libavcodec/dsputil.c b

[libav-devel] [PATCH] vp3dsp: don't do aligned reads on input.

2013-01-22 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The input is not guarenteed to be aligned. --- libavcodec/vp3dsp.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/vp3dsp.c b/libavcodec/vp3dsp.c index 1883099..0ce6b81 100644 --- a/libavcodec/vp3dsp.c +++ b

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsputil

2013-01-22 Thread Ronald S. Bultje
Hi, On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun di...@biurrun.de wrote: [..] This patch doesn't convert sh4 and ppc. I can do ppc, I don't have access to a sh4 cross-compilation environment. Ronald ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsputil

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 8:49 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun di...@biurrun.de wrote: [..] This patch doesn't convert sh4 and ppc. I can do ppc, I don't have access to a sh4 cross-compilation environment. And arm also

Re: [libav-devel] [PATCH 2/2] Separate h264 qpel from dsputil

2013-01-22 Thread Ronald S. Bultje
Hi, On Tue, Jan 22, 2013 at 10:26 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Tue, Jan 22, 2013 at 8:49 PM, Ronald S. Bultje rsbul...@gmail.com wrote: Hi, On Fri, Jan 18, 2013 at 2:37 PM, Diego Biurrun di...@biurrun.de wrote: [..] This patch doesn't convert sh4 and ppc. I can

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code from general dsputil code

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 1:01 AM, Diego Biurrun di...@biurrun.de wrote: --- This is untested due to lack of a bfin cross-compilation environment. libavcodec/bfin/Makefile |4 ++-- libavcodec/bfin/dsputil_bfin.c |8 +--- libavcodec/bfin/vp3_bfin.c |6 ++

[libav-devel] [PATCH] Move put_no_rnd_pixels_l2 function to new VP35MCDSPContext.

2013-01-21 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- configure | 7 --- libavcodec/Makefile | 1 + libavcodec/dsputil.c | 1 - libavcodec/dsputil.h | 2 -- libavcodec/dsputil_template.c | 4 libavcodec/vp3.c | 5

Re: [libav-devel] [PATCH] Move put_no_rnd_pixels_l2 function to new VP35MCDSPContext.

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 10:53 AM, Luca Barbato lu_z...@gentoo.org wrote: On 21/01/13 19:45, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com Change the subject to match our guidelines. lavc: Move put_no_rnd_pixels_l2 function to new VP35MCDSPContext Why the MC btw, I

[libav-devel] [PATCH] Move put_no_rnd_pixels_l2 function to VP3DSPContext.

2013-01-21 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The function is only used in VP3 and VP5, so no need to have it in DSPContext. --- libavcodec/dsputil.c | 1 - libavcodec/dsputil.h | 2 -- libavcodec/dsputil_template.c | 4 libavcodec/vp3.c | 2 +- libavcodec

[libav-devel] [PATCH] vp3/5: move put_no_rnd_pixels_l2 from dsputil to VP3DSPContext.

2013-01-21 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The function is only used in VP3 and VP5, so no need to have it in DSPContext. --- libavcodec/dsputil.c | 1 - libavcodec/dsputil.h | 2 -- libavcodec/dsputil_template.c | 4 libavcodec/vp3.c | 2 +- libavcodec

Re: [libav-devel] [PATCH] Move put_no_rnd_pixels_l2 function to new VP35MCDSPContext.

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 10:58 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 10:45:44AM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- configure | 7 --- libavcodec/Makefile | 1 + libavcodec

Re: [libav-devel] [PATCH] Move put_no_rnd_pixels_l2 function to new VP35MCDSPContext.

2013-01-21 Thread Ronald S. Bultje
Hi, On Jan 21, 2013 11:59 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 11:04:25AM -0800, Ronald S. Bultje wrote: On Mon, Jan 21, 2013 at 10:58 AM, Diego Biurrun di...@biurrun.de wrote: On Mon, Jan 21, 2013 at 10:45:44AM -0800, Ronald S. Bultje wrote: From: Ronald S

[libav-devel] [PATCH] dsputil: remove avg_no_rnd_pixels8.

2013-01-21 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This is never used. --- libavcodec/alpha/dsputil_alpha.c | 5 - libavcodec/arm/dsputil_init_neon.c| 7 - libavcodec/arm/dsputil_neon.S | 6 +- libavcodec/dsputil.c | 1 - libavcodec/dsputil.h

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 1:13 PM, Luca Barbato lu_z...@gentoo.org wrote: On 21/01/13 20:38, Luca Barbato wrote: +void ff_vp3dsp_init_bfin(VP3DSPContext *c, int flags) +{ +c-idct_add = ff_bfin_vp3_idct_add; +c-idct_put = ff_bfin_vp3_idct_put; c-idct missing. vp3dsp has no

Re: [libav-devel] [PATCH] bfin: vp3: Separate VP3 initialization code

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 2:31 PM, Luca Barbato lu_z...@gentoo.org wrote: On 21/01/13 22:43, Luca Barbato wrote: Actually the idct_dc_add not sure if we can safely mix and match them, probably we can. I'd push tomorrow the updated patch, idct_dc_add is compatible from what I can see.

Re: [libav-devel] [PATCH] Drop DCTELEM typedef

2013-01-21 Thread Ronald S. Bultje
Hi, On Mon, Jan 21, 2013 at 4:04 PM, Diego Biurrun di...@biurrun.de wrote: It does not help as an abstraction and adds dsputil dependencies. I like the commit. I do want to add, though, that you're not actually practically removing the dsputil dependency from a lot of files (at build time),

[libav-devel] [PATCH] dsputil: remove some never-assigned function pointers from the struct.

2013-01-21 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/dsputil.h | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/dsputil.h b/libavcodec/dsputil.h index b01c912..e4bbd46 100644 --- a/libavcodec/dsputil.h +++ b/libavcodec/dsputil.h @@ -277,7 +277,7 @@ typedef

Re: [libav-devel] [PATCH 2/3] Move wmv idct to its own DSP context.

2013-01-20 Thread Ronald S. Bultje
Hi, On Sun, Jan 20, 2013 at 5:12 AM, Diego Biurrun di...@biurrun.de wrote: On Sat, Jan 19, 2013 at 01:52:24PM -0800, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com This allows us to remove FF_IDCT_WMV2, which serves no practical purpose other than to be able to select

Re: [libav-devel] [PATCH] Move vector_fmul_add from dsputil to avfloatdsp.

2013-01-20 Thread Ronald S. Bultje
Hi, On Sun, Jan 20, 2013 at 1:30 AM, Luca Barbato lu_z...@gentoo.org wrote: On 20/01/13 07:36, Ronald S. Bultje wrote: From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/aacsbr.c | 10 +- libavcodec/arm/dsputil_init_neon.c | 3 --- libavcodec/arm

[libav-devel] [PATCH] floatdsp: move vector_fmul_add from dsputil to avfloatdsp.

2013-01-20 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com --- libavcodec/aacsbr.c | 10 +- libavcodec/arm/dsputil_init_neon.c | 3 --- libavcodec/arm/dsputil_neon.S | 27 --- libavcodec/dsputil.c| 7 --- libavcodec/dsputil.h

[libav-devel] [PATCH] floatdsp: move vector_fmul_reverse from dsputil to avfloatdsp.

2013-01-20 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com Now, nellymoserenc and aacenc no longer depends on dsputil. Independent of this patch, wmaprodec also does not depend on dsputil, so I removed it from there also. --- libavcodec/aacdec.c | 10 ++-- libavcodec/aacenc.c

[libav-devel] [PATCH] dsputil: remove butterflies_float_interleave.

2013-01-20 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com The function is unused. --- libavcodec/dsputil.c | 13 - libavcodec/dsputil.h | 17 - libavcodec/x86/dsputil.asm | 44 libavcodec/x86/dsputil_mmx.c | 7 --- 4

Re: [libav-devel] [PATCH 06/14] x32 yasm: x86inc add ptrsize and p-suffix

2013-01-20 Thread Ronald S. Bultje
Hi, On Sun, Jan 20, 2013 at 2:32 PM, Matthias Räncker theonetruecam...@gmx.de wrote: - new ptrsize macro equals 8 on x64, 4 otherwise - added p suffix to registers and function arguments refering to pointer sized registers and arguments Signed-off-by: Matthias Räncker

[libav-devel] [PATCH] floatdsp: move scalarproduct_float from dsputil to avfloatdsp.

2013-01-20 Thread Ronald S. Bultje
From: Ronald S. Bultje rsbul...@gmail.com This makes the aac decoder and all voice codecs independent of dsputil. --- libavcodec/aac.h| 1 - libavcodec/aacdec.c | 3 +-- libavcodec/acelp_pitch_delay.c | 4 ++-- libavcodec/acelp_vectors.c | 6

  1   2   3   4   5   6   7   8   9   10   >