[libav-devel] [PATCH] rtp: Packetization of JPEG (RFC 2435)

2012-09-23 Thread Samuel Pitoiset
RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the License, or

[libav-devel] [PATCH] rtp: Packetization of JPEG (RFC 2435)

2012-09-12 Thread Samuel Pitoiset
ct start, const uint8_t *restrict end); diff --git a/libavformat/rtpenc_jpeg.c b/libavformat/rtpenc_jpeg.c new file mode 100644 index 000..6a39eba --- /dev/null +++ b/libavformat/rtpenc_jpeg.c @@ -0,0 +1,120 @@ +/* + * RTP JPEG-compressed video Packetizer, RFC 2435 + * Copyright (c) 20

Re: [libav-devel] [PATCH] rtp: Packetization of JPEG (RFC 2435)

2012-09-12 Thread Samuel Pitoiset
On Tue, Sep 11, 2012 at 1:52 PM, Martin Storsjö wrote: > On Fri, 7 Sep 2012, Samuel Pitoiset wrote: > >> --- >> Changelog | 1 + >> libavformat/Makefile | 1 + >> libavformat/rtpenc.c | 4 ++ >> libavformat/rtpenc.h | 1

Re: [libav-devel] [PATCH 13/13] rtpdec_jpeg: Error out on other unsupported type values as well

2012-09-11 Thread Samuel Pitoiset
if (type > 1) { > +av_log(ctx, AV_LOG_ERROR, "Unimplemented RTP/JPEG type %d\n", type); > +return AVERROR_PATCHWELCOME; > +} > > /* Parse the quantization table header. */ > if (off == 0) { > -- This patchset look

Re: [libav-devel] [PATCH 01/13] rtpdec_jpeg: Write the DHT section properly

2012-09-11 Thread Samuel Pitoiset
On Tue, Sep 11, 2012 at 4:54 PM, Martin Storsjö wrote: > On Tue, 11 Sep 2012, Samuel Pitoiset wrote: > >> On Tue, Sep 11, 2012 at 1:46 PM, Martin Storsjö wrote: >>> >>> Currently the size header of the generated DHT section is >>> incorrect, making th

Re: [libav-devel] [PATCH 01/13] rtpdec_jpeg: Write the DHT section properly

2012-09-11 Thread Samuel Pitoiset
Maybe, you can use put_huffman_table() from libavcodec/mjpegenc.c now. -- Best regards, Samuel Pitoiset. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] rtpdec_jpeg: Add support for default quantizers

2012-09-10 Thread Samuel Pitoiset
Generate quantization tables when they are not present in the first chunk. --- libavformat/rtpdec_jpeg.c | 50 --- 1 file changed, 47 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index c77ecbf..671763d

[libav-devel] [PATCH] rtpdec_jpeg: Add support for default quantizers

2012-09-10 Thread Samuel Pitoiset
Generate quantization tables when they are not present in the first chunk. --- libavformat/rtpdec_jpeg.c | 46 +++--- 1 file changed, 43 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index c77ecbf..585af9e

[libav-devel] [PATCH] rtpdec_jpeg: Add support for default quantizers

2012-09-10 Thread Samuel Pitoiset
Generate quantization tables when they are not present in the first chunk. --- libavformat/rtpdec_jpeg.c | 49 --- 1 file changed, 46 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index c77ecbf..e4f02f0

Re: [libav-devel] [PATCH] rtpdec_jpeg: Add support for default quantizers

2012-09-10 Thread Samuel Pitoiset
On Mon, Sep 10, 2012 at 1:15 PM, Martin Storsjö wrote: > On Sun, 9 Sep 2012, Samuel Pitoiset wrote: > >> Generate quantization tables when they are not present in the >> first chunk. >> --- >> libavformat/rtpdec_jpeg.c | 57 >> +

[libav-devel] [PATCH] rtpdec_jpeg: Add support for default quantizers

2012-09-09 Thread Samuel Pitoiset
Generate quantization tables when they are not present in the first chunk. --- libavformat/rtpdec_jpeg.c | 57 --- 1 file changed, 54 insertions(+), 3 deletions(-) diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c index c77ecbf..ce8f8e2

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-09 Thread Samuel Pitoiset
On Sun, Sep 9, 2012 at 3:08 PM, Martin Storsjö wrote: > On Fri, 7 Sep 2012, Samuel Pitoiset wrote: > >> --- >> Changelog| 1 + >> libavcodec/Makefile | 1 + >> libavformat/Makefile | 1 + >> libavformat/rtp

[libav-devel] [PATCH] rtp: Packetization of JPEG (RFC 2435)

2012-09-07 Thread Samuel Pitoiset
RTP JPEG-compressed video Packetizer, RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundatio

[libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-07 Thread Samuel Pitoiset
+/* + * RTP JPEG-compressed Video Depacketizer, RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-07 Thread Samuel Pitoiset
On Fri, Sep 7, 2012 at 1:21 PM, Martin Storsjö wrote: > On Fri, 7 Sep 2012, Samuel Pitoiset wrote: > >> --- >> Fix build with --disable-everything --enable-demuxer=rtsp >> --- >> Changelog| 1 + >> configure| 2 +- &

[libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-07 Thread Samuel Pitoiset
+ b/libavformat/rtpdec_jpeg.c @@ -0,0 +1,335 @@ +/* + * RTP JPEG-compressed Video Depacketizer, RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser Gener

[libav-devel] [PATCH] [WIP] rtp: Packetization of JPEG (RFC 2435)

2012-09-06 Thread Samuel Pitoiset
peg.c new file mode 100644 index 000..0308930 --- /dev/null +++ b/libavformat/rtpenc_jpeg.c @@ -0,0 +1,53 @@ +/* + * RTP JPEG-compressed video Packetizer, RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/

[libav-devel] [PATCH 1/2] mjpeg: Rename some symbols to avpriv_* instead of ff_*

2012-09-06 Thread Samuel Pitoiset
These symbols will be used from the RTP/JPEG depacketizer. --- libavcodec/mjpeg.c | 14 +++--- libavcodec/mjpeg.h | 14 +++--- libavcodec/mjpeg2jpeg_bsf.c | 12 ++-- libavcodec/mjpegdec.c | 24 libavcodec/mjpegenc.c | 3

Re: [libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-06 Thread Samuel Pitoiset
On Thu, Sep 6, 2012 at 3:00 PM, Martin Storsjö wrote: > On Thu, 6 Sep 2012, Samuel Pitoiset wrote: > >> --- >> Changelog| 1 + >> libavformat/Makefile | 1 + >> libavformat/rtpdec.c | 1 + >> libavformat/rtpdec_formats.h

[libav-devel] [PATCH 2/2] rtp: Depacketization of JPEG (RFC 2435)

2012-09-06 Thread Samuel Pitoiset
peg4_generic_dynamic_handler; diff --git a/libavformat/rtpdec_jpeg.c b/libavformat/rtpdec_jpeg.c new file mode 100644 index 000..79916fd --- /dev/null +++ b/libavformat/rtpdec_jpeg.c @@ -0,0 +1,330 @@ +/* + * RTP JPEG-compressed Video Depacketizer, RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset

[libav-devel] [PATCH 1/2] mjpeg: Rename some symbols to avpriv_* instead of ff_*

2012-09-06 Thread Samuel Pitoiset
These symbols will be used from the RTP/JPEG depacketizer. --- libavcodec/mjpeg.c | 63 - libavcodec/mjpeg.h | 76 ++--- libavcodec/mjpeg2jpeg_bsf.c | 12 +++ libavcodec/mjpegdec.c | 24 +++-

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-09-06 Thread Samuel Pitoiset
On Thu, Sep 6, 2012 at 10:30 AM, Martin Storsjö wrote: > On Wed, 5 Sep 2012, Samuel Pitoiset wrote: > >>>> +/* JFIF header */ >>>> +put_marker(&pbc, APP0); >>>> +put_bits(&pbc, 16, 16); >>>> +ff_put_string(&pbc, &qu

[libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-09-06 Thread Samuel Pitoiset
--- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 17337 thread 0x661b] avio_rb32 (s=0x0) at aviobuf.c:552 552 unsigned int avio_rb32(AVIOContext *s) (gdb) bt #

[libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-09-05 Thread Samuel Pitoiset
--- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 17337 thread 0x661b] avio_rb32 (s=0x0) at aviobuf.c:552 552 unsigned int avio_rb32(AVIOContext *s) (gdb) bt #

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-09-05 Thread Samuel Pitoiset
. So, could you give me more explanations about that, please? -- Best regards, Samuel Pitoiset. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-08-28 Thread Samuel Pitoiset
On Tue, Aug 28, 2012 at 2:55 PM, Martin Storsjö wrote: > On Sat, 25 Aug 2012, Samuel Pitoiset wrote: > >> --- >> You can test it by using the following link: >> rtsp://elmer.tapir.caltech.edu/Lecture6_tape1_web.mov >> >> However, the server seems a little wei

Re: [libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-08-28 Thread Samuel Pitoiset
On Sun, Aug 26, 2012 at 7:36 PM, Justin Ruggles wrote: > On 08/26/2012 01:18 PM, Samuel Pitoiset wrote: >> On Sun, Aug 26, 2012 at 6:57 PM, Luca Barbato wrote: >>> On 8/26/12 6:22 PM, Samuel Pitoiset wrote: >>>> >>>> --- >>>> This patch

Re: [libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-08-26 Thread Samuel Pitoiset
On Sun, Aug 26, 2012 at 6:57 PM, Luca Barbato wrote: > On 8/26/12 6:22 PM, Samuel Pitoiset wrote: >> >> --- >> This patch fixes the following crash: >> >> Program received signal EXC_BAD_ACCESS, Could not access memory. >> Reason: KERN_INVALID_ADDRESS at ad

[libav-devel] [PATCH] mov_chan: Fix a crash in ff_mov_read_chan()

2012-08-26 Thread Samuel Pitoiset
--- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 17337 thread 0x661b] avio_rb32 (s=0x0) at aviobuf.c:552 552 unsigned int avio_rb32(AVIOContext *s) (gdb) bt #

[libav-devel] [PATCH] rtpdec_h264: Fix a crash by removing the definition of the pixel format

2012-08-26 Thread Samuel Pitoiset
--- This patch fixes the following crash: Program received signal EXC_BAD_ACCESS, Could not access memory. Reason: KERN_INVALID_ADDRESS at address: 0x0018 [Switching to process 16366 thread 0x651b] 0x0001001ff9ab in decode_nal_units (h=0x106b17718, buf=0x106b10760 "?\a?\006\001",

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-08-25 Thread Samuel Pitoiset
On Sat, Aug 25, 2012 at 12:07 PM, Luca Barbato wrote: > On 8/25/12 11:57 AM, Samuel Pitoiset wrote: >> >> On Sat, Aug 25, 2012 at 11:18 AM, Luca Barbato wrote: >>> >>> On 8/25/12 1:51 AM, Samuel Pitoiset wrote: >>>> >>>> >>>

Re: [libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-08-25 Thread Samuel Pitoiset
On Sat, Aug 25, 2012 at 11:18 AM, Luca Barbato wrote: > On 8/25/12 1:51 AM, Samuel Pitoiset wrote: >> >> --- >> You can test it by using the following link: >> rtsp://elmer.tapir.caltech.edu/Lecture6_tape1_web.mov >> >> However, the server seems a little

[libav-devel] [PATCH] rtp: Depacketization of JPEG

2012-08-24 Thread Samuel Pitoiset
, RFC 2435 + * Copyright (c) 2012 Samuel Pitoiset + * + * This file is part of Libav. + * + * Libav is free software; you can redistribute it and/or + * modify it under the terms of the GNU Lesser General Public + * License as published by the Free Software Foundation; either + * version 2.1 of the

Re: [libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-21 Thread Samuel Pitoiset
On Tue, Aug 21, 2012 at 12:39 PM, Johan Andersson wrote: > On Tue, Aug 21, 2012 at 12:16:43PM +0200, Samuel Pitoiset wrote: >> On Tue, Aug 21, 2012 at 12:13 PM, Johan Andersson wrote: >> > On Tue, Aug 21, 2012 at 11:10:36AM +0200, Samuel Pitoiset wrote: >> >> On

Re: [libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-21 Thread Samuel Pitoiset
On Tue, Aug 21, 2012 at 12:16 PM, Luca Barbato wrote: > On 8/21/12 12:13 PM, Johan Andersson wrote: >> >> On Tue, Aug 21, 2012 at 11:10:36AM +0200, Samuel Pitoiset wrote: >>> >>> On Tue, Aug 21, 2012 at 10:34 AM, Luca Barbato >>> wrote: >>&g

Re: [libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-21 Thread Samuel Pitoiset
On Tue, Aug 21, 2012 at 12:13 PM, Johan Andersson wrote: > On Tue, Aug 21, 2012 at 11:10:36AM +0200, Samuel Pitoiset wrote: >> On Tue, Aug 21, 2012 at 10:34 AM, Luca Barbato wrote: >> > On 8/20/12 10:13 PM, Samuel Pitoiset wrote: >> >> >> >> RFC 2616 s

Re: [libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-21 Thread Samuel Pitoiset
On Tue, Aug 21, 2012 at 11:39 AM, Luca Barbato wrote: > On 8/21/12 11:10 AM, Samuel Pitoiset wrote: >> >> On Tue, Aug 21, 2012 at 10:34 AM, Luca Barbato wrote: >>> >>> On 8/20/12 10:13 PM, Samuel Pitoiset wrote: >>>> >>>> >>>&

Re: [libav-devel] [PATCH] rtmp: support strict rtmp servers

2012-08-21 Thread Samuel Pitoiset
On Sun, Aug 19, 2012 at 1:02 PM, Samuel Pitoiset wrote: > In order to send or receive a stream FCPublish, FCSubscribe and _checkbw > are completely optional and often not implemented. releaseStream over a > non-existen stream might report an error instead of being silent. > --- &g

Re: [libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-21 Thread Samuel Pitoiset
On Tue, Aug 21, 2012 at 10:34 AM, Luca Barbato wrote: > On 8/20/12 10:13 PM, Samuel Pitoiset wrote: >> >> RFC 2616 says that byte range specifications in HTTP apply to the >> sequence of bytes which start at zero. >> --- >> libavformat/http.c | 2 +- >&

[libav-devel] [PATCH] http: Only send positive values for the byte range field

2012-08-20 Thread Samuel Pitoiset
RFC 2616 says that byte range specifications in HTTP apply to the sequence of bytes which start at zero. --- libavformat/http.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index ce4a508..ad38f63 100644 --- a/libavformat/http.c +++ b/l

[libav-devel] [PATCH] rtmp: support strict rtmp servers

2012-08-19 Thread Samuel Pitoiset
In order to send or receive a stream FCPublish, FCSubscribe and _checkbw are completely optional and often not implemented. releaseStream over a non-existen stream might report an error instead of being silent. --- libavformat/rtmpproto.c | 11 +++ 1 file changed, 7 insertions(+), 4 deleti

Re: [libav-devel] [PATCH] rtmp: Gracefully ignore Adobe-specific, artifact errors

2012-08-19 Thread Samuel Pitoiset
On Sun, Aug 19, 2012 at 2:14 AM, Luca Barbato wrote: > On 8/17/12 3:51 PM, Martin Storsjö wrote: >> >> On Fri, 17 Aug 2012, Samuel Pitoiset wrote: >> >>> --- >>> libavformat/rtmpproto.c | 11 +++ >>> 1 file changed, 7 insertions(+),

[libav-devel] [PATCH] rtmp: Gracefully ignore Adobe-specific, artifact errors

2012-08-17 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 6205cd2..ad94e85 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -549,7 +549,7 @@ static int gen_release_stream(

[libav-devel] [PATCH] rtmp: Gracefully ignore Adobe specific historical artefacs errors

2012-08-16 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index ca871c9..9067bb2 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -549,7 +549,7 @@ static int gen_release_stream(

[libav-devel] [PATCH] rtmpdh: Do not generate the same private key when using libnettle

2012-08-16 Thread Samuel Pitoiset
Replace mpz_random by mpz_urandomb with a random state initialization in order to improve the randomness. --- libavformat/rtmpdh.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/rtmpdh.c b/libavformat/rtmpdh.c index 92bce7a..38c2f3d 100644 --- a/libavform

Re: [libav-devel] [PATCH] rtmp: Use int instead of ssize_t

2012-08-16 Thread Samuel Pitoiset
On Thu, Aug 16, 2012 at 9:26 PM, Martin Storsjö wrote: > Not all compilers support ssize_t (MSVC doesn't), and none of these > variables need to be larger than 32 bit. Btw, is there an equivalent to ssize_t on MSVC ? (a question just for my personal skills). -- Best regards, Samu

Re: [libav-devel] [PATCH] rtmp: Gracefully ignore releaseStream errors

2012-08-16 Thread Samuel Pitoiset
On Thu, Aug 16, 2012 at 6:28 PM, Luca Barbato wrote: > On 08/16/2012 02:16 PM, Martin Storsjö wrote: >> On Thu, 16 Aug 2012, Samuel Pitoiset wrote: >> >>> Some strict servers like crtmpserver returns an error when the specified >>> stream is n

Re: [libav-devel] [PATCH] rtmp: Automatically compute the hash for SWFVerification

2012-08-16 Thread Samuel Pitoiset
On Wed, Aug 15, 2012 at 4:30 PM, Martin Storsjö wrote: > On Wed, 15 Aug 2012, Samuel Pitoiset wrote: > >> --- >> doc/protocols.texi | 3 ++ >> libavformat/rtmpproto.c | 134 >> >> libavformat/version.

[libav-devel] [PATCH] rtmp: Gracefully ignore releaseStream errors

2012-08-16 Thread Samuel Pitoiset
Some strict servers like crtmpserver returns an error when the specified stream is not found in call to releaseStream. --- libavformat/rtmpproto.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index db11501..49b7e19 100

[libav-devel] [PATCH] rtmp: Automatically compute the hash for SWFVerification

2012-08-15 Thread Samuel Pitoiset
--- doc/protocols.texi | 3 ++ libavformat/rtmpproto.c | 134 libavformat/version.h | 2 +- 3 files changed, 138 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index bdb3e8c..ea5706f 100644 --- a/doc/pr

Re: [libav-devel] [PATCH 2/2] rtmp: Automatically compute the hash for SWFVerification

2012-08-15 Thread Samuel Pitoiset
On Wed, Aug 15, 2012 at 12:51 PM, Martin Storsjö wrote: > On Wed, 15 Aug 2012, Samuel Pitoiset wrote: > >> On Tue, Aug 14, 2012 at 10:08 PM, Martin Storsjö wrote: >>> >>> On Mon, 13 Aug 2012, Samuel Pitoiset wrote: >>> >>>> --- >>>>

Re: [libav-devel] [PATCH 2/2] rtmp: Automatically compute the hash for SWFVerification

2012-08-15 Thread Samuel Pitoiset
On Tue, Aug 14, 2012 at 10:08 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Samuel Pitoiset wrote: > >> --- >> doc/protocols.texi | 3 ++ >> libavformat/rtmpproto.c | 127 >> >> libavformat/version.

Re: [libav-devel] [PATCH 1/2] rtmp: Add support for SWFVerification

2012-08-15 Thread Samuel Pitoiset
On Tue, Aug 14, 2012 at 10:08 PM, Martin Storsjö wrote: > On Tue, 14 Aug 2012, Samuel Pitoiset wrote: > >> On Tue, Aug 14, 2012 at 9:56 PM, Samuel Pitoiset >> wrote: >>> >>> On Tue, Aug 14, 2012 at 9:53 PM, Martin Storsjö wrote: >>>>

Re: [libav-devel] [PATCH 1/2] rtmp: Add support for SWFVerification

2012-08-14 Thread Samuel Pitoiset
On Tue, Aug 14, 2012 at 9:56 PM, Samuel Pitoiset wrote: > On Tue, Aug 14, 2012 at 9:53 PM, Martin Storsjö wrote: >> On Mon, 13 Aug 2012, Samuel Pitoiset wrote: >> >>> Specifies how the server verifies client SWF files before allowing the >>> files to connect

Re: [libav-devel] [PATCH 1/2] rtmp: Add support for SWFVerification

2012-08-14 Thread Samuel Pitoiset
On Tue, Aug 14, 2012 at 9:53 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Samuel Pitoiset wrote: > >> Specifies how the server verifies client SWF files before allowing the >> files to connect to an application. Verifying SWF files is a security >> measure that preven

Re: [libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Samuel Pitoiset
On Tue, Aug 14, 2012 at 12:11 AM, Diego Elio Pettenò wrote: > On 13/08/2012 15:03, Samuel Pitoiset wrote: >> Ok with you guys. >> Indeed, I think I won't have the time to do this task before the end >> but after the summer it's possible. > > Then I'd sa

Re: [libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Samuel Pitoiset
On Tue, Aug 14, 2012 at 12:00 AM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Diego Elio Pettenò wrote: > >> On 13/08/2012 14:35, Samuel Pitoiset wrote: >>> >>> +@item rtmp_usher_token >>> +Authentication token for strict servers like Justin.tv. >>&g

Re: [libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 11:46 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Samuel Pitoiset wrote: > >> On Mon, Aug 13, 2012 at 11:39 PM, Martin Storsjö wrote: >>> >>> On Mon, 13 Aug 2012, Samuel Pitoiset wrote: >>> >>>> This token sent to

Re: [libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 11:39 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Samuel Pitoiset wrote: > >> This token sent to the server using a NetStream.Authenticate.UserToken >> invoke call is required for strict servers like Justin.tv. > > > Didn't l

[libav-devel] [PATCH] rtmp: Add support for authentification token

2012-08-13 Thread Samuel Pitoiset
This token sent to the server using a NetStream.Authenticate.UserToken invoke call is required for strict servers like Justin.tv. --- doc/protocols.texi | 3 +++ libavformat/rtmpproto.c | 31 +++ libavformat/version.h | 2 +- 3 files changed, 35 insertions(+),

Re: [libav-devel] [PATCH] rtmp: handle bytes read reports

2012-08-13 Thread Samuel Pitoiset
(pkt->type) { > +case RTMP_PT_BYTES_READ: > +av_dlog(s, "received bytes read report\n"); > +break; > case RTMP_PT_CHUNK_SIZE: > if ((ret = handle_chunk_size(s, pkt)) < 0) > return ret; > -- OK. -- Best regards, Samuel

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 6:00 PM, Diego Elio Pettenò wrote: > On 13/08/2012 08:52, Samuel Pitoiset wrote: >> I could, but how to detect that the server deals with LZMA? > > I'm just wondering what would happen if the user would pass a swf file > that is not what we h

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 5:50 PM, Diego Elio Pettenò wrote: > On 13/08/2012 03:06, Samuel Pitoiset wrote: >>> > And last thing, how does this deal with Flash 11 LZMA-compressed swf >>> > files? >> This is not supported. > > Does it error out? Ignore it sil

Re: [libav-devel] [PATCH 2/3] rtmp: Do not send _checkbw calls as notifications

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 3:53 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Luca Barbato wrote: > >> On 8/11/12 12:41 PM, Samuel Pitoiset wrote: >>> >>> In order to properly track _checkbw errors, we have to track them by >>> using a proper invoke number.

[libav-devel] [PATCH 2/2] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
--- doc/protocols.texi | 3 ++ libavformat/rtmpproto.c | 127 libavformat/version.h | 2 +- 3 files changed, 131 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index bdb3e8c..ea5706f 100644 --- a/doc/pr

[libav-devel] [PATCH 1/2] rtmp: Add support for SWFVerification

2012-08-13 Thread Samuel Pitoiset
Specifies how the server verifies client SWF files before allowing the files to connect to an application. Verifying SWF files is a security measure that prevents someone from creating their own SWF files that can attempt to stream your resources. --- doc/protocols.texi | 6 + libavforma

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 4:45 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Samuel Pitoiset wrote: > >> On Mon, Aug 13, 2012 at 2:25 PM, Martin Storsjö wrote: >>> >>> On Mon, 13 Aug 2012, Samuel Pitoiset wrote: >>> >>> memcpy(rt->swfhash,

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 2:25 PM, Martin Storsjö wrote: > On Mon, 13 Aug 2012, Samuel Pitoiset wrote: > >> --- >> libavformat/rtmpproto.c | 128 >> >> 1 file changed, 128 insertions(+) > > > Please squash in

Re: [libav-devel] [PATCH 5/5] rtmp: Add new option 'rtmp_swfvfy'

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 2:28 PM, Martin Storsjö wrote: > On Sun, 12 Aug 2012, Luca Barbato wrote: > >> On 8/12/12 12:37 AM, Samuel Pitoiset wrote: >>> >>> This option specifies the URL to player swf file, compute hash/size >>> automatically. &g

Re: [libav-devel] [PATCH 4/5] rtmp: Add support for SWFVerification

2012-08-13 Thread Samuel Pitoiset
On Mon, Aug 13, 2012 at 2:03 PM, Martin Storsjö wrote: > On Sun, 12 Aug 2012, Samuel Pitoiset wrote: > >> Specifies how the server verifies client SWF files before allowing the >> files to connect to an application. Verifying SWF files is a security >> measure that preven

[libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 128 1 file changed, 128 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index f6e6538..b732fc5 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -41,6 +41,10 @@ #inclu

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-13 Thread Samuel Pitoiset
On Sun, Aug 12, 2012 at 9:59 PM, Diego Elio Pettenò wrote: > On 12/08/2012 12:45, Samuel Pitoiset wrote: >> +if ((ret = rtmp_uncompress_swfplayer(in_data + 8, in_size - 8, >> + &out_data, &out_size)) < 0) > > Al

Re: [libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-12 Thread Samuel Pitoiset
On Sun, Aug 12, 2012 at 9:47 PM, Diego Elio Pettenò wrote: > On 12/08/2012 12:45, Samuel Pitoiset wrote: >> +#include >> + > > no CONFIG_ZLIB protection? Oops. Indeed, it's required here, thanks. -- Best regards, Samuel Pitoiset. _

[libav-devel] [PATCH 6/6] rtmp: Automatically compute the hash for SWFVerification

2012-08-12 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 121 1 file changed, 121 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index f6e6538..acb49f3 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -41,6 +41,8 @@ #includ

[libav-devel] [PATCH 5/6] rtmp: Add new option 'rtmp_swf'

2012-08-12 Thread Samuel Pitoiset
This option specifies the URL to player swf file, compute hash/size automatically. --- doc/protocols.texi | 3 +++ libavformat/rtmpproto.c | 2 ++ libavformat/version.h | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index bdb3e8

Re: [libav-devel] [PATCH 5/5] rtmp: Add new option 'rtmp_swfvfy'

2012-08-12 Thread Samuel Pitoiset
On Sun, Aug 12, 2012 at 4:27 PM, Luca Barbato wrote: > On 8/12/12 12:37 AM, Samuel Pitoiset wrote: >> >> This option specifies the URL to player swf file, compute hash/size >> automatically. >> --- >> doc/protocols.texi | 3 +++ >> libavformat/rtmppr

[libav-devel] [PATCH 5/5] rtmp: Add new option 'rtmp_swfvfy'

2012-08-11 Thread Samuel Pitoiset
This option specifies the URL to player swf file, compute hash/size automatically. --- doc/protocols.texi | 3 +++ libavformat/rtmpproto.c | 2 ++ libavformat/version.h | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index bdb3e8

[libav-devel] [PATCH 4/5] rtmp: Add support for SWFVerification

2012-08-11 Thread Samuel Pitoiset
Specifies how the server verifies client SWF files before allowing the files to connect to an application. Verifying SWF files is a security measure that prevents someone from creating their own SWF files that can attempt to stream your resources. --- libavformat/rtmpproto.c | 61 +

[libav-devel] [PATCH 3/5] rtmp: Add a new option 'rtmp_swfhash'

2012-08-11 Thread Samuel Pitoiset
This option specifies the SHA256 hash of the decompressed SWF file (32 bytes). --- doc/protocols.texi | 3 +++ libavformat/rtmpproto.c | 3 +++ libavformat/version.h | 2 +- 3 files changed, 7 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 6bb634b..

[libav-devel] [PATCH 2/5] rtmp: Add a new option 'rtmp_swfsize'

2012-08-11 Thread Samuel Pitoiset
This option specifies the size of the decompressed SWF file which is required for SWFVerification. --- doc/protocols.texi | 3 +++ libavformat/rtmpproto.c | 2 ++ libavformat/version.h | 2 +- 3 files changed, 6 insertions(+), 1 deletion(-) diff --git a/doc/protocols.texi b/doc/protocols.t

[libav-devel] [PATCH 1/5] rtmp: Display a warning message when the SWFVerification is ignored

2012-08-11 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index c85424e..82c2466 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -970,6 +970,8 @@ static int handle_ping(URLContext *s, RTMPPacket *pkt)

Re: [libav-devel] [PATCH 3/3] rtmp: Gracefully ignore _checkbw errors by tracking them

2012-08-11 Thread Samuel Pitoiset
On Sat, Aug 11, 2012 at 12:50 PM, Martin Storsjö wrote: > On Sat, 11 Aug 2012, Samuel Pitoiset wrote: > >> --- >> libavformat/rtmpproto.c | 19 +++ >> 1 file changed, 15 insertions(+), 4 deletions(-) > > > You forgot to set the in-reply-to field of

[libav-devel] [PATCH 3/3] rtmp: Gracefully ignore _checkbw errors by tracking them

2012-08-11 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 19 +++ 1 file changed, 15 insertions(+), 4 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index ebbe204..a9f014c 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -628,7 +628,7 @@ static int gen_check_

[libav-devel] [PATCH 2/3] rtmp: Do not send _checkbw calls as notifications

2012-08-11 Thread Samuel Pitoiset
In order to properly track _checkbw errors, we have to track them by using a proper invoke number. --- libavformat/rtmp.h | 9 - libavformat/rtmpproto.c | 2 +- 2 files changed, 1 insertion(+), 10 deletions(-) diff --git a/libavformat/rtmp.h b/libavformat/rtmp.h index c9aa67e..b9c5f1

[libav-devel] [PATCH 1/3] rtmp: Factorize the code by adding find_tracked_method

2012-08-11 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 40 ++-- 1 file changed, 26 insertions(+), 14 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index c85424e..24e515c 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -154,6 +154,31 @

Re: [libav-devel] [PATCH] rtmp: split chunk_size var into in_chunk_size and out_chunk_size

2012-08-11 Thread Samuel Pitoiset
elps for the case with incoming connections from > wirecast - even with this it's hard to handle, but right now the whole > concept is so broken that it's hard to debug things. So it's a required step > anyway. > OK. -- Best regards, Samuel Pitoiset. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] rtmp: split chunk_size var into in_chunk_size and out_chunk_size

2012-08-10 Thread Samuel Pitoiset
> packet with multiple chunks one of those could be a chunk size one, > which isn't supported right now but Martin thinks with this change it > will be easier to support it. > > Please Martin correct me if I'm wrong. Okay, thanks, I understand. -- Best regards, Samuel P

Re: [libav-devel] [PATCH] rtmp: split chunk_size var into in_chunk_size and out_chunk_size

2012-08-10 Thread Samuel Pitoiset
en defined by the user. > @@ -1653,7 +1657,7 @@ static int rtmp_write(URLContext *s, const uint8_t > *buf, int size) > RTMPPacket rpkt = { 0 }; > > if ((ret = ff_rtmp_packet_read_internal(rt->stream, &rpkt, &

Re: [libav-devel] [PATCH] rtmp: Gracefully ignore _checkbw errors

2012-08-10 Thread Samuel Pitoiset
On Fri, Aug 10, 2012 at 4:20 PM, Martin Storsjö wrote: > On Fri, 10 Aug 2012, Samuel Pitoiset wrote: > >> --- >> libavformat/rtmp.h | 9 >> libavformat/rtmpproto.c | 61 >> ++--- >> 2 files cha

[libav-devel] [PATCH] rtmp: Gracefully ignore _checkbw errors

2012-08-10 Thread Samuel Pitoiset
--- libavformat/rtmp.h | 9 libavformat/rtmpproto.c | 61 ++--- 2 files changed, 42 insertions(+), 28 deletions(-) diff --git a/libavformat/rtmp.h b/libavformat/rtmp.h index c9aa67e..b9c5f1e 100644 --- a/libavformat/rtmp.h +++ b/libavform

Re: [libav-devel] [PATCH 1/3] rtmp: Factorize the code by adding handle_invoke_result

2012-08-09 Thread Samuel Pitoiset
On Thu, Aug 9, 2012 at 7:39 PM, Luca Barbato wrote: > On 08/09/2012 02:57 PM, Samuel Pitoiset wrote: >> --- >> libavformat/rtmpproto.c | 147 >> +--- >> 1 file changed, 78 insertions(+), 69 deletions(-) >> > > I

Re: [libav-devel] [PATCH] rtmpproto: ignore non-fatal errors

2012-08-09 Thread Samuel Pitoiset
On Thu, Aug 9, 2012 at 7:13 PM, Samuel Pitoiset wrote: > On Thu, Aug 9, 2012 at 7:06 PM, Luca Barbato wrote: >> fc* and checkbw methods may be not implemented, yet the server can >> accept and stream perfectly. > > I'm writing a patch for that too. =) > >> ---

Re: [libav-devel] [PATCH] rtmpproto: ignore non-fatal errors

2012-08-09 Thread Samuel Pitoiset
is called. > +ret = 0; > +level = AV_LOG_WARNING; > +} > +av_log(s, level, "Server error: %s\n",tmpstr); > + } > + > +return ret; > } else if (!memcmp(pkt->data, "\002\000\007_result&q

Re: [libav-devel] [PATCH] rtmp: Support 'rtmp_live', an option which specifies if the media is a live stream.

2012-08-09 Thread Samuel Pitoiset
On Tue, May 1, 2012 at 9:56 PM, Samuel Pitoiset wrote: > --- > libavformat/rtmpproto.c | 10 +- > 1 files changed, 9 insertions(+), 1 deletions(-) > WTF? -- Best regards, Samuel Pitoiset. ___ libav-devel mailing list libav-dev

[libav-devel] [PATCH 3/3] rtmp: Factorize the code by adding handle_invoke_error

2012-08-09 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 23 --- 1 file changed, 16 insertions(+), 7 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index a2d2529..c85424e 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -1021,6 +1021,20 @@ static int han

[libav-devel] [PATCH 2/3] rtmp Factorize the code by adding handle_invoke_status

2012-08-09 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 58 + 1 file changed, 34 insertions(+), 24 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index c2021de..a2d2529 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -1098,1

[libav-devel] [PATCH 1/3] rtmp: Factorize the code by adding handle_invoke_result

2012-08-09 Thread Samuel Pitoiset
--- libavformat/rtmpproto.c | 147 +--- 1 file changed, 78 insertions(+), 69 deletions(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 6ad90b8..c2021de 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -1021,1

Re: [libav-devel] [PATCH] rtmp: Ignore server errors

2012-08-09 Thread Samuel Pitoiset
On Thu, Aug 9, 2012 at 1:48 PM, Martin Storsjö wrote: > On Thu, 9 Aug 2012, Samuel Pitoiset wrote: > >> This fixes publishing streams to strict servers like crtmpserver. >> --- >> libavformat/rtmpproto.c | 1 - >> 1 file changed, 1 deletion(-) >> >&

[libav-devel] [PATCH] rtmp: Ignore server errors

2012-08-09 Thread Samuel Pitoiset
This fixes publishing streams to strict servers like crtmpserver. --- libavformat/rtmpproto.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index 6ad90b8..0a652ff 100644 --- a/libavformat/rtmpproto.c +++ b/libavformat/rtmpproto.c @@ -1036,7 +1

[libav-devel] [PATCH] xtea: Fix doxygen comments

2012-08-09 Thread Samuel Pitoiset
--- libavutil/xtea.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/xtea.h b/libavutil/xtea.h index cf305c6..7d2b07b 100644 --- a/libavutil/xtea.h +++ b/libavutil/xtea.h @@ -36,7 +36,7 @@ typedef struct AVXTEA { /** * Initialize an AVXTEA context. * - * @par

  1   2   3   4   5   >