[libav-devel] [PATCH 2/2] vf_interlace: Use AV_CEIL_RSHIFT

2016-01-21 Thread Vittorio Giovara
--- libavfilter/vf_interlace.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavfilter/vf_interlace.c b/libavfilter/vf_interlace.c index 939fabc..ac435d7 100644 --- a/libavfilter/vf_interlace.c +++ b/libavfilter/vf_interlace.c @@ -138,8 +138,10 @@ static void

Re: [libav-devel] [PATCH] mov: Add an option to toggle dref opening

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 12:27 PM, Derek Buitenhuis wrote: > This feature is mostly only used by NLE software, and is > both of dubious value being enabled by default, and a > possible security risk. > > Signed-off-by: Derek Buitenhuis > ---

Re: [libav-devel] [PATCH 1/3] imgconvert: Move the shrink functions only where needed

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 4:59 AM, Diego Biurrun wrote: >> +src += 2 * src_wrap; >> +dst += dst_wrap; >> +} >> +} > > You've reformatted the code while moving. This is nice and all, but I fear > it might throw off the Git copy detection routines. I would

Re: [libav-devel] [PATCH] hpeldsp: Shrink put_no_rnd_pixels_tab array to the required minimal size

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 5:54 AM, Diego Biurrun wrote: > --- > > I do wonder why that was ever bigger than necessary ... > > libavcodec/hpeldsp.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/hpeldsp.h b/libavcodec/hpeldsp.h > index

Re: [libav-devel] [PATCH] lavf: remove the concat protocol

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 7:42 AM, Anton Khirnov wrote: > It is of very limited usefulness and is a source of important security > problems. > > Bug-Id: CVE-2016-1897 > Bug-Id: CVE-2016-1898 > --- I'm ok with removing this, however shouldn't this be followed by a version bump of

[libav-devel] [PATCH 2/2] riff: add C210 FourCC (Canopus C210)

2016-01-20 Thread Vittorio Giovara
From: Piotr Bandurski --- libavformat/riff.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/riff.c b/libavformat/riff.c index f22fd47..cce9bb2 100644 --- a/libavformat/riff.c +++ b/libavformat/riff.c @@ -248,6 +248,7 @@ const AVCodecTag ff_codec_bmp_tags[] = {

[libav-devel] [PATCH 1/2] riff: add YUYV FourCC (Drastic YUYV)

2016-01-20 Thread Vittorio Giovara
From: Piotr Bandurski --- libavcodec/raw.c | 1 + libavformat/riff.c | 1 + 2 files changed, 2 insertions(+) diff --git a/libavcodec/raw.c b/libavcodec/raw.c index 62ad338..cda70ac 100644 --- a/libavcodec/raw.c +++ b/libavcodec/raw.c @@ -53,6 +53,7 @@ const PixelFormatTag

Re: [libav-devel] [PATCH] eatqi: Remove mpegvideo dependency

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 5:10 AM, Diego Biurrun <di...@biurrun.de> wrote: > On Tue, Jan 19, 2016 at 07:45:25PM -0500, Vittorio Giovara wrote: >> --- a/libavcodec/eatqi.c >> +++ b/libavcodec/eatqi.c >> @@ -35,69 +35,177 @@ >> >> +/* Based off mpeg1_decode_bloc

Re: [libav-devel] [PATCH] build: Disable VDA if an unsupported compiler is used

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 3:19 AM, Martin Storsjö <mar...@martin.st> wrote: > On Wed, 20 Jan 2016, Vittorio Giovara wrote: > >> --- >> Alternatively we could make configure fail. Opinions? >> Vittorio >> >> configure | 9 - >> 1 file changed

[libav-devel] [PATCH] h264: Print user data only from well known sources

2016-01-20 Thread Vittorio Giovara
Right now only x264 info is printed at verbose level, anything else is printed at trace level. --- libavcodec/h264_sei.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/libavcodec/h264_sei.c b/libavcodec/h264_sei.c index 1fb1fc5..62c7f73 100644 ---

Re: [libav-devel] [PATCH 1/2] h264: Print user data SEI under normal debug verbosity

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 2:05 PM, Kieran Kunhya <kier...@obe.tv> wrote: > On Wed, 28 Oct 2015 at 13:29 Vittorio Giovara <vittorio.giov...@gmail.com> > wrote: > >> On Mon, Oct 26, 2015 at 2:33 PM, Luca Barbato <lu_z...@gentoo.org> wrote: >> > On 22/10/15

Re: [libav-devel] [PATCH 2/2] h264: Print the complete user message

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 2:07 PM, Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > On 10/22/2015 1:13 PM, Vittorio Giovara wrote: >> This will allow dumping the complete x264 encode info when needed. > > strings(1) I wasn't aware this tool had all the input protocols lib

Re: [libav-devel] [PATCH] lavf: remove the concat protocol

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 3:23 PM, Anton Khirnov <an...@khirnov.net> wrote: > Quoting Vittorio Giovara (2016-01-20 18:41:57) >> On Wed, Jan 20, 2016 at 7:42 AM, Anton Khirnov <an...@khirnov.net> wrote: >> > It is of very limited usefulness and is a source of im

Re: [libav-devel] [PATCH 2/2] configure: Fail if a requested component is not available

2016-01-20 Thread Vittorio Giovara
On Wed, Jan 20, 2016 at 4:34 PM, Luca Barbato wrote: > --- > > To be squashed with the previous, brought in for additional clarity. > > configure | 16 +++- > 1 file changed, 15 insertions(+), 1 deletion(-) > > diff --git a/configure b/configure > index

Re: [libav-devel] [PATCH] configure: Improve setting specific features

2016-01-19 Thread Vittorio Giovara
On Tue, Jan 19, 2016 at 4:50 PM, Luca Barbato wrote: > Before this patch trying to enable only https by issuing > > --disable-protocols --enable-protocol=https --enable-gnutls > > does not enable https, and > > --disable-all --enable-protocols > > does not enable

[libav-devel] [PATCH] imgconvert: Drop outdated comment block

2016-01-19 Thread Vittorio Giovara
--- libavcodec/imgconvert.c | 6 -- 1 file changed, 6 deletions(-) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c index f8e6f6c..4667a4f 100644 --- a/libavcodec/imgconvert.c +++ b/libavcodec/imgconvert.c @@ -24,12 +24,6 @@ * misc image conversion routines */ -/* TODO: -

[libav-devel] [PATCH] yuv2rgb: Document the color space coefficients

2016-01-19 Thread Vittorio Giovara
Based on the original documentation found in mpeg2dec (1995). Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Based off an archeological expedition with Derek. Vittorio libswscale/yuv2rgb.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libswscale/yuv2r

[libav-devel] [PATCH 1/3] imgconvert: Move the shrink functions only where needed

2016-01-19 Thread Vittorio Giovara
--- libavcodec/imgconvert.c | 87 libavcodec/imgconvert.h | 31 --- libavcodec/mpegvideoencdsp.c | 94 ++-- 3 files changed, 90 insertions(+), 122 deletions(-) delete mode 100644

[libav-devel] [PATCH 2/3] imgconvert: Move AVPicture-related static function to the deprecated section

2016-01-19 Thread Vittorio Giovara
--- libavcodec/imgconvert.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c index 4c707f3..7589828 100644 --- a/libavcodec/imgconvert.c +++ b/libavcodec/imgconvert.c @@ -159,6 +159,8 @@ enum AVPixelFormat

[libav-devel] [PATCH 3/3] imgconvert: Add the proper API guard to a deprecated function

2016-01-19 Thread Vittorio Giovara
--- libavcodec/imgconvert.c | 2 ++ libavcodec/version.h| 3 +++ 2 files changed, 5 insertions(+) diff --git a/libavcodec/imgconvert.c b/libavcodec/imgconvert.c index 7589828..f8e6f6c 100644 --- a/libavcodec/imgconvert.c +++ b/libavcodec/imgconvert.c @@ -39,12 +39,14 @@ #include

Re: [libav-devel] [PATCH/RFC] lavc: configure: Factor out celp module

2016-01-19 Thread Vittorio Giovara
On Tue, Jan 19, 2016 at 1:36 PM, Diego Biurrun wrote: > Leave these out or create proper fine-grained dependencies. Bloating > the build for the other codecs is not acceptable. I have a very similar > patch in a branch I need to revisit some day, waiting for me to address >

Re: [libav-devel] [PATCH 1/2] lavc: Make sure that the effective timebase would not overflow

2016-01-19 Thread Vittorio Giovara
On Tue, Jan 19, 2016 at 2:06 PM, Luca Barbato wrote: > From: Arttu Ylä-Outinen > > In the unlikely situation the user decides to set ticks_per_frame > and timebase to a value large enough to overflow. > > Signed-off-by: Luca Barbato

[libav-devel] [PATCH/RFC] lavc: configure: Factor out celp module

2016-01-19 Thread Vittorio Giovara
--- This might compile a couple of unnecessary files, but they are relatively small and it will simplify more entries in this way. Vittorio configure | 13 - libavcodec/Makefile | 32 ++-- 2 files changed, 18 insertions(+), 27 deletions(-) diff

[libav-devel] [PATCH] eatqi: Remove mpegvideo dependency

2016-01-19 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- configure | 2 +- libavcodec/Makefile| 2 +- libavcodec/eatqi.c | 179 +++-- libavcodec/mpeg12.h| 1 - libavcodec/mpeg12dec.c | 5 -- 5 files change

[libav-devel] [PATCH] build: Disable VDA if an unsupported compiler is used

2016-01-19 Thread Vittorio Giovara
--- Alternatively we could make configure fail. Opinions? Vittorio configure | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 2d0573a..b7658fe 100755 --- a/configure +++ b/configure @@ -2430,7 +2430,7 @@ enable swscale_alpha enable

Re: [libav-devel] [PATCH] qsvenc: Add private option to replace coder_type

2016-01-19 Thread Vittorio Giovara
On Mon, Jan 18, 2016 at 3:52 PM, Anton Khirnov <an...@khirnov.net> wrote: > Quoting Vittorio Giovara (2016-01-13 21:28:11) >> Missing from be00ec832c519427cd92218abac77dafdc1d5487. >> --- >> libavcodec/qsvenc.c | 10 -- >> libavcodec/qsvenc.h | 2 ++ &

Re: [libav-devel] [PATCH 4/4] avcodec/v210: document the requirement for sample_factor

2016-01-19 Thread Vittorio Giovara
On Fri, Jan 15, 2016 at 2:35 PM, James Darnley wrote: > The sample factor must be the same for both 8- and 10-bit functions chosen > otherwise the output will be incorrect. Thanks for the set, can you explain in more detail why this requirement is necessary? -- Vittorio

Re: [libav-devel] [PATCH] libkvazaar: Set frame rate as a rational number

2016-01-19 Thread Vittorio Giovara
On Mon, Jan 18, 2016 at 2:59 PM, Luca Barbato wrote: > On 18/01/16 15:05, Arttu Ylä-Outinen wrote: >> On 2016-01-18 15:22, Luca Barbato wrote: >>> On 18/01/16 08:23, Arttu Ylä-Outinen wrote: I sent this to FFmpeg as well and they noticed that the multiplication might

Re: [libav-devel] [PATCH 00/14] codec private options

2016-01-19 Thread Vittorio Giovara
On Mon, Jan 11, 2016 at 4:14 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 11/01/16 21:46, Vittorio Giovara wrote: >> On Mon, Jan 4, 2016 at 8:34 AM, Vittorio Giovara >> <vittorio.giov...@gmail.com> wrote: >>> AVCodecContext holds a lot of fields that a

Re: [libav-devel] [PATCH 1/2] configure: Improve setting specific features

2016-01-19 Thread Vittorio Giovara
On Sun, Jan 17, 2016 at 2:55 AM, Luca Barbato wrote: > Before this patch trying to enable only https by issuing > > --disable-protocols --enable-protocol=https > > does not work as expected, nor does > > --disable-all --enable-protocols > > Now a `select_any` keyword

[libav-devel] [PATCH] qsvenc: Add private option to replace coder_type

2016-01-13 Thread Vittorio Giovara
Missing from be00ec832c519427cd92218abac77dafdc1d5487. --- libavcodec/qsvenc.c | 10 -- libavcodec/qsvenc.h | 2 ++ 2 files changed, 10 insertions(+), 2 deletions(-) diff --git a/libavcodec/qsvenc.c b/libavcodec/qsvenc.c index bf3dc0f..baf8f49 100644 --- a/libavcodec/qsvenc.c +++

[libav-devel] [PATCH] lavc: Move b_frame_strategy and b_sensitivity to codec private options

2016-01-11 Thread Vittorio Giovara
The b_frame_strategy option is only used by mpegvideoenc, qsv, x264, and xavs, while b_sensitivity is only used by mpegvideoenc. These are very codec-specific options, so deprecate the global variants. Set proper limits to the maximum allowed values. Signed-off-by: Vittorio Giovara

[libav-devel] [PATCH] lavc: Move scenechange_threshold to codec private options

2016-01-11 Thread Vittorio Giovara
This option is only used by mpegvideoenc, x264, and xavs. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 10 -- libavcodec/libx264.c | 16 ++-- liba

Re: [libav-devel] [PATCH 05/14] lavc: Move scenechange_threshold to codec private options

2016-01-11 Thread Vittorio Giovara
On Mon, Jan 4, 2016 at 8:50 AM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Mon, Jan 4, 2016 at 2:34 PM, Vittorio Giovara >> if (avctx->qmin >= 0) >> x4->params.rc.i_qp_min = avctx->qmin; >> if (avctx->qmax >= 0)

[libav-devel] [PATCH] lavc: Move pre_me to codec private options

2016-01-11 Thread Vittorio Giovara
This option is only used by mpegvideoenc. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Updated after nevcairiel's comments. Vittorio libavcodec/avcodec.h | 9 - libavcodec/mpegvideo.h

Re: [libav-devel] [PATCH 00/14] codec private options

2016-01-11 Thread Vittorio Giovara
On Mon, Jan 4, 2016 at 8:34 AM, Vittorio Giovara <vittorio.giov...@gmail.com> wrote: > AVCodecContext holds a lot of fields that are used seldom within > libavcodec, in most cases only to set options that apply to a single > family of codecs, or sometimes to completely u

[libav-devel] [PATCH] lavc: Move chromaoffset to codec private options

2016-01-11 Thread Vittorio Giovara
This option is only used by x264 and xavs. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/libx264.c | 12 +++- libavcodec/lib

Re: [libav-devel] [PATCH 1/2] avcodec: Add Cineform HD Decoder

2016-01-11 Thread Vittorio Giovara
On Sun, Jan 10, 2016 at 1:28 AM, Kieran Kunhya wrote: > --- > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/avcodec.h| 1 + > libavcodec/cfhd.c | 565 > > libavcodec/cfhd.h |

Re: [libav-devel] [PATCH] asfdec: Fix typo.

2016-01-11 Thread Vittorio Giovara
On Sat, Jan 9, 2016 at 7:35 PM, Alexandra Hájková wrote: > --- > libavformat/asfdec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) nit: "Fix typo in comment" (and no need for a full stop in the commit title) -- Vittorio

Re: [libav-devel] [PATCH] APIchanges: Add missing av_pix_fmt_get_chroma_sub_sample entry

2016-01-11 Thread Vittorio Giovara
On Mon, Jan 11, 2016 at 2:53 PM, Luca Barbato wrote: > --- > doc/APIchanges | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index a55fbca..ffa270e 100644 > --- a/doc/APIchanges > +++ b/doc/APIchanges > @@ -576,8

[libav-devel] [PATCH] lavu: add AV_CEIL_RSHIFT and use it in various places

2016-01-08 Thread Vittorio Giovara
From: Clément Bœsch <ubi...@gmail.com> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/ffv1dec.c | 4 ++-- libavcodec/ffv1enc.c | 4 ++-- libavcodec/mimic.c| 4 ++-- libavfilter/vf_framepack.c| 5 +++-

Re: [libav-devel] [PATCH] lavu: add FF_CEIL_RSHIFT and use it in various places

2016-01-08 Thread Vittorio Giovara
On Thu, Jan 7, 2016 at 11:04 PM, Clément Bœsch <u...@pkh.me> wrote: > On Thu, Jan 07, 2016 at 06:14:24PM -0300, James Almer wrote: >> On 1/6/2016 6:13 AM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2016-01-04 16:40:23) >> >> From: Clément Bœsch <u

Re: [libav-devel] [PATCH] lavu: add FF_CEIL_RSHIFT and use it in various places

2016-01-06 Thread Vittorio Giovara
On Wed, Jan 6, 2016 at 10:13 AM, Anton Khirnov wrote: > > This is a public header, so this should probably be AV-prefixed. And > there should be the bump/apichanges dance. I'm not sure something like this should be public, and a quick check on debian shows no package using it.

Re: [libav-devel] [PATCH 5/6] Use avpriv_report_missing_feature() where appropriate

2016-01-05 Thread Vittorio Giovara
On Tue, Dec 22, 2015 at 12:41 PM, Diego Biurrun <di...@biurrun.de> wrote: > On Thu, Dec 17, 2015 at 10:28:58AM -0500, Vittorio Giovara wrote: >> On Thu, Dec 17, 2015 at 7:28 AM, Diego Biurrun <di...@biurrun.de> wrote: >> > --- a/libavdevice/vfwcap.c >> > ++

[libav-devel] [PATCH 03/14] lavc: Move frame_skip_* to codec private options

2016-01-04 Thread Vittorio Giovara
of such option (frame_skip_threshold) without the other three. For this reason rename the option to something more consistent with the other libvpx variables. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 30 ++ liba

[libav-devel] [PATCH 04/14] lavc: Move chromaoffset to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by x264 and xavs. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/libx264.c | 12 +++- libavcodec/lib

[libav-devel] [PATCH 12/14] lavc: Move prediction_method to codec private options

2016-01-04 Thread Vittorio Giovara
This options is only used by huffyuv, ffvhuv, jpegls, mjpeg, mpegvideoenc, png, utvideo. It is a very codec-specific options, so deprecate the global variant. Set proper limits to the maximum allowed values, and update utvideoenc tests to use the new option name. Signed-off-by: Vittorio Giovara

[libav-devel] [PATCH 06/14] lavc: Move noise_reduction to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc, x264, xavs, and vpx. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 +++-- libavcodec/libvpxenc.c | 10 +- liba

[libav-devel] [PATCH 01/14] lavc: Move b_frame_strategy and b_sensitivity to codec private options

2016-01-04 Thread Vittorio Giovara
The b_frame_strategy option is only used by mpegvideoenc, qsv, x264, and xavs, while b_sensitivity is only used by mpegvideoenc. These are very codec-specific options, so deprecate the global variants. Set proper limits to the maximum allowed values. Signed-off-by: Vittorio Giovara

[libav-devel] [PATCH 09/14] lavc: Move timecode_frame_start to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpeg2. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/mpeg12enc.c | 13 +++-- libavcodec/mpegvideo.h

[libav-devel] [PATCH] sunrastenc: Properly load codec private options

2016-01-04 Thread Vittorio Giovara
Initialize the private class field and give the class a more appropriate name. Add a class member to the codec context. --- As spotted by Diego (thanks). Vittorio libavcodec/sunrastenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/sunrastenc.c

[libav-devel] [PATCH 08/14] lavc: Move context_model to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by ffv1 and ffvhuff. It is a very codec-specific option, so deprecate the global variant. Improve documentation a little. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/ffv1.h

[libav-devel] [PATCH 00/14] codec private options

2016-01-04 Thread Vittorio Giovara
selection is a trade off between how widespread the option is within libavcodec and how much it makes sense for an option to be global. Vittorio Vittorio Giovara (14): lavc: Move b_frame_strategy and b_sensitivity to codec private options lavc: Move brd_scale to codec private options lavc: Move

[libav-devel] [PATCH 07/14] lavc: Move mpeg_quant to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc, and xvid. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/libxvid.c | 10 ++ libavcodec/mpegv

[libav-devel] [PATCH 02/14] lavc: Move brd_scale to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc, It is a very codec-specific option, so deprecate the global variant. Set proper limits to the maximum allowed values. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/mpegv

[libav-devel] [PATCH 05/14] lavc: Move scenechange_threshold to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc, x264, and xavs. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 10 -- libavcodec/libx264.c | 16 ++-- liba

[libav-devel] [PATCH 11/14] lavc: Move {min, max}_prediction_order to codec private options

2016-01-04 Thread Vittorio Giovara
These options are only used by alac and flac. They are very codec-specific options, so deprecate the global variants. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/alacenc.c | 27 --- libavcodec/avcodec.h

[libav-devel] [PATCH 13/14] lavc: Move me_penalty_compensation to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc. It is a very codec-specific options, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 7 --- libavcodec/mpegvideo.h | 2 ++ libavcodec/mpegvideo_enc

[libav-devel] [PATCH 14/14] lavc: Move pre_me to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc. It is a very codec-specific option, so deprecate the global variant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/avcodec.h | 9 - libavcodec/mpegvideo.h | 3 +++ libavcodec/mpegvideo_enc

[libav-devel] [PATCH 10/14] lavc: Move rtp_payload_size to codec private options

2016-01-04 Thread Vittorio Giovara
This option is only used by mpegvideoenc and openh264. It is a very codec-specific option, so deprecate the global variant. The openh264 option is dropped altogether since it is just a fallback for -max_nal_size anyway. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- liba

[libav-devel] [PATCH] lavu: add FF_CEIL_RSHIFT and use it in various places

2016-01-04 Thread Vittorio Giovara
From: Clément Bœsch <ubi...@gmail.com> This macro is faster when shift is constant. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- This macro is needed by the cfhd decoder and it slightly improves performance where it is used. Vittorio libavcodec/ffv1dec.c

Re: [libav-devel] [PATCH] Cineform HD Decoder:

2016-01-04 Thread Vittorio Giovara
On Mon, Jan 4, 2016 at 1:04 AM, Kieran Kunhya wrote: > Decodes YUV422P10 samples in AVI and MOV (Gopro Studio) > Older files with more subbands, skips, Bayer not supported > --- > +static av_cold int cfhd_init_decoder(AVCodecContext *avctx) > +{ > +CFHDContext *s =

Re: [libav-devel] [PATCH 5/6] Use avpriv_report_missing_feature() where appropriate

2015-12-17 Thread Vittorio Giovara
On Thu, Dec 17, 2015 at 7:28 AM, Diego Biurrun wrote: > diff --git a/libavcodec/alac.c b/libavcodec/alac.c > index 72e8a57..2dc8e9d 100644 > --- a/libavcodec/alac.c > +++ b/libavcodec/alac.c > @@ -266,7 +266,7 @@ static int decode_element(AVCodecContext *avctx, AVFrame >

Re: [libav-devel] [PATCH 031/264] lavf: add AVCodecParameters to AVStream

2015-12-12 Thread Vittorio Giovara
On Sat, Dec 12, 2015 at 3:49 PM, Anton Khirnov wrote: > --- > libavformat/avformat.h | 11 +++ > libavformat/utils.c| 5 + > 2 files changed, 16 insertions(+) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index cd53420..8f730de 100644 >

Re: [libav-devel] [PATCH 029/264] lavc: add codec parameters

2015-12-12 Thread Vittorio Giovara
On Sat, Dec 12, 2015 at 3:49 PM, Anton Khirnov wrote: > --- > libavcodec/avcodec.h | 163 > +++ > libavcodec/utils.c | 151 +++ > 2 files changed, 314 insertions(+) version bump or

Re: [libav-devel] [PATCH 032/264] lavf: deprecate the stream codec context

2015-12-12 Thread Vittorio Giovara
On Sat, Dec 12, 2015 at 3:49 PM, Anton Khirnov wrote: > --- > libavformat/avformat.h | 13 - > libavformat/version.h | 3 +++ > 2 files changed, 7 insertions(+), 9 deletions(-) > > diff --git a/libavformat/avformat.h b/libavformat/avformat.h > index

Re: [libav-devel] [PATCH 034/264] mux: add a compatibility wrapper for the AVCodecParameters transition

2015-12-12 Thread Vittorio Giovara
On Sat, Dec 12, 2015 at 3:49 PM, Anton Khirnov wrote: > --- > libavformat/mux.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a/libavformat/mux.c b/libavformat/mux.c > index 7a51578..b10180e 100644 > --- a/libavformat/mux.c > +++ b/libavformat/mux.c >

Re: [libav-devel] [PATCH] parser: Suppress spurious warnings

2015-12-07 Thread Vittorio Giovara
On Mon, Dec 7, 2015 at 11:03 AM, Luca Barbato wrote: > On 07/12/15 16:55, Anton Khirnov wrote: >> Yes, so the API is broken. The right solution is to fix the API (which >> I'm going to do after TEP2). I think keeping the warning there is >> better, it should remind us of the

Re: [libav-devel] [PATCH 026/264] flvdec: do not create any streams in read_header()

2015-12-07 Thread Vittorio Giovara
On Sun, Dec 6, 2015 at 4:59 AM, Anton Khirnov wrote: > The current muxer behaviour is to create streams in read_header() based > on the audio/video presence flags, but fill in the stream parameters > later when we actually get some packets for them. This is rather shady, >

Re: [libav-devel] [PATCH] swfdec: support compressed swf

2015-12-07 Thread Vittorio Giovara
On Fri, Dec 4, 2015 at 6:13 AM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Fri, Dec 4, 2015 at 12:06 PM, Diego Biurrun <di...@biurrun.de> wrote: >> On Wed, Dec 02, 2015 at 06:41:00PM -0500, Vittorio Giovara wrote: >>> >>> --- a/libavformat/

[libav-devel] [PATCH] swfdec: support compressed swf

2015-12-07 Thread Vittorio Giovara
From: Clément Bœsch <ubi...@gmail.com> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Added Changelog entry and modified the inflate return value check as discussed with Luca. Vittorio Changelog| 1 + configure| 1 + libavformat/s

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
On Thu, Dec 3, 2015 at 3:48 AM, Anton Khirnov <an...@khirnov.net> wrote: > Quoting Vittorio Giovara (2015-11-30 18:19:36) >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. However they might very well be private, and, due to t

[libav-devel] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
is employed in a similarly way. Remove this functionality from AVCodecContex, these variable are mostly frame properties, and too few encoders support setting them with anything useful. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Amended commit message. Vittorio liba

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
On Thu, Dec 3, 2015 at 12:31 PM, Anton Khirnov <an...@khirnov.net> wrote: > Quoting Vittorio Giovara (2015-12-03 17:53:12) >> On Thu, Dec 3, 2015 at 3:48 AM, Anton Khirnov <an...@khirnov.net> wrote: >> > Quoting Vittorio Giovara (2015-11-30 18:19:36) >> >>

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-03 Thread Vittorio Giovara
On Thu, Dec 3, 2015 at 1:04 PM, Anton Khirnov wrote: >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. > > "leaked"? I already said it's not statistics. And they are very > deliberately exported. One can argue that we don't want to provide

Re: [libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-12-02 Thread Vittorio Giovara
On Wed, Dec 2, 2015 at 1:53 PM, Andreas Cadhalpun <andreas.cadhal...@googlemail.com> wrote: > On 30.11.2015 18:19, Vittorio Giovara wrote: >> These variables leaked from mpegvideoenc where are supposedly used for >> statistics. However they might very well be private, and, due

[libav-devel] [PATCH] matroskadec: Fix sample_aspect_ratio for stereo matroska content

2015-12-02 Thread Vittorio Giovara
email.com> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavformat/matroskadec.c | 35 +-- 1 file changed, 33 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index bdf2eb4..89c512b 100644

[libav-devel] [PATCH] swfdec: support compressed swf

2015-12-02 Thread Vittorio Giovara
From: Clément Bœsch <ubi...@gmail.com> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- configure| 1 + libavformat/swf.h| 13 libavformat/swfdec.c | 86 +--- 3 files changed, 96 insertions(+),

[libav-devel] [PATCH] sgienc: Make sure to initialize skipped header portions

2015-12-02 Thread Vittorio Giovara
Fix fate tests with asan. Introduced during bytestream2 porting (in revision 62cc8f4d79dad119e8efeaae080a58a8dcb1e89d). Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Got suggested to use plain _byte functions. Vittorio libavcodec/sgienc.c | 8 +--- 1 file chan

[libav-devel] [PATCH] sgienc: Make sure to initialize skipped header portions

2015-12-02 Thread Vittorio Giovara
Fix fate tests with asan. Introduced during bytestream2 porting (in revision 62cc8f4d79dad119e8efeaae080a58a8dcb1e89d). Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/sgienc.c | 8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/liba

Re: [libav-devel] [PATCH] g723: Add missing header

2015-12-02 Thread Vittorio Giovara
On Wed, Dec 2, 2015 at 6:45 PM, Luca Barbato wrote: > Unbreak make check. > --- > > libavcodec/g723_1.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/g723_1.h b/libavcodec/g723_1.h > index 3fd52df..166d897 100644 > --- a/libavcodec/g723_1.h > +++

Re: [libav-devel] [PATCH] lavc: Deprecate coder_type and its symbols

2015-11-30 Thread Vittorio Giovara
On Mon, Nov 30, 2015 at 12:20 PM, Luca Barbato <lu_z...@gentoo.org> wrote: > On 30/11/15 18:17, Vittorio Giovara wrote: >> +{ "none", NULL, 0, AV_OPT_TYPE_CONST, { .i64 = 0 }, >> INT_MIN, INT_MAX, VE, "coder" }, > >

[libav-devel] [RFC] [PATCH] lavc: Drop exporting 2-pass encoding stats

2015-11-30 Thread Vittorio Giovara
(for example AV_PKT_DATA_QUALITY_FACTOR) these fields are removed from the global context. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/aacenc.c| 12 libavcodec/avcodec.h | 17 - libavcodec/mpegvideo_enc.

[libav-devel] [PATCH] lavc: Deprecate coder_type and its symbols

2015-11-30 Thread Vittorio Giovara
Most option values are simply unused or ignored and in practice the majory of codecs only need to check whether to enable rle or not. Add appropriate codec private options which better expose the allowed features. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Fixed s

[libav-devel] [PATCH] vsrc_color: Drop unneeded variable

2015-11-24 Thread Vittorio Giovara
Bug-Id: CID 1339818 --- libavfilter/vsrc_color.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libavfilter/vsrc_color.c b/libavfilter/vsrc_color.c index b58c11a..8c8ca3f 100644 --- a/libavfilter/vsrc_color.c +++ b/libavfilter/vsrc_color.c @@ -57,7 +57,6 @@ typedef struct

Re: [libav-devel] [PATCH v3 2/3] avfoundation: basic working implementation

2015-11-24 Thread Vittorio Giovara
On Mon, Nov 23, 2015 at 7:55 PM, Luca Barbato wrote: > On 23/11/15 23:08, Alexandre Lision wrote: >> This commit adds basic support for video devices under OSX. >> Device is opened based on currently active format, and first pixel format >> available. >> --- >> configure

Re: [libav-devel] [PATCH 2/2] nut: Mark non-fatal errors as warnings

2015-11-24 Thread Vittorio Giovara
On Mon, Nov 23, 2015 at 7:25 PM, Luca Barbato wrote: > And make one more informative. > --- > libavformat/nutdec.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c > index 1778f42..b873e82 100644 > ---

Re: [libav-devel] [PATCH 1/2] nut: Provide more information on failure

2015-11-24 Thread Vittorio Giovara
On Mon, Nov 23, 2015 at 7:25 PM, Luca Barbato wrote: > --- > libavformat/nutdec.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) > > diff --git a/libavformat/nutdec.c b/libavformat/nutdec.c > index bf1ab7b..1778f42 100644 > --- a/libavformat/nutdec.c

Re: [libav-devel] [PATCH] sgi: Correctly propagate meaningful error values

2015-11-24 Thread Vittorio Giovara
On Tue, Nov 24, 2015 at 4:05 AM, Clément Bœsch <u...@pkh.me> wrote: > On Mon, Nov 23, 2015 at 06:56:34PM -0500, Vittorio Giovara wrote: > [...] >> if (length < 1) { >> av_free(encode_buf); >> -return -

[libav-devel] [PATCH] lavc: Deprecate coder_type and its symbols

2015-11-24 Thread Vittorio Giovara
Most option values are simply unused or ignored and in practice the majory of codecs only need to check whether to enable rle or not. Add appropriate codec private options which better expose the allowed features. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- Fixed t

Re: [libav-devel] [PATCH] libvpxenc: remove some unused ctrl id mappings

2015-11-23 Thread Vittorio Giovara
On Mon, Nov 23, 2015 at 12:38 PM, Luca Barbato wrote: > From: James Zern > > VP8E_UPD_ENTROPY, VP8E_UPD_REFERENCE, VP8E_USE_REFERENCE were removed > from libvpx and the remaining values were never used here > > Reviewed-by: Michael Niedermayer

Re: [libav-devel] [PATCH] configure: Clearly state that MSYS native builds are discouraged

2015-11-23 Thread Vittorio Giovara
On Sat, Nov 21, 2015 at 12:55 PM, Luca Barbato wrote: > MSYS, as per cygwin, by default uses a custom posix abstraction > in the form of a "msys2.dll". Programs build that way are harder to > distribute and use. > > MSYS2 provides alternate launcher scripts that provide a

[libav-devel] [PATCH 1/4] g723_1: Fix lsp2lpc() so it can handle values at the ends of the table

2015-11-23 Thread Vittorio Giovara
From: Michael Niedermayer <michae...@gmx.at> Fixes out of array reads. Found-by: Mateusz "j00ru" Jurczyk and Gynvael Coldwind Signed-off-by: Michael Niedermayer <michae...@gmx.at> Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/g723

[libav-devel] [PATCH 3/4] g723_1: Move sharable functions to a separate file

2015-11-23 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/Makefile| 4 +- libavcodec/g723_1.c| 268 libavcodec/g723_1.h| 141 - libavcodec/g723_1dec.c | 404 + 4

[libav-devel] [PATCH 4/4] g723_1 encoder

2015-11-23 Thread Vittorio Giovara
From: Mohamed Naufal <naufa...@gmail.com> Additional improvements by Michael Niedermayer <michae...@gmx.at>. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- doc/general.texi |2 +- libavcodec/Makefile|2 + libavcodec/allcodecs.c |

[libav-devel] [PATCH 2/4] g723_1: Rename files to better reflect their purpose

2015-11-23 Thread Vittorio Giovara
Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- libavcodec/Makefile| 2 +- libavcodec/{g723_1_data.h => g723_1.h} | 6 +++--- libavcodec/{g723_1.c => g723_1dec.c} | 2 +- 3 files changed, 5 insertions(+), 5 deletions(-) rename libavcodec/{g

[libav-devel] [PATCH] lavc: Deprecate coder_type and its symbols

2015-11-23 Thread Vittorio Giovara
Most option values are simply unused or ignored and in practice the majory of codecs only need to check whether to enable rle or not. Add appropriate codec private options which better expose the allowed features. Signed-off-by: Vittorio Giovara <vittorio.giov...@gmail.com> --- liba

[libav-devel] [PATCH 2/3] texturedspenc: Avoid using separate variables

2015-11-23 Thread Vittorio Giovara
Use the result directly, removing an unneeded cast. --- libavcodec/texturedspenc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/libavcodec/texturedspenc.c b/libavcodec/texturedspenc.c index a351bea..d2d9a34 100644 --- a/libavcodec/texturedspenc.c +++

[libav-devel] [PATCH 1/3] textureencdsp: cosmetics: Use normal static const for tables

2015-11-23 Thread Vittorio Giovara
--- libavcodec/texturedspenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavcodec/texturedspenc.c b/libavcodec/texturedspenc.c index 2036998..a351bea 100644 --- a/libavcodec/texturedspenc.c +++ b/libavcodec/texturedspenc.c @@ -32,13 +32,13 @@ #include

[libav-devel] [PATCH 3/3] texturedsp: Explicitly cast RGBA parameters to unsigned

2015-11-23 Thread Vittorio Giovara
Silences warnings when using -Wshift-overflow (GCC 6+). Found-by: James Almer --- libavcodec/texturedsp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/texturedsp.c b/libavcodec/texturedsp.c index 78eb6fa..58446b1 100644 ---

<    9   10   11   12   13   14   15   16   17   18   >