[libav-devel] [PATCH 1/2] fate: Move Canopus decoder tests to a separate file

2016-06-03 Thread Vittorio Giovara
--- tests/Makefile| 1 + tests/fate/canopus.mak| 33 + tests/fate/lossless-video.mak | 12 tests/fate/video.mak | 21 - 4 files changed, 34 insertions(+), 33 deletions(-) create mode 100644 tests/fa

Re: [libav-devel] [PATCH] avconv: Do not copyextradata if not empty

2016-06-03 Thread Vittorio Giovara
Wrong title, "avconv: Do not copy extradata if source buffer is empty". On Fri, Jun 3, 2016 at 12:14 PM, Vittorio Giovara wrote: > Fixes clang-usan runtime error "null pointer passed as argument 2, > which is declared to never be null" while streamcopyi

[libav-devel] [PATCH] avconv: Do not copyextradata if not empty

2016-06-03 Thread Vittorio Giovara
Fixes clang-usan runtime error "null pointer passed as argument 2, which is declared to never be null" while streamcopying. --- avconv.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/avconv.c b/avconv.c index d863103..2e3bde9 100644 --- a/avconv.c +++ b/avconv.c

[libav-devel] [PATCH 1/3] lavc: Document AV_PKT_DATA_NEW_EXTRADATA

2016-06-01 Thread Vittorio Giovara
--- I removed the code example to avoid any possible confusion with extradata handling. Vittorio libavcodec/avcodec.h | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index f33b7e5..01a6286 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/a

[libav-devel] [PATCH 3/3] mov: Implement support for multiple sample description tables

2016-06-01 Thread Vittorio Giovara
, enable this feature only for multiple avcC's. All other stsd types (such as hvc1 and hev1) need decoder-side changes, so they are left disabled for now. Signed-off-by: Vittorio Giovara --- I slightly simplified the stsc/stsd index tracking so that it's less wasteful. I tried the seeking wi

[libav-devel] [PATCH 2/3] h264: Support AV_PKT_DATA_NEW_EXTRADATA

2016-06-01 Thread Vittorio Giovara
--- I left the context extradata unchanged, and I process the new extradata directly. This fixed the crash at decoder_close. Vittorio libavcodec/h264.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 224ba2f..869b528 100644 --- a/li

[libav-devel] [PATCH] pixdesc: Use C99 array to list color properties names

2016-06-01 Thread Vittorio Giovara
--- libavutil/pixdesc.c | 73 - 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index b383cd4..7a53ba3 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -1595,32 +1595,69 @@ st

Re: [libav-devel] [PATCH 1/3] pixdesc: Use C99 array to list color properties names

2016-06-01 Thread Vittorio Giovara
On Wed, Jun 1, 2016 at 3:52 PM, Martin Storsjö wrote: > On Wed, 1 Jun 2016, Vittorio Giovara wrote: > >> --- >> libavutil/pixdesc.c | 73 >> - >> 1 file changed, 55 insertions(+), 18 deletions(-) > > > W

[libav-devel] [PATCH 1/3] pixdesc: Use C99 array to list color properties names

2016-06-01 Thread Vittorio Giovara
--- libavutil/pixdesc.c | 73 - 1 file changed, 55 insertions(+), 18 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index b383cd4..30405f3 100644 --- a/libavutil/pixdesc.c +++ b/libavutil/pixdesc.c @@ -1595,32 +1595,69 @@ st

[libav-devel] [PATCH 3/3] pixdesc: Make sure transfer characteristics names match x264 and x265

2016-06-01 Thread Vittorio Giovara
This allows to directly use av_color_transfer_name() return value as command line parameters for either encoders. --- libavutil/pixdesc.c | 6 +++--- libavutil/version.h | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/libavutil/pixdesc.c b/libavutil/pixdesc.c index 1c0a80e..

[libav-devel] [PATCH 2/3] pixfmt: Add ARIB STD-B76 color transfer characteristic

2016-06-01 Thread Vittorio Giovara
/doc_end_user/current_document.php?id=10481 And also with latest proposal for color format in mkv: https://mailarchive.ietf.org/arch/search/?email_list=cellar&gbt=1&q=Colour+Format+proposal Signed-off-by: Vittorio Giovara --- libavcodec/options_table.h | 1 + libavcodec/version.h

[libav-devel] [PATCH] avcodec/aic: add frame threading support

2016-06-01 Thread Vittorio Giovara
From: Paul B Mahol Signed-off-by: Paul B Mahol --- libavcodec/aic.c | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/libavcodec/aic.c b/libavcodec/aic.c index 5decc78..ff8e392 100644 --- a/libavcodec/aic.c +++ b/libavcodec/aic.c @@ -28,6 +28,7 @@ #include "get_bits.h"

[libav-devel] [PATCH] sgirledec: simplify, no need to use reget buffer

2016-06-01 Thread Vittorio Giovara
From: Paul B Mahol Signed-off-by: Paul B Mahol --- libavcodec/sgirledec.c | 32 +++- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/libavcodec/sgirledec.c b/libavcodec/sgirledec.c index 67d79c8..f636bbc 100644 --- a/libavcodec/sgirledec.c +++ b/libavc

Re: [libav-devel] [PATCH 3/3][RFC] mov: Implement support for multiple sample description tables

2016-05-31 Thread Vittorio Giovara
On Sat, May 28, 2016 at 12:09 AM, Luca Barbato wrote: > On 28/05/16 02:00, Vittorio Giovara wrote: >> Keep data from each stsd in a separate AVCodecParameter, and replace the >> stream one when the index in stsc table changes. Since extradata may >> change too, no

Re: [libav-devel] [PATCH 2/3][RFC] h264: Support AV_PKT_DATA_NEW_EXTRADATA

2016-05-31 Thread Vittorio Giovara
On Sat, May 28, 2016 at 2:40 AM, Anton Khirnov wrote: > Quoting Hendrik Leppkes (2016-05-28 02:30:27) >> On Sat, May 28, 2016 at 2:00 AM, Vittorio Giovara >> wrote: >> > --- >> > This triggers a bug in the h264 decoder: whenever the extradata is changed >>

Re: [libav-devel] [PATCH 1/3] lavc: Document AV_PKT_DATA_NEW_EXTRADATA

2016-05-31 Thread Vittorio Giovara
On Fri, May 27, 2016 at 8:31 PM, Hendrik Leppkes wrote: > On Sat, May 28, 2016 at 2:00 AM, Vittorio Giovara > wrote: >> --- >> libavcodec/avcodec.h | 23 +++ >> 1 file changed, 23 insertions(+) >> >> diff --git a/libavcodec/avcodec.h b/l

[libav-devel] [PATCH 2/3][RFC] h264: Support AV_PKT_DATA_NEW_EXTRADATA

2016-05-27 Thread Vittorio Giovara
--- This triggers a bug in the h264 decoder: whenever the extradata is changed avconv will crash trying to av_freep the context extradata. I'm not sure how to prevent that, does anybody have some ideas? Vittorio libavcodec/h264.c | 24 1 file changed, 24 insertions(+) di

[libav-devel] [PATCH 3/3][RFC] mov: Implement support for multiple sample description tables

2016-05-27 Thread Vittorio Giovara
Keep data from each stsd in a separate AVCodecParameter, and replace the stream one when the index in stsc table changes. Since extradata may change too, notify the decoder with AV_PKT_DATA_NEW_EXTRADATA. --- Note that I couldn't find a way to make this work while seeking: I can modify the packet e

[libav-devel] [PATCH 1/3] lavc: Document AV_PKT_DATA_NEW_EXTRADATA

2016-05-27 Thread Vittorio Giovara
--- libavcodec/avcodec.h | 23 +++ 1 file changed, 23 insertions(+) diff --git a/libavcodec/avcodec.h b/libavcodec/avcodec.h index bb54565..8b9bac8 100644 --- a/libavcodec/avcodec.h +++ b/libavcodec/avcodec.h @@ -1187,6 +1187,29 @@ typedef struct AVCPBProperties { */ enum A

Re: [libav-devel] [PATCH 2/3] [RFC] build: Simplify linker version script file handling

2016-05-27 Thread Vittorio Giovara
On Fri, May 27, 2016 at 2:39 PM, Diego Biurrun wrote: > --- > > Needs at least a more detailed log message. > Maybe also a comment in the version.h files that you need to bump > version in the .v files also. What is the benefit of this change? Having to modify 5+ files at bump rather than having

Re: [libav-devel] [PATCH] ac3: Check the array bound before dereferencing

2016-05-26 Thread Vittorio Giovara
On Wed, May 25, 2016 at 8:41 PM, Luca Barbato wrote: > CC: libav-sta...@libav.org > --- > > gcc 6.1 is getting smarter. > > libavcodec/ac3enc_template.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/ac3enc_template.c b/libavcodec/ac3enc_template.c > index 8fe

Re: [libav-devel] [PATCH 00/38] Convert to the new bitstream reader, set 3

2016-05-25 Thread Vittorio Giovara
On Wed, May 25, 2016 at 10:49 AM, Ronald S. Bultje wrote: > Hi, > > On Wed, May 25, 2016 at 9:54 AM, Luca Barbato wrote: > >> On 25/05/16 15:32, Ronald S. Bultje wrote: >> > I agree, ARM 32bit results would be very interesting. >> >> The odroid images I have are arm64 only (and I'm still figuring

Re: [libav-devel] get_bits.h to bitstream.h converstion table

2016-05-23 Thread Vittorio Giovara
On Mon, May 23, 2016 at 4:15 AM, Alexandra Hájková wrote: > GET_RL_VLC --> BITSTREAM_RL_VLC I find this a little strange, as it's the only ALL CAPS name. -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/lis

Re: [libav-devel] [PATCH 2/7] attributes: Add av_unlikely macro

2016-05-20 Thread Vittorio Giovara
On Fri, May 20, 2016 at 11:37 AM, Alexandra Hájková wrote: > --- > > Rebased patch. > > doc/APIchanges | 3 +++ > libavutil/attributes.h | 6 ++ > libavutil/version.h| 2 +- > 3 files changed, 10 insertions(+), 1 deletion(-) > > diff --git a/doc/APIchanges b/doc/APIchanges > index

Re: [libav-devel] [PATCH 3/8] mov: Fix parsing short loci

2016-05-18 Thread Vittorio Giovara
On Wed, May 18, 2016 at 3:18 PM, Martin Storsjö wrote: > On Wed, 18 May 2016, Vittorio Giovara wrote: > >> On Wed, May 18, 2016 at 7:02 AM, Martin Storsjö wrote: >>> >>> From: Michael Niedermayer >>> >>> Previously, we required the minimum numb

Re: [libav-devel] [PATCH 3/8] mov: Fix parsing short loci

2016-05-18 Thread Vittorio Giovara
On Wed, May 18, 2016 at 7:02 AM, Martin Storsjö wrote: > From: Michael Niedermayer > > Previously, we required the minimum number of bytes required for > the full box. Don't strictly require the astronomical body and additional > notes fields, but do require an altitude field (which currently isn

Re: [libav-devel] [PATCH 6/8] movenc: Write ?xyz geotag metadata for mov files

2016-05-18 Thread Vittorio Giovara
On Wed, May 18, 2016 at 7:02 AM, Martin Storsjö wrote: > From: Michael Niedermayer > > --- > libavformat/movenc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/movenc.c b/libavformat/movenc.c > index ae754e1..9b36ca9 100644 > --- a/libavformat/movenc.c > +++ b/libavformat/

Re: [libav-devel] [PATCH 5/8] mov: Also export loci altitude

2016-05-18 Thread Vittorio Giovara
On Wed, May 18, 2016 at 7:02 AM, Martin Storsjö wrote: > From: Michael Niedermayer > > --- > libavformat/mov.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 3130c32..0c1354b 100644 > --- a/libavformat/mov.c > +++ b

Re: [libav-devel] [PATCH 4/8] mov: Append place name instead of overwriting for loci

2016-05-18 Thread Vittorio Giovara
On Wed, May 18, 2016 at 7:02 AM, Martin Storsjö wrote: > From: Michael Niedermayer > > --- > libavformat/mov.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavformat/mov.c b/libavformat/mov.c > index 81803cf..3130c32 100644 > --- a/libavformat/mov.c > +++ b/li

Re: [libav-devel] [PATCH 1/2] xtea-test: Use struct allocation functions from the API

2016-05-17 Thread Vittorio Giovara
On Tue, May 17, 2016 at 12:49 PM, Diego Biurrun wrote: > --- > libavutil/tests/xtea.c | 24 ++-- > 1 file changed, 14 insertions(+), 10 deletions(-) > > diff --git a/libavutil/tests/xtea.c b/libavutil/tests/xtea.c > index 326f271..09a4daf 100644 > --- a/libavutil/tests/xtea.c

Re: [libav-devel] [PATCHv3 2/4] avprobe: Print stereo3d information

2016-05-17 Thread Vittorio Giovara
On Thu, Apr 21, 2016 at 5:18 PM, Vittorio Giovara wrote: > --- > avprobe.c | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/avprobe.c b/avprobe.c > index a0e14d4..44e2e5e 100644 > --- a/avprobe.c > +++ b/avprobe.c > @@ -27,6 +27,7 @@ >

Re: [libav-devel] [PATCH 11/19] h264: move initializing the slice start out of h264_slice_header_parse()

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:26 AM, Anton Khirnov wrote: > --- > libavcodec/h264.h | 1 + > libavcodec/h264_slice.c | 33 - > 2 files changed, 17 insertions(+), 17 deletions(-) ok i think -- Vittorio ___ libav-devel

Re: [libav-devel] [PATCH 05/19] h264: call ff_h264_fill_mbaff_ref_list() when constructing the normal ref list

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:25 AM, Anton Khirnov wrote: > There is no real reason to call it separately. > --- > libavcodec/h264.h | 1 - > libavcodec/h264_refs.c | 53 > ++--- > libavcodec/h264_slice.c | 2 -- > 3 files changed, 28 insertions(+

Re: [libav-devel] [PATCH 13/14] nvenc: De-compensate aspect ratio compensation of DVD-like content.

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:29 AM, Anton Khirnov wrote: > From: Philip Langdale > > For reasons we are not privy to, nvidia decided that the nvenc encoder > should apply aspect ratio compensation to 'DVD like' content, assuming that > the content is not bt.601 compliant, but needs to be bt.601 comp

Re: [libav-devel] [PATCH 19/19] lavc: add H.264 MVC profiles

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:26 AM, Anton Khirnov wrote: > --- > doc/APIchanges| 3 +++ > libavcodec/avcodec.h | 2 ++ > libavcodec/profiles.c | 2 ++ > libavcodec/version.h | 2 +- > 4 files changed, 8 insertions(+), 1 deletion(-) > Sure. -- Vittorio

Re: [libav-devel] [PATCH 15/19] h264: factor starting a new field out of parsing the slice header

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:26 AM, Anton Khirnov wrote: > --- > libavcodec/h264.h | 1 + > libavcodec/h264_slice.c | 357 > +--- > 2 files changed, 189 insertions(+), 169 deletions(-) probably ok -- Vittorio

Re: [libav-devel] [PATCH 01/14] nvenc: fix the rc option definitions

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:28 AM, Anton Khirnov wrote: > --- > libavcodec/nvenc_h264.c | 2 +- > libavcodec/nvenc_hevc.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) probably ok -- Vittorio ___ libav-devel mailing list libav-devel@libav.o

Re: [libav-devel] [PATCH 09/19] h264: move building the reference list out of h264_slice_header_parse()

2016-05-16 Thread Vittorio Giovara
On Mon, May 16, 2016 at 4:25 AM, Anton Khirnov wrote: > --- > libavcodec/h264_slice.c | 7 --- > 1 file changed, 4 insertions(+), 3 deletions(-) > Could you add some context in the commit log please? -- Vittorio ___ libav-devel mailing list libav-

Re: [libav-devel] [PATCH] avcodec: Validate the timebase

2016-05-13 Thread Vittorio Giovara
On Fri, May 13, 2016 at 1:15 PM, Luca Barbato wrote: > --- > libavcodec/utils.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/libavcodec/utils.c b/libavcodec/utils.c > index d42885d..b4fca03 100644 > --- a/libavcodec/utils.c > +++ b/libavcodec/utils.c > @@ -1063,6 +1063,14 @@ F

Re: [libav-devel] [PATCHv3.1 1/4] stereo3d: Add API to get name from value or value from name

2016-05-12 Thread Vittorio Giovara
On Wed, May 4, 2016 at 1:51 PM, wm4 wrote: > On Thu, 21 Apr 2016 17:24:07 -0400 > Vittorio Giovara wrote: > >> Use it in av_dump_format() instead of a huge switch case. >> --- >> Modified return value to avoid returning NULL. >> Vittorio >> >>

Re: [libav-devel] [PATCH 5/6] avio: Add avio_read wrapper to simplify error checking

2016-05-12 Thread Vittorio Giovara
Andreas, sorry we keep getting sidetracked, since you originally requested this API, would be able to send a patch with the appropriate rename/apichange/version bump? Thanks for your help. Vittorio On Sat, Mar 19, 2016 at 7:50 PM, Luca Barbato wrote: > On 19/03/16 21:55, Vittorio Giovara wr

Re: [libav-devel] [PATCH] Split global .gitignore file into per-directory files

2016-05-11 Thread Vittorio Giovara
On Wed, May 11, 2016 at 7:43 AM, Luca Barbato wrote: > On 11/05/16 12:13, Diego Biurrun wrote: >> --- > > Sounds good. This is a nice trick -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-de

Re: [libav-devel] [PATCH] simple_idct_template: Fix strict aliasing violation

2016-05-09 Thread Vittorio Giovara
On Mon, May 9, 2016 at 12:15 PM, Derek Buitenhuis wrote: > On 5/9/2016 5:13 PM, Vittorio Giovara wrote: >> *on gcc 4.4. > > On all compilers. 4.4 just happened to hit it. still relevant to mention it imho -- Vittorio ___ libav-devel mai

Re: [libav-devel] [PATCH 3/7] Add the new bitstream reader.

2016-05-09 Thread Vittorio Giovara
On Mon, May 9, 2016 at 6:41 AM, Alexandra Hájková wrote: >> >> >> Sorry to be a broken record here but these are still the wrong way round >> imo. Please can you consider using bitstream_read_long for the former and >> bitstream_read for the latter. It's so counter-intuitive to someone writing >>

Re: [libav-devel] [PATCH] simple_idct_template: Fix strict aliasing violation

2016-05-09 Thread Vittorio Giovara
On Sun, May 8, 2016 at 2:57 PM, Martin Storsjö wrote: > From: Michael Niedermayer > > This fixes fate-wmv8-intrax8. *on gcc 4.4. > --- > libavcodec/simple_idct_template.c | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/simple_idct_templat

Re: [libav-devel] [PATCH 5/5] latmenc: Convert to the new bitstream reader.

2016-05-09 Thread Vittorio Giovara
On Mon, May 9, 2016 at 6:52 AM, Luca Barbato wrote: > On 07/05/16 12:35, Alexandra Hájková wrote: >> +bitstream_init(&bc, par->extradata, par->extradata_size * 8); > > Those can be changed to init8 later, so it is ok. Why later? Let's change them now if it makes sense. -- Vittorio __

Re: [libav-devel] [PATCH 2/3] Add some more deprecation guards

2016-05-05 Thread Vittorio Giovara
On Wed, May 4, 2016 at 6:17 PM, Diego Biurrun wrote: > Avoids unused function/label/variable warnings after the next version bump. > --- > avconv.c | 2 ++ > libavcodec/error_resilience.c | 2 ++ > libavcodec/qtrleenc.c | 6 ++ > 3 files changed, 10 insertions(+)

Re: [libav-devel] [PATCH] avio: Remove a leftover comment

2016-05-04 Thread Vittorio Giovara
On Wed, May 4, 2016 at 2:50 PM, Martin Storsjö wrote: > The declarations that this comment referred to were removed > in 2439f2ca8 - there is no unbuffered IO in this header now. > --- > libavformat/avio.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavformat/avio.h b/libavformat/

Re: [libav-devel] [PATCHv3.1 1/4] stereo3d: Add API to get name from value or value from name

2016-05-04 Thread Vittorio Giovara
On Wed, Apr 27, 2016 at 11:39 AM, Vittorio Giovara wrote: > On Thu, Apr 21, 2016 at 5:24 PM, Vittorio Giovara > wrote: >> Use it in av_dump_format() instead of a huge switch case. >> --- >> Modified return value to avoid returning NULL. >> Vittorio &g

Re: [libav-devel] [PATCH] mmal: Add better codec long names

2016-05-04 Thread Vittorio Giovara
On Mon, May 2, 2016 at 1:31 PM, Diego Biurrun wrote: > --- > libavcodec/mmaldec.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/libavcodec/mmaldec.c b/libavcodec/mmaldec.c > index 193df7e..4bbb32c 100644 > --- a/libavcodec/mmaldec.c > +++ b/libavcodec/mmaldec

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-05-03 Thread Vittorio Giovara
On Tue, May 3, 2016 at 3:36 PM, Mark Thompson wrote: > On 03/05/16 16:50, Vittorio Giovara wrote: >> On Tue, May 3, 2016 at 7:25 AM, Anton Khirnov wrote: >>> Quoting Kieran Kunhya (2016-05-03 11:33:42) >>>> On Tue, 3 May 2016 at 07:43 Luca Barbato wrote: >&g

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-05-03 Thread Vittorio Giovara
On Tue, May 3, 2016 at 2:14 PM, Luca Barbato wrote: > On 04/05/16 00:50, Vittorio Giovara wrote: >> IMO Anton is right wrt common/uncommon, but Kieran is right for the >> trailing number being confusing. >> I would propose bitstream_uintread and bitstream_longread which would

Re: [libav-devel] [RFC PATCH 02/12] attributes: add av_unlikely macro

2016-05-03 Thread Vittorio Giovara
On Tue, May 3, 2016 at 1:35 PM, Alexandra Hájková wrote: >>> libavutil/attributes.h | 6 ++ >>> 1 file changed, 6 insertions(+) >> >> Just for documentation reasons for people not on IRC: >> >> [13:58] <@Daemon404> if it can be *proven* to speed up very core bits like >> bitreading, i am not

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-05-03 Thread Vittorio Giovara
On Tue, May 3, 2016 at 7:11 AM, Christophe Gisquet wrote: > For the 2nd aspect, you've already told you're not interested in that code, > but when replacing bitstream_read_32(s, 1) by bitstream_read_bit(s) at this > location: You know, the best way to make a dev care about some code is making sur

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-05-03 Thread Vittorio Giovara
On Tue, May 3, 2016 at 12:00 PM, Hendrik Leppkes wrote: > On Tue, May 3, 2016 at 5:50 PM, Vittorio Giovara > wrote: >> On Tue, May 3, 2016 at 7:25 AM, Anton Khirnov wrote: >>> Quoting Kieran Kunhya (2016-05-03 11:33:42) >>>> On Tue, 3 May 2016 at 07:43 Luca Bar

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-05-03 Thread Vittorio Giovara
On Tue, May 3, 2016 at 7:25 AM, Anton Khirnov wrote: > Quoting Kieran Kunhya (2016-05-03 11:33:42) >> On Tue, 3 May 2016 at 07:43 Luca Barbato wrote: >> >> > On 03/05/16 15:34, Kieran Kunhya wrote: >> > > I disagree, the old names are relatively clear. Whilst I think the speed >> > > improvements

Re: [libav-devel] [PATCH 1/2] rtpdec: Use AVERROR_PATCHWELCOME instead of AVERROR(ENOSYS) for unimplemented features

2016-04-29 Thread Vittorio Giovara
On Fri, Apr 29, 2016 at 1:38 PM, Martin Storsjö wrote: > --- > libavformat/rtpdec_h264.c | 2 +- > libavformat/rtpdec_vp9.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavformat/rtpdec_h264.c b/libavformat/rtpdec_h264.c > index d7b39ac..d7c5e15 100644 > --- a/li

Re: [libav-devel] [PATCH 1/3] Drop pointless assert.h #includes

2016-04-29 Thread Vittorio Giovara
On Fri, Apr 29, 2016 at 10:08 AM, Diego Biurrun wrote: > On Tue, Apr 19, 2016 at 04:37:10PM +0200, Diego Biurrun wrote: >> --- >> avconv_vdpau.c | 1 - >> libavcodec/ac3dsp.c | 1 - >> libavcodec/ffv1.c| 2 +- >> libavcodec/h264.c| 1

Re: [libav-devel] [PATCHv3.1 4/4] mov: Parse uuid box and detect spherical videos

2016-04-27 Thread Vittorio Giovara
On Wed, Apr 27, 2016 at 12:09 PM, Derek Buitenhuis wrote: > On 4/21/2016 10:24 PM, Vittorio Giovara wrote: >> +size_t len = atom.size - sizeof(uuid); >> +uint8_t *buffer = av_malloc(len + 1); >> +if (!buffer) >> +return AVERROR(ENOM

Re: [libav-devel] [PATCHv3.1 4/4] mov: Parse uuid box and detect spherical videos

2016-04-27 Thread Vittorio Giovara
On Thu, Apr 21, 2016 at 5:24 PM, Vittorio Giovara wrote: > --- > Updated to the new side data. > Vittorio > > libavformat/isom.h | 1 + > libavformat/mov.c | 89 > ++ > 2 files changed, 90 insertion

Re: [libav-devel] [PATCHv3.1 3/4] lavc: Add AVSphericalVideo side data

2016-04-27 Thread Vittorio Giovara
On Thu, Apr 21, 2016 at 5:24 PM, Vittorio Giovara wrote: > --- > Added my third interpretation of the spherical side data. > Vittorio > > avprobe.c| 8 > libavcodec/avcodec.h | 20 > libavcodec/version.h | 4 ++-- > l

Re: [libav-devel] [PATCHv3.1 1/4] stereo3d: Add API to get name from value or value from name

2016-04-27 Thread Vittorio Giovara
On Thu, Apr 21, 2016 at 5:24 PM, Vittorio Giovara wrote: > Use it in av_dump_format() instead of a huge switch case. > --- > Modified return value to avoid returning NULL. > Vittorio > > doc/APIchanges | 3 +++ > libavformat/dump.c | 33 +

Re: [libav-devel] [RFC PATCH 02/12] attributes: add av_unlikely macro

2016-04-27 Thread Vittorio Giovara
On Wed, Apr 27, 2016 at 7:37 AM, Alexandra Hájková wrote: > --- > libavutil/attributes.h | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavutil/attributes.h b/libavutil/attributes.h > index d7f2bb5..1a8d738 100644 > --- a/libavutil/attributes.h > +++ b/libavutil/attributes.h > @

Re: [libav-devel] [RFC PATCH 04/12] add the new bitstream reader

2016-04-27 Thread Vittorio Giovara
On Wed, Apr 27, 2016 at 9:04 AM, Anton Khirnov wrote: > Quoting Ronald S. Bultje (2016-04-27 14:37:20) >> Hi, >> >> On Wed, Apr 27, 2016 at 7:37 AM, Alexandra Hájková < >> alexandra.khirn...@gmail.com> wrote: >> >> > --- >> > libavcodec/bitstream.h | 475 >> > +

Re: [libav-devel] [PATCH 2/2] pgssub: Support BT709 subtitles

2016-04-25 Thread Vittorio Giovara
On Mon, Apr 25, 2016 at 11:09 AM, Hendrik Leppkes wrote: > On Mon, Apr 25, 2016 at 5:04 PM, Vittorio Giovara > wrote: >> On Mon, Apr 25, 2016 at 2:56 AM, Jan Ekstrom wrote: >>> On Apr 25, 2016 6:15 AM, "Vittorio Giovara" >>> wrote: >>>> >&

Re: [libav-devel] [PATCH 2/2] pgssub: Support BT709 subtitles

2016-04-25 Thread Vittorio Giovara
On Mon, Apr 25, 2016 at 2:56 AM, Jan Ekstrom wrote: > On Apr 25, 2016 6:15 AM, "Vittorio Giovara" > wrote: >> >> > +/* Default to BT.709 colorimetry. In case of <= 576 height use > BT.601 */ >> >> colorimetry? don't you mean col

Re: [libav-devel] [PATCH 2/2] pgssub: Support BT709 subtitles

2016-04-24 Thread Vittorio Giovara
On Sun, Apr 24, 2016 at 4:06 PM, Luca Barbato wrote: > From: Jan Ekström > > Use the frame dimension to guess what is what: > SD is BT.601, HD is BT.709 > > The default for is BT.709 due to most observed HDMV content being HD. > --- > > Some additional info here as well. > > libavcodec/pgssubdec

[libav-devel] [PATCH 1/2] dds: Drop gray-alpha swapping

2016-04-22 Thread Vittorio Giovara
The original sample was generate with invalid software. --- libavcodec/dds.c | 12 tests/ref/fate/dds-ya | 2 +- 2 files changed, 1 insertion(+), 13 deletions(-) diff --git a/libavcodec/dds.c b/libavcodec/dds.c index fcfc84e..f549cad 100644 --- a/libavcodec/dds.c +++ b/libavcod

[libav-devel] [PATCH 2/2] dds: Add support for monochrome images

2016-04-22 Thread Vittorio Giovara
--- libavcodec/dds.c | 4 tests/fate/image.mak | 1 + tests/ref/fate/dds-monob | 2 ++ 3 files changed, 7 insertions(+) create mode 100644 tests/ref/fate/dds-monob diff --git a/libavcodec/dds.c b/libavcodec/dds.c index f549cad..91e0c24 100644 --- a/libavcodec/dds.c +++ b/libavco

[libav-devel] [PATCHv3.1 2/4] avprobe: Print stereo3d information

2016-04-21 Thread Vittorio Giovara
--- avprobe.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/avprobe.c b/avprobe.c index a0e14d4..44e2e5e 100644 --- a/avprobe.c +++ b/avprobe.c @@ -27,6 +27,7 @@ #include "libavutil/display.h" #include "libavutil/opt.h" #include "libavutil/pixdesc.h" +#include "libavutil/ster

[libav-devel] [PATCHv3.1 3/4] lavc: Add AVSphericalVideo side data

2016-04-21 Thread Vittorio Giovara
--- Added my third interpretation of the spherical side data. Vittorio avprobe.c| 8 libavcodec/avcodec.h | 20 libavcodec/version.h | 4 ++-- libavformat/dump.c | 17 + 4 files changed, 47 insertions(+), 2 deletions(-) diff --git a/a

[libav-devel] [PATCHv3.1 1/4] stereo3d: Add API to get name from value or value from name

2016-04-21 Thread Vittorio Giovara
Use it in av_dump_format() instead of a huge switch case. --- Modified return value to avoid returning NULL. Vittorio doc/APIchanges | 3 +++ libavformat/dump.c | 33 + libavutil/stereo3d.c | 33 + libavutil/stereo3d.h | 18

[libav-devel] [PATCHv3.1 4/4] mov: Parse uuid box and detect spherical videos

2016-04-21 Thread Vittorio Giovara
--- Updated to the new side data. Vittorio libavformat/isom.h | 1 + libavformat/mov.c | 89 ++ 2 files changed, 90 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index aec623b..1221446 100644 --- a/libavformat/isom.h +++

[libav-devel] [PATCHv3 4/4] mov: Parse uuid box and detect spherical videos

2016-04-21 Thread Vittorio Giovara
--- libavformat/isom.h | 1 + libavformat/mov.c | 89 ++ 2 files changed, 90 insertions(+) diff --git a/libavformat/isom.h b/libavformat/isom.h index aec623b..1221446 100644 --- a/libavformat/isom.h +++ b/libavformat/isom.h @@ -138,6 +138,7 @@

[libav-devel] [PATCHv3 1/4] stereo3d: Add API to get name from value or value from name

2016-04-21 Thread Vittorio Giovara
Use it in av_dump_format() instead of a huge switch case. --- doc/APIchanges | 3 +++ libavformat/dump.c | 33 + libavutil/stereo3d.c | 33 + libavutil/stereo3d.h | 18 ++ libavutil/version.h | 2 +- 5 files

[libav-devel] [PATCHv3 2/4] avprobe: Print stereo3d information

2016-04-21 Thread Vittorio Giovara
--- avprobe.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/avprobe.c b/avprobe.c index a0e14d4..44e2e5e 100644 --- a/avprobe.c +++ b/avprobe.c @@ -27,6 +27,7 @@ #include "libavutil/display.h" #include "libavutil/opt.h" #include "libavutil/pixdesc.h" +#include "libavutil/ster

[libav-devel] [PATCHv3 3/4] lavc: Add AVSphericalType side data

2016-04-21 Thread Vittorio Giovara
--- avprobe.c| 8 libavcodec/avcodec.h | 20 libavcodec/version.h | 4 ++-- libavformat/dump.c | 17 + 4 files changed, 47 insertions(+), 2 deletions(-) diff --git a/avprobe.c b/avprobe.c index 44e2e5e..dfaf64f 100644 --- a/avprobe.c +

Re: [libav-devel] [PATCH] stereo3d: Add API to get name from value or value from name

2016-04-21 Thread Vittorio Giovara
On Tue, Apr 19, 2016 at 9:15 AM, Vittorio Giovara wrote: > Use it in av_dump_format() instead of a huge switch case. > Needed in the next commit as well. > --- > doc/APIchanges | 3 +++ > libavformat/dump.c | 33 + > libavut

[libav-devel] [PATCH] stereo3d: Add API to get name from value or value from name

2016-04-19 Thread Vittorio Giovara
Use it in av_dump_format() instead of a huge switch case. Needed in the next commit as well. --- doc/APIchanges | 3 +++ libavformat/dump.c | 33 + libavutil/stereo3d.c | 33 + libavutil/stereo3d.h | 18 ++ li

Re: [libav-devel] [PATCHv2 3/6] [RFC] lavc: Add AVSphericalType side data

2016-04-19 Thread Vittorio Giovara
On Tue, Apr 19, 2016 at 3:06 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-04-14 16:45:38) >> On Thu, Apr 14, 2016 at 5:53 AM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2016-04-11 23:28:27) >> >> --- >> >> I didn't want

Re: [libav-devel] [PATCH 2/6] x264: Forbid inverted Stereo3D mode

2016-04-18 Thread Vittorio Giovara
On Thu, Apr 14, 2016 at 11:47 AM, Vittorio Giovara wrote: > On Thu, Apr 14, 2016 at 5:47 AM, Anton Khirnov wrote: >> Quoting Vittorio Giovara (2016-04-11 18:38:43) >>> On Sun, Apr 10, 2016 at 2:55 AM, Anton Khirnov wrote: >>> > Quoting Vittorio Giovara (2016-04-07

Re: [libav-devel] [RFC] [PATCH] Cineform HD Decoder

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:18 AM, Anton Khirnov wrote: > Quoting Diego Biurrun (2016-04-16 14:57:20) >> From: Kieran Kunhya >> >> Decodes YUV 4:2:2 10-bit and RGB 12-bit files. >> Older files with more subbands, skips, Bayer, alpha not supported. >> Alpha requires addition of GBRAP12 pixel format.

Re: [libav-devel] [PATCH 16/16] h264: eliminate max_contexts

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > It is always equal to nb_slice_ctx. > --- > libavcodec/h264.c | 3 +-- > libavcodec/h264.h | 8 > libavcodec/h264_slice.c | 2 +- > 3 files changed, 2 insertions(+), 11 deletions(-) probably ok -- Vittorio

Re: [libav-devel] [PATCH 14/16] h264: remove an artificial restriction on the number of slice threads

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > This limit is now unnecessary, we can easily support an arbitrary number > of threads. > --- > libavcodec/h264.c | 5 ++--- > libavcodec/h264.h | 3 --- > libavcodec/h264_slice.c | 17 + > 3 files changed, 3 ins

Re: [libav-devel] [PATCH 13/16] h264: remove pointless setting of some variables in loop_filter

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > Those should already be set to the correct values. > --- > libavcodec/h264_slice.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/h264_slice.c b/libavcodec/h264_slice.c > index 809c8b9..d912429 100644 > --- a/libavcodec

Re: [libav-devel] [PATCH 12/16] h264: remove a pointless comment

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > --- > libavcodec/h264_slice.c | 3 --- > 1 file changed, 3 deletions(-) ok -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH 10/16] h264: remove H264Context.pict_type

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > It is not used for anything internally, just exported in the output > frames. So remove the indirection and set it directly in frame_start(). > --- > libavcodec/h264.c | 2 -- > libavcodec/h264.h | 2 -- > libavcodec/h264_slice.c

Re: [libav-devel] [PATCH 09/16] h264: drop a pointless indirection

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > --- > libavcodec/h264.h | 4 > libavcodec/h264_mb_template.c | 18 -- > libavcodec/h264_mc_template.c | 4 ++-- > libavcodec/h264_slice.c | 3 --- > 4 files changed, 14 insertions(+), 15 deletions(-)

Re: [libav-devel] [PATCH 08/16] h264: remove unused H264SliceContext.rbsp_buffer

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:26 AM, Anton Khirnov wrote: > --- > libavcodec/h264.c | 6 +- > libavcodec/h264.h | 4 > 2 files changed, 1 insertion(+), 9 deletions(-) ok -- Vittorio ___ libav-devel mailing list libav-devel@libav.org https://lists

Re: [libav-devel] [PATCH 07/16] h264: merge ff_h264_free_context() into h264_decode_end()

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > It is no longer called from outside the h264 decoder. > --- > libavcodec/h264.c | 74 > +-- > libavcodec/h264.h | 6 - > 2 files changed, 34 insertions(+), 46 deletions(-) should be

Re: [libav-devel] [PATCH 06/16] h264: eliminate low_delay

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > It is always unconditionally initialized in decode_postinit() and then > immediately used in one place further below. All the other places where > it is accessed are just useless fluff. > --- > libavcodec/h264.c | 10 +- > liba

Re: [libav-devel] [PATCH 05/16] h264: remove a stale comment

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > This comment used to apply to code that was removed. > --- > libavcodec/h264.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/libavcodec/h264.c b/libavcodec/h264.c > index 9280fb9..434d561 100644 > --- a/libavcodec/h264.c > +++ b/

Re: [libav-devel] [PATCH 04/16] h264_refs: remove an unused parameter from ff_h264_fill_mbaff_ref_list()

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > --- > libavcodec/h264.h | 2 +- > libavcodec/h264_refs.c | 2 +- > libavcodec/h264_slice.c | 2 +- > 3 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/h264.h b/libavcodec/h264.h > index 580c821..f551d79 1006

Re: [libav-devel] [PATCH 03/16] h264_refs: make the H264Context const where possible

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > --- > libavcodec/h264.h | 2 +- > libavcodec/h264_refs.c | 15 --- > 2 files changed, 9 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/h264.h b/libavcodec/h264.h > index ac6074b..580c821 100644 > --- a/libavcodec

Re: [libav-devel] [PATCH 02/16] h264_refs: reorder functions to avoid forward declarations

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > --- > libavcodec/h264_refs.c | 69 > -- > 1 file changed, 33 insertions(+), 36 deletions(-) > > diff --git a/libavcodec/h264_refs.c b/libavcodec/h264_refs.c > index 08c3bff..0a0cc8d 100644 > -

Re: [libav-devel] [PATCH 01/16] h264: eliminate copy_fields

2016-04-18 Thread Vittorio Giovara
On Mon, Apr 18, 2016 at 4:25 AM, Anton Khirnov wrote: > It is very fragile against fields being moved and hides what is actually > being copied. Copy all the fields explicitly instead. > --- > libavcodec/h264_slice.c | 22 -- > 1 file changed, 16 insertions(+), 6 deletions(-)

Re: [libav-devel] [PATCH 01/11] avcodec/mmaldec: Use av_assert0() instead of assert()

2016-04-14 Thread Vittorio Giovara
On Thu, Apr 14, 2016 at 6:47 AM, wm4 wrote: > On Thu, 14 Apr 2016 12:40:22 +0200 > Diego Biurrun wrote: > >> On Thu, Apr 14, 2016 at 12:21:17PM +0200, wm4 wrote: >> > --- a/libavcodec/mmaldec.c >> > +++ b/libavcodec/mmaldec.c >> > @@ -166,7 +166,7 @@ static void ffmmal_stop_decoder(AVCodecContext

Re: [libav-devel] [PATCH 2/6] x264: Forbid inverted Stereo3D mode

2016-04-14 Thread Vittorio Giovara
On Thu, Apr 14, 2016 at 5:47 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-04-11 18:38:43) >> On Sun, Apr 10, 2016 at 2:55 AM, Anton Khirnov wrote: >> > Quoting Vittorio Giovara (2016-04-07 18:17:54) >> >> On Thu, Apr 7, 2016 at 5:06 AM, Anton Khirnov w

Re: [libav-devel] [PATCH] img2enc: Refactor the atomic renaming code

2016-04-14 Thread Vittorio Giovara
On Thu, Apr 14, 2016 at 5:35 AM, Luca Barbato wrote: > And use it for the separate-plane side-feature as well. > --- > libavformat/img2enc.c | 74 > --- > 1 file changed, 47 insertions(+), 27 deletions(-) Does this fix bug 935? If so please mentio

Re: [libav-devel] [PATCHv2 3/6] [RFC] lavc: Add AVSphericalType side data

2016-04-14 Thread Vittorio Giovara
On Thu, Apr 14, 2016 at 5:53 AM, Anton Khirnov wrote: > Quoting Vittorio Giovara (2016-04-11 23:28:27) >> --- >> I didn't want to add additional function calls or types, so I concentrated >> everything in a single enumeration. >> Vittorio

<    5   6   7   8   9   10   11   12   13   14   >