Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-19 Thread Luca Barbato
On 19/10/13 14:08, Maxim Polijakowski wrote: > Please keep in mind that we're about to initialize >600k of memory at > avcodec_register(), i.e. at startup. startup is a slowpath so it is fine. > I don't know how fast the code is - moreover, I spent zero time to > optimize it, so running it always

Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-19 Thread Maxim Polijakowski
Am 19.10.2013 13:57, schrieb Luca Barbato: On 19/10/13 13:49, Maxim Polijakowski wrote: Am 19.10.2013 01:45, schrieb Luca Barbato: On 19/10/13 00:37, Maxim Polijakowski wrote: --> VLC tables have been made static. There is no dynamic allocation and deallocation anymore To initialize static da

Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-19 Thread Luca Barbato
On 19/10/13 13:49, Maxim Polijakowski wrote: > Am 19.10.2013 01:45, schrieb Luca Barbato: >> On 19/10/13 00:37, Maxim Polijakowski wrote: >>> --> VLC tables have been made static. There is no dynamic allocation and >>> deallocation anymore >> To initialize static data you might use the init_static_

Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-19 Thread Maxim Polijakowski
Am 19.10.2013 01:45, schrieb Luca Barbato: On 19/10/13 00:37, Maxim Polijakowski wrote: --> VLC tables have been made static. There is no dynamic allocation and deallocation anymore To initialize static data you might use the init_static_data callback, the rest seems ok to go to me. IIRC, ini

Re: [libav-devel] [PATCH] ATRAC3+ decoder, 2nd try

2013-10-18 Thread Luca Barbato
On 19/10/13 00:37, Maxim Polijakowski wrote: > --> VLC tables have been made static. There is no dynamic allocation and > deallocation anymore To initialize static data you might use the init_static_data callback, the rest seems ok to go to me. lu ___ l