[libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread j
Attached patch adds Ogg Skeleton 4 support to the ogg demuxer. For more info on OggIndex and Ogg Skeleton see https://wiki.xiph.org/Ogg_Skeleton_4 diff --git a/libavformat/oggparseskeleton.c b/libavformat/oggparseskeleton.c index e318e9e..6d4c8e0 100644 --- a/libavformat/oggparseskeleton.c +++

Re: [libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread Diego Biurrun
On Mon, Sep 26, 2011 at 10:46:23PM +0200, j...@v2v.cc wrote: Attached patch adds Ogg Skeleton 4 support to the ogg demuxer. For more info on OggIndex and Ogg Skeleton see https://wiki.xiph.org/Ogg_Skeleton_4 Please send patches via git-send-email. Use KR coding style with 4 space indentation.

Re: [libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread Luca Barbato
On 9/26/11 10:46 PM, j...@v2v.cc wrote: +static int skeleton_read_vlc (uint8_t ** data, int * size, int64_t * result) Isn't it the normal xiph_vlc? we should have it already implemented but I couldn't find it by a cursory look over. lu ___

Re: [libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 9/26/11 10:46 PM, j...@v2v.cc wrote: +static int skeleton_read_vlc (uint8_t ** data, int * size, int64_t * result) Isn't it the normal xiph_vlc? It's not the usual xiph roman vlc, it's the sane one. we should have it already implemented but I

Re: [libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread Luca Barbato
On 9/27/11 2:28 AM, Måns Rullgård wrote: Luca Barbatolu_z...@gentoo.org writes: On 9/26/11 10:46 PM, j...@v2v.cc wrote: +static int skeleton_read_vlc (uint8_t ** data, int * size, int64_t * result) Isn't it the normal xiph_vlc? It's not the usual xiph roman vlc, it's the sane one. we

Re: [libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread Måns Rullgård
Luca Barbato lu_z...@gentoo.org writes: On 9/27/11 2:28 AM, Måns Rullgård wrote: Luca Barbatolu_z...@gentoo.org writes: On 9/26/11 10:46 PM, j...@v2v.cc wrote: +static int skeleton_read_vlc (uint8_t ** data, int * size, int64_t * result) Isn't it the normal xiph_vlc? It's not the

Re: [libav-devel] [PATCH] Add Ogg Skeleton 4 decoding support

2011-09-26 Thread Luca Barbato
On 9/27/11 2:42 AM, Måns Rullgård wrote: Not quite, that reads from an AVIOContext, not a memory buffer. You are absolutely right ^^; I thought the function uses avio up there but does not. lu ___ libav-devel mailing list libav-devel@libav.org