Re: [libav-devel] [PATCH] Add support for CUVID decode

Hi, I had some comments in a mail from 2016-11-02, message id 20161102083330.15572.40655@localhost They don't seem to have been addressed. Also, could you please do one of: - send new patches as replies in one thread - number the new threads (such as v2, v3 etc.) so that it's simpler to find the

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 08, 2016 at 02:28:44PM +, Ruta Gadkari wrote: > On 11/08/2016 03:47 PM, Diego Biurrun wrote: > > This duplicates the AVHWaccel declaration and breaks in interesting ways. > Since HWACCEL is not used as a stand-alone, reverted to ff_cuvid_hwaccel > being defined only when

[libav-devel] [PATCH] Add support for CUVID decode

Please review patch to add support for CUVID decode in Libav. On 11/08/2016 03:47 PM, Diego Biurrun wrote: > This does not work like you think it does. When cuvid was requested you check > whether or not libnvcuvid is available. Settle on one name and use that > throughout. Corrected. Used

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: > From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 > From: Timo Rothenpieler > Date: Tue, 8 Nov 2016 14:13:23 +0530 > Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > > ---

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 08, 2016 at 11:38:43AM +0100, Hendrik Leppkes wrote: > On Tue, Nov 8, 2016 at 11:16 AM, Diego Biurrun wrote: > > On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: > >> From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 > >> From: Timo

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 8, 2016 at 11:16 AM, Diego Biurrun wrote: > On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: >> From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 >> From: Timo Rothenpieler >> Date: Tue, 8 Nov 2016 14:13:23

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 08, 2016 at 09:46:23AM +, Ruta Gadkari wrote: > From a4d39730fc6b4b0be80483d349cb367992d979ad Mon Sep 17 00:00:00 2001 > From: Timo Rothenpieler > Date: Tue, 8 Nov 2016 14:13:23 +0530 > Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > > ---

[libav-devel] [PATCH] Add support for CUVID decode

Please review patch to add support for CUVID decode in Libav. On 11/05/2016 04:17 PM, Diego Biurrun wrote: > This patch has grown. Now it adds cuvid support to avconv. Did Timo write > that? It's still under his name. If you create new functionality, do so in > separate patches. Patches

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Fri, Nov 04, 2016 at 09:37:50AM +, Ruta Gadkari wrote: > Please review patch to add support for CUVID decode in Libav. > > Also added cuvid hwaccel support. Probably Anton and/or Luca will have more to say about this. >

[libav-devel] [PATCH] Add support for CUVID decode

Please review patch to add support for CUVID decode in Libav. Also added cuvid hwaccel support. On 11/03/2016 10:40 PM, Diego Biurrun wrote: > What about the hwaccels? You need to hook up those as well (and test their > standalone compilation). Had missed out on hwaccels. Hooked those in

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Wed, Nov 02, 2016 at 08:15:01AM +, Ruta Gadkari wrote: > >> --- a/libavcodec/Makefile > >> +++ b/libavcodec/Makefile > > >As I said before, you do not add all the necessary entries. > > >See also > >https://www.libav.org/documentation/developer.html#New-codecs-or-formats-checklist > > I

Re: [libav-devel] [PATCH] Add support for CUVID decode

>From ddf28495a627f5e9d39a87682d4d9ba20f18e290 Mon Sep 17 00:00:00 2001 >From: Ruta Gadkari >Date: Tue, 1 Nov 2016 16:32:48 +0530 >Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > >--- > configure | 50 +++ > libavcodec/Makefile| 9 + >

[libav-devel] [PATCH] Add support for CUVID decode

Please review patch to add support for hardware accelerated CUVID decode in Libav. Changes incorporated from previous review comments, changed the commit author to Timo Rothenpieler. >> --- a/libavcodec/Makefile >> +++ b/libavcodec/Makefile >As I said before, you do not add all the

Re: [libav-devel] [PATCH] Add support for CUVID decode

On 10/27/2016 8:58 AM, Ruta Gadkari wrote: > From 31f2ef09647f120f3ad245db0ad4f5339171ff57 Mon Sep 17 00:00:00 2001 > From: rgadkari_test > Date: Thu, 27 Oct 2016 16:35:59 +0530 > Subject: [PATCH 1/1] CUVID: Add support for CUVID decode > > --- > configure |

Re: [libav-devel] [PATCH] Add support for CUVID decode

On 01/11/2016 12:54, Ruta Gadkari wrote: > Have kept Timo's authorship in copyright on file cuvid.c > Do you mean the "From" in the submitted patch as well? Depending on how much it is changed you can do that or you can mention him in the commit message. lu

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 01, 2016 at 11:12:12AM +, Ruta Gadkari wrote: > --- a/configure > +++ b/configure > @@ -234,6 +234,7 @@ External library support: > >The following libraries provide various hardware acceleration features: >--enable-cudaNvidia CUDA (dynamically linked) > +

Re: [libav-devel] [PATCH] Add support for CUVID decode

> Looks like your Git is misconfigured. Corrected my Git config in the new patch. > Also, this is an implementation written by Timo Rothenspieler for ffmpeg, so > keeping authorship alive would surely be appreciated. Have kept Timo's authorship in copyright on file cuvid.c Do you mean the

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Tue, Nov 01, 2016 at 11:15:55AM +, Ruta Gadkari wrote: > Thanks for your review. > I have updated the patch and taken care of all the review comments and sent a > new patch for review. What about Hendrik's question/comment? Diego ___

Re: [libav-devel] [PATCH] Add support for CUVID decode

Thanks for your review. I have updated the patch and taken care of all the review comments and sent a new patch for review. Regards Ruta --- This email message is for the sole use of the intended recipient(s) and

[libav-devel] [PATCH] Add support for CUVID decode

Patch to add support for hardware accelerated CUVID decode in Libav. Thanks Ruta --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any unauthorized

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Thu, Oct 27, 2016 at 11:58:50AM +, Ruta Gadkari wrote: > --- a/configure > +++ b/configure > @@ -1223,6 +1224,7 @@ HWACCEL_LIBRARY_NONFREE_LIST=" > " > HWACCEL_LIBRARY_LIST=" > $HWACCEL_LIBRARY_NONFREE_LIST > +cuvid Isn't cuvid nonfree? > @@ -2125,8 +2128,10 @@

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Thu, Oct 27, 2016 at 8:58 PM, Diego Biurrun wrote: > On Thu, Oct 27, 2016 at 11:58:50AM +, Ruta Gadkari wrote: >> From 31f2ef09647f120f3ad245db0ad4f5339171ff57 Mon Sep 17 00:00:00 2001 >> From: rgadkari_test > > Looks like your Git is misconfigured.

Re: [libav-devel] [PATCH] Add support for CUVID decode

On 27/10/2016 13:58, Ruta Gadkari wrote: > This patch adds support for hardware accelerated CUVID decode in Libav. > I wanted to test it a bit before giving you a full review but I couldn't do that today and yesterday. Hopefully I'll get through it during the weekend. Thank you a lot =) lu

Re: [libav-devel] [PATCH] Add support for CUVID decode

On Thu, Oct 27, 2016 at 11:58:50AM +, Ruta Gadkari wrote: > From 31f2ef09647f120f3ad245db0ad4f5339171ff57 Mon Sep 17 00:00:00 2001 > From: rgadkari_test Looks like your Git is misconfigured. > --- a/configure > +++ b/configure > @@ -1223,6 +1224,7 @@

[libav-devel] [PATCH] Add support for CUVID decode

This patch adds support for hardware accelerated CUVID decode in Libav. Thanks Ruta --- This email message is for the sole use of the intended recipient(s) and may contain confidential information. Any