[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-26 Thread Vittorio Giovara
--- Variable name change and two possible out of bounds reads spotted by Kostya. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 126 libavcodec/aliaspixenc.c |

Re: [libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-26 Thread Kostya Shishkov
On Wed, Mar 26, 2014 at 07:19:54PM +0100, Vittorio Giovara wrote: --- Variable name change and two possible out of bounds reads spotted by Kostya. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 126

Re: [libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-26 Thread Vittorio Giovara
On Wed, Mar 26, 2014 at 7:28 PM, Kostya Shishkov kostya.shish...@gmail.com wrote: On Wed, Mar 26, 2014 at 07:19:54PM +0100, Vittorio Giovara wrote: --- +x = avctx-width; x = 0; out_buf = f-data[0]; +while (bytestream2_get_bytes_left(gb) 0) { +int i; + +/* set

[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Vittorio Giovara
--- Amended as requested. Thanks for the reviews. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 115 + libavcodec/aliaspixenc.c | 130

Re: [libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Kostya Shishkov
On Thu, Mar 20, 2014 at 01:10:06PM +0100, Vittorio Giovara wrote: --- Amended as requested. Thanks for the reviews. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 115

[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Vittorio Giovara
--- Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 115 + libavcodec/aliaspixenc.c | 131 +++ libavcodec/allcodecs.c | 1 +

[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Vittorio Giovara
--- Some more tweaks Justin asked me. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 114 libavcodec/aliaspixenc.c | 132

Re: [libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Justin Ruggles
On 03/20/2014 11:57 AM, Vittorio Giovara wrote: --- Some more tweaks Justin asked me. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 114

[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Vittorio Giovara
--- Amended as asked by Justin. I only kept the avctx-pix_fmt checks because they look more readable to me. Cheers, Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 114

Re: [libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Justin Ruggles
On 03/20/2014 09:13 PM, Vittorio Giovara wrote: --- Amended as asked by Justin. I only kept the avctx-pix_fmt checks because they look more readable to me. Cheers, Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 +

[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Vittorio Giovara
--- Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 114 libavcodec/aliaspixenc.c | 132 +++ libavcodec/allcodecs.c | 1 +

[libav-devel] [PATCH] Alias PIX image encoder and decoder

2014-03-20 Thread Vittorio Giovara
--- Now with a working gray encoder. Vittorio Changelog| 1 + doc/general.texi | 2 + libavcodec/Makefile | 2 + libavcodec/aliaspixdec.c | 114 libavcodec/aliaspixenc.c | 134