Re: [libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-10 Thread Luca Barbato
On 10/12/14 03:56, Vittorio Giovara wrote: Sounds good, here is the proposed revised commit log: matroskadec: Fix read-after-free in matroska_read_seek() In matroska_read_seek(), |tracks| is assigned at the begining of the function. However, functions like matroska_parse_cues() could reallocat

Re: [libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-09 Thread Vittorio Giovara
On Tue, Dec 9, 2014 at 6:11 PM, Timothy Gu wrote: > On Tue, Dec 9, 2014 at 10:09 AM, Vittorio Giovara > wrote: >> On Tue, Dec 9, 2014 at 5:55 PM, Luca Barbato wrote: >>> On 09/12/14 15:53, Vittorio Giovara wrote: From: Xiaohan Wang Date: Thu, 6 Nov 2014 12:59:54 -0800 Subject

Re: [libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-09 Thread Timothy Gu
On Tue, Dec 9, 2014 at 10:09 AM, Vittorio Giovara wrote: > On Tue, Dec 9, 2014 at 5:55 PM, Luca Barbato wrote: >> On 09/12/14 15:53, Vittorio Giovara wrote: >>> >>> From: Xiaohan Wang >>> Date: Thu, 6 Nov 2014 12:59:54 -0800 >>> Subject: [PATCH] Fix read-after-free in matroska_read_seek(). >>> >>

Re: [libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-09 Thread Vittorio Giovara
On Tue, Dec 9, 2014 at 5:55 PM, Luca Barbato wrote: > On 09/12/14 15:53, Vittorio Giovara wrote: >> >> From: Xiaohan Wang >> Date: Thu, 6 Nov 2014 12:59:54 -0800 >> Subject: [PATCH] Fix read-after-free in matroska_read_seek(). >> >> In matroska_read_seek(),|tracks| is assigned at the begining of

Re: [libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-09 Thread Luca Barbato
On 09/12/14 15:53, Vittorio Giovara wrote: From: Xiaohan Wang Date: Thu, 6 Nov 2014 12:59:54 -0800 Subject: [PATCH] Fix read-after-free in matroska_read_seek(). In matroska_read_seek(),|tracks| is assigned at the begining of the function. However, functions like matroska_parse_cues() could real

[libav-devel] [PATCH] Fix read-after-free in matroska_read_seek()

2014-12-09 Thread Vittorio Giovara
From: Xiaohan Wang Date: Thu, 6 Nov 2014 12:59:54 -0800 Subject: [PATCH] Fix read-after-free in matroska_read_seek(). In matroska_read_seek(),|tracks| is assigned at the begining of the function. However, functions like matroska_parse_cues() could reallocate the tracks so that|tracks| can get i