Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-24 Thread Sean McGovern
Nevermind, apparently I didn't read down far enough and inet_pton() is in that same _BSD_VISIBLE #ifdef. -- Sean On 4/24/11, Sean McGovern wrote: > 2011/4/24 Måns Rullgård > >> Diego Biurrun writes: >> >> > On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns Rullgård wrote: >> >> Diego Biurrun wri

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-24 Thread Sean McGovern
2011/4/24 Måns Rullgård > Diego Biurrun writes: > > > On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns Rullgård wrote: > >> Diego Biurrun writes: > >> > > >> > The FreeBSD FATE box passes '-D__BSD_VISIBLE -D__XSI_VISIBLE=600' as > >> > extra CFLAGS to configure: > >> > > >> > http://fate.libav.or

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-24 Thread Måns Rullgård
Diego Biurrun writes: > On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns Rullgård wrote: >> Diego Biurrun writes: >> > >> > The FreeBSD FATE box passes '-D__BSD_VISIBLE -D__XSI_VISIBLE=600' as >> > extra CFLAGS to configure: >> > >> > http://fate.libav.org/x86_32-freebsd-gcc-4.4/20110423101824 >>

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Diego Biurrun
On Sat, Apr 23, 2011 at 04:29:36PM +0100, Måns Rullgård wrote: > Diego Biurrun writes: > > > > The FreeBSD FATE box passes '-D__BSD_VISIBLE -D__XSI_VISIBLE=600' as > > extra CFLAGS to configure: > > > > http://fate.libav.org/x86_32-freebsd-gcc-4.4/20110423101824 > > > > I think the DragonFlay box

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Måns Rullgård
Diego Biurrun writes: > On Sat, Apr 23, 2011 at 01:04:49PM +0300, Martin Storsjö wrote: >> >> As far as I can see, there's nothing else you can define to make it work, >> except undefining _POSIX_C_SOURCE. Here's the relevant parts of >> sys/cdefs.h >> (http://gitweb.dragonflybsd.org/dragonfl

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Luca Barbato
On 4/23/11 12:26 PM, Diego Biurrun wrote: On Sat, Apr 23, 2011 at 01:04:49PM +0300, Martin Storsjö wrote: As far as I can see, there's nothing else you can define to make it work, except undefining _POSIX_C_SOURCE. Here's the relevant parts of sys/cdefs.h (http://gitweb.dragonflybsd.org/dragonf

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Diego Biurrun
On Sat, Apr 23, 2011 at 01:04:49PM +0300, Martin Storsjö wrote: > > As far as I can see, there's nothing else you can define to make it work, > except undefining _POSIX_C_SOURCE. Here's the relevant parts of > sys/cdefs.h > (http://gitweb.dragonflybsd.org/dragonfly.git/blob?f=sys/sys/cdefs.h):

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-23 Thread Martin Storsjö
On Fri, 22 Apr 2011, Måns Rullgård wrote: > Martin Storsjö writes: > > > On Fri, 22 Apr 2011, Måns Rullgård wrote: > > > >> __BSD_VISIBLE should not be set directly, IIRC. _BSD_SOURCE is the > >> correct symbol to define. This can be done with add_cppflags -D_BSD_SOURCE > >> in the relevant OS

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Måns Rullgård
Martin Storsjö writes: > On Fri, 22 Apr 2011, Måns Rullgård wrote: > >> "Ronald S. Bultje" writes: >> >> > Hi, >> > >> > On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö wrote: >> >> Setting this should fix the FATE build failure on DragonFly BSD, >> >> since inet_aton only is visible if __BSD_

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Martin Storsjö
On Fri, 22 Apr 2011, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > > > Hi, > > > > On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö wrote: > >> Setting this should fix the FATE build failure on DragonFly BSD, > >> since inet_aton only is visible if __BSD_VISIBLE is set. > >> > >> Alternati

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö wrote: >> Setting this should fix the FATE build failure on DragonFly BSD, >> since inet_aton only is visible if __BSD_VISIBLE is set. >> >> Alternatively, a line defining __BSD_VISIBLE=1 could be >> added at th

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Martin Storsjö
On Fri, 22 Apr 2011, Diego Biurrun wrote: > On Fri, Apr 22, 2011 at 12:48:16AM +0300, Martin Storsjö wrote: > > Setting this should fix the FATE build failure on DragonFly BSD, > > since inet_aton only is visible if __BSD_VISIBLE is set. > > > > --- a/doc/general.texi > > +++ b/doc/general.texi >

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Diego Biurrun
On Fri, Apr 22, 2011 at 12:48:16AM +0300, Martin Storsjö wrote: > Setting this should fix the FATE build failure on DragonFly BSD, > since inet_aton only is visible if __BSD_VISIBLE is set. > > --- a/doc/general.texi > +++ b/doc/general.texi > @@ -784,9 +784,9 @@ to configure. > > -@subsubsectio

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-22 Thread Diego Biurrun
On Thu, Apr 21, 2011 at 06:30:57PM -0400, Ronald S. Bultje wrote: > > On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö wrote: > > Setting this should fix the FATE build failure on DragonFly BSD, > > since inet_aton only is visible if __BSD_VISIBLE is set. > > > > Alternatively, a line defining __B

Re: [libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-21 Thread Ronald S. Bultje
Hi, On Thu, Apr 21, 2011 at 5:48 PM, Martin Storsjö wrote: > Setting this should fix the FATE build failure on DragonFly BSD, > since inet_aton only is visible if __BSD_VISIBLE is set. > > Alternatively, a line defining __BSD_VISIBLE=1 could be > added at the top of os_support.c. For FreeBSD, sim

[libav-devel] [PATCH] Mention that DragonFly BSD requires __BSD_VISIBLE set

2011-04-21 Thread Martin Storsjö
Setting this should fix the FATE build failure on DragonFly BSD, since inet_aton only is visible if __BSD_VISIBLE is set. Alternatively, a line defining __BSD_VISIBLE=1 could be added at the top of os_support.c. For FreeBSD, similar lines are required in libavdevice/bktr.c and libavdevice/oss_audi