Re: [libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-17 Thread Justin Ruggles
On 01/17/2013 11:24 AM, Ronald S. Bultje wrote: > + > +#include "libavutil/attributes.h" Why is attributes.h needed? > +#include "libavutil/cpu.h" > +#include "libavutil/arm/cpu.h" > +#include "libavcodec/vorbisdsp.h" > + > +void ff_vorbis_inverse_coupling_neon(float *mag, float *ang, int blocksi

[libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-17 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Conveniently (together with Justin's earlier patches), this makes our vorbis decoder entirely independent of dsputil. (Untested on ppc/arm.) --- libavcodec/Makefile | 2 +- libavcodec/arm/Makefile | 3 ++ libavcodec/arm/dsputil_init_neon.

Re: [libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-16 Thread Diego Biurrun
On Tue, Jan 15, 2013 at 04:10:34PM -0800, Ronald S. Bultje wrote: > On Tue, Jan 15, 2013 at 3:10 PM, Diego Biurrun wrote: > >> +#include "libavutil/common.h" > >> +#include "vorbisdsp.h" > >> +#include "vorbis.h" > > > > Only vorbisdsp.h is needed. > > Uhm, no. You've not tested your own suggesti

Re: [libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-15 Thread Ronald S. Bultje
Hi, On Tue, Jan 15, 2013 at 3:10 PM, Diego Biurrun wrote: >> +#include "libavutil/common.h" >> +#include "vorbisdsp.h" >> +#include "vorbis.h" > > Only vorbisdsp.h is needed. Uhm, no. You've not tested your own suggestions. Once tested, please send counter-patches (which you've by then already

Re: [libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-15 Thread Diego Biurrun
On Tue, Jan 15, 2013 at 02:17:14PM -0800, Ronald S. Bultje wrote: > From: "Ronald S. Bultje" > > Conveniently (together with Justin's earlier patches), this makes > our vorbis decoder entirely independent of dsputil. > > (Untested on ppc/arm.) > --- *PLEASE* use --annotate instead of cluttering

[libav-devel] [PATCH] Move vorbis_inverse_coupling from dsputil to vorbisdspcontext.

2013-01-15 Thread Ronald S. Bultje
From: "Ronald S. Bultje" Conveniently (together with Justin's earlier patches), this makes our vorbis decoder entirely independent of dsputil. (Untested on ppc/arm.) --- libavcodec/Makefile | 2 +- libavcodec/arm/Makefile | 3 ++ libavcodec/arm/dsputil_init_neo