Re: [libav-devel] [PATCH] yadif: Port inline assembly to YASM

2013-01-09 Thread Luca Barbato
On 09/01/13 16:34, Daniel Kang wrote: > --- > Updated with Loren's suggestion. > --- > libavfilter/x86/Makefile |3 +- > libavfilter/x86/yadif.asm| 242 +++ > libavfilter/x86/yadif.c | 74 --- > libavfilter/x86/yadif_init.c

[libav-devel] [PATCH] yadif: Port inline assembly to YASM

2013-01-09 Thread Daniel Kang
--- Updated with Loren's suggestion. --- libavfilter/x86/Makefile |3 +- libavfilter/x86/yadif.asm| 242 +++ libavfilter/x86/yadif.c | 74 --- libavfilter/x86/yadif_init.c | 54 libavfilter/x86/yadif_template.c

[libav-devel] [PATCH] yadif: Port inline assembly to YASM

2013-01-09 Thread Diego Biurrun
From: Daniel Kang Signed-off-by: Diego Biurrun --- Patch unchanged except for better file names. libavfilter/x86/Makefile |3 +- libavfilter/x86/yadif.asm | 242 ++ libavfilter/x86/{yadif.c => yadif_init.c} | 60 +++- libavfi

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-07 Thread Loren Merritt
On Sat, 5 Jan 2013, Daniel Kang wrote: > +%macro CHECK1 0 > +movam3, m0 > +pcmpgtw m3, m2 > +pminsw m0, m2 > +movam6, m3 > +pandm5, m3 > +pandn m3, m1 > +por m3, m5 > +movam1, m3 sse4: pblendvb --Loren Merritt __

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-06 Thread Diego Biurrun
On Sat, Jan 05, 2013 at 05:55:59PM -0500, Daniel Kang wrote: > On Sat, Jan 5, 2013 at 5:47 PM, Diego Biurrun wrote: > > On Sat, Jan 05, 2013 at 12:48:58PM -0500, Daniel Kang wrote: > >> On Sat, Jan 5, 2013 at 12:29 PM, Diego Biurrun wrote: > >> > On Sat, Jan 05, 2013 at 11:01:19AM -0600, Daniel K

[libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
--- Addresses Justin's comments. --- libavfilter/x86/Makefile |1 + libavfilter/x86/yadif.c | 60 +++-- libavfilter/x86/yadif_template.c | 261 -- libavfilter/x86/yadif_yasm.asm | 249 4 files c

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Justin Ruggles
On 01/05/2013 05:57 PM, Daniel Kang wrote: > +%else > +pshufw m3, m2, 9 > +%endif use base-4 please. q0021 -Justin ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Justin Ruggles
On 01/05/2013 05:57 PM, Daniel Kang wrote: > +#if HAVE_YASM > + > +#if ARCH_X86_32 > +void ff_yadif_filter_line_mmxext(uint8_t *dst, uint8_t *prev, uint8_t *cur, > + uint8_t *next, int w, int prefs, > + int mrefs, int parity, int mode)

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Justin Ruggles
On 01/05/2013 05:57 PM, Daniel Kang wrote: > av_cold void ff_yadif_init_x86(YADIFContext *yadif) > { > int cpu_flags = av_get_cpu_flags(); > > -#if HAVE_MMXEXT_INLINE > +#if HAVE_YASM > +#if ARCH_X86_32 && HAVE_MMXEXT_EXTERNAL > if (cpu_flags & AV_CPU_FLAG_MMXEXT) > -yadif->fi

[libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
--- Fixes some more of Diego's comments. --- libavfilter/x86/Makefile |1 + libavfilter/x86/yadif.c | 63 - libavfilter/x86/yadif_template.c | 261 -- libavfilter/x86/yadif_yasm.asm | 249

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
On Sat, Jan 5, 2013 at 5:47 PM, Diego Biurrun wrote: > On Sat, Jan 05, 2013 at 12:48:58PM -0500, Daniel Kang wrote: >> On Sat, Jan 5, 2013 at 12:29 PM, Diego Biurrun wrote: >> > On Sat, Jan 05, 2013 at 11:01:19AM -0600, Daniel Kang wrote: >> >> >> >> --- a/libavfilter/x86/yadif.c >> >> +++ b/liba

[libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
--- Addresses Deigo's and Kerian's comments. Addresses Ronald's first round of comments. I'll fix the rest in another patch. --- libavfilter/x86/Makefile |1 + libavfilter/x86/yadif.c | 59 - libavfilter/x86/yadif_template.c | 261 --

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Diego Biurrun
On Sat, Jan 05, 2013 at 12:48:58PM -0500, Daniel Kang wrote: > On Sat, Jan 5, 2013 at 12:29 PM, Diego Biurrun wrote: > > On Sat, Jan 05, 2013 at 11:01:19AM -0600, Daniel Kang wrote: > >> > >> --- a/libavfilter/x86/yadif.c > >> +++ b/libavfilter/x86/yadif.c > >> av_cold void ff_yadif_init_x86(YADI

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Kieran Kunhya
On Sat, Jan 5, 2013 at 5:01 PM, Daniel Kang wrote: > - * Libav is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License as published by You appear to have changed the licence of the ASM. ___ liba

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Ronald S. Bultje
Hi, actual asm now: On Sat, Jan 5, 2013 at 9:01 AM, Daniel Kang wrote: > +%macro CHECK 2 > +movu m2, [curq+mrefsq+%1] > +movu m3, [curq+prefsq+%2] > +mova m4, m2 > +mova m5, m2 > +pxor m4, m3 > +pavgb m5, m3 pxor m4, m2, m3 pavgb m5, m2, m3

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
On Sat, Jan 5, 2013 at 12:29 PM, Diego Biurrun wrote: > On Sat, Jan 05, 2013 at 11:01:19AM -0600, Daniel Kang wrote: >> >> --- a/libavfilter/x86/Makefile >> +++ b/libavfilter/x86/Makefile >> @@ -4,3 +4,4 @@ OBJS-$(CONFIG_YADIF_FILTER) += x86/yadif.o >> >> YASM-OBJS-$(CONFIG_HQDN3

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Hendrik Leppkes
On Sat, Jan 5, 2013 at 6:43 PM, Daniel Kang wrote: > >> That way stack alignment works on msvc also. Now, this is harder >> because you'll need to use only 6 regs on msvc (instead of 7), because >> the 7th one needs to hold the stack pointer. You can test locally by >> changing HAVE_INLINE_ASM fro

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
On Sat, Jan 5, 2013 at 12:17 PM, Ronald S. Bultje wrote: > Hi, > > On Sat, Jan 5, 2013 at 9:01 AM, Daniel Kang wrote: >> --- a/libavfilter/x86/yadif.c >> +++ b/libavfilter/x86/yadif.c >> @@ -26,49 +26,34 @@ >> #include "libavcodec/x86/dsputil_mmx.h" >> #include "libavfilter/yadif.h" >> >> -#if

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Diego Biurrun
On Sat, Jan 05, 2013 at 11:01:19AM -0600, Daniel Kang wrote: > > --- a/libavfilter/x86/Makefile > +++ b/libavfilter/x86/Makefile > @@ -4,3 +4,4 @@ OBJS-$(CONFIG_YADIF_FILTER) += x86/yadif.o > > YASM-OBJS-$(CONFIG_HQDN3D_FILTER)+= x86/hqdn3d.o > YASM-OBJS-$(CONFIG_V

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Ronald S. Bultje
Hi, On Sat, Jan 5, 2013 at 9:01 AM, Daniel Kang wrote: > --- a/libavfilter/x86/yadif.c > +++ b/libavfilter/x86/yadif.c > @@ -26,49 +26,34 @@ > #include "libavcodec/x86/dsputil_mmx.h" > #include "libavfilter/yadif.h" > > -#if HAVE_INLINE_ASM > +#if HAVE_YASM > > DECLARE_ASM_CONST(16, const xmm_

Re: [libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
If someone could test this on msvc 32/64-bit that would be great. ___ libav-devel mailing list libav-devel@libav.org https://lists.libav.org/mailman/listinfo/libav-devel

[libav-devel] [PATCH] YADIF: Port inline assembly to YASM

2013-01-05 Thread Daniel Kang
--- libavfilter/x86/Makefile |1 + libavfilter/x86/yadif.c | 43 ++- libavfilter/x86/yadif_template.c | 261 -- libavfilter/x86/yadif_yasm.asm | 246 +++ 4 files changed, 261 insertions(+), 290 delet