Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Diego Biurrun
On Mon, Jul 23, 2012 at 08:56:55PM -0400, Derek Buitenhuis wrote: > On 23/07/2012 8:54 PM, Uoti Urpala wrote: > > No, the MP3 decoder is already "MP3 (MPEG audio layer 3)", matching what > > I suggested changing AAC to. The name you quoted above is from the > > libavformat _demuxer_. Thus this make

Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Uoti Urpala
On Tue, 2012-07-24 at 01:48 +0100, Måns Rullgård wrote: > Derek Buitenhuis writes: > > > On 23/07/2012 8:15 PM, Diego Biurrun wrote: > >> Most people know the codec as "AAC" and not "Advanced Audio Coding". > >> --- > >> libavcodec/aacdec.c |2 +- > >> 1 files changed, 1 insertions(+), 1 del

Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Derek Buitenhuis
On 23/07/2012 8:54 PM, Uoti Urpala wrote: > No, the MP3 decoder is already "MP3 (MPEG audio layer 3)", matching what > I suggested changing AAC to. The name you quoted above is from the > libavformat _demuxer_. Thus this makes the audio codecs more consistent, > but there is already an inconsistenc

Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Uoti Urpala
On Mon, 2012-07-23 at 20:43 -0400, Derek Buitenhuis wrote: > On 23/07/2012 8:15 PM, Diego Biurrun wrote: > > Most people know the codec as "AAC" and not "Advanced Audio Coding". > > --- > > libavcodec/aacdec.c |2 +- > > 1 files changed, 1 insertions(+), 1 deletions(-) > > OK. But, should we

Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Derek Buitenhuis
On 23/07/2012 8:48 PM, Måns Rullgård wrote: >> OK. But, should we not change e.g. MP3? > MP3 is not an official designation whatsoever. I was going by the rationale of this patch. "Most people will recognize 'MP3'." Merely a musing. - Derek ___ libav-

Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Måns Rullgård
Derek Buitenhuis writes: > On 23/07/2012 8:15 PM, Diego Biurrun wrote: >> Most people know the codec as "AAC" and not "Advanced Audio Coding". >> --- >> libavcodec/aacdec.c |2 +- >> 1 files changed, 1 insertions(+), 1 deletions(-) > > OK. But, should we not change e.g. MP3? MP3 is not an o

Re: [libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Derek Buitenhuis
On 23/07/2012 8:15 PM, Diego Biurrun wrote: > Most people know the codec as "AAC" and not "Advanced Audio Coding". > --- > libavcodec/aacdec.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) OK. But, should we not change e.g. MP3? It is currently: "MPEG audio layer 2/3" - Derek __

[libav-devel] [PATCH] aac: Mention abbreviation as well in long_name

2012-07-23 Thread Diego Biurrun
Most people know the codec as "AAC" and not "Advanced Audio Coding". --- libavcodec/aacdec.c |2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 4be5255..76d4120 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -284