Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Anton Khirnov
On Sun, 19 Aug 2012 15:02:22 -0700, "Ronald S. Bultje" wrote: > Hi, > > On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: > > > > On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" > > wrote: > >> From: "Ronald S. Bultje" > >> > >> --- > >> libavcodec/aacdec.c | 3 ++- > >> 1 file

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Ronald S. Bultje
Hi, On Sun, Aug 19, 2012 at 3:08 PM, Måns Rullgård wrote: > "Ronald S. Bultje" writes: > >> Hi, >> >> On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: >>> >>> On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" >>> wrote: From: "Ronald S. Bultje" --- libavcodec/

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: >> >> On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" >> wrote: >>> From: "Ronald S. Bultje" >>> >>> --- >>> libavcodec/aacdec.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Ronald S. Bultje
Hi, On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: > > On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" > wrote: >> From: "Ronald S. Bultje" >> >> --- >> libavcodec/aacdec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/aacdec.c b/libav

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Derek Buitenhuis
On 19/08/2012 12:23 PM, Måns Rullgård wrote: >> Indeed not, but it would seem to make it more consistent with the rest of >> the code, no? (See: line directly under it). > > No, and stop making shit up. Let me be clear: I don't care if this patch is rejected or accepted. Rather than 'making shit

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Måns Rullgård
Derek Buitenhuis writes: > On 19/08/2012 7:25 AM, Måns Rullgård wrote: >>> +s.f = *scale; >>> t.i = s.i ^ (sign & 1U<<31); >>> *dst++ = v[idx& 3] * t.f; >>> >>> -- >> That is not a simplification. > > Indeed not, but it would seem to make it more consistent with the rest of >

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Derek Buitenhuis
On 19/08/2012 7:25 AM, Måns Rullgård wrote: >> +s.f = *scale; >> t.i = s.i ^ (sign & 1U<<31); >> *dst++ = v[idx& 3] * t.f; >> >> -- > That is not a simplification. Indeed not, but it would seem to make it more consistent with the rest of the code, no? (See: line directly under

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Anton Khirnov
On Sun, 19 Aug 2012 17:20:17 +0200, Luca Barbato wrote: > On 8/19/12 4:54 PM, Martin Storsjö wrote: > > It's not trivial unless it's the first union member. > > For static initialization it is pretty much impossible. =\ > But this is not static initialization. What this patch does is very clos

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Luca Barbato
On 8/19/12 4:54 PM, Martin Storsjö wrote: It's not trivial unless it's the first union member. For static initialization it is pretty much impossible. =\ According to my browsing across msvc related forums that is a sorely missed feature w/out a sane replacement even in their C++... lu

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Martin Storsjö
On Sun, 19 Aug 2012, Anton Khirnov wrote: On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" wrote: From: "Ronald S. Bultje" --- libavcodec/aacdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 1c59ec5..bf99cc3 1

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Anton Khirnov
On Sun, 19 Aug 2012 07:14:46 -0700, "Ronald S. Bultje" wrote: > Hi, > > On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: > > > > On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" > > wrote: > >> From: "Ronald S. Bultje" > >> > >> --- > >> libavcodec/aacdec.c | 3 ++- > >> 1 file

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Måns Rullgård
"Ronald S. Bultje" writes: > Hi, > > On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: >> >> On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" >> wrote: >>> From: "Ronald S. Bultje" >>> >>> --- >>> libavcodec/aacdec.c | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>>

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Ronald S. Bultje
Hi, On Sat, Aug 18, 2012 at 11:09 PM, Anton Khirnov wrote: > > On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" > wrote: >> From: "Ronald S. Bultje" >> >> --- >> libavcodec/aacdec.c | 3 ++- >> 1 file changed, 2 insertions(+), 1 deletion(-) >> >> diff --git a/libavcodec/aacdec.c b/libav

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-19 Thread Måns Rullgård
"Ronald S. Bultje" writes: > From: "Ronald S. Bultje" > > --- > libavcodec/aacdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c > index 1c59ec5..bf99cc3 100644 > --- a/libavcodec/aacdec.c > +++ b/libavcodec/aacdec.c > @@ -

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-18 Thread Kostya Shishkov
On Sun, Aug 19, 2012 at 08:09:38AM +0200, Anton Khirnov wrote: > > On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" > wrote: > > From: "Ronald S. Bultje" > > > > --- > > libavcodec/aacdec.c | 3 ++- > > 1 file changed, 2 insertions(+), 1 deletion(-) > > > > diff --git a/libavcodec/aacd

Re: [libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-18 Thread Anton Khirnov
On Sat, 18 Aug 2012 22:32:15 -0700, "Ronald S. Bultje" wrote: > From: "Ronald S. Bultje" > > --- > libavcodec/aacdec.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c > index 1c59ec5..bf99cc3 100644 > --- a/libavcodec/aacde

[libav-devel] [PATCH] aac: simplify initialization statement.

2012-08-18 Thread Ronald S. Bultje
From: "Ronald S. Bultje" --- libavcodec/aacdec.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/aacdec.c b/libavcodec/aacdec.c index 1c59ec5..bf99cc3 100644 --- a/libavcodec/aacdec.c +++ b/libavcodec/aacdec.c @@ -1257,9 +1257,10 @@ static inline float *VMUL4S(fl