Re: [libav-devel] [PATCH] asvenc: Forward the error instead of asserting on it

2014-12-16 Thread Anton Khirnov
Quoting Luca Barbato (2014-12-13 13:19:16) Bug-Id: CID 732997 CC: libav-sta...@libav.org --- What does this actually fix? Is there any reason to think this assert is triggerable? -- Anton Khirnov ___ libav-devel mailing list libav-devel@libav.org

Re: [libav-devel] [PATCH] asvenc: Forward the error instead of asserting on it

2014-12-16 Thread Luca Barbato
On 16/12/14 11:15, Anton Khirnov wrote: Quoting Luca Barbato (2014-12-13 13:19:16) Bug-Id: CID 732997 CC: libav-sta...@libav.org --- What does this actually fix? Is there any reason to think this assert is triggerable? I didn't check if the dct_get can generate a block causing ccp to be in

Re: [libav-devel] [PATCH] asvenc: Forward the error instead of asserting on it

2014-12-15 Thread Vittorio Giovara
On Sat, Dec 13, 2014 at 1:19 PM, Luca Barbato lu_z...@gentoo.org wrote: Bug-Id: CID 732997 CC: libav-sta...@libav.org --- Now w/out the silly typo. libavcodec/asvenc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) lgtm -- Vittorio

[libav-devel] [PATCH] asvenc: Forward the error instead of asserting on it

2014-12-13 Thread Luca Barbato
Bug-Id: CID 732997 CC: libav-sta...@libav.org --- Now w/out the silly typo. libavcodec/asvenc.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/libavcodec/asvenc.c b/libavcodec/asvenc.c index 98baaec..d865c2e 100644 --- a/libavcodec/asvenc.c +++