Re: [libav-devel] [PATCH] aviocat: Flush the output before closing

2012-01-20 Thread Anton Khirnov
On Fri, 20 Jan 2012 16:27:53 -0800, Luca Barbato wrote: > On 20/01/12 15:27, Martin Storsjö wrote: > > That's a very good question - not sure if avio_close() is intended to be > > a "discard this and just close it quickly" function or a full graceful > > close. At the moment, I don't think of any

Re: [libav-devel] [PATCH] aviocat: Flush the output before closing

2012-01-20 Thread Luca Barbato
On 20/01/12 15:27, Martin Storsjö wrote: > That's a very good question - not sure if avio_close() is intended to be > a "discard this and just close it quickly" function or a full graceful > close. At the moment, I don't think of any good reason why it shouldn't > flush by default when closing - I

Re: [libav-devel] [PATCH] aviocat: Flush the output before closing

2012-01-20 Thread Martin Storsjö
On Fri, 20 Jan 2012, Måns Rullgård wrote: Martin Storsjö writes: Without this, the end of the file might not be transmitted/written. --- Sorry for not noticing this earlier... tools/aviocat.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/aviocat.c b/tools/av

Re: [libav-devel] [PATCH] aviocat: Flush the output before closing

2012-01-20 Thread Måns Rullgård
Martin Storsjö writes: > Without this, the end of the file might not be > transmitted/written. > --- > Sorry for not noticing this earlier... > > tools/aviocat.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/tools/aviocat.c b/tools/aviocat.c > index c43c69d..183cd

Re: [libav-devel] [PATCH] aviocat: Flush the output before closing

2012-01-20 Thread Janne Grunau
On 2012-01-20 22:54:26 +0200, Martin Storsjö wrote: > Without this, the end of the file might not be > transmitted/written. > --- > Sorry for not noticing this earlier... > > tools/aviocat.c |1 + > 1 files changed, 1 insertions(+), 0 deletions(-) > > diff --git a/tools/aviocat.c b/tools/avi

[libav-devel] [PATCH] aviocat: Flush the output before closing

2012-01-20 Thread Martin Storsjö
Without this, the end of the file might not be transmitted/written. --- Sorry for not noticing this earlier... tools/aviocat.c |1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/tools/aviocat.c b/tools/aviocat.c index c43c69d..183cdf70 100644 --- a/tools/aviocat.c +++ b/tool