Re: [libav-devel] [PATCH] dirac: Make a full demuxer

2017-03-27 Thread Luca Barbato
On 27/03/2017 12:53, Kieran Kunhya wrote: > On Mon, 27 Mar 2017 at 11:36 Luca Barbato wrote: > >> On 27/03/2017 12:28, Kieran Kunhya wrote: >>> These offsets are optional so you need to search for BBCD >> >> Is there something to know that we are in a situation or the other >> beside check if the

Re: [libav-devel] [PATCH] dirac: Make a full demuxer

2017-03-27 Thread Kieran Kunhya
On Mon, 27 Mar 2017 at 11:36 Luca Barbato wrote: > On 27/03/2017 12:28, Kieran Kunhya wrote: > > These offsets are optional so you need to search for BBCD > > Is there something to know that we are in a situation or the other > beside check if the two values are as expected and fallback otherwise

Re: [libav-devel] [PATCH] dirac: Make a full demuxer

2017-03-27 Thread Luca Barbato
On 27/03/2017 12:28, Kieran Kunhya wrote: > These offsets are optional so you need to search for BBCD Is there something to know that we are in a situation or the other beside check if the two values are as expected and fallback otherwise? BBCD+1byte is way too common and I'm not seeing escaping

Re: [libav-devel] [PATCH] dirac: Make a full demuxer

2017-03-27 Thread Kieran Kunhya
On Sun, 26 Mar 2017 at 18:12 Luca Barbato wrote: > The dirac raw bitstream contains enough framing information to make a > full demuxer out of it. > +parse_code = avio_r8(s->pb); > +next_off = avio_rb32(s->pb); > +prev_off = avio_rb32(s->pb); > These offsets are optional so you n

Re: [libav-devel] [PATCH] dirac: Make a full demuxer

2017-03-27 Thread Diego Biurrun
On Sun, Mar 26, 2017 at 07:11:50PM +0200, Luca Barbato wrote: > --- a/libavformat/diracdec.c > +++ b/libavformat/diracdec.c > @@ -19,9 +19,16 @@ > > +#include "libavcodec/dirac.h" > #include "libavutil/intreadwrite.h" > + #include "libavutil/intreadwrite.h" #include "libavcodec/dirac.h" > @@

[libav-devel] [PATCH] dirac: Make a full demuxer

2017-03-26 Thread Luca Barbato
The dirac raw bitstream contains enough framing information to make a full demuxer out of it. --- libavformat/diracdec.c | 146 - 1 file changed, 143 insertions(+), 3 deletions(-) diff --git a/libavformat/diracdec.c b/libavformat/diracdec.c index f2