Re: [libav-devel] [PATCH] fft-test: Pass the right struct members instead of casting

2014-07-26 Thread Diego Biurrun
On Sat, Jul 26, 2014 at 03:50:47PM +0200, Anton Khirnov wrote: > On Wed, 23 Jul 2014 13:40:52 -0700, Diego Biurrun wrote: > > --- > > > > .. and I do wonder why people just have to paper over everything with casts > > .. > > Because there's still a cast in there, your patch just makes it less o

Re: [libav-devel] [PATCH] fft-test: Pass the right struct members instead of casting

2014-07-26 Thread Anton Khirnov
On Wed, 23 Jul 2014 13:40:52 -0700, Diego Biurrun wrote: > --- > > .. and I do wonder why people just have to paper over everything with casts .. > Because there's still a cast in there, your patch just makes it less obvious (which IMO is not a good idea) -- Anton Khirnov ___

Re: [libav-devel] [PATCH] fft-test: Pass the right struct members instead of casting

2014-07-25 Thread Diego Biurrun
On Wed, Jul 23, 2014 at 01:40:52PM -0700, Diego Biurrun wrote: > --- > > .. and I do wonder why people just have to paper over everything with casts .. > > libavcodec/fft-test.c | 28 > 1 file changed, 12 insertions(+), 16 deletions(-) OKed by Vittorio on IRC. Dieg

[libav-devel] [PATCH] fft-test: Pass the right struct members instead of casting

2014-07-23 Thread Diego Biurrun
--- .. and I do wonder why people just have to paper over everything with casts .. libavcodec/fft-test.c | 28 1 file changed, 12 insertions(+), 16 deletions(-) diff --git a/libavcodec/fft-test.c b/libavcodec/fft-test.c index 063f8b1..f62cf0d 100644 --- a/libavcodec