Re: [libav-devel] [PATCH] flvdec: Initialize the padding in new extradata side data

2018-02-01 Thread Luca Barbato
On 01/02/2018 12:42, Martin Storsjö wrote: The other alternative would be to make av_packet_new_side_data zero-initialize the side data that it allocates (or at least the padding?), to avoid having to keep assumptions like these over here. (That would also match what ffmpeg does.) Would that

Re: [libav-devel] [PATCH] flvdec: Initialize the padding in new extradata side data

2018-02-01 Thread Martin Storsjö
On Thu, 1 Feb 2018, Luca Barbato wrote: On 01/02/2018 11:44, Martin Storsjö wrote: We already allocate the internal extradata buffer with initialized padding in flv_queue_extradata, but when copied into side data (which is allocated by av_packet_new_side_data, which does allocate the padding

Re: [libav-devel] [PATCH] flvdec: Initialize the padding in new extradata side data

2018-02-01 Thread Luca Barbato
On 01/02/2018 11:44, Martin Storsjö wrote: We already allocate the internal extradata buffer with initialized padding in flv_queue_extradata, but when copied into side data (which is allocated by av_packet_new_side_data, which does allocate the padding but doesn't initialize it), we forgot to

[libav-devel] [PATCH] flvdec: Initialize the padding in new extradata side data

2018-02-01 Thread Martin Storsjö
We already allocate the internal extradata buffer with initialized padding in flv_queue_extradata, but when copied into side data (which is allocated by av_packet_new_side_data, which does allocate the padding but doesn't initialize it), we forgot to initialize the padding there. ---