Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-03-19 Thread Vittorio Giovara
On Sat, Feb 6, 2016 at 3:22 PM, Luca Barbato wrote: > On 06/02/16 19:39, Henrik Gramner wrote: >> On Sat, Feb 6, 2016 at 7:34 PM, Luca Barbato wrote: >>> Give how this function is used it is not really important, its purpose >>> is to not break the

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Luca Barbato
On 06/02/16 19:39, Henrik Gramner wrote: > On Sat, Feb 6, 2016 at 7:34 PM, Luca Barbato wrote: >> Give how this function is used it is not really important, its purpose >> is to not break the terminal printing garbage. > > That's true I guess. > >> Do you have time to get me

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Luca Barbato
On 06/02/16 17:37, Diego Biurrun wrote: > On Sat, Feb 06, 2016 at 01:03:45PM +0100, Luca Barbato wrote: >> And move x264-specific printing in a separate function. > > to a Amended, thank you. >> --- a/libavcodec/h264_sei.c >> +++ b/libavcodec/h264_sei.c >> @@ -213,30 +215,92 @@ static int

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Luca Barbato
On 06/02/16 19:23, Henrik Gramner wrote: > On Sat, Feb 6, 2016 at 1:03 PM, Luca Barbato wrote: >> +if (isprint(val)) > > Shouldn't we use a locale-independent version similar to the other > functions in libavutil/avstring.h? Give how this function is used it is not

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Henrik Gramner
On Sat, Feb 6, 2016 at 7:34 PM, Luca Barbato wrote: > Give how this function is used it is not really important, its purpose > is to not break the terminal printing garbage. That's true I guess. > Do you have time to get me a function that is local independent? static

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Diego Biurrun
On Sat, Feb 06, 2016 at 01:03:45PM +0100, Luca Barbato wrote: > And move x264-specific printing in a separate function. to a > --- a/libavcodec/h264_sei.c > +++ b/libavcodec/h264_sei.c > @@ -213,30 +215,92 @@ static int decode_registered_user_data(H264Context *h, > int size) > +static void

Re: [libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Henrik Gramner
On Sat, Feb 6, 2016 at 1:03 PM, Luca Barbato wrote: > +if (isprint(val)) Shouldn't we use a locale-independent version similar to the other functions in libavutil/avstring.h? ___ libav-devel mailing list

[libav-devel] [PATCH] h264: Use isprint to sanitize the SEI debug message

2016-02-06 Thread Luca Barbato
And move x264-specific printing in a separate function. --- libavcodec/h264_sei.c | 88 --- 1 file changed, 76 insertions(+), 12 deletions(-) diff --git a/libavcodec/h264_sei.c b/libavcodec/h264_sei.c index 1fb1fc5..069ab9b 100644 ---